Description of problem: The Installer/Partitioningscreen for the "custom partitioning" doesnt fit on the screen when german language is selected. See Screenshot
Created attachment 8993 [details] Screenshot from Netinstall Screenshot from Netinstall 26. Feb. 2017
I really thought there was a recent bug report for a half-visible "done"-button in this screen, and equally badly visible "next" etc. buttons in consequent screens, but I don't manage to find an open or closed recent report. (A very similar issue did get fixed in the past, though) You mention you got this error when doing an install in German. Is that because you don't see this problem when you're doing a default English install on the same hardware? Do you mind attaching /root/drakx/report.bug.xz from the install that gave this problem? Or, if you didn't manage to get past that screen, please: * reproduce the issue * switch to tty2 by pressing "Ctrl + Alt + F2" * insert a USB-key * then type "bug", so that report.bug will be written to the key * attach report.bug Thx :-)
Keywords: (none) => NEEDINFOCC: (none) => marja11Assignee: bugsquad => mageiatoolsSummary: Displayerror DrakX-Installer - custom partitioning (german) => "Done" button off-screen when custom partitioning (german), the partitioning screen also overlaps the left panel.Source RPM: (none) => drakx-installer-stage2
I doubt that's related to the translations. It usually happen b/c of the way we size the partition buttons and the particular partition layout we encounter.
CC: (none) => thierry.vignaud
*** Bug 20361 has been marked as a duplicate of this bug. ***
CC: (none) => aurelienmurith
Created attachment 8996 [details] Aurélien's report.bug.xz
Tested on an other system again. Its not only in the "custom partitioning" Screen like written in comment 1. It happens also on some systems before (like if you have 2 or more existing partitions).
I got the same in VirtualBox not only for the partitioner but also for most other screens.
Priority: Normal => HighTarget Milestone: --- => Mageia 6
Do we still need "NEEDINFO" ?
Keywords: NEEDINFO => (none)
*** Bug 20438 has been marked as a duplicate of this bug. ***
CC: (none) => yleny
A new variation of bug#12422, bug#11988, bug#14839, bug#15272, bug#15264 ... :-(
CC: (none) => mageia
Hello, For my ticket : mageia 6 sta2 installer : the window is too big, can not see the right side with buttons ( https://bugs.mageia.org/show_bug.cgi?id=20438) I launch a new install with the mageia 6 sta 2 installer to help you to fix the problem. In the mageia installer, the window start to be too big when I choose custom partitioning. Then in the console log, juste after the window is too big, I have the following error message : Entering step 'Partitioning' (runinstall2:730): Gtk-WARNING **: Theme parsing error: diskdrake.css:86:25: The style property GtlPaned:handle-size is deprecated and shouldn't be used anymore.it will removed in a future version. GLib-CRITICAL **: Source ID 687 was not found when attempting to remove it at /usr/lib/libDrakX/interactive/gtk.pm line 924. (runinstall2:730): Gtk-WARNING **: Theme parsing error: diskdrake.css:86:25: The style property GtlPaned:handle-size is deprecated and shouldn't be used anymore.it will removed in a future version. (runinstall2:730): Gtk-WARNING **: Theme parsing error: diskdrake.css:86:25: The style property GtlPaned:handle-size is deprecated and shouldn't be used anymore.it will removed in a future version.
When (In reply to Y.LE_NY from comment #11) > Hello, > > For my ticket : mageia 6 sta2 installer : the window is too big, can not see > the right side with buttons ( https://bugs.mageia.org/show_bug.cgi?id=20438) > > I launch a new install with the mageia 6 sta 2 installer to help you to fix > the problem. > > In the mageia installer, the window start to be too big when I choose custom > partitioning. > Then in the console log, juste after the window is too big, I have the > following error message : > > Entering step 'Partitioning' > > (runinstall2:730): Gtk-WARNING **: Theme parsing error: diskdrake.css:86:25: > The style property GtlPaned:handle-size is deprecated and shouldn't be used > anymore.it will removed in a future version. GLib-CRITICAL **: Source ID 687 > was not found when attempting to remove it at > /usr/lib/libDrakX/interactive/gtk.pm line 924. > > (runinstall2:730): Gtk-WARNING **: Theme parsing error: diskdrake.css:86:25: > The style property GtlPaned:handle-size is deprecated and shouldn't be used > anymore.it will removed in a future version. > > (runinstall2:730): Gtk-WARNING **: Theme parsing error: diskdrake.css:86:25: > The style property GtlPaned:handle-size is deprecated and shouldn't be used > anymore.it will removed in a future version. When I go in the next steps in the installation process, I have a lot of errors with GLib-CRITICAL **: Source ID xxx was not found when attempting to remove it at /usr/lib/libDrakX/interactive/gtk.pm line 924. Where the xxx ID source number have an other value. For example in the parts : Entering step 'Formatting', Entering step 'Choosing packages', Entering step 'Installing', Entering step 'Bootloader'
Summary: "Done" button off-screen when custom partitioning (german), the partitioning screen also overlaps the left panel. => "Done" button off-screen when custom partitioning, the partitioning screen also overlaps the left panel.
Upgrading as release_blocker, as it's a pretty bad looking issue, even if it's not critical. If we release Mageia 6 ~2 years after the previous stable with such a clear visual regression, that wouldn't be good for reviews :/
Priority: High => release_blocker
Created attachment 9094 [details] Screenshot with button text translated In this case the translation is the problem - it's the width of the three buttons below the panel that's forcing the width of the dialogue box to expand. Here's a screenshot with the buttons translated...
Created attachment 9095 [details] Screenshot without button text translated and here's the same thing with the translation disabled just for those buttons.
Maybe we/i can change it from "In den Experten-Modus wechseln" (Toggle to expert mode) to "Experten Modus" (expert mode) only ?
We have then (maybe) also to modify "Toggle to normal mode" (it apears after clicking on expert mode)... "Zum Experten-Modus" ; "Zum Normalen-Modus"
Indeed. We may have to check for more languages (at least one of the dup is for French) It's a side effect of putting all buttons on the same bar: http://gitweb.mageia.org/software/drakx/commit/perl-install/diskdrake/hd_gtk.pm?id=947ab9bb0fb06611b5bd54465f98545ff175afb2 Compare with mga5 that had 2 button lines: https://doc.mageia.org/installer/5/en/content/diskdrake.html One solution would be not to make all buttons equally sized aka calling set_child_non_homogeneous(0) Which with mygtk3 style, means replacing: $per_kind_action_box = gtknew('HButtonBox', layout => 'edge')) by: $per_kind_action_box = gtknew('HButtonBox', layout => 'edge', homogenous => 0))
And maybe keep the existing "toggle to foobar mode" as a tooltip. I'll script the translation fixup
Created attachment 9096 [details] do not make all action buttons the same size
Created attachment 9097 [details] shrink "expert/normal mode" string
Thanks, Thierry :-) We should ask i18n, to make sure the grammatical case doesn't change when the string is shortened. Like for Czech https://bugs.mageia.org/attachment.cgi?id=9097&action=diff#a/perl-install/share/po/cs.po_sec1 I have the feeling "režimu" is incorrect, but that it should be nominative "režim" now. CC'ing Tomás Kindl and i18n team Also, in the original Danish translation the word "mode" was ommitted The odd "Ekspert -> Normal" now changed to "Normal" without "->" And same for: msgstr "Normal -> Ekspert" msgstr "Ekspert" https://bugs.mageia.org/attachment.cgi?id=9097&action=diff#a/perl-install/share/po/da.po_sec1 CC'ing René Neukirch
CC: (none) => i18n-bugs, rene, supp
Created attachment 9101 [details] english partitioning screen I have got something similar also in the normal partitioning screen (see english screenshot). I think its because Windows marked the first partition as "System-reserviert" (system reserved). As you can see in the screenshot, the filesystem description "Empty" leaves the screen (Emp). Maybe the whole Harddrive partition bar is also to long (?).
Please forget comment 23. I can scroll here to the right.
(In reply to Thierry Vignaud from comment #21) > Created attachment 9097 [details] > shrink "expert/normal mode" string https://ml.mageia.org/l/arc/i18n-discuss/2017-03/msg00023.html Tarakbumba informed us that: > For Turkish they should be: > Normal kip > Uzman kipi (Btw, what does the option to "Edit Attachment As Comment" do in our Bugzilla? Paste the entire attachment into a comment, with the edits, or...?)
Don't bother, I'll just fix my local commit.
(In reply to Thierry Vignaud from comment #26) > Don't bother, I'll just fix my local commit. Thanks, Thierry :-) Here's another one https://ml.mageia.org/l/arc/i18n-discuss/2017-03/msg00026.html Yochenhsieh mentions: > for zh_tw: > > msgid "Normal mode" > > msgstr "ä¸è¬æ¨¡å¼"
OK, I removed 2 extra characters Let's blame google translator's validation :-)
Keywords: (none) => PATCH
commit 8e5160b818c6d4f25ca7aa5d72db6d5754b92334 Author: Thierry Vignaud <thierry.vignaud@...> Date: Wed Mar 15 07:48:29 2017 +0100 shrink "expert/normal mode" string Thus fixing too big translations that make the partition window to be too big (mga#20360) This was a side effect of commit 947ab9bb0fb06611b5bd54465f98545ff175afb2 Adjust translations accordingly (note that some translators have already done so) --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=8e5160b818c6d4f25ca7aa5d72db6d5754b92334
commit 784a9155115058cbb494506681178d4af5f0d956 Author: Thierry Vignaud <thierry.vignaud@...> Date: Wed Mar 15 07:51:11 2017 +0100 do not make all action buttons the same size Thus fixing too big translations that make the partition window to be too big (mga#20360) This was a side effect of commit 947ab9bb0fb06611b5bd54465f98545ff175afb2 which itself partially reverted commit 8e187d972ed59909271d48915eef4af34e7fe068 --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=784a9155115058cbb494506681178d4af5f0d956
Closing
Status: NEW => RESOLVEDResolution: (none) => FIXED
commit 464abafd8ae6e441a9c82b10d32c0543c9149eb6 Author: Marja van Waes <marja@...> Date: Fri Mar 17 08:06:41 2017 +0100 change 'Normal mode' string exactly to what yochenhsieh proposed (mga#20360) --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=464abafd8ae6e441a9c82b10d32c0543c9149eb6
*** Bug 20575 has been marked as a duplicate of this bug. ***
CC: (none) => vigenmailbox
(In reply to psyca from comment #23) > I have got something similar also in the normal partitioning screen (see > english screenshot). > I think its because Windows marked the first partition as > "System-reserviert" (system reserved). > As you can see in the screenshot, the filesystem description "Empty" leaves > the screen (Emp). Maybe the whole Harddrive partition bar is also to long > (?). For this, we could use ellipses for the wizard too See http://gitweb.mageia.org/software/drakx/commit/?id=5299ba86 But please open another bug report for that
Blocks: (none) => 20624