Description of problem: Until 5beta2 build2 no problem. At introduction of new graphics, custom disk partitioning behaves didferently: the buttons on the right hand side (expert mode) are only partially displayed. In made a screenshot with a camera and will attach it. Or from the installer screenshot if I find it. Reproducible: Steps to Reproduce:
Source RPM: (none) => drakx-installer-stage2Whiteboard: (none) => 5beta2Assignee: bugsquad => ennael1
Created attachment 5729 [details] buttons
Assignee: ennael1 => thierry.vignaud
On a next try (next build, 64 bits), I notice that each partition being handled by diskdrake, makes the GUI grow in size a little, so after several drives, the GUI is of such size that the buttons on the right hand side fall off the screen. So if less paritions were used than here (see screenshot) it will be less bad or not visible. If more, worse.
Hardware: i586 => All
Sorry the screenshot does not show it. But I was using 7 partitions.
(In reply to Dick Gevers from comment #2) > On a next try (next build, 64 bits), I notice that each partition being > handled by diskdrake, makes the GUI grow in size a little, so after several > drives, the GUI is of such size that the buttons on the right hand side fall > off the screen. > > So if less paritions were used than here (see screenshot) it will be less > bad or not visible. If more, worse. I have the same experience on a harddisk with "many" partitions. A custom disk partitioning is not possible.
CC: (none) => g.sprik
This is an old bug that has reappeared - see bug 11988 for history. As I note there, I think it should be considered a release blocker, as it makes it impossible to install using custom disk partitioning when you have more than a few partitions. Note also the associated problem of the window "jumping" to the left hand side (bug 12369) which was never fixed.
CC: (none) => mageia
Still valid. Making it release blocker, IMHO not acceptable for release of final. Change as needed.
Priority: Normal => release_blockerWhiteboard: 5beta2 => 5beta3
Created attachment 5862 [details] Custom partitioning in 5beta3 dual ISO, 2015-02-05 It's fixed in some way with the classical ISOs from 2015-02-05. There are still some pixels missing from the buttons, but there is now a horizontal scrollbar, see the attached screenshot. It would be great if the buttons could be made a couple of pixels smaller though to get rid of the useless scrollbar.
CC: (none) => remi
Created attachment 5863 [details] Custom partitioning in 5beta3 dual ISO, in English this time Same screenshot as previously, but with the English locale (it was Danish previously). Here the buttons fit in the UI, there is no scrollbar, but it still looks a bit cramped. I think we should reduce the internal padding in the buttons, so that their minimal size fits in better in the UI. Then for languages with really long button labels, it's ok to have a scrollbar IMO (but not if there are 40px internal padding on each sides of the button).
commit 32a9e3c6366361c1c6e6fce1594e2fc01da299ba Author: unknown <ex.thierry.vignaud@...> Date: Thu Feb 12 15:38:30 2015 +0100 switch to logarithm sizing of partition buttons instead of using a ratio to the total disk size in order to compute width share, we now use the log of the partition size to the smallest one. this reduce the risk of having too small buttons, fixes several issues in the installer: - buttons being too big causing their box & thus the dialog to increase which triggers a gtk+ bug which makes the window to jump (mga#12422) - as well as several other related issues (mga#11988, mga#14839, mga#15272) (from Rosa but simplified) --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=32a9e3c6366361c1c6e6fce1594e2fc01da299ba Bug links: Mageia https://bugs.mageia.org/14839 https://bugs.mageia.org/15272 https://bugs.mageia.org/12422 https://bugs.mageia.org/11988
commit 1d57ba59bedf6fae41301720e71839eb91db3cce Author: Thierry Vignaud <thierry.vignaud@...> Date: Thu Feb 19 09:41:04 2015 +0100 use an horizontal scrolling bar when needed gtk+ sometimes doesn't respect our sizing which causes the container to enlarge (see previous commit) with previous commit, this reduce the risk of having too small buttons, and fixes several issues in the installer: - buttons being too big causing their box & thus the dialog to increase which triggers a gtk+ bug which makes the window to jump (mga#12422) - as well as several other related issues (mga#11988, mga#14839, mga#15272, mga#15264) --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=1d57ba59bedf6fae41301720e71839eb91db3cce Bug links: Mageia https://bugs.mageia.org/14839 https://bugs.mageia.org/15272 https://bugs.mageia.org/12422 https://bugs.mageia.org/15264 https://bugs.mageia.org/11988
You can try Cauldron once your favorite mirror has this morning's installer (16.62). Check install/stage2/VERSION eg: http://distrib-coffee.ipsl.jussieu.fr/pub/linux/Mageia/distrib/cauldron/x86_64/install/stage2/VERSION (not yet up to date)
Keywords: (none) => NEEDINFO
Created attachment 5931 [details] Custom partitioning with stage2 16.62 Still not fixed, though as stated previously this is not a major blocker anymore IMO.
Attachment 5863 is obsolete: 0 => 1 Attachment 5862 is obsolete: 0 => 1
The buttons are properly displayed. Window that jumps is bug #12422
Status: NEW => RESOLVEDResolution: (none) => FIXED
(In reply to Thierry Vignaud from comment #13) > The buttons are properly displayed. > Window that jumps is bug #12422 Yes, what I meant is that the buttons are still somewhat too big for the window (like 10px), and if you chose a locale with longer strings than the English ones, then the buttons expand even more and you get an horizontal scrollbar. But that's a minor issue IMO.
button sizing is done by gtk+ according to the theme which imposes some borders. We cannot do anything about it.
Ok, then I'm fine with RESOLVED FIXED :-)
Beg pardon, but seeing this still in rc and I think the comment closing this bug earlier is too easy. Why not take it upstream, or choose an alternative. After all this makes Mageia installer look bad. Why do we swallow that? I don't mean to offend anyone, but see if this can be reconsidered? Thanks. I do not dare to reopen, but it should be thought about anyway.
CC: (none) => eeeemail, ennael1
The buttons being off screen is preventing installation, this should be reopened. See eg. https://bugs.mageia.org/show_bug.cgi?id=15264#c9
Keywords: NEEDINFO => (none)Status: RESOLVED => REOPENEDCC: (none) => lewyssmithResolution: FIXED => (none)Whiteboard: 5beta3 => 5rc
To me it does not prevent installation: i can read all the buttons when handling the first partition. But after handling successive partitions the buttons are legible less and less. If adwaita cannot handle this, it is IMHO time to throw away adwaita. I di not want to see M5 released with all these graphical glitches: there just are too many making Mageia installer look bad :((
screenshot of RC1?
Not available at this moment. but looking exactly the same as first attachment to this bug!
Lewis can you add one for your missing buttons please
(In reply to claire robinson from comment #22) > Lewis can you add one for your missing buttons please Need to find & re-open my own bug about 'missing' partition action buttons (& others overflowing the window) for GPT disc with many partitions Custom partitioning. I cannot find it with any search, even my own bugs. It had screen photographs. I think it was marked as duplicate of *this* bug. This problem *is* serious in that it prevents installation of Mageia 5 if you hit it. It seems to be more a case of the buttons (mount point etc) being displaced beyond the window, rather than them simply being too big.
commit a674dfbf7d84330dca4f3bf58f61f4ef35fd15fc Author: Thierry Vignaud <thierry.vignaud@...> Date: Fri Feb 27 20:02:20 2015 +0100 fix too wide buttons closing mga#12422, mga#13471, mga#14839, mga#15379 issue introduced in commit 1d4957dddcbf98c3a985186b8b61be2b3f004b3c but was showing only in some cases --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=a674dfbf7d84330dca4f3bf58f61f4ef35fd15fc Bug links: Mageia https://bugs.mageia.org/12422 https://bugs.mageia.org/13471 https://bugs.mageia.org/14839 https://bugs.mageia.org/15379
Duplicate *** This bug has been marked as a duplicate of bug 12422 ***
Status: REOPENED => RESOLVEDResolution: (none) => DUPLICATE
commit 77cd051688f1e8aae47aed0c8ac40ea45360461a Author: Thierry Vignaud <thierry.vignaud@...> Date: Fri Feb 27 20:02:20 2015 +0100 fix too wide buttons closing mga#12422, mga#13471, mga#14839, mga#15379 issue introduced in commit 1d4957dddcbf98c3a985186b8b61be2b3f004b3c but was showing only in some cases --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=77cd051688f1e8aae47aed0c8ac40ea45360461a Bug links: Mageia https://bugs.mageia.org/12422 https://bugs.mageia.org/13471 https://bugs.mageia.org/14839 https://bugs.mageia.org/15379