Bug 15272 - Classic DVD install on real EFI hardware custom GPT disc partitioning does not show partition options
Summary: Classic DVD install on real EFI hardware custom GPT disc partitioning does no...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: release_blocker major
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO
: 15474 (view as bug list)
Depends on:
Blocks: 14069
  Show dependency treegraph
 
Reported: 2015-02-12 06:56 CET by Lewis Smith
Modified: 2015-03-27 21:35 CET (History)
10 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
screen1.jpg shows truncated partitioning selection screen (109.36 KB, image/jpeg)
2015-02-12 06:59 CET, Lewis Smith
Details
Custom GPT partitioning screen lacks essential options (80.31 KB, image/jpeg)
2015-02-12 07:13 CET, Lewis Smith
Details
Custom GPT partition screen lacks options (87.98 KB, image/jpeg)
2015-02-12 07:16 CET, Lewis Smith
Details
fdisk & gdisk output equivalent to the photos (2.87 KB, text/plain)
2015-02-13 21:15 CET, Lewis Smith
Details

Description Lewis Smith 2015-02-12 06:56:07 CET
Description of problem:
Doing Classic M5b3 DVD installation on real x64 EFI hardware with fully partitioned GPT disc.
1) The partitioning choice screen NEXT (& HELP) buttons are off-screen below, but just clickable. [photo]
2) Selecting Custom partitioning, when selecting a partition (here / then /boot/EFI) its details are displayed, but there are no visible options for specifying the mount point or filesystem type. [2 photos]

Version-Release number of selected component (if applicable):
Mageia 5 Beta3

How reproducible:
Always.

Steps to Reproduce:
1.
2.
3.


Reproducible: 

Steps to Reproduce:
Comment 1 Lewis Smith 2015-02-12 06:59:40 CET
Created attachment 5899 [details]
screen1.jpg shows truncated partitioning selection screen

Shows off-screen Next & Help buttons
Comment 2 Lewis Smith 2015-02-12 07:13:55 CET
Created attachment 5900 [details]
Custom GPT partitioning screen lacks essential options

Here for root partition.
Comment 3 Lewis Smith 2015-02-12 07:16:28 CET
Created attachment 5901 [details]
Custom GPT partition screen lacks options

Here for the EFI System Partition (not normally alterable anyway).
Comment 4 Martin Whitaker 2015-02-12 10:08:30 CET
I saw this in beta 2, but assumed it was the same issue as bug 11988 (also reported in bug 14839). But it's definitely worse when you boot the installer in EFI mode. I've not checked this, but maybe the EFI boot defaults to a different screen resolution.

CC: (none) => mageia

Comment 5 claire robinson 2015-02-12 10:47:59 CET
Looks to happen vertically when the "Use the free space on a windows partition" option is offered, missing a scroll bar.

Horizontally perhaps due to the number of partitions pushing it off screen to the right.

Priority: Normal => release_blocker
CC: (none) => eeeemail, ennael1, thierry.vignaud, tmb
Blocks: (none) => 14069

Comment 6 Thierry Vignaud 2015-02-12 11:09:11 CET
We can try put the part options in a scrolledwindow with 'automatic' & 'never' policy (for vertical/horizontal).
For partition buttons, we can try either fix again the sizing or put the blue/red buttons in a scrolled window ('never' vertically & 'automatic' horizontally)
Comment 7 Martin Whitaker 2015-02-12 20:48:00 CET
As suspected, when booted in EFI mode, the stage 2 installer is running with a screen resolution of 640x480 (presumably due to the known issue with the X server), which explains why this issue is worse in EFI mode than in legacy mode.
Comment 8 Thierry Vignaud 2015-02-13 08:38:26 CET
No that's totally unrelated.
The window size is the same whatever is the resolution and would fit in 640x480.

The actual issue is a partition buttons sizing one.

Can you show the output of fdisk -l on this machine?
So that I can try to reproduce with a fake disk using scsi_debug.
I've patches that I went to test against know reproducers.

Keywords: (none) => NEEDINFO

Comment 9 Martin Whitaker 2015-02-13 09:39:02 CET
(In reply to Thierry Vignaud from comment #8)
> No that's totally unrelated.
> The window size is the same whatever is the resolution and would fit in
> 640x480.
> 
The vertical problem (Next and Help buttons) does not occur when booted in legacy mode with a 800x600 resolution.

> The actual issue is a partition buttons sizing one.
> 
> Can you show the output of fdisk -l on this machine?
> So that I can try to reproduce with a fake disk using scsi_debug.
> I've patches that I went to test against know reproducers.

# fdisk -l

Disk /dev/sda: 232.9 GiB, 250059350016 bytes, 488397168 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 0B837D18-E60C-46C6-8D83-C9BC208FC72E

Device            Start          End   Size Type
/dev/sda1          2048       616447   300M Windows recovery environment
/dev/sda2        616448       821247   100M EFI System
/dev/sda3        821248      1083391   128M Microsoft reserved
/dev/sda4       1083392    202409983    96G Microsoft basic data
/dev/sda5     202409984    210798591     4G Microsoft basic data
/dev/sda6     210798592    244353023    16G Microsoft basic data
/dev/sda7     244353024    277907455    16G Microsoft basic data
/dev/sda8     277907456    286296063     4G Microsoft basic data
/dev/sda9     286296064    294684671     4G Microsoft basic data
/dev/sda10    294684672    328239103    16G Microsoft basic data
/dev/sda11    328239104    462542847    64G Microsoft basic data
Comment 10 Lewis Smith 2015-02-13 21:15:37 CET
Created attachment 5908 [details]
fdisk & gdisk output equivalent to the photos

In response to Comment 8, two versions of the same disc layout re Comment 2 & Comment 3.
Comment 11 Juergen Harms 2015-02-15 16:05:06 CET
I have an additional problem that is probably related to this bug (my configuration is similar to that of Lewis): 

Selecting "Custom disk partioning" (Partion selection screen) produces a screen like the one shown in attachment 5900 [details], but the box where the layout of existing partitions should be displayed is blank: it is not possible to select a partition.

Workaround: switching to expert mode and then back to normal mode makes the missing display appear

I confirm the "horizontally pushing buttons off-screen" effect: in the screen that comes after a partition has been selected, all the right-hand action-buttons cut-off at the right border of the screen (e.g. the Mount point button is cut off after the M) (my display has 1600 x1200 pixels).

CC: (none) => juergen.harms

Comment 12 Martin Whitaker 2015-02-15 17:08:09 CET
(In reply to Juergen Harms from comment #11) 
> Selecting "Custom disk partioning" (Partion selection screen) produces a
> screen like the one shown in attachment 5900 [details], but the box where
> the layout of existing partitions should be displayed is blank: it is not
> possible to select a partition.
> 
Seen here too - see bug 11988. My workaround was to click on one of the filesystem type buttons, but I guess anything that triggers a screen redraw does the trick. I've found this bug to be a bit intermittent - occasionally the existing partition layout gets drawn straight away.
Comment 13 Ben McMonagle 2015-02-16 20:12:39 CET
Recently I have been performing a large number of installs.
Irregularly the installer complains that he cannot read my partition table " it is too corrupted for me to read ".
Asks if I wish to erase partitions - yes / no.

If I choose " no ", sometimes I am presented with a  2 column table with all partitions listed in left column and mount points [ selectable ] in the right column.

If, as in Lewis' case, more than an arbitrary #(eg:7- Win8(4 partitions) + Mageia(3 partitions)) of partitions is presented by an HDD table, could this table be presented instead of the horizontal bar?

My reasoning is: if a user has this number of partitions, it could be concluded that they are very familiar with the setup / naming of their partitions and would know which partition(s) to use for their particular install.

CC: (none) => westel

Comment 14 Mageia Robot 2015-02-17 23:43:43 CET
commit 32a9e3c6366361c1c6e6fce1594e2fc01da299ba
Author: unknown <ex.thierry.vignaud@...>
Date:   Thu Feb 12 15:38:30 2015 +0100

    switch to logarithm sizing of partition buttons
    
    instead of using a ratio to the total disk size in order to compute width
    share, we now  use the log of the partition size to the smallest one.
    
    this reduce the risk of having too small buttons, fixes several issues
    in the installer:
    - buttons being too big causing their box & thus the dialog to increase
      which triggers a gtk+ bug which makes the window to jump (mga#12422)
    - as well as several other related issues (mga#11988, mga#14839, mga#15272)
    
    (from Rosa but simplified)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=32a9e3c6366361c1c6e6fce1594e2fc01da299ba

 Bug links:
   Mageia
      https://bugs.mageia.org/14839
      https://bugs.mageia.org/15272
      https://bugs.mageia.org/12422
      https://bugs.mageia.org/11988
Comment 15 Martin Whitaker 2015-02-19 10:06:27 CET
Replacing hd_gtk.pm on the beta 3 classic installer ISO with the latest version from git does not fix the problem for me. Details have changed - but I think that's more because with beta 3, stage 2 no longer drops the screen resolution to 640x480. I'll try to provide more information when I have more time.

Note that I can also reproduce this bug by shrinking the Mageia Control Centre window to the minimum allowed size. When diskdrake is run standalone, it behaves correctly.
Comment 16 Mageia Robot 2015-02-19 10:31:55 CET
commit 1d57ba59bedf6fae41301720e71839eb91db3cce
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Thu Feb 19 09:41:04 2015 +0100

    use an horizontal scrolling bar when needed
    
    gtk+ sometimes doesn't respect our sizing which causes the container to
    enlarge (see previous commit)
    
    with previous commit, this reduce the risk of having too small buttons,
    and fixes several issues in the installer:
    - buttons being too big causing their box & thus the dialog to increase
      which triggers a gtk+ bug which makes the window to jump (mga#12422)
    - as well as several other related issues (mga#11988, mga#14839,
      mga#15272, mga#15264)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=1d57ba59bedf6fae41301720e71839eb91db3cce

 Bug links:
   Mageia
      https://bugs.mageia.org/14839
      https://bugs.mageia.org/15272
      https://bugs.mageia.org/12422
      https://bugs.mageia.org/15264
      https://bugs.mageia.org/11988
Comment 17 Mageia Robot 2015-02-19 10:32:02 CET
commit f3c7c3356286dba238bac199ff6210a8e415a964
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Thu Feb 19 10:11:30 2015 +0100

    use a vertical scrolling bar when needed
    
    there might be too much solutions (mga#15272)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=f3c7c3356286dba238bac199ff6210a8e415a964
Comment 18 Thierry Vignaud 2015-02-19 10:37:15 CET
You can try Cauldron once your favorite mirror has this morning's installer (16.62).
Check install/stage2/VERSION
eg: http://distrib-coffee.ipsl.jussieu.fr/pub/linux/Mageia/distrib/cauldron/x86_64/install/stage2/VERSION
(not yet up to date)
Comment 19 Anne Nicolas 2015-02-20 13:54:52 CET
reporter that would be great if you can test it to check it's fixed or not. We are in the last run for mageia 5
Comment 20 Martin Whitaker 2015-02-20 22:51:28 CET
For me, this has fixed the buttons being moved outside the window and the window jumping to the left issues. I'm still seeing the issue with the partition buttons not being drawn until I click on a button (I have seen this once in many runs on the desktop, but it is happening consistently in the installer).

A couple of cosmetic issues:

1) When first started, the window width is unknown (the widget size hasn't been allocated, and $::real_windowwidth doesn't contain anything), leading to a negative width being allocated to the partition buttons. I fixed this in hd_gtk.pm by:

@@ -328,6 +328,7 @@
     if ($w->{window}->get_window) {
 	my $windowwidth = $w->{window}->get_allocated_width;
 	$windowwidth = $::real_windowwidth if $windowwidth <= 1;
-	$width = $windowwidth - first(get_action_box_size()) - 25;
+	$windowwidth = $windowwidth - first(get_action_box_size()) - 25;
+	$width = $windowwidth if $windowwidth > 0;
     }
 
2) The partition buttons are sized better if you suppress the label display on buttons that are too narrow to display an ellipsis. I fixed this in hd_gtk.pm by:

@@ -358,4 +359,6 @@
 	$info and $w->get_child->set_ellipsize('end');
+	my $buttonwidth = $entry->{size} * $ratio + $minwidth;
+	$info and $w->get_child->set_visible($buttonwidth > 40);
 	$w->set_tooltip_text($info);
 	$w->signal_connect(clicked => sub { 
 	    $current_button != $w or return;

P.S. hd_gtk.pm appears to have reverted to linear sizing of the partition buttons. Was this intentional?
Comment 21 Thierry Vignaud 2015-02-21 05:05:49 CET
With what desktop do you see partition buttons not displayed?

$::real_windowwidth is set early in installer so it's set in installer case (obviously it's not in standalone mode).

The 2nd bit looks interesting.

we keep linear sizing as log sizing had issues too and it misrepresents usage of disk space
Comment 22 Martin Whitaker 2015-02-21 10:17:13 CET
(In reply to Thierry Vignaud from comment #21)
> With what desktop do you see partition buttons not displayed?
> 
I've been testing with Mageia-4, Cinnamon, and the Blue Menta theme. There it happens maybe once in 40 times. The Details box doesn't get displayed either (same in installer).

Now the main bug is fixed, I'll install beta3 and see if it's any more frequent there, and try some other themes as well.

> $::real_windowwidth is set early in installer so it's set in installer case
> (obviously it's not in standalone mode).
> 
Yes, this bug shows up when running drakconf. If you run it from the command line, you see the warning messages.

> The 2nd bit looks interesting.
>
For my case, it stops the scroll bar appearing when run from the desktop, so gives a better user experience.

> we keep linear sizing as log sizing had issues too and it misrepresents
> usage of disk space

I prefer linear sizing too. Just wanted to check I was testing the right thing.
Comment 23 Anne Nicolas 2015-02-21 15:53:03 CET
Please include fixes if ok to allow more tests and close that bug
Comment 24 Stephane 2015-02-21 17:56:54 CET
I tested version 16.62 of Stage2 on real Hardware EFI.
This version solved problem of increasing without limit the horizontal partition table. Great.
For me all buttons seems here and screenshots feature via F2 are back :-)

CC: (none) => stephane_oss

Anne Nicolas 2015-02-23 23:38:39 CET

Assignee: bugsquad => tmb

Comment 25 Thierry Vignaud 2015-02-24 06:36:48 CET
Closing then

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Assignee: tmb => thierry.vignaud

Comment 26 Stephane 2015-03-01 11:13:32 CET
Sorry but there are regressions on stage2.

It seems that it is stage2 from Beta3 which is included in current RC :
- screenshots are empty,
- Partition table are growing each time I edit a partition to specify Type/mount point.

VERSION 16.62 dated 19 Feb was good not the VERSION included in RC iso.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 27 Thierry Vignaud 2015-03-01 12:06:04 CET
That's unrelated issues.
This bug which is about hidden buttons is fixed.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 28 Anne Nicolas 2015-03-01 18:11:54 CET
Just tested last stage2 on test isos and I can confirm it's fixed
Comment 29 Lewis Smith 2015-03-12 20:34:44 CET
Sorry to re-open this, but installing the latest 3 March M5 Classic x64 DVD on EFI/GPT hardware, the first disc partitioning choice screen *still* has the Help & Next buttons off-screen for me, but just clickable. This is unchanged from my initial description (1) with its screenshot
 https://bugs.mageia.org/attachment.cgi?id=5899
This would stop most people continuing the installation.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 30 Lewis Smith 2015-03-12 20:36:27 CET
I should have confirmed above that the major issue (2) of selected partition options is resolved: they are indeed visible & effective.
Comment 31 Thierry Vignaud 2015-03-12 20:47:13 CET
That's unrelated issues.
This bug which is about hidden buttons is fixed.
Please open a new bug report for Help/next buttons (with a screenshot)

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 32 Marja Van Waes 2015-03-14 20:55:43 CET
*** Bug 15474 has been marked as a duplicate of this bug. ***

CC: (none) => unruh

Comment 33 Marja Van Waes 2015-03-14 20:57:40 CET
(In reply to Thierry Vignaud from comment #31)
> That's unrelated issues.
> This bug which is about hidden buttons is fixed.
> Please open a new bug report for Help/next buttons (with a screenshot)

He filed bug 15485 for that

CC: (none) => marja11

Comment 34 Mageia Robot 2015-03-27 21:35:50 CET
commit 281d55f77a148cb8fafd4e73912c31e06d81acf4
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Mar 27 08:45:06 2015 -0400

    fix failing to read partition table (mga#13592, mga#15272)
    
    this is making it more readable regarding:
    "I cannot read the partition table of device XXX, it is too corrupted"
    (mga#13592, mga#15272, mga#15472)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=281d55f77a148cb8fafd4e73912c31e06d81acf4

 Bug links:
   Mageia
      https://bugs.mageia.org/15472
      https://bugs.mageia.org/15272
      https://bugs.mageia.org/13592

Note You need to log in before you can comment on or make changes to this bug.