Bug 914 - submit should not use authenticated ssh to do the svn checkout
Summary: submit should not use authenticated ssh to do the svn checkout
Status: RESOLVED FIXED
Alias: None
Product: Infrastructure
Classification: Unclassified
Component: BuildSystem (show other bugs)
Version: unspecified
Hardware: i586 Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Sysadmin Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 858
  Show dependency treegraph
 
Reported: 2011-04-21 12:47 CEST by Michael Scherer
Modified: 2014-05-08 18:04 CEST (History)
2 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Script in perl to replace old bash script (510 bytes, application/octet-stream)
2011-04-21 14:00 CEST, Michael Scherer
Details

Description Michael Scherer 2011-04-21 12:47:37 CEST
When using mgarepo submit, svn access use ssh, which cause some issue if the forwarding is not set. We should use a regular checkout with svn+ssh so people do not need anything special.
Michael Scherer 2011-04-21 12:48:42 CEST

Blocks: (none) => 858

Comment 1 Michael Scherer 2011-04-21 12:57:18 CEST
On simple way would be to do a replacement in submit_package , just before the exec :
$* is "-t cauldron --define sid=7ef09d9e-fd3b-49e7-9d2a-06354a0f4f42 -r 89293 svn+ssh://svn.mageia.org/svn/packages/cauldron/null"

Maybe we should rewrite it to use something else than bash ( cause I see not elegant way to do 's|^svn+ssh://|svn://|' )
Comment 2 Michael Scherer 2011-04-21 14:00:48 CEST
Created attachment 268 [details]
Script in perl to replace old bash script

Here is a proposal for a the replacement. 

But a better solution would be to not have mgarepo to give the url, but maybe to give the information needed to find it, or maybe to have mgarepo do the filtering job itself.
Comment 3 Nicolas Vigier 2011-04-21 15:08:25 CEST
(In reply to comment #2)
> Created attachment 268 [details]
> Script in perl to replace old bash script
> 
> Here is a proposal for a the replacement. 
> 
> But a better solution would be to not have mgarepo to give the url, but maybe
> to give the information needed to find it, or maybe to have mgarepo do the
> filtering job itself.

Yes, I was thinking about doing that. Not give a URL but only the name of the
package. And add an option to specify a branch (as I think the reason for giving an URL was to be able to use branches).

What is described in this mail :
http://www.mageia.org/pipermail/mageia-dev/20110129/002372.html
But I didn't take time to do it yet.

But we can use your script as a temporary solution.

CC: (none) => boklm

Comment 4 Michael Scherer 2011-07-20 22:16:08 CEST
Ok, I deployed it today, we still need a better fix.
Comment 5 Marja Van Waes 2011-10-09 23:24:30 CEST
(In reply to comment #4)
> Ok, I deployed it today, we still need a better fix.

Any news?

CC: (none) => marja11

Comment 6 Marja Van Waes 2012-01-13 22:13:50 CET
Pinging. because nothing happened to this report since more than 3 months ago, and it still has the status NEW or REOPENED.

Please set status to ASSIGNED. If for work flow reasons you can't do that, then please put OK on the whiteboard instead.
Manuel Hiebel 2012-01-28 15:23:19 CET

Assignee: mageia-sysadm => sysadmin-bugs

Comment 7 Nicolas Vigier 2013-09-21 16:22:46 CEST
Submit script replace svn+ssh:// with svn:// in the URL.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Nicolas Vigier 2014-05-08 18:04:58 CEST

CC: boklm => (none)


Note You need to log in before you can comment on or make changes to this bug.