Bug 26180 - Build and backport android-tools-10.0.0_r39 to Mageia 7
Summary: Build and backport android-tools-10.0.0_r39 to Mageia 7
Status: RESOLVED OLD
Alias: None
Product: Mageia
Classification: Unclassified
Component: Backports (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: David GEIGER
QA Contact:
URL:
Whiteboard: MGA7TOO
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-11 07:21 CET by Kristoffer Grundström
Modified: 2023-01-31 06:13 CET (History)
3 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Here's the full rebuild log (20.94 KB, text/plain)
2020-02-11 07:34 CET, Kristoffer Grundström
Details
Trying to rebuild with latest android tag (1.33 KB, text/plain)
2020-05-17 06:17 CEST, Kristoffer Grundström
Details
New output (20.98 KB, text/plain)
2020-05-17 14:56 CEST, Kristoffer Grundström
Details

Description Kristoffer Grundström 2020-02-11 07:21:25 CET
Description of problem: I can't get my phone (SM-G975F a.k.a Samsung Galaxy S10 Plus) recognized by fastboot-android devices in Download mode and I suspect that since it runs Android Q I also need a corresponding fastboot binary for the phone to be identified correctly. I did try to rebuild the src.rpm from Cauldron, but it failed with the error:

rm: cannot remove 'core': Is a directory

Version-Release number of selected component (if applicable): 10.0.0_r2

How reproducible: All the time.

Steps to Reproduce:
1. Go to a mageia mirror.
2. Download android-tools-10.0.0_r2-1.mga8.src.rpm
3. Open a terminal.
4. cd to where the src rpm is downloaded.
5. Run rpmbuild --rebuild android-tools-10.0.0_r2-1.mga8.src.rpm.
6. The rebuild fails.
Comment 1 Kristoffer Grundström 2020-02-11 07:34:39 CET
Created attachment 11506 [details]
Here's the full rebuild log

CC: (none) => hamnisdude

Morgan Leijström 2020-02-11 14:15:05 CET

CC: (none) => fri

Comment 2 Lewis Smith 2020-02-11 20:03:02 CET
Perhaps it is not as simple as you (Kristoffer) tried.

Assigning to DavidG as registered maintainer; CC'ing Christiaan as principle recent committer of this pkg.

Assignee: bugsquad => geiger.david68210
Source RPM: android-tools => android-tools-10.0.0_r2-1.mga8.src.rpm
CC: (none) => cjw
Severity: normal => enhancement
Version: 7 => Cauldron

Comment 3 Kristoffer Grundström 2020-05-17 06:17:07 CEST
Created attachment 11646 [details]
Trying to rebuild with latest android tag

It still doesn't build even though I cloned the latest stable source archives.

Here are the errors I get with rpmbuild -ba:

I used the android-10.0.0_r36 branch.

Attachment 11506 is obsolete: 0 => 1

Kristoffer Grundström 2020-05-17 06:17:44 CEST

Summary: Backport android-tools-10.0.0_r2-1 to Mageia 7 => Build and backport android-tools-10.0.0_r36 to Mageia 7

Kristoffer Grundström 2020-05-17 06:18:40 CEST

Source RPM: android-tools-10.0.0_r2-1.mga8.src.rpm => (none)

Comment 4 Christiaan Welvaart 2020-05-17 12:15:26 CEST
Use %configure2_5x instead of %configure .
Comment 5 Kristoffer Grundström 2020-05-17 14:56:40 CEST
Created attachment 11647 [details]
New output

I changed the %configure line, but it still won't build.

Attachment 11646 is obsolete: 0 => 1

Comment 6 Christiaan Welvaart 2020-05-17 15:47:13 CEST
std::basic_string_view::starts_with() is a c++2a feature that is apparently not available in gcc 8.4.0's libstdc++.

The function substr() can be used instead in the source code, see the definition of starts_with() in /usr/include/c++/10/string_view in cauldron.
Comment 7 Kristoffer Grundström 2020-05-17 16:38:25 CEST
(In reply to Christiaan Welvaart from comment #6)
> std::basic_string_view::starts_with() is a c++2a feature that is apparently
> not available in gcc 8.4.0's libstdc++.
> 
> The function substr() can be used instead in the source code, see the
> definition of starts_with() in /usr/include/c++/10/string_view in cauldron.

I'm not a developer, just a packager.

Could you write a patch for that?
Kristoffer Grundström 2020-06-26 16:03:57 CEST

Summary: Build and backport android-tools-10.0.0_r36 to Mageia 7 => Build and backport android-tools-10.0.0_r39 to Mageia 7

Comment 8 Kristoffer Grundström 2020-06-26 16:06:07 CEST
I made new source archives for core, extras, mdnsresponder and changed the spec file to build for android-10.0.0_r39, but it ends with:

/bin/sh: ../depcomp: No such file or directory
make: *** [Makefile:2159: core/adb/client/libadb_a-usb_libusb.o] Error 127
Comment 9 Morgan Leijström 2020-10-14 17:37:51 CEST
An update is always welcome...

Whiteboard: (none) => MGA7TOO
See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=24139, https://bugs.mageia.org/show_bug.cgi?id=27414

Comment 10 Morgan Leijström 2020-11-30 09:40:44 CET
Quick note:

I noticed in journal on a mga7 machine where i have adb-tools installed:

systemd-udevd[932]: Specified group 'adbusers' unknown

So i think android-tools should create that user (or inform user to do that), and admin should select user(s) to become member(s) of that group?
Morgan Leijström 2020-11-30 09:41:08 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=26474

Morgan Leijström 2020-11-30 09:43:01 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=23715

Comment 11 David GEIGER 2023-01-31 06:13:38 CET
Mageia 7 is EOL, so closing as OLD.

Resolution: (none) => OLD
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.