Bug 8379 - drakx-finish-install should enable nonfree repo if nonfree packages are installed (live install
Summary: drakx-finish-install should enable nonfree repo if nonfree packages are insta...
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: Olivier Blin
QA Contact:
Whiteboard: 3final
Depends on:
Reported: 2012-12-13 01:06 CET by Derek Jennings
Modified: 2013-05-17 15:56 CEST (History)
7 users (show)

See Also:
Source RPM: drakxtools
Status comment:

Enable nonfree media if draklive has install nonfree packages (484 bytes, patch)
2013-03-16 13:12 CET, Derek Jennings
Details | Diff
reuploaded patch (483 bytes, patch)
2013-03-16 14:14 CET, Derek Jennings
Details | Diff
Revised patch to use subroutine (345 bytes, patch)
2013-03-16 22:53 CET, Derek Jennings
Details | Diff
Output of journalctl -a (367.42 KB, text/plain)
2013-04-08 05:11 CEST, Dave Hodgins

Description Derek Jennings 2012-12-13 01:06:54 CET
This forum post illustrates the problem

If a user installs from a live CD, and after completing the install runs 'Updates' on being prompted by mgaapplet then because the nonfree repo is not enabled by default any nonfree packages already installed by draklive-install will not be updated.

This causes problems when the updates includes a new kernel. Any user with Nvidia or ATI video will see a black screen on the next login.

To make the installation 'bullet proof' either nonfree repos should be enabled by default by draklive-install, or else they should be enabled if any nonfree packages have been installed. (I think some nonfree packages get installed, even if Nvidia or ATI video is not present)

Behaviour is confirmed in Mga3beta1 and Mga2
Derek Jennings 2012-12-13 01:07:28 CET

Whiteboard: (none) => 3beta1

Thierry Vignaud 2012-12-13 10:19:41 CET

CC: (none) => thierry.vignaud
Assignee: bugsquad => thierry.vignaud

Comment 1 claire robinson 2013-01-10 22:29:19 CET
See also bug 6061 which seems related.

Priority: Normal => release_blocker

claire robinson 2013-01-10 22:36:04 CET

CC: (none) => eeeemail, ennael1, tmb

Comment 2 user7 2013-01-13 18:06:09 CET
Not sure, but seems to be a duplicate of bug 8368

CC: (none) => wassi

Manuel Hiebel 2013-01-27 00:02:41 CET

Summary: draklive-install should enable nonfree repo if nonfree packages are installed => drakx-finish-install should enable nonfree repo if nonfree packages are installed (live install
Source RPM: draklive-install => drakxtools

Comment 3 Derek Jennings 2013-03-16 13:12:11 CET
Created attachment 3620 [details]
Enable nonfree media if draklive has install nonfree packages

Here is a simple proposed patch.
finish-install runs automatically after reboot following installation of Mageia Live. One of its tasks is to add online media.

This patch simply enables Nonfree and Nonfree Updates repositories if there are already nonfree packages installed by draklive
Comment 4 Derek Jennings 2013-03-16 14:14:13 CET
Created attachment 3621 [details]
reuploaded patch

Attachment 3620 is obsolete: 0 => 1

Comment 5 Derek Jennings 2013-03-16 22:53:57 CET
Created attachment 3624 [details]
Revised patch to use subroutine

This revised patch uses the subroutine in attachment 3622 [details] to enable Nonfree media on the first boot so long as there are already nonfree packages installed.
Comment 6 Anne Nicolas 2013-03-21 09:06:30 CET
Thierry can you have a look on that patch so that we can have it for beta 4?
Dave Hodgins 2013-03-25 02:56:21 CET

CC: (none) => davidwhodgins
Whiteboard: 3beta1 => 3beta5

Dave Hodgins 2013-03-25 02:56:31 CET

Whiteboard: 3beta5 => 3beta4

Manuel Hiebel 2013-04-07 22:06:02 CEST

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=9651

Comment 7 Dave Hodgins 2013-04-08 05:11:18 CEST
Created attachment 3709 [details]
Output of journalctl -a

With the latest iso images, draklive-finish-install is no
longer running the network configuration, or adding the
Comment 8 claire robinson 2013-04-08 12:33:03 CEST
Confirmed. Even with network configured in live mode and working after reboot, it is no missing the media config after installation.

It seems to exit normally but just skip these parts, looking at Dave's log..

Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_network
Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_urpmi
Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_authentication
Apr 07 22:53:05 localhost finish-install[1667]: ignoring ask_users
Apr 07 22:53:05 localhost finish-install[1667]: calling ask_encrypt_home
Apr 07 22:53:05 localhost finish-install[1667]: calling ask_glx
Apr 07 22:53:05 localhost finish-install[1667]: modified file /etc/sysconfig/finish-install
Apr 07 22:53:05 localhost finish-install[1667]: ### Program is exiting ###
Comment 9 Thomas Backlund 2013-04-08 12:44:24 CEST

I think this is a fallout of me adding "Live Core" and "Live Nonfree" medias at end of live iso build in order to be able to provide grub2 and broadcom-wl packages to those installing without network Connection, so drakx skips media adding as it detects already configured medias.

@blino, @tv: is there some way to tell drakx / finish-install to add online medias anyway ? Or atleast add the question...

I think I could add a "urpmi.addmedia --distrib --mirrorlist"  as one of the post-install scripts that runs once, but I think that would be a "hack"

CC: (none) => mageia

Comment 10 Thomas Backlund 2013-04-09 13:37:50 CEST
Fixed by blino in drakxtools-15.37-1.mga3

Resolution: (none) => FIXED

Comment 11 Thomas Backlund 2013-04-09 13:39:13 CEST
oops, the fix in drakxtools-15.37-1.mga3 was only about comment 7, not all of this br

Resolution: FIXED => (none)

Dave Hodgins 2013-04-14 20:28:58 CEST

Whiteboard: 3beta4 => 3RC

Comment 12 Dave Hodgins 2013-04-14 20:50:07 CEST
While it now adds the repositories, only the Live Core, Live Nonfree,
Core Release and Core Updates repositories are enabled. the Nonfree
Release and Nonfree Updates still need to be enabled.

Also, as the network configuration is completely skipped, the user
is never given an opportunity to set the hostname.
Comment 13 claire robinson 2013-04-15 20:03:01 CEST
Comment 14 claire robinson 2013-04-16 17:09:20 CEST
See also bug 9758
Comment 15 Dave Hodgins 2013-04-17 05:19:34 CEST
Still present after i586 RC install ...
# urpmq --list-media active
Core Release
Nonfree Release
Core Release2
Core Updates
Comment 16 claire robinson 2013-05-09 18:57:06 CEST
Is this fixed in Final first builds?
Comment 17 Olivier Blin 2013-05-09 20:05:25 CEST
I have just committed a fix in svn (r8197)
This should also fix enabling nonfree repositories when configuring updates from the installer.

Though, this will not fix bug 9758, since rpmdrake tools use different code.

Assignee: thierry.vignaud => mageia

Comment 18 claire robinson 2013-05-09 20:16:42 CEST
Thanks Olivier, bug 8368 is similar too.
Dave Hodgins 2013-05-12 03:58:23 CEST

Whiteboard: 3RC => 3final

Comment 19 Dave Hodgins 2013-05-14 08:52:55 CEST
The fix needs to be pushed, and the iso images rebuilt.
Comment 20 Thomas Backlund 2013-05-14 09:13:43 CEST
Yep, pushed them last night, will be on next isos
Comment 21 claire robinson 2013-05-15 13:00:19 CEST
Still valid 2nd build (15th May)
Comment 22 Thomas Backlund 2013-05-15 18:28:45 CEST
(In reply to claire robinson from comment #21)
> Still valid 2nd build (15th May)

Did kernel-firmware-nonfree get removed at "remove unneeded packages / languages" ?

according to svn commit r8197 that's the one being tracked...

So it does not exactly a usable way...


how about just doing something like checking installed rpm release tags like rpm -qa | grep ".nonfree" to enable nonfree medias and checking for ".tainted" for tainted medias...
Comment 23 claire robinson 2013-05-15 18:32:33 CEST
Yes, I think it does for me.
Comment 24 Thierry Vignaud 2013-05-17 15:56:44 CEST
Initial bug (enabling nonfree/tainted if such packages being installed) is fixed with latest urpmi
kernel-firmware-nonfree is bug #10115

Resolution: (none) => FIXED

Note You need to log in before you can comment on or make changes to this bug.