Bug 32412 - Welcome message on login screen.
Summary: Welcome message on login screen.
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: All Packagers
QA Contact:
URL:
Whiteboard: MGA9TOO
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-19 07:05 CEST by Jose Manuel López
Modified: 2024-03-26 02:23 CET (History)
6 users (show)

See Also:
Source RPM: sddm-theme-coffee-ng-2.0-1.mga9.src.rpm
CVE:
Status comment:


Attachments
Mageia normal sddm.jpg (68.24 KB, image/jpeg)
2023-10-19 07:07 CEST, Jose Manuel López
Details
Mageia with hostname file changed (68.37 KB, image/jpeg)
2023-10-19 07:08 CEST, Jose Manuel López
Details
Mageia with line sddm modified (67.79 KB, image/jpeg)
2023-10-19 07:41 CEST, Jose Manuel López
Details
Suggested spec for apply changes on sddm-theme-coffe-ng (842 bytes, text/plain)
2023-10-19 22:57 CEST, katnatek
Details
Patch to add Mageia Linux Words (647 bytes, patch)
2023-10-19 22:58 CEST, katnatek
Details | Diff
patch to show hostname only if it's not localhost (731 bytes, patch)
2023-10-22 00:09 CEST, Aurelian R
Details | Diff
Alternative patch to show Welcome Mageia in hostname (1.47 KB, patch)
2023-10-22 04:20 CEST, katnatek
Details | Diff
new patch (1.37 KB, patch)
2023-10-22 22:01 CEST, Aurelian R
Details | Diff
Patch to Enhace Welcome Message (1.35 KB, patch)
2023-10-23 04:03 CEST, katnatek
Details | Diff
Patch to Enhace Welcome Message v4 (1.41 KB, patch)
2023-10-23 19:59 CEST, katnatek
Details | Diff
Diff with changes from the current spec in Cauldron (1.11 KB, patch)
2023-11-07 23:51 CET, katnatek
Details | Diff
Some improves to proposed spec to prepare for future versions of the theme (1.26 KB, patch)
2023-11-11 05:59 CET, katnatek
Details | Diff

Description Jose Manuel López 2023-10-19 07:05:55 CEST
Description of problem: Version-Release number of selected component (if applicable): When Mageia starts, on the login screen, on all the computers on which I have installed the system, the welcome message "Welcome localhost" appears. This looks strange to a normal user. I think we should change this to one of these two options: "Welcome" or "Welcome to Mageia".

I have verified that you have to change the word "localhost" in the hostname file within /etc, or ideally you would modify the Mageia sddm so that it only shows "Welcome". I don't know if modifying the file affects file sharing or networks or servers in any way, but we could also indicate "Mageia" there or change the sddm so that "Welcome to Mageia" appears.



How reproducible: Install Mageia sddm theme and will see this.
Comment 1 Jose Manuel López 2023-10-19 07:07:09 CEST
Created attachment 14071 [details]
Mageia normal sddm.jpg

This is a screenshot with a Mageia sddm without modify where appears "Welcome to localhost"
Comment 2 Jose Manuel López 2023-10-19 07:08:26 CEST
Created attachment 14072 [details]
Mageia with hostname file changed

This is a screenshot with a Mageia sddm with /etc/hostname file modification, where appears "Welcome to Mageia"
Comment 3 Jose Manuel López 2023-10-19 07:41:04 CEST
Created attachment 14073 [details]
Mageia with line sddm modified

Another option is to modify the mainql in the sddm theme and change to a fixed line of text indicating a message that does not require translations, like in this screenshot.
Comment 4 katnatek 2023-10-19 19:42:53 CEST
I don't know on clean install but it works for me, I still have the old coffe and the coffe-ng and both give me "Bienvenido <machine name>"

I suspect of missing requires/recommends on coffe-ng
As root run sddm-greeter --test-mode --theme /usr/share/sddm/themes/mga-coffee-2.0/
Comment 5 katnatek 2023-10-19 19:47:38 CEST
Old coffe sddm theme
https://www.imagebam.com/view/MEPL1IW

New coffe-ng sddm theme
https://www.imagebam.com/view/MEPL1J1
Comment 6 katnatek 2023-10-19 22:00:48 CEST
Forget to say that best way to set machine name is in the network wizard on MCC, not remember if this change needs to reboot the machine
Comment 7 katnatek 2023-10-19 22:57:30 CEST
Created attachment 14074 [details]
Suggested spec for apply changes on sddm-theme-coffe-ng

I change the spec to apply a patch, I test on my system and works
Comment 8 katnatek 2023-10-19 22:58:16 CEST
Created attachment 14075 [details]
Patch to add Mageia Linux Words
Comment 9 katnatek 2023-10-19 22:59:14 CEST
Still need to find why on your system not add the machine name
Comment 10 katnatek 2023-10-19 23:13:09 CEST
Look if you have this packages

rpm -qa|grep qtquick
qtquickcontrols5-5.15.7-1.mga9
qtquickcontrols25-5.15.7-1.mga9
Comment 11 Jose Manuel López 2023-10-19 23:15:32 CEST
This is:

[jose@localhost ~]$ rpm -qa|grep qtquick
qtquickcontrols5-5.15.7-1.mga9
qtquickcontrols25-5.15.7-1.mga9
qtquicktimeline6-6.4.1-2.mga9
qtquick3d6-6.4.1-2.mga9
[jose@localhost ~]$
Comment 12 Jose Manuel López 2023-10-19 23:19:04 CEST
This is with the command:

[jose@localhost ~]$ sddm-greeter --test-mode --theme /usr/share/sddm/themes/mga-coffee-2.0/
[23:09:56.762] (EE) GREETER: Socket error:  "QLocalSocket::connectToServer: Nombre inválido"
[23:09:56.762] (WW) GREETER: QFont::fromString: Invalid description '(empty)'
[23:09:56.768] (II) GREETER: Loading file:///usr/share/sddm/themes/mga-coffee-2.0//Main.qml...
[23:09:57.025] (WW) GREETER: file:///usr/share/sddm/themes/mga-coffee-2.0//Main.qml:71:31: Unable to assign [undefined] to double
[jose@localhost ~]$
Comment 13 katnatek 2023-10-20 00:21:07 CEST
(In reply to Jose Manuel López from comment #12)
> This is with the command:
> 
> [jose@localhost ~]$ sddm-greeter --test-mode --theme
> /usr/share/sddm/themes/mga-coffee-2.0/
> [23:09:56.762] (EE) GREETER: Socket error:  "QLocalSocket::connectToServer:
> Nombre inválido"
> [23:09:56.762] (WW) GREETER: QFont::fromString: Invalid description '(empty)'
> [23:09:56.768] (II) GREETER: Loading
> file:///usr/share/sddm/themes/mga-coffee-2.0//Main.qml...
> [23:09:57.025] (WW) GREETER:
> file:///usr/share/sddm/themes/mga-coffee-2.0//Main.qml:71:31: Unable to
> assign [undefined] to double
> [jose@localhost ~]$

Same here running as user, so I don't know

Try set as root the hostname again, like in wiki example

hostnamectl set-hostname myhost.local

Try remove all users ~/.Xauthority files
Comment 14 sturmvogel 2023-10-20 10:37:05 CEST
As you can clearly see at the terminal output from Jose, his machine does not have a proper hostname. He still uses the generic „localhost“:
[jose@localhost ~]$

That is the only reason why he sees „Welcome localhost“. The welcome message shows the hostname.So this is intented behaviour.
Comment 15 sturmvogel 2023-10-20 10:42:08 CEST
It is the administrators/user responsibility to give each of his machines a unique hostname…

It is the intented upstream behaviour of SDDM to show hostnames. Instead of patching this behaviour away, either convince the SDDM devs to change the behaviour (which is the same since ages) or educate administrators/users to give their machines unique hostnames…
Comment 16 Morgan Leijström 2023-10-20 10:52:57 CEST
The installer ought to ask user to set hostname.
I think we have an old bug about it but I failed to find it right now.

Can you too try to find, and if not found issue a bug?

CC: (none) => fri

Comment 17 Jose Manuel López 2023-10-20 11:02:00 CEST
The installer does not request the host username unless you lift the network. In my case gw installed several VMs with the classic installer without having to indicate the host name. In addition, this will sound to any user unknown... I think the installer should request the host name, when the username is requested, so the user will clearly see this option and put the name that will then appear on the login. In fact, it would indicate a brief description of the objective being that, such as "this name will appear in the welcome greeting on the login screen"
Comment 18 sturmvogel 2023-10-20 13:20:56 CEST
Bug 10077
Bug 21349
Comment 19 sturmvogel 2023-10-20 13:23:02 CEST
Nevertheless, the documentation has it covered howto set hostname via MCC. Advanced user use hostnmectl...
https://doc.mageia.org/mcc/9/en/content/mcc-network.html
Comment 20 Jose Manuel López 2023-10-20 13:37:15 CEST
MCC covers this when the connection is wired. When creating a Wi-Fi connection, this does not happen. I have verified it several times.

Besides, as I mentioned, very few normal users will care to verify this, if it does not appear on the screen where user data is requested in the installer.

As an advanced user in installing Mageia, I can confirm this...
Comment 21 Jose Manuel López 2023-10-20 13:40:00 CEST
Precisely, the classic DVD installer is designed so as not to have to lift the network during installation. That is why it is important that this data is requested when the user is created, not when the network is set up.

Because as I mentioned before, a user can install mageia with the complete installer and then connect through the network center to a Wi-Fi network and then, at no time will they see this data.
Morgan Leijström 2023-10-20 13:46:11 CEST

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=10077

Comment 22 sturmvogel 2023-10-20 17:19:56 CEST
(In reply to Jose Manuel López from comment #20)
> MCC covers this when the connection is wired. When creating a Wi-Fi
> connection, this does not happen. I have verified it several times.
As can be seen in the documentation, you need to hit the button "advanced". This applies for all connections...



(In reply to Jose Manuel López from comment #21)
> That is why it is important that this data
> is requested when the user is created, not when the network is set up.
This would be wrong as a user account is not related to a hostname. A hostname is a label which is used to identify a computer in a computer network.
Comment 23 Morgan Leijström 2023-10-20 18:22:06 CEST
(In reply to sturmvogel from comment #22)
> (In reply to Jose Manuel López from comment #20)
> > MCC covers this when the connection is wired. When creating a Wi-Fi
> > connection, this does not happen. I have verified it several times.
> As can be seen in the documentation, you need to hit the button "advanced".

That is what is wrong. This important setting should come up front of user without needing to investigate what is hidden under "Advanced"


 
> (In reply to Jose Manuel López from comment #21)
> > That is why it is important that this data
> > is requested when the user is created, not when the network is set up.
> This would be wrong as a user account is not related to a hostname. A
> hostname is a label which is used to identify a computer in a computer
> network.


Anyway, as one way to make user not miss it, it could practically be on the same screen as when setting up first user. (and while at it also make room for joining wheel group, Bug 26632 )

Practically, users often names their systems like "morgan-laptop" anyway, so it seem logical for home & office use, which are most installations.
Comment 24 katnatek 2023-10-20 20:22:36 CEST
One recent experience (bug#32376) probe is wise to add online repositories at install time.

BTW, for the change that Morgan suggest in comment#23 is necessary to open a new report.

What was causing joselp not see the hostname after edit /etc/hostname was found, find the balance between be easy to use and teach to users to read manuals is hard.

@joselp what you think of my suggestions about the package?
Comment 25 Squalus acanthias 2023-10-21 21:21:25 CEST
I also get "Wellcome to localhost". Is it necessary for the hostname to appear there? I would also prefer "Wellcome to Mageia" or better yet a simple "Mageia Linux" or "Mageia GNU/Linux". Regards.

CC: (none) => squalus

Comment 26 Squalus acanthias 2023-10-21 22:14:42 CEST
Sorry. I hadn't read Comment 15. I understand this derives from the design of SDDM. Personally, I have changed the hostname with "# hostnamectl set-hostname [new_hostname]".
Comment 28 Aurelian R 2023-10-22 00:09:45 CEST
Created attachment 14077 [details]
patch to show hostname only if it's not localhost

A simple conditional to show the hostname only if its not "localhost"
Something like

"Welcome to Mageia!"
"   My_Host_Name   "

CC: (none) => arusanu

Comment 29 katnatek 2023-10-22 04:20:23 CEST
Created attachment 14079 [details]
Alternative patch to show Welcome Mageia in hostname

I try to make the message say in each language
 
Welcome to Mageia 
in <hostname>

But I don't know why it's not showing the hostname :S, just print until the "in" word
Comment 30 Aurelian R 2023-10-22 10:12:28 CEST
 (In reply to katnatek from comment #29)

Use accolades { } when setting text
like this:
 case "fr": { text = text+( sddm.hostName == "localhost" ? "" : "\n dans "+sddm.hostName) };break;

IMO, "in" is a very tricky preposition in various languages. Maybe using "Host:, Computer:, System: or Node:" is more eloquent.
Comment 31 Aurelian R 2023-10-22 10:26:45 CEST
BTW, sddm-greeter in test mode disables some of its more sensitive functions like login, power buttons and, among them, the reading of the host name. So you really need to log out to the sddm screen to see the effects when using sddm.hostName or any other sensitive functions.
Comment 32 Jose Manuel López 2023-10-22 12:52:11 CEST
I think that, as is being said, the most appropriate thing to do is to modify sddm on that line, so that if there is no host name, it shows "Welcome to Mageia" in the corresponding language.

We are on the right track improving this.
Comment 33 katnatek 2023-10-22 19:56:03 CEST
(In reply to Aurelian R from comment #31)
> BTW, sddm-greeter in test mode disables some of its more sensitive functions
> like login, power buttons and, among them, the reading of the host name. So
> you really need to log out to the sddm screen to see the effects when using
> sddm.hostName or any other sensitive functions.

Yes I learn that time ago when start to play with sddm themes, I test change Main.qml of the installed theme, I will try your suggestion and come back latter
Comment 34 katnatek 2023-10-22 20:01:23 CEST
(In reply to Jose Manuel López from comment #32)
> I think that, as is being said, the most appropriate thing to do is to
> modify sddm on that line, so that if there is no host name, it shows
> "Welcome to Mageia" in the corresponding language.
> 
> We are on the right track improving this.

Well if I get this change works we will have a nice welcome message regardless of the hostname, and people that take care to set a custom hostname still see the hostname in the message
Comment 35 Aurelian R 2023-10-22 22:01:14 CEST
Created attachment 14081 [details]
new patch

(In reply to katnatek from comment #34)
> Well if I get this change works we will have a nice welcome message
> regardless of the hostname, and people that take care to set a custom
> hostname still see the hostname in the message

My comment #30 does not seem to be enough in order to show the hostname, so I attached a new patch that should fix it.

Regards, A.
Comment 36 katnatek 2023-10-22 22:35:00 CEST
(In reply to Aurelian R from comment #30)
>  (In reply to katnatek from comment #29)
> 
> Use accolades { } when setting text
> like this:
>  case "fr": { text = text+( sddm.hostName == "localhost" ? "" : "\n dans
> "+sddm.hostName) };break;
> 
> IMO, "in" is a very tricky preposition in various languages. Maybe using
> "Host:, Computer:, System: or Node:" is more eloquent.

No matter how I handle this, after the comparison with "localhost" sddm.hostName returns empty string :S, that is a bug, but I don't know how to debug that
Comment 37 katnatek 2023-10-22 22:51:09 CEST
(In reply to Aurelian R from comment #28)
> Created attachment 14077 [details]
> patch to show hostname only if it's not localhost
> 
> A simple conditional to show the hostname only if its not "localhost"
> Something like
> 
> "Welcome to Mageia!"
> "   My_Host_Name   "

Funny, your patch works and mine not
Comment 38 Aurelian R 2023-10-22 23:07:00 CEST
(In reply to katnatek from comment #37)
The first one (attachment 14077 [details]) was basic, while the second one(attachment 14081 [details]) matches your translation options from your patch without the "switch" and "onCompleted" instructions. 
I think, in your patch, using sddm.hostname inside "Component.onCompleted" doesn't behave as expected.
Comment 39 katnatek 2023-10-23 01:47:00 CEST
(In reply to Aurelian R from comment #38)
> (In reply to katnatek from comment #37)
> The first one (attachment 14077 [details]) was basic, while the second
> one(attachment 14081 [details]) matches your translation options from your
> patch without the "switch" and "onCompleted" instructions. 
> I think, in your patch, using sddm.hostname inside "Component.onCompleted"
> doesn't behave as expected.

The second patch works, I think sddm.hostName only can be handled the right way in text: 

https://www.imagebam.com/view/MEPNWDG
katnatek 2023-10-23 02:56:45 CEST

Source RPM: Sddm => sddm-theme-coffee-ng-2.0-1.mga9.src.rpm

Comment 40 katnatek 2023-10-23 03:38:21 CEST Comment hidden (obsolete)
Comment 41 katnatek 2023-10-23 04:03:20 CEST
Created attachment 14082 [details]
Patch to Enhace Welcome Message

Sorry for my previous comment#40,the changes of Aurelian R, also works using switch
@Jose Manuel, we need you choose between attachment 14077 [details] , attachment 14081 [details] and this one I change "in" by "at"

Attachment 14075 is obsolete: 0 => 1
Attachment 14079 is obsolete: 0 => 1

Comment 42 Jose Manuel López 2023-10-23 06:59:10 CEST
Patch 14081 is not working correctly, or I am not putting it correctly in the main.qml file.

Patch 14077 works fine:

- If I don't have a hostname it says "Welcome to Mageia!"
- If I have hostname it says "Welcome to Mageia! Jose"

As for the preposition, I think "at" is more appropriate than "in" here.
Comment 43 katnatek 2023-10-23 19:52:53 CEST
(In reply to Jose Manuel López from comment #42)
> Patch 14081 is not working correctly, or I am not putting it correctly in
> the main.qml file.
> 
> Patch 14077 works fine:
> 
> - If I don't have a hostname it says "Welcome to Mageia!"
> - If I have hostname it says "Welcome to Mageia! Jose"
> 
> As for the preposition, I think "at" is more appropriate than "in" here.

What I do is this, in terminal in my work folder for mgarepo

mgaerpo co 9/sddm-theme-coffee-ng 
cd sddm-theme-coffee-ng 
then replace the spec by attachment 14074 [details]
you can create in SOURCES folder a file with the pacth you wish to apply

bm -lp

If all goes right, in BUILD folder you should see mga-coffee-2.0 with the Main.qml changed.
I suggest this way and not replace directly Main.qml in sources to fit the Policies for an update
Comment 44 katnatek 2023-10-23 19:59:42 CEST
Created attachment 14084 [details]
Patch to Enhace Welcome Message v4

I ask for help in i18n list, I get some suggestions, this patch implements that suggestions

I think with this patch and spec in attachmment 14074, we can release an update for sddm-theme-coffee-ng

Attachment 14082 is obsolete: 0 => 1

Comment 45 katnatek 2023-10-23 20:01:20 CEST
(In reply to katnatek from comment #43)
> (In reply to Jose Manuel López from comment #42) 
> What I do is this, in terminal in my work folder for mgarepo
> 
> mgaerpo co 9/sddm-theme-coffee-ng 
> cd sddm-theme-coffee-ng 
> then replace the spec by attachment 14074 [details]
> you can create in SOURCES folder a file with the pacth you wish to apply
> 
> bm -lp
> 
> If all goes right, in BUILD folder you should see mga-coffee-2.0 with the
> Main.qml changed.
> I suggest this way and not replace directly Main.qml in sources to fit the
> Policies for an update

Forgot to say the file name for the patch must be mga-coffe-ng-addmageia.patch
Comment 46 Marja Van Waes 2023-10-25 22:02:50 CEST
(In reply to katnatek from comment #44)
> Created attachment 14084 [details]
> Patch to Enhace Welcome Message v4
> 
> I ask for help in i18n list, I get some suggestions, this patch implements
> that suggestions
> 
> I think with this patch and spec in attachmment 14074, we can release an
> update for sddm-theme-coffee-ng

Can you ask your mentor to review your spec file and patch and arrange with him to get it pushed (first to cauldron, then to Mageia 9 updates_testing)?

Assignee: bugsquad => j.alberto.vc
Version: 9 => Cauldron
Whiteboard: (none) => MGA9TOO
CC: (none) => marja11

Comment 47 katnatek 2023-10-26 01:13:55 CEST
(In reply to Marja Van Waes from comment #46)
> Can you ask your mentor to review your spec file and patch and arrange with
> him to get it pushed (first to cauldron, then to Mageia 9 updates_testing)?
This is Jose Manuel's baby, he is managing this with his mentor
Comment 48 katnatek 2023-11-05 17:38:09 CET
If you want to preview the theme, I upload a package to blogdrake's repository, you don't need to add the repository, just:

urpmi https://ftp.blogdrake.net/mageia/mageia8/free/noarch/sddm-theme-coffee-ng-2.0-1.0.1bdk_mga8.noarch.rpm

or

urpmi https://ftp.blogdrake.net/mageia/mageia9/free/noarch/sddm-theme-coffee-ng-2.0-1.0.1bdk_mga9.noarch.rpm
katnatek 2023-11-07 23:44:29 CET

CC: (none) => ngompa13

Comment 49 katnatek 2023-11-07 23:51:24 CET
Created attachment 14142 [details]
Diff with changes from the current spec in Cauldron

I also fix a typo in spec attachment#14074 [details]
The patch is attachment#14084 [details]
Comment 50 katnatek 2023-11-11 05:59:46 CET
Created attachment 14146 [details]
Some improves to proposed spec to prepare for future versions of the theme

I tweak the proposed spec, this is the updated changes

The patch is attachment#14084 [details]

Attachment 14074 is obsolete: 0 => 1
Attachment 14142 is obsolete: 0 => 1

Comment 51 Neal Gompa 2023-12-06 01:07:40 CET
We should actually ask ourselves if we should have this custom theme at all. The Breeze theme for SDDM supports having a custom wallpaper set and looks much nicer than this theme altogether.

I would encourage us to consider moving in that direction instead (making a copy of the Breeze SDDM theme and adapting that with a default Mageia background instead of the KDE one).
Comment 52 katnatek 2023-12-06 01:19:24 CET
(In reply to Neal Gompa from comment #51)
> We should actually ask ourselves if we should have this custom theme at all.
> The Breeze theme for SDDM supports having a custom wallpaper set and looks
> much nicer than this theme altogether.
> 
> I would encourage us to consider moving in that direction instead (making a
> copy of the Breeze SDDM theme and adapting that with a default Mageia
> background instead of the KDE one).

Well Breeze sddm the requires kde/ plasma components

import org.kde.plasma.core 2.0 as PlasmaCore
import org.kde.plasma.components 3.0 as PlasmaComponents3
import org.kde.plasma.extras 2.0 as PlasmaExtras

This theme works only with qtquick and sddm components, so is best for including in other desktops where mageia install also sddm as dm manager like in lxqt
Comment 53 katnatek 2023-12-06 21:54:23 CET
(In reply to Neal Gompa from comment #51)
> We should actually ask ourselves if we should have this custom theme at all.
> The Breeze theme for SDDM supports having a custom wallpaper set and looks
> much nicer than this theme altogether.
> 
> I would encourage us to consider moving in that direction instead (making a
> copy of the Breeze SDDM theme and adapting that with a default Mageia
> background instead of the KDE one).

More information https://bugs.mageia.org/show_bug.cgi?id=24861#c66
katnatek 2023-12-27 22:40:38 CET

Assignee: j.alberto.vc => pkg-bugs

Comment 54 katnatek 2023-12-27 22:41:25 CET
Send to all packager to see if someone  want to make the change
Comment 55 papoteur 2024-03-02 19:57:44 CET
Hi katnatek,
Thank you for your suggestions.
The string "Welcome to Mageia" is already present and translated in MageiaWelcome. Thus it would be interesting to reuse it.
What I would make is:
use
text: qsTranslate("app", "Welcome to Mageia") in Main.qml

add "translations" subdirectory
inside this directory, create a symlink from /usr/share/mageiawelcome/translations/mageiawelcome_xx.qm xx.qm 
where xx is the language code
This latest part is not fun. However,I have test it and it works.
Papoteur

CC: (none) => yvesbrungard

Comment 56 katnatek 2024-03-02 20:36:50 CET
(In reply to papoteur from comment #55)
> Hi katnatek,
> Thank you for your suggestions.
> The string "Welcome to Mageia" is already present and translated in
> MageiaWelcome. Thus it would be interesting to reuse it.
> What I would make is:
> use
> text: qsTranslate("app", "Welcome to Mageia") in Main.qml
> 
> add "translations" subdirectory
> inside this directory, create a symlink from
> /usr/share/mageiawelcome/translations/mageiawelcome_xx.qm xx.qm 
> where xx is the language code
> This latest part is not fun. However,I have test it and it works.
> Papoteur

Some translations are part of sddm package, the change just adds some strings I don't really get how qml translations works, but I think to integrate the changes must be added to sddm translations, I think is less difficult in the way is handled by suggested changes
Comment 57 papoteur 2024-03-25 19:06:22 CET
(In reply to katnatek from comment #56)
> Some translations are part of sddm package, the change just adds some
> strings I don't really get how qml translations works, but I think to
> integrate the changes must be added to sddm translations, I think is less
> difficult in the way is handled by suggested changes

This theme is not part of SDDM package, thus there is no reason to put the translations in SDDM.
Comment 58 katnatek 2024-03-26 02:16:08 CET
(In reply to papoteur from comment #57)
> (In reply to katnatek from comment #56)
> > Some translations are part of sddm package, the change just adds some
> > strings I don't really get how qml translations works, but I think to
> > integrate the changes must be added to sddm translations, I think is less
> > difficult in the way is handled by suggested changes
> 
> This theme is not part of SDDM package, thus there is no reason to put the
> translations in SDDM.

But all the sddm themes get the basic translations from the sddm translation, at less I don't find another method to add extra translations to sddm themes, If you know of one please let me know
Comment 59 katnatek 2024-03-26 02:23:00 CET
(In reply to katnatek from comment #58)
> (In reply to papoteur from comment #57)
> > (In reply to katnatek from comment #56)
> > > Some translations are part of sddm package, the change just adds some
> > > strings I don't really get how qml translations works, but I think to
> > > integrate the changes must be added to sddm translations, I think is less
> > > difficult in the way is handled by suggested changes
> > 
> > This theme is not part of SDDM package, thus there is no reason to put the
> > translations in SDDM.
> 
> But all the sddm themes get the basic translations from the sddm
> translation, at less I don't find another method to add extra translations
> to sddm themes, If you know of one please let me know

The metadata.desktop of the sddm themes that use translations

/usr/share/sddm/themes/theme-name/metadata.desktop

Have the line

TranslationsDirectory=translations

That is a reference to

/usr/share/sddm/translations

Note You need to log in before you can comment on or make changes to this bug.