Bug 21916 - PHP 7 for Mageia 7
Summary: PHP 7 for Mageia 7
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: Mageia 7
Assignee: José Jorge
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-22 14:21 CEST by Marc Krämer
Modified: 2017-11-12 10:09 CET (History)
4 users (show)

See Also:
Source RPM: php-5.6.31-1.mga6.src.rpm
CVE:
Status comment:


Attachments
Patch cauldron to use PHP 7.1.11 (174.39 KB, patch)
2017-10-30 00:38 CET, Marc Krämer
Details | Diff
remove suhosin, setting to conflicts instead of suggested (5.68 KB, text/plain)
2017-11-11 14:59 CET, Marc Krämer
Details

Description Marc Krämer 2017-10-22 14:21:32 CEST
PHP 5.6 has lost active support on the beginning of the year and will loose support on the end of 2018 (which gives some time). But since mga7 will probably be released on mid of 2018, php will soon be without active security patches.

I suggest adding php 7.1 now and update this version to 7.2 before final relase.

Since I'm also wating for this package for my webserver, is there anything I can help to integrate? I've looked into the patches you applied to the experimental php 7 support for mga6 and the patches for current php 5.6, but there is not much documentation why all these patches are applied.
Comment 1 Frédéric "LpSolit" Buclin 2017-10-22 15:17:50 CEST
You already filed this bug, see bug 19614. :)

If a maintainer can package PHP 7.1, it will be included in Cauldron.

*** This bug has been marked as a duplicate of bug 19614 ***

Status: UNCONFIRMED => RESOLVED
Resolution: (none) => DUPLICATE

Comment 2 Marc Krämer 2017-10-22 18:57:58 CEST
Yes that's right. But this bug was closed as won't fix and was proposed for the mga6 cauldron phase. 
Now this request is for mga7 - and as I stated, this has to be resolved before the next release.

Status: RESOLVED => UNCONFIRMED
Resolution: DUPLICATE => (none)

Comment 3 Marja Van Waes 2017-10-23 11:52:15 CEST
Hi M K,

You might want to help us find more PHP devs :-)

Mageia is a community distribution. As you know that means that there is no division between those who make the distro and those who use it. Every user is expected to contribute in a way that matches with his talents and means. We need to do everything ourselves.

Would you be able to try to tell many PHP devs about our great project and (hopefully) give some of those with time a longing to join us?

Cheers,
Marja

_____________________________________________________________________________


Assigning this update request to all packagers collectively, since there is no registered maintainer for PHP.

Target Milestone: --- => Mageia 7
Status: UNCONFIRMED => NEW
Assignee: bugsquad => pkg-bugs
Ever confirmed: 0 => 1
CC: (none) => marja11
Summary: Update PHP Package => PHP 7 for Mageia 7

Comment 4 David Walser 2017-10-26 18:19:46 CEST
Indeed, we lost our two PHP maintainers.  One passed away and the other left the project.  The latter did start work on the update to PHP 7 in SVN (that work should be still able to be found there), so someone else can pick it up and run with it.
Comment 5 Frédéric "LpSolit" Buclin 2017-10-27 13:34:43 CEST
(In reply to David Walser from comment #4)
> Indeed, we lost our two PHP maintainers.  One passed away and the other left
> the project.  The latter did start work on the update to PHP 7 in SVN (that
> work should be still able to be found there), so someone else can pick it up
> and run with it.

As there is no documentation about why such or such patches are needed, would it be OK to start again with a vanilla PHP7 and see what breaks and only reapply patches which seem to still be relevant, instead of applying them all without understanding why we need them?

CC: (none) => LpSolit

Comment 6 Marc Krämer 2017-10-27 13:39:10 CEST
If someone can help me with the packaging, I can try to get started with php7. Do you have any documentation why php7 was removed from mga6 - any packages that didn't work etc.

@Frédéric, I think this can be almost done, a few patches are clear, they are linux / mga specific (e.g. differences in default config), cron-jobs,...
Comment 7 Thomas Backlund 2017-10-27 13:47:55 CEST
(In reply to Frédéric Buclin from comment #5)

> 
> As there is no documentation about why such or such patches are needed,
> would it be OK to start again with a vanilla PHP7 and see what breaks and
> only reapply patches which seem to still be relevant, instead of applying
> them all without understanding why we need them?

Not blindly drop all patches... it will break... 

many patches are either path adoptions to match our packaging policy or 
security hardening... and by the looks of it not too hard to rebase...

If you read the patches many of them are "self-explanatory"

but of course they could be commented better in spec

CC: (none) => tmb

Comment 8 Thomas Backlund 2017-10-27 13:49:52 CEST
Start from 7.0.2 is probably easier than current 5.6.31

http://svnweb.mageia.org/packages/cauldron/php/releases/3%3A7.0.2/4.mga6/
Comment 9 Marc Krämer 2017-10-30 00:38:48 CET
Created attachment 9767 [details]
Patch cauldron to use PHP 7.1.11

I've started the work on PHP 7.1.11 for cauldron (which is btw. not installable by the online installer).

Is there anyone who can help me with the packaging?

Attached patch file works for building php for cauldron. Packages seems to work as far as I can tell. Since 7.0.2 I've deactivated a few patches which seems to be resolved. Dependency to suhosin is deactivated, since no php7 version is available.
Comment 10 Marc Krämer 2017-11-05 18:45:46 CET
has anybody had the time for a review of my patch?
Comment 11 DavidS 2017-11-08 16:17:24 CET
Hello M K,

for my understanding: this path apllies to  php-5.6.31-1.mga6?

CC: (none) => kostuek

Comment 12 Marc Krämer 2017-11-08 17:18:06 CET
This patch is build on cauldron (mga7).
Used mgarepo and bm to build.

I did not test it for mga6.
José Jorge 2017-11-10 17:09:37 CET

CC: (none) => lists.jjorge
Assignee: pkg-bugs => lists.jjorge

Comment 13 José Jorge 2017-11-10 17:10:20 CET
My padawan DavidS is working on this.

Status: NEW => ASSIGNED

Comment 14 Marc Krämer 2017-11-10 21:31:18 CET
let me know if I can help to bring this forward for mga7 (maybe as a backport for mga6)
Comment 15 DavidS 2017-11-10 21:37:56 CET
It builds in my system, however I have some more questions. I had to comment out the Patch20: line in the spec, since patch20 was removed from the SOURCES and the package wouldn't build otherwise. I'm assuming removing patch20 was intentional?

Also, the patch tool asked me cryptic questions about Patch401 (running against 5.6.31-2 version) and depending on how I answer would keep or remove it from the SOURCES. So same question here: in my actual build patch401 is removed, is this how it should be?
Comment 16 Marc Krämer 2017-11-10 22:45:35 CET
Right, Patch20 is also commented out at my machine. This patch was originally developed for php 5.5. The code is already integrated in this build (in function php_mail)

Patch401? I never saw a patch like that.
I did a checkout of mga6, but there is no such patch. In mga7 I don't see it either.
What is the content of the patch? Maybe it is obsolete too.
Comment 17 Marc Krämer 2017-11-10 23:00:37 CET
Found Patch 401 in the svn. Patch 401 is a backport of a php 7.1 "feature".
Comment 18 DavidS 2017-11-11 08:56:48 CET
Sneaky backports. Let's see what José says to the build then.
Comment 19 Marc Krämer 2017-11-11 11:02:40 CET
@David: Are you getting the new php maintainer? If you will, maybe I can join. I'm currently no packager, but maybe I can become one (like you).

I've added a few more patches:
https://bugs.mageia.org/show_bug.cgi?id=21382
https://bugs.mageia.org/show_bug.cgi?id=21915


But let's look forward to josé's comments on the new version.
Comment 20 DavidS 2017-11-11 11:20:22 CET
To be honest, I don't have much experience with php. Maybe you could consider joining the apprentice program indeed, so the php package can get some maintenance in the long run :)
Comment 21 José Jorge 2017-11-11 11:31:06 CET
(In reply to Marc K. from comment #19)
> @David: Are you getting the new php maintainer? If you will, maybe I can
> join. I'm currently no packager, but maybe I can become one (like you).

Yes you can become packager, and we need you. Please let's work the right way : you add yourself in this page table :

https://wiki.mageia.org/en/Becoming_a_Mageia_Packager

and then you'll send me directly your work. Php is big enough that if you only work on it it will be a big help to Mageia.

Your first patches (the ones attached to this bug) are commited to cauldron, and building.
Comment 22 Marc Krämer 2017-11-11 14:59:40 CET
Created attachment 9782 [details]
remove suhosin, setting to conflicts instead of suggested

@David: you can remove "php-7.0.2.tar.xz" from sha1.lst as well
patch file "php-libtool.diff" can be deleted as well.

I've added a new patch since suhosin is not supported for php >5.6.

@José I've written a mail to you, at least concerning the wiki ;-)
Comment 23 José Jorge 2017-11-12 09:24:40 CET
All this is now in cauldron, and Marc is our new packager ;-)

Resolution: (none) => FIXED
Status: ASSIGNED => RESOLVED

DavidS 2017-11-12 10:09:35 CET

CC: kostuek => (none)


Note You need to log in before you can comment on or make changes to this bug.