Bug 1839 - iurt shouldn't install suggested packages when installing build dependencies
Summary: iurt shouldn't install suggested packages when installing build dependencies
Status: RESOLVED FIXED
Alias: None
Product: Infrastructure
Classification: Unclassified
Component: BuildSystem (show other bugs)
Version: unspecified
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Sysadmin Team
QA Contact:
URL:
Whiteboard:
Keywords:
: 1858 (view as bug list)
Depends on:
Blocks: 858
  Show dependency treegraph
 
Reported: 2011-06-17 19:29 CEST by Jerome Quelin
Modified: 2014-05-08 18:04 CEST (History)
5 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
attempt to fix the bug (678 bytes, patch)
2011-07-20 12:18 CEST, Jerome Quelin
Details | Diff

Description Jerome Quelin 2011-06-17 19:29:05 CEST
when building a package on the bs, urpmi installs the requirements + their suggested dependencies. however, if a suggested pkg cannot be installed, the install fails and the package cannot be built.

a suggests should never prevent bs from working.
this bites me with the following:
- perl-Dist-Zilla suggests perl-Task-Dist-Zilla (requiring all dzil plugins)
- perl-Task-Dist-Zilla requires perl-Dist-Zilla (normal, the task goal is to provide the developer with a working installation)

currently i want to build a new perl-Task-Dist-Zilla, it pulls perl-Dist-Zilla which wants to pull perl-Task-Dist-Zilla which wants to pull perl(Dist::Zilla::Plugin::WSDL::Types). however, this perl module doesn't exist anymore upstream, and perl-Dist-Zilla-Plugin-WSDL has been updated to latest version. therefore, perl-Task-Dist-Zilla cannot be installed. and thus, perl-Dist-Zilla install fails which means perl-Task-Dist-Zilla cannot be built.

this is just wrong. suggests should either a) not be pulled on the bs or b) not be fatal if their install fails.
Comment 1 Michael Scherer 2011-06-18 16:07:38 CEST
I would say that iurt should not pull suggests. Suggests are optional, and we want reproductible build, even outside of iurt.

CC: (none) => misc

Comment 2 Ahmad Samir 2011-06-20 00:45:20 CEST
*** Bug 1858 has been marked as a duplicate of this bug. ***

CC: (none) => cjw

Nicolas Vigier 2011-06-20 01:47:54 CEST

CC: (none) => boklm
Depends on: (none) => 858

Nicolas Vigier 2011-06-20 01:48:43 CEST

Blocks: (none) => 858
Depends on: 858 => (none)

Comment 3 Jerome Quelin 2011-06-20 13:47:11 CEST
i agree with misc - due to repeatability that is a good thing, solution b) should not be used. therefore, bs should not pull suggests.
Comment 4 Christiaan Welvaart 2011-06-26 21:32:29 CEST
fixed summary - this is not a bug in urpmi, iurt's handling of suggests should be independent of the default behavior of urpmi

Summary: urpmi should not install suggests before building a package / suggests should not be fatal => iurt should ignore suggested packages when installing build dependencies

Ahmad Samir 2011-06-27 01:41:58 CEST

Summary: iurt should ignore suggested packages when installing build dependencies => iurt shouldn't install suggested packages when installing build dependencies

Comment 5 Jerome Quelin 2011-07-20 12:18:14 CEST
Created attachment 662 [details]
attempt to fix the bug

passing --no-suggests to urpmi from iurt should prevent urpmi from installing suggestions.
Comment 6 Pascal Terjan 2011-07-31 23:59:51 CEST
This looks fine to me

CC: (none) => pterjan

Comment 7 Jerome Quelin 2011-08-20 14:16:31 CEST
can it be applied to build system then? thanks.
Comment 8 Shlomi Fish 2011-08-21 19:27:55 CEST
(In reply to comment #7)
> can it be applied to build system then? thanks.

Hi, I now tried building perl-Task-Dist-Zilla in vein as well. Very annoying. Please apply the patch to the build system.

Regards,

-- Shlomi Fish

CC: (none) => shlomif

Comment 9 Jerome Quelin 2011-08-22 13:50:32 CEST
(In reply to comment #8)
> Hi, I now tried building perl-Task-Dist-Zilla in vein as well. Very annoying.
> Please apply the patch to the build system.

yes, task::dist::zilla is looping with dist::zilla as suggests. all perl-dist-zilla-* cannot be currently updated on mageia.
Comment 10 Pascal Terjan 2011-08-22 13:57:38 CEST
Please commit it to http://svnweb.mageia.org/soft/build_system/iurt/trunk/ I'll try to build a package and deploy it tonight (or annoy other sysadmins :) )
Comment 11 Jerome Quelin 2011-08-22 14:05:22 CEST
committed to svn.
Comment 12 Pascal Terjan 2011-08-25 23:29:27 CEST
Installed on the build system, sorry for the delay

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 13 Jerome Quelin 2011-08-26 12:58:47 CEST
thanks! perl-dist-zilla-* currently being updated
Nicolas Vigier 2014-05-08 18:04:12 CEST

CC: boklm => (none)


Note You need to log in before you can comment on or make changes to this bug.