Bug 12560 - Update request: Cannot edit menus in Cinnamon
Summary: Update request: Cannot edit menus in Cinnamon
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: Mageia 4
Assignee: QA Team
QA Contact:
URL:
Whiteboard: has_procedure advisory mga4-64-ok mga...
Keywords: Triaged, validated_update
: 13357 (view as bug list)
Depends on: 12761
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-04 00:03 CET by Martin Whitaker
Modified: 2014-05-29 09:27 CEST (History)
8 users (show)

See Also:
Source RPM: cinnamon-2.0.14-5.3.mga4
CVE:
Status comment:


Attachments
Changes needed to allow menu editing (5.35 KB, application/x-compressed)
2014-03-11 20:49 CET, Martin Whitaker
Details

Description Martin Whitaker 2014-02-04 00:03:25 CET
In the Cinnamon menu editor, none of the buttons that allow you to edit the menus do anything. Running in a terminal, I see:

% /usr/bin/cinnamon-menu-editor
Traceback (most recent call last):
  File "/usr/bin/cinnamon-desktop-editor", line 5, in <module>
    os.execvp("/usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py", ("",) + tuple(sys.argv[1:]))
  File "/usr/lib64/python2.7/os.py", line 344, in execvp
    _execvpe(file, args)
  File "/usr/lib64/python2.7/os.py", line 368, in _execvpe
    func(file, *argrest)
OSError: [Errno 2] No such file or directory

/usr/lib/cinnamon-desktop-editor/cinnamon-desktop-editor.py is indeed not there.

Similarly, attempting to edit any of the entries in the launcher app files fails - most likely for the same or similar reason.

Reproducible: 

Steps to Reproduce:
Sander Lepik 2014-02-04 08:23:02 CET

CC: (none) => mageia
Assignee: bugsquad => joequant

Comment 1 Joseph Wang 2014-02-04 08:25:44 CET
Thanks for the report.  I'll take a look.
Manuel Hiebel 2014-02-04 18:39:35 CET

Keywords: (none) => Triaged

Rata de Pruebas 2014-02-14 13:37:46 CET

CC: (none) => ratadp

Rata de Pruebas 2014-02-14 13:38:19 CET

Target Milestone: --- => Mageia 4

Comment 2 Joseph Wang 2014-02-14 14:28:42 CET
FYI, I'm working on this in cauldron.  I have a version of cinnamon in cauldron in which there are no output errors, but there does seem to be a problem saving the desktop files which I am looking into.
Comment 3 Martin Whitaker 2014-03-02 20:55:02 CET
Any further progress on this? Just now I would have liked to suggest to someone on the forum that they tried Cinnamon, but until this bug is fixed, I don't feel I can recommend it.
Comment 4 Martin Whitaker 2014-03-11 20:49:23 CET
Created attachment 5046 [details]
Changes needed to allow menu editing

For anyone who doesn't want to wait for an official update, this fixes the problem for me. You can install this from the command line by

  su -c 'tar Pxvf cinnamon-desktop-editor.tgz'

This will replace the file

  /usr/bin/cinnamon-desktop-editor

and install the files

  /usr/share/cinnamon-desktop-editor/cinnamon-desktop-editor.py
  /usr/share/cinnamon-desktop-editor/directory-editor.ui
  /usr/share/cinnamon-desktop-editor/launcher-editor.ui

I've noticed a few bugs when editing launcher items on the panel, but it mostly works.

The new files come from the Cinnamon git repository - the only modifications I have made are to change some of the file paths.
Comment 5 Joseph Wang 2014-03-12 00:08:55 CET
I've got an unofficial patch working locally, but for some reason it's behaving oddly (i.e. it doesn't crash but sometimes menus work and sometimes they don't).

I'll try to get something out by the end of the week.
Comment 6 Joseph Wang 2014-03-12 07:15:08 CET
Hi,

For me the menu pops up, but there is some sort of incompatible the garbles the menu output.  Will look a bit deeper, but there seems to be some schema mismatch.
Comment 7 Joseph Wang 2014-03-14 08:37:44 CET
I just check in the some cinnamon changes into cauldron.  It turns out that I had been spinning my wheels for a while.  The cinnamon menu editor is broken for cauldron, but it turns out that alacarte is broken in the same way, so whatever is the problem, it's not cinnamon.

I'll try to see what is going on in the dev list.
Comment 8 Joseph Wang 2014-04-18 15:29:46 CEST
Can you test the version of cinnamon in updates_testing for Mageia 4.  This should fix the problem.
Comment 9 Martin Whitaker 2014-04-18 21:09:58 CEST
Same behaviour as before. However, the package version number in updates_testing is the same as the one in release - are you sure you uploaded the new version?
Comment 10 Joseph Wang 2014-04-19 04:54:26 CEST
Oops.  No I didn't check in the patch

Wait a few hours and try 

cinnamon-2.0.14-6.mga4
Comment 11 Martin Whitaker 2014-04-19 20:15:10 CEST
This fixes the initial problem, and allows a new item to be added to a menu. However, there is a further problem - you can't change the icon associated with the menu item. Running in a terminal, the following error message appears when you click on the icon button in the Launcher Properties window:

Traceback (most recent call last):
  File "/usr/share/cinnamon-desktop-editor/cinnamon-desktop-editor.py", line 104, in pick_icon
    icon_info_fn = icon_info.get_filename()
AttributeError: 'NoneType' object has no attribute 'get_filename'

Changing the offending line to

    icon_info_fn = icon_info.get_filename() if icon_info != None else None

will fix this.
Comment 12 Joseph Wang 2014-04-20 12:00:34 CEST
Thanks for the info.  I'll try to fix it and get a new version out this week.

Any other problems?
Comment 13 Joseph Wang 2014-04-28 17:34:42 CEST
I just pushed out cinnamon-2.0.14-7.mga4.

Can you try that one?  Thanks
Comment 14 Martin Whitaker 2014-04-28 21:25:38 CEST
No problems with this version. Thanks!
Comment 15 Joseph Wang 2014-04-29 04:55:23 CEST
Could you do me one more favor and install the new task-cinnamon that also got pushed out?

Once I get confirmation that that works, I'll push out both packages to QA.
Comment 16 Joseph Wang 2014-04-29 12:44:23 CEST
Sending to QA.  Please test as follows:

* Install cinnamon
* run /usr/bin/cinnamon-menu-editor
* edit menus

Component: RPM Packages => Backports
Assignee: joequant => qa-bugs
Source RPM: cinnamon-2.0.14-5.mga4.src.rpm => cinnamon-2.0.14-7.mga4

Joseph Wang 2014-04-29 12:44:47 CEST

CC: (none) => joequant
Summary: Cannot edit menus in Cinnamon => Backport request: Cannot edit menus in Cinnamon

Comment 17 claire robinson 2014-04-29 13:19:00 CEST
Please don't assign two bugs to QA for the same update, include information from this one in the advisory text for the update and assign one bug for the update. You can use Depends/Blocks in the bugs and add a reference to both bugs in the advisory if you like.

This is all explained in the updates policy I linked on the other bug.

Thanks Joseph.

Assignee: qa-bugs => joequant

Comment 18 Martin Whitaker 2014-04-29 20:43:03 CEST
(In reply to Joseph Wang from comment #15)
> Could you do me one more favor and install the new task-cinnamon that also
> got pushed out?

task-cinnamon installed without any problems.
Comment 19 Philippe Makowski 2014-05-10 15:48:28 CEST
*** Bug 13357 has been marked as a duplicate of this bug. ***

CC: (none) => kristoffer.grundstrom1983

Philippe Makowski 2014-05-10 16:10:02 CEST

CC: (none) => makowski.mageia
Depends on: (none) => 12761

Comment 20 Joseph Wang 2014-05-14 16:01:54 CEST
Can someone test the latest cinnamon package from updates_testing (version 5.2).  There was a bug in 5.1 which caused the sound and other applets not to show up.

The test would be to install the cinnamon package.  Check to see if that sound and color are part of the cinnamon-settings and also right-click the sound applet and select settings to make sure that works.
Comment 21 Philippe Makowski 2014-05-15 22:21:53 CEST
Joseph, it is hard to follow you, with multiple bugs for the same package (12761) and multiple update candidates ....

Assignee: joequant => qa-bugs

claire robinson 2014-05-15 22:24:01 CEST

Assignee: qa-bugs => joequant

Comment 22 claire robinson 2014-05-15 22:24:27 CEST
Please see comment 17, thanks.
Comment 23 Joseph Wang 2014-05-16 10:38:51 CEST
I'll put out an advisory sometime this weekend.  The problem is that since cinnamon is all integrated, there is a non-trivial interaction between bugs, updates, and fixes, and part of it involves me looking into the code to figure out what is going on.

I think I have a set of fixes that work, and I'll put it all into a single advisory with a single set of tests.
Comment 24 Philippe Makowski 2014-05-18 11:27:53 CEST
(In reply to Joseph Wang from comment #20)
> Can someone test the latest cinnamon package from updates_testing (version
> 5.2).  
???
in Cauldron ?
please can we move on mga4 ?
Comment 25 Philippe Makowski 2014-05-18 11:43:30 CEST
sorry, found.
cinnamon-2.0.14-5.2.mga4 found and ok for me on x86_64
Comment 26 Joseph Wang 2014-05-26 14:06:48 CEST
I have uploaded a patched/updated package for Mageia 4.

To test:

1) install the cinnamon package.  This will not work in VirtualBox
64-bit due to a bug in VirtualBox in handling opengl which cinnamon
requires.  The cinnamon package required some changing of directories,
which is prone to cause regressions.  1c) will test for those
regressions.

1a) nautilus should now be orphaned 
1b) execute /usr/bin/cinnamon-menu-editor from the command line.  This
should work
1c) To into the corner start menu.  Right click -> Settings -> open
menu editor
1d) run cinnamon-looking-glass from the command line.  Should have a window
1e) run cinnamon-json-makepot.  Should display help message
2) task-cinnamon now should require pulseaudio.
3) regressions
3a) under hardware in the cinnamon system settings, there should be an
applet color and sound.  Both should work.  Clicking the sound applet
on the panel should bring up a sound volume editors and *not* the
cinnamon-system-settings menu
3b) please check that the power applet is functional and indicates battery life.  The power applet is currently
broken in cauldron due to upower-1.0 changes.  Please confirm that
Mageia 4 does not have this regression.

Suggested advisory:
------------------

Cinnamon and task-cinnamon have been updated to fix the following
bugs.

a) 12560 - The cinnamon-menu-editor was not working.  In addition,
there were additional cinnamon-looking-glass was broken
b) 12761 - Cinnamon pulls in nautilus which is not necessary
c) 12507 - Pulseaudio is now installed with cinnamon


Updated packages in core/updates_testing:
========================
cinnamon-2.0.14-5.3.mga4
task-cinnamon-2.0.0-4.1.mga4
task-cinnamon-devel-2.0.0-4.1.mga4
task-cinnamon-minimal-2.0.0-4.1.mga4

Source RPMs: 
cinnamon-2.0.14-5.3.mga4.src.rpm
task-cinnamon-2.0.0-4.1.mga4.src.rpm
Joseph Wang 2014-05-26 14:08:27 CEST

Assignee: joequant => qa-bugs
Summary: Backport request: Cannot edit menus in Cinnamon => Update request: Cannot edit menus in Cinnamon
Source RPM: cinnamon-2.0.14-7.mga4 => cinnamon-2.0.14-5.3.mga4

Comment 27 Philippe Makowski 2014-05-26 18:56:41 CEST
Test ok on MGA4-64

Whiteboard: (none) => has_procedure mga4-64-ok

Comment 28 Jüri Ivask 2014-05-26 21:23:19 CEST
Tested on Mageia 4 32bit
Seems to be OK. Sound and Network Manager applets settings buttons now open their own settings window, not Cinnamon Control Centre. Could not test power applet as this is desktop computer.

CC: (none) => jyri2000

claire robinson 2014-05-27 15:55:43 CEST

Component: Backports => RPM Packages

Philippe Makowski 2014-05-27 16:10:22 CEST

Whiteboard: has_procedure mga4-64-ok => has_procedure mga4-64-ok mga4-32-ok

Comment 29 claire robinson 2014-05-27 16:12:15 CEST
Adding OK from previous testing. Philippe were you able to test the power applet?

Checked with urpmq ..

pulseaudio is added as a suggest to task-cinnamon-minimal
nautilus is dropped as a require from cinnamon
Comment 30 Philippe Makowski 2014-05-27 16:15:58 CEST
(In reply to claire robinson from comment #29)
> Adding OK from previous testing. Philippe were you able to test the power
> applet?
yes, it was on my laptop.
I tested all that is in comment #26
Comment 31 claire robinson 2014-05-27 16:23:20 CEST
Thankyou. Advisory uploaded, added bug links to the references.

Validating.

Could sysadmin please push to 4 updates

Thanks

Keywords: (none) => validated_update
Whiteboard: has_procedure mga4-64-ok mga4-32-ok => has_procedure advisory mga4-64-ok mga4-32-ok
CC: (none) => sysadmin-bugs

Comment 32 Thomas Backlund 2014-05-29 09:27:22 CEST
Update pushed:
http://advisories.mageia.org/MGAA-2014-0123.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.