Description of problem: Svnserve systemd service is unable to start. Problem is two-fold: - on one side, theres no rule in svnserve.service to create a PID file, thus making the start of svnservice fail - on the other side, svnserve *needs* to be passed the --root folder, which svnserve.service does not IMO subversion rpm should create a /var/svn or /var/subversion folder as standard for the distro, pretty much like Apache does with /var/www. It's not the cleanest way to fix it, but svnserve doesn't seem to allow a general .conf file without overriding per-repository configuration, so it's a matter of convention over configuration. As for the PID problem, just adding PIDFile=/run/svnserve/pid to svnservice.file and changing the --pid parameter is enough to make ir work. Version-Release number of selected component (if applicable): 1.7.9-1 How reproducible: Always Steps to Reproduce: 1. Start svnserve.service either automatically or via systemctl start svnserve.service 2. Service fails to start Reproducible: Steps to Reproduce:
Hardware: i586 => x86_64
Well, the line for PID should probably be PIDFile=/var/run/svnserve.pid to avoid messing with folder creation and such, the previous one was just an attempt to do ir similarly to other .service
Keywords: (none) => TriagedCC: (none) => fundawang, guillomovitch, shlomifVersion: Cauldron => 3
CC: fundawang => (none)
Hi, With subversion-1.7.9-4mga (available on http://pkgsubmit.mageia.org/ ) for Cauldron, this seems to work fine. Can you test it? Regards, -- Shlomi Fish
Yes, it's fixed now, thanks.
someone for make a backport ?
(In reply to Manuel Hiebel from comment #4) > someone for make a backport ? Was it already updated as part of: [Q] ------------------------------------------------------------------------ r442085 | oden | 2013-06-12 13:44:23 +0300 (Wed, 12 Jun 2013) | 2 lines Changed paths: M /updates/3/subversion/current/SPECS/subversion.spec - fix #10500 (apache-mod_dav_svn should require apache-mod_dav or httpd will fail to start.) ------------------------------------------------------------------------ r441922 | oden | 2013-06-11 11:04:38 +0300 (Tue, 11 Jun 2013) | 2 lines Changed paths: M /updates/3/subversion/current/SOURCES/sha1.lst A /updates/3/subversion/current/SOURCES/subversion-1.7.10.tar.bz2.asc D /updates/3/subversion/current/SOURCES/subversion-1.7.9.tar.bz2.asc M /updates/3/subversion/current/SPECS/subversion.spec - 1.7.10 (fixes CVE-2013-2112) [/Q] If not, would an update on such a problem be allowed? Regards, -- Shlomi Fish
Not sure how I missed it when testing before. Probably did, but got sidetracked by the problem getting httpd to start, and forgot to report it. In order to get svnserve.service to start, had to mkdir /run/svnserve, so it looks like it should have a file in /usr/lib/tmpfiles.d/ with d /run/svnserve 755 root root Yes, an update to fix the bug would be allowed.
CC: (none) => davidwhodgins
Submitted as an update to Mageia 3 core/updates_testing to http://pkgsubmit.mageia.org/ . If and once it builds, please test: shlomif[rpms]:$mageia/3/subversion$ mgarepo submit 3/subversion --define section=core/updates_testing -t 3 Fetching revision... URL: svn+ssh://svn.mageia.org/svn/packages/updates/3/subversion Commit: 448230 | shlomif | Fix MGA#9843 - make svnserve systemd task start properly. Package submitted!
Shlomi, you're supposed to be following https://wiki.mageia.org/en/Updates_policy#Maintainer_.28or_any_interested_packager.29 Requires writing an advisory with the list of srpms, rpms, and a description of what's been changed, and then assigning to the qa-bugs address.
I have uploaded a patched/updated package for Mageia 3. You can test this by running «systemctl start svnserve.service» from the command line, and making sure the svnservice is running in a task manager (such as ps auxwwwwwwwwwww, htop, top or KDE's Ctrl+Esc). Also make sure that svn in general is working by running the following command: svn co svn://svn.valgrind.org/valgrind/trunk Suggested advisotry: ======================== Updated Subversion pacakges to fix the svnserve startup: Carlos Vives reported that the "svnserve systemd service is unable to start", and gave a solution. This solution was implemented in these updates. References: http://bugs.mageia.org/show_bug.cgi?id=9843 ======================== Updated packages in core/updates_testing: ======================== apache-mod_dav_svn-1.7.10-1.2.mga3 lib64svn0-1.7.10-1.2.mga3 lib64svn-gnome-keyring0-1.7.10-1.2.mga3 lib64svnjavahl1-1.7.10-1.2.mga3 lib64svn-kwallet0-1.7.10-1.2.mga3 perl-SVN-1.7.10-1.2.mga3 perl-svn-devel-1.7.10-1.2.mga3 python-svn-1.7.10-1.2.mga3 python-svn-devel-1.7.10-1.2.mga3 ruby-svn-1.7.10-1.2.mga3 ruby-svn-devel-1.7.10-1.2.mga3 subversion-1.7.10-1.2.mga3 subversion-devel-1.7.10-1.2.mga3 subversion-doc-1.7.10-1.2.mga3 subversion-gnome-keyring-devel-1.7.10-1.2.mga3 subversion-kwallet-devel-1.7.10-1.2.mga3 subversion-server-1.7.10-1.2.mga3 subversion-tools-1.7.10-1.2.mga3 svn-javahl-1.7.10-1.2.mga3 SRPMS: subversion-1.7.10-1.2.mga3.src.rpm
Assignee: bugsquad => qa-bugs
(In reply to Dave Hodgins from comment #8) > Shlomi, you're supposed to be following > https://wiki.mageia.org/en/Updates_policy#Maintainer_. > 28or_any_interested_packager.29 > > Requires writing an advisory with the list of srpms, rpms, and > a description of what's been changed, and then assigning to the > qa-bugs address. Thanks! I did that now. Regards, -- Shlomi Fish
[root@x3 system]# systemctl status svnserve.service svnserve.service - Subversion protocol daemon Loaded: loaded (/usr/lib/systemd/system/svnserve.service; enabled) Active: active (running) since Mon, 2013-07-01 15:37:09 EDT; 1s ago Using subversion-server from subversion-1.7.10-1.2.mga3.src.rpm on Mageia 3 x86_64.
Whiteboard: (none) => MGA3-64-OK
http://svnweb.mageia.org/advisories/9843.adv?view=markup&sortby=date uploaded
Testing complete Mageia 3 i586. (I did not test all the binary packages, but just what was needed to be able to start svnserve.service, and checking that "svn co" still works as expected). -- Validating update. Please push the update from core/updates_testing to core/updates. Advisory already uploaded (comment 12), and SRPM in comment 9.
Keywords: (none) => validated_updateWhiteboard: MGA3-64-OK => MGA3-32-OK MGA3-64-OKCC: (none) => remi, sysadmin-bugs
http://advisories.mageia.org/MGAA-2013-0046.html
Status: NEW => RESOLVEDCC: (none) => boklmResolution: (none) => FIXED
CC: boklm => (none)