Bug 9304 - new gnome-shell package wall paper does not fill screen (in gdm and lock screen)
Summary: new gnome-shell package wall paper does not fill screen (in gdm and lock screen)
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard: 4beta2
Keywords: Junior_job
: 9320 9822 10109 (view as bug list)
Depends on:
Blocks: 11704 11844
  Show dependency treegraph
 
Reported: 2013-03-09 09:19 CET by Simon Putt
Modified: 2014-01-16 22:58 CET (History)
12 users (show)

See Also:
Source RPM: gnome-shell
CVE:
Status comment:


Attachments
What my 2-monitor gdm screen looks like (323.44 KB, image/jpeg)
2014-01-14 22:34 CET, Reinout van Schouwen
Details

Description Simon Putt 2013-03-09 09:19:03 CET
the new gnome-shell package just built, with the fixed wall paper, has a problem, on my widescreen monitor it does not fill the screen.
Comment 1 Manuel Hiebel 2013-03-09 11:26:30 CET
a screenshot or photo ?
Comment 2 Simon Putt 2013-03-09 12:03:50 CET
not much really to show, the mageia wallpaper is centred with grey bars each side, usually wallpapers are set to fill?
Comment 3 Manuel Hiebel 2013-03-09 12:07:51 CET
yep, I think so, if you know some css (seems I was wrong) 0:)

http://svnweb.mageia.org/packages/cauldron/gnome-shell/current/SOURCES/gnome-shell-3.6.3.1-fix-gdm-background.patch?view=markup&pathrev=401812

(a new background is coming too)
Comment 4 Jani Välimaa 2013-03-10 20:32:15 CET
*** Bug 9320 has been marked as a duplicate of this bug. ***

CC: (none) => kralleforpresident

Comment 5 Dimitri Jakov 2013-04-09 23:35:49 CEST
Same here. I've got a 5:4 1280x1024 display, and I've got horizontal gray bars at the top and at the bottom. In addition to that, the artwork in the center clashes with actual login/password widgets, negatively affecting overall aesthetic feel.

CC: (none) => mitya

Comment 6 Manuel Hiebel 2013-04-22 22:10:25 CEST
*** Bug 9822 has been marked as a duplicate of this bug. ***

CC: (none) => mageia

Comment 7 Manuel Hiebel 2013-04-22 22:14:28 CEST
maybe we should switch back to the state before (ie in black), as I have seen some bugs related to the no possibility to have dynamic background size in the gnome bugzilla

Priority: Normal => release_blocker

Comment 8 Shlomi Fish 2013-04-23 15:40:30 CEST
Hi all,

I cannot reproduce this bug here with gnome-shell on latest cauldron . I have a
dimensions:    1920x1080 pixels (508x285 millimeters) screen and the default wallpaper as well as the two other alternatives work fine.

Regards,

-- Shlomi Fish

CC: (none) => shlomif

Comment 9 Manuel Hiebel 2013-04-23 21:48:51 CEST
because your resolution is listed in /usr/share/mga/backgrounds/
Comment 10 Manuel Hiebel 2013-05-11 21:51:00 CEST
so, could someone remove the patch ?

CC: (none) => nicolas.lecureuil, olav

Manuel Hiebel 2013-05-11 22:16:04 CEST

Summary: new gnome-shell package wall paper does not fill screen => new gnome-shell package wall paper does not fill screen (in gdm and lock screen)

Comment 11 Sander Lepik 2013-05-15 15:44:31 CEST
*** Bug 10109 has been marked as a duplicate of this bug. ***

CC: (none) => eeeemail

Comment 12 Olivier Blin 2013-05-18 14:44:38 CEST
We should not remove this patch, but investigate why /usr/share/mga/backgrounds/default.jpg points to the wrong wallpaper size.
Where does the link point to on your systems?

Is it better after you run XFdrake --auto ? (this may modify your graphics settings)

CC: (none) => anssi.hannula, mageia

Comment 13 Manuel Hiebel 2013-05-18 19:01:26 CEST
well it can't point to the right background for some users (like me there is no 1366*768 png, and patch works only for exact png size)
Comment 14 Olivier Blin 2013-05-18 23:47:28 CEST
For a 1366x768 screen, I guess we should choose the 1920x1080 wallpaper, since they have (approximately) the same ratio.

This is what set_default_background() in /usr/lib/libDrakX/Xconfig/resolution_and_depth.pm is supposed to do.

Does it get fixed if you run XFdrake --auto ?

CC: (none) => thierry.vignaud

Comment 15 Manuel Hiebel 2013-12-05 21:53:46 CET
In reply to Olivier Blin from comment #14)
> For a 1366x768 screen, I guess we should choose the 1920x1080 wallpaper,
> since they have (approximately) the same ratio.
> 
> This is what set_default_background() in
> /usr/lib/libDrakX/Xconfig/resolution_and_depth.pm is supposed to do.
> 
> Does it get fixed if you run XFdrake --auto ?

no, and is still valid in mageia4, seriously, removing the patch was and is certainly best way to do no ?

Keywords: (none) => Junior_job
Blocks: (none) => 11844, 11704
Source RPM: gnome-shell-3.6.3.1-2.mga3 => gnome-shell
Whiteboard: (none) => 4beta2

Comment 16 Thierry Vignaud 2013-12-05 22:13:51 CET
BTW we have the same issue with 1920x1200: theme is properly scaled once logged but not with GDM
Comment 17 Atilla ÖNTAŞ 2014-01-14 10:54:27 CET
I wonder is this bug really a release blocker? I can see gdm and gnome-shell works properly for the reporter and commentators. It should be a cosmetic issue not a functionality. Shouldn't we change the tag?

CC: (none) => tarakbumba

Comment 18 Colin Guthrie 2014-01-14 11:14:51 CET
Well considering our last release had it, I don't think it's a release blocker either. I actually spoke to upstream about it and did a few tweaks but none of them really worked out that well.

Still chatting to see if we can find a solution.
Comment 19 Manuel Hiebel 2014-01-14 15:03:41 CET
well we can remove integration of the background, it will fix it like already said
Comment 20 Reinout van Schouwen 2014-01-14 22:34:42 CET
Created attachment 4791 [details]
What my 2-monitor gdm screen looks like

I was about to file a bug for this weird gdm background on multiple monitors and then found this bug. Is it the same? It looks quite strange...

CC: (none) => reinout

Comment 21 Colin Guthrie 2014-01-16 19:37:35 CET
I've committed a fix for this to gnome-shell. Should work fine now thanks to some help from upstream.
Comment 22 Manuel Hiebel 2014-01-16 21:22:09 CET
Personnaly, I see the blue of the background, not the complete one, but it is much better than before anyway. Thanks.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 23 Colin Guthrie 2014-01-16 22:23:17 CET
(In reply to Manuel Hiebel from comment #22)
> Personnaly, I see the blue of the background, not the complete one, but it
> is much better than before anyway. Thanks.

Ooops, seems my testing of the CSS change was bogus. I matched the colour of the background, to avoid artefacts when changing monitor setups, but this doesn't actually make sense as it goes *over* the image :s

I've removed the CSS tweak. It looks good without it under normal circumstances so no real need for that change anyway. Should be fixed in next push :)
Comment 24 Colin Guthrie 2014-01-16 22:54:32 CET
So a small point... the backgrounds of the login screen and the password entry screen after lock are fixed, but the default image on the actual shield is unchanged. This is a dconf key AFAIK, org.gnome.desktop.screensaver.picture-uri

Not sure which package we should change this in tho.
Comment 25 Colin Guthrie 2014-01-16 22:58:00 CET
(In reply to Colin Guthrie from comment #24)
> Not sure which package we should change this in tho.

OK, so seems it would be in /usr/share/glib-2.0/schemas/glib2-branding.gschema.override from mageia-theme-gnome

We already override the background for the general desktop, but not the screen lock. Would just be an extra line or two if we want to use the same image for the lock screen. Not sure we do tho'... I'm no designer!

Note You need to log in before you can comment on or make changes to this bug.