Bug 9302 - post script fails for ppp during mga2 -> mga3 upgrade
Summary: post script fails for ppp during mga2 -> mga3 upgrade
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker minor
Target Milestone: ---
Assignee: Colin Guthrie
QA Contact:
URL: http://picpaste.com/4a39d7649f3dec098...
Whiteboard: 3beta3
Keywords:
Depends on:
Blocks: 8016
  Show dependency treegraph
 
Reported: 2013-03-09 06:38 CET by bozonius
Modified: 2013-04-17 14:29 CEST (History)
9 users (show)

See Also:
Source RPM: ppp
CVE:
Status comment:


Attachments
report.bug.xz (189.07 KB, application/x-xz)
2013-03-18 14:49 CET, claire robinson
Details

Description bozonius 2013-03-09 06:38:27 CET
Description of problem:
Error window appears during upgrade to mageia 3


Version-Release number of selected component (if applicable):
Mageia-3-beta3-i586-DVD.iso

How reproducible:
Starting with mga2 install with all updates, upgrade to mageia 3 using the Mageia-3-beta3-i586-DVD.iso

Steps to Reproduce:
1.  upgrade mageia 2 using Mageia-3-beta3-i586-DVD.iso 
2.  choose upgrade (do not destroy existing install)
3.  except for the partitioning option, use defaults
4.  wait for "INSTALLING" stage when this error occurs

Workaround:
Hit return or continue and the install proceeds


Reproducible: 

Steps to Reproduce:
bozonius 2013-03-09 11:11:02 CET

URL: (none) => http://picpaste.com/4a39d7649f3dec09882e17f55684bd39.png

Comment 1 Manuel Hiebel 2013-03-09 11:25:31 CET
can you attach your file /root/drakx/upgrade.log (or ddebug.log) I don't remember

Keywords: (none) => NEEDINFO
Component: Release (media or process) => RPM Packages
Source RPM: (none) => ppp

Comment 2 claire robinson 2013-03-18 13:49:35 CET
Confirmed here. I'll add some logs when it's done.

Whiteboard: (none) => 3beta3

Comment 3 claire robinson 2013-03-18 14:49:44 CET
Created attachment 3633 [details]
report.bug.xz

report.bug.xz from failed upgrade.

Tried to complete the upgrade several times so there may be some repetition but ERROR: 'sript' failed for ppp only showed once.
claire robinson 2013-03-18 14:49:56 CET

Keywords: NEEDINFO => (none)

Comment 4 Manuel Hiebel 2013-03-19 00:22:42 CET
interesting part:

<27>[  830.867847] systemd-tmpfiles[2072]: Failed to open initscripts.conf: No such file or directory
<27>[  833.725800] systemd-tmpfiles[2098]: Failed to open ppp.conf: No such file or directory

* installed package ppp-2.4.5-6.mga2.i586 is conflicting with initscripts-9.41-12.mga3.i586 (Conflicts: ppp[<= 2.4.5-7])
* promoting ppp-2.4.5-14.mga3.i586 because of conflict above
* selecting ppp-2.4.5-14.mga3.i586
* set_rejected: ppp-2.4.5-6.mga2.i586

* urpmi error: ERROR: 'script' failed for ppp-2.4.5-14.mga3.i586: 

%post(ppp-2.4.5-14.mga3.i586) scriptlet failed, exit status 1
ppp-2.4.5-14.mga3.i586

file /var/run/ppp/resolv.conf: remove failed: No such file or directory
file /var/run/ppp: remove failed: No such file or directory

Priority: Normal => release_blocker
CC: (none) => arnaud.patard, johnny, mageia, thierry.vignaud
Blocks: (none) => 8016
Summary: script fails for ppp during mga2 -> mga3 upgrade => post script fails for ppp during mga2 -> mga3 upgrade

Comment 5 Luc Menut 2013-03-19 01:19:15 CET
(In reply to Manuel Hiebel from comment #4)
> interesting part:
> 
> <27>[  830.867847] systemd-tmpfiles[2072]: Failed to open initscripts.conf:
> No such file or directory
> <27>[  833.725800] systemd-tmpfiles[2098]: Failed to open ppp.conf: No such
> file or directory
> 
...
> 
> * urpmi error: ERROR: 'script' failed for ppp-2.4.5-14.mga3.i586: 
> 
> %post(ppp-2.4.5-14.mga3.i586) scriptlet failed, exit status 1
> ppp-2.4.5-14.mga3.i586

ppp postinstall scriptlet is
/usr/bin/systemd-tmpfiles --create ppp.conf

another interesting part of the log is update order of initscripts, ppp and systemd:

xzcat report.bug.xz | grep -n "ERROR: 'script'\|update of initscripts\|update of ppp\|update of systemd"
20450:* trans: scheduling update of initscripts-9.41-12.mga3.i586
20457:* trans: scheduling update of ppp-2.4.5-14.mga3.i586
20458:* urpmi error: ERROR: 'script' failed for ppp-2.4.5-14.mga3.i586: 
20553:* trans: scheduling update of systemd-units-195-15.mga3.i586
20638:* trans: scheduling update of systemd-195-15.mga3.i586

systemd is updated after initscripts and ppp, and here is the problem, because initscripts and ppp postinstall scripts run with mga2 systemd-tmpfiles, which only supports absolute path for <program.conf>, and fails to open initscripts.conf and ppp.conf.

@Colin
All packages that use %_tmpfilescreate *.conf should probably need a
  Requires(post) systemd >= systemd_version_that_handle_basename_conf
to ensure that a recent systemd is installed before the update of these packages.

btw, in most of cases couldn't we make %_tmpfilescreate program.conf non fatal (by appending || /usr/bin/true) in case of error ?

CC: (none) => lmenut
Hardware: i586 => All

Comment 6 Thierry Vignaud 2013-03-19 07:11:53 CET
That would be "|| :"
Comment 7 Colin Guthrie 2013-03-19 10:47:45 CET
Ahh right yeah good catch re the versioned requires.

I'm not sure about the "|| :" appending tho'. It's masking a genuine error in that case. I mean if in the old days RPM failed to create the /var/run/foo dir on package installation, would you expect it to be silent about it?

Sure these are usually trivial errors but they can still affect a service from running. e.g. I have had several bug reports about people installing something and then saying it doesn't start due to tmpfiles not running properly...
Comment 8 Colin Guthrie 2013-03-19 10:48:08 CET
Assigning to me.

Assignee: bugsquad => mageia

claire robinson 2013-03-19 10:57:11 CET

CC: (none) => eeeemail

Comment 9 claire robinson 2013-03-19 16:58:37 CET
mpage script failed in today's upgrade from beta3 dvd, showed a pop-up error with ppp and mpage.

Is this a separate issue or another symptom of the same one? 

There's nothing obvious in report.bug.
https://dl.dropbox.com/u/4147101/mga3b3/report2.bug.xz

urpmi error: ERROR: 'script' failed for mpage-2.5.6-5.mga3.i586:
Comment 10 claire robinson 2013-03-19 17:00:15 CET
Also a new one of these..

systemd-tmpfiles[2180]: Failed to open httpd.conf: No such file or directory
Comment 11 Luc Menut 2013-03-19 22:53:22 CET
(In reply to Colin Guthrie from comment #7)
...
> I'm not sure about the "|| :" appending tho'. It's masking a genuine error
> in that case. 

hum, I understand, but IIUC it's what happen when there are other commands that run fine after %_tmpfilescreate.
urpmi seems to return with error on a script only when the last command fails.
eg. in c5, systemd-tmpfiles fails for initscripts and ppp but we have "urpmi error: ERROR: 'script' failed " only for ppp, but not for initscripts because the commands after %_tmpfilescreate don't fail.
Comment 12 Luc Menut 2013-03-19 22:56:30 CET
(In reply to claire robinson from comment #9)
> mpage script failed in today's upgrade from beta3 dvd, showed a pop-up error
> with ppp and mpage.
> 
> Is this a separate issue or another symptom of the same one? 
> 
> There's nothing obvious in report.bug.
> https://dl.dropbox.com/u/4147101/mga3b3/report2.bug.xz
> 
> urpmi error: ERROR: 'script' failed for mpage-2.5.6-5.mga3.i586:

I don't understand this error because mpage doesn't have any script.

Thierry, an idea?
Comment 13 Luc Menut 2013-03-19 23:02:34 CET
(In reply to claire robinson from comment #10)
> Also a new one of these..
> 
> systemd-tmpfiles[2180]: Failed to open httpd.conf: No such file or directory

same problem as comment 5; apache is updated before systemd.

xzcat report2.bug.xz | grep -n "ERROR: 'script'\|update of initscripts\|update of ppp\|update of apache\|update of systemd"
23693:* trans: scheduling update of initscripts-9.41-12.mga3.i586
23703:* trans: scheduling update of ppp-2.4.5-14.mga3.i586
23705:* urpmi error: ERROR: 'script' failed for ppp-2.4.5-14.mga3.i586: 
23796:* trans: scheduling update of apache-mod_perl-2.0.7-11.mga3.i586
23840:* trans: scheduling update of apache-2.4.4-1.mga3.i586
23855:* trans: scheduling update of systemd-195-15.mga3.i586
23869:* trans: scheduling update of systemd-units-195-15.mga3.i586
25500:* trans: scheduling update of apache-commons-logging-1.1.1-21.mga3.noarch 
25763:* urpmi error: ERROR: 'script' failed for mpage-2.5.6-5.mga3.i586: 
26480:* trans: scheduling update of apache-commons-codec-1.7-2.mga3.noarch 
26555:* trans: scheduling update of apache-commons-lang-2.6-9.mga3.noarch
27091:* trans: scheduling update of apache-mod_php-5.4.12-2.mga3.i586
Comment 14 bozonius 2013-03-21 03:07:20 CET
Just tested the upgrade on the Mageia-3-beta3-i586-DVD in my VB environment and it still errors.  (Just to confirm; this is now VB 4.2.10, still under Scientific Linux 6.3)
bozonius 2013-03-21 03:48:31 CET

CC: (none) => bozonius

Comment 15 bozonius 2013-03-21 03:55:20 CET
Maybe this is interesting? 

From console 4, I notice the following:  http://picpaste.com/830b8de36b83b193eb8c54938ae74a3b.png

I suggest that perhaps the installer expects files that don't exist yet?  I will examine my installed Mageia 2 environment in a moment...
Comment 16 bozonius 2013-03-21 04:18:12 CET
BTW, my upgraded VM does NOT hang this time.

I did not experience the httpd error Claire reports, though, just for the record.

And the system comes up in X and the KDE desktop; no errors after reboot.
Comment 17 bozonius 2013-03-21 04:28:05 CET
Back to my M2 VM state:  There is no /etc/ppp.conf or /etc/ppp/ppp.conf file (would it be somewhere else? it doesn't seem to come with the M2 ppp).

There is, however, an initscripts.conf file in /etc/tmpfiles.d.  

My M2 configuration should be pretty much what comes with its installer, plus any updates to those packages.  I don't recall installing anything else, or modifying my /etc in any way.  This VM install was strictly for testing upgrade to M3B3.
Comment 18 claire robinson 2013-03-21 09:37:02 CET
(In reply to bozonius from comment #16)
> I did not experience the httpd error Claire reports, though, just for the
> record.

Did you install apache before upgrading?
Comment 19 Colin Guthrie 2013-03-21 10:15:45 CET
[colin@jimmy ~]$ urpmf ppp.conf
ppp:/usr/lib/tmpfiles.d/ppp.conf

This is all to do with the tmpfiles.d config. I've not yet gone through and done a mass-update of the packages using this so the error will obviously still exist until it has been fixed! I will try and do so shortly.
Comment 20 bozonius 2013-03-22 00:55:20 CET
(In reply to claire robinson from comment #18)
> (In reply to bozonius from comment #16)
> > I did not experience the httpd error Claire reports, though, just for the
> > record.
> 
> Did you install apache before upgrading?

(DOH!)  no.  sorry.
Comment 21 Colin Guthrie 2013-03-22 17:43:02 CET
FWIW, I'm waiting for my git-svn clone of all packages to perform this update. I hope to be able to do it over the weekend.
Comment 22 Colin Guthrie 2013-03-24 22:05:32 CET
I've fixed all the packages calling %tmpfilescreate macro to require a newer systemd such that they should be ordered correctly on upgrade.
Comment 23 Colin Guthrie 2013-03-24 23:04:56 CET
And I've now also fixed a whole bunch of other packages that were not using the nice tmpfiles macros but calling it directly.
Comment 24 Malo Deniélou 2013-04-15 18:21:59 CEST
Hi Colin, what is the status on that one? Thanks.

CC: (none) => pierre-malo.denielou

Comment 25 Colin Guthrie 2013-04-15 18:56:20 CEST
So this should be fixed now AFAIK. We were waiting for people to test things, but nobody has said much.

I'll go ahead and close this as any other occurrence of it will likely be reported outside of this bug.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 26 claire robinson 2013-04-15 19:26:54 CEST
I'll check it again now with boot.iso. RC DVD's are not yet available.
Comment 27 claire robinson 2013-04-16 20:22:29 CEST
Not sure if it's the same thing but with upgrade from 3RC DVD

ERROR: 'script' failed for firefox-gl-17.0.5-1.mga3.noarch.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 28 Thierry Vignaud 2013-04-16 20:23:57 CEST
Obviously, it's a different issue, so please open another bug report

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 29 Thierry Vignaud 2013-04-16 20:29:10 CEST
(with your /root/drakx/report.bug.xz)
Comment 30 claire robinson 2013-04-16 20:29:49 CEST
This affects more than ppp Thierry so nothing obvious about it.
Comment 31 Thierry Vignaud 2013-04-16 20:50:05 CEST
The previous bug was ppp post script faillure.
Now you've another package that is buggy.
that has nothing to do with _this_ bug report which is about ppp faillure.
Comment 32 claire robinson 2013-04-16 20:51:54 CEST
New bug 9766 created, please find logs there, (why?) although it appears to be the same issue.
Comment 33 claire robinson 2013-04-16 20:52:41 CEST
Little point asking for tests and then berating the results..
Comment 34 Colin Guthrie 2013-04-17 14:29:43 CEST
Just to round this off, this bug ultimately did affect several packages as was made obvious in comment 5 and comment 7 but the bug title was not updated to reflect this.

Sadly the logs don't provide much information other than "script failed" so it's not immediately obvious to reporters if the problem is the same or something different.

Just a bit of a communication breakdown and mismatch of "technical-obviousness" vs. "observable-obviousness". I'm certain no offence was meant by anyone :)

Anyway, glad this upgrade issue is fixed :)

Note You need to log in before you can comment on or make changes to this bug.