Bug 7578 - diskdrake thinks all pre-existing partitions in LVM on LUKS are ext4
Summary: diskdrake thinks all pre-existing partitions in LVM on LUKS are ext4
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker critical
Target Milestone: ---
Assignee: Pascal Terjan
QA Contact:
URL:
Whiteboard: 3alpha3 MGA4TOO 5beta3
Keywords:
Depends on:
Blocks: 14069
  Show dependency treegraph
 
Reported: 2012-09-26 00:59 CEST by Joe Shmoe
Modified: 2015-04-27 11:21 CEST (History)
6 users (show)

See Also:
Source RPM: drakxtools
CVE:
Status comment:


Attachments

Description Joe Shmoe 2012-09-26 00:59:44 CEST
diskdrake claims that partitions in an LVM on LUKS previously formatted as e.g. XFS, JFS or swap are ext4. Consequently, it cannot mount them.


To reproduce:

1. Create partition $fubar in an LVM on LUKS and format it as e.g. XFS, JFS or swap. Use any system or diskdrake in Mageia 3alpha1 to do that, but do *not* set a mount point.

2. Reboot into 3alpha1.

3. Start diskdrake, enter LUKS key. Partition $fubar will be shown as ext4.

4. Set mount point and click mount. Mounting fails.

However, diskdrake behaves correctly after vgchange -ay and then either

A. mount $fubar /somewhere, or

B. blkid $fubar.

I reproduced this in an installed, updated 3alpha1 on a physical i586 machine and in the 3alpha1 net installer in an x86_64 VM.


Bug 4238 may be related, but there it seems blkid does not work, while this bug here occurs even though blkid works.


Pascal, I'm sure policy does not allow me to assign bugs, but I hope it is okay in this case, because of what Marja said:
https://bugs.mageia.org/show_bug.cgi?id=5505#c16
Joe Shmoe 2012-09-26 01:00:08 CEST

Whiteboard: (none) => 3alpha1

Comment 1 Joe Shmoe 2012-10-16 11:11:23 CEST
Reproduced in 3alpha2 net installer (vmlinuz/all.rdz from 02-Oct-2012).

Whiteboard: 3alpha1 => 3alpha2

Comment 2 Joe Shmoe 2012-11-25 21:00:13 CET
Reproduced in 3alpha3 Live DVD Gnome x86_64, both in the installer selected in grub or in the live system's diskdrake.

However, this same LVM on LUKS setup was created by the the 3alpha3 Dual CD. It installed itself into this LVM and works.
Comment 3 Joe Shmoe 2012-11-25 21:01:06 CET
Reproduced in 3alpha3 Live DVD Gnome x86_64, both in the installer selected in grub or in the live system's diskdrake.

However, this same LVM on LUKS setup was created by the the 3alpha3 Dual CD. It installed itself into this LVM and works.
Joe Shmoe 2012-11-25 21:03:12 CET

Source RPM: (none) => drakxtools
Whiteboard: 3alpha2 => 3alpha3

Manuel Hiebel 2012-11-25 21:29:38 CET

CC: (none) => thierry.vignaud

Glen Ogilvie 2013-03-17 01:11:08 CET

CC: (none) => nelg

Comment 4 Glen Ogilvie 2013-03-17 01:11:35 CET
should this be a release blocker?
Comment 5 Raphael Gertz 2013-04-10 10:33:53 CEST
I rise the severity to critical as it trashed a luks partition in an install with a version of installer 2

CC: (none) => mageia
Severity: normal => critical

Comment 6 Samuel Verschelde 2015-04-23 12:46:59 CEST
There has been some work on diskdrake and the installer since then. Can you tell me if this bug is still valid in Mageia 4 and if possible in latest Cauldron ?
Samuel Verschelde 2015-04-23 12:47:17 CEST

Keywords: (none) => NEEDINFO

Comment 7 Joe Shmoe 2015-04-24 13:32:26 CEST
Still valid with Mageia-4.1-LiveDVD-KDE4-x86_64-DVD.iso and Mageia-5-beta3-LiveCD-KDE4-en-i586-CD.iso.
Samuel Verschelde 2015-04-24 13:51:06 CEST

Keywords: NEEDINFO => (none)
Whiteboard: 3alpha3 => 3alpha3 MGA4TOO 5beta3

Comment 8 claire robinson 2015-04-24 18:12:35 CEST
Setting release_blocker as it could affect DVD upgrades.

Please verify the bug exists in 5 RC isos which should be released over the weekend. There have been many changes between beta3 and RC so things might have changed.

Priority: Normal => release_blocker

claire robinson 2015-04-24 18:13:13 CEST

CC: (none) => mageia, tmb
Blocks: (none) => 14069

claire robinson 2015-04-24 18:17:53 CEST

CC: (none) => eeeemail

Comment 9 Joe Shmoe 2015-04-26 11:44:33 CEST
Bug still valid with Mageia-5-RC-LiveCD-KDE4-en-i586-CD.iso in Virtualbox.

The blkid workaround I gave works when running the Live system (then either diskdrake from Control Center or the Live installer), but does not seem to get diskdrake to work when booting directly into the installer.
Comment 10 Pascal Terjan 2015-04-27 00:01:18 CEST
This was supposed to be fixed by those 2 commits:

http://gitweb.mageia.org/software/drakx/commit/perl-install/diskdrake/interactive.pm?id=4974a4e759e2672b058d2c506b0f45d15ff762ee
http://gitweb.mageia.org/software/drakx/commit/perl-install/diskdrake/interactive.pm?id=3980ebfd98fe7be5cce63bdfba0c567a052d996a

But reading them:
- It will not run vgchange -ay if not in installer
- It will not update the view of the disks after doing so, so will not know there  is a new LVM as this is done a few lines earlier
Comment 11 Mageia Robot 2015-04-27 00:08:11 CEST
commit 1e292ec66fcad786a80a29af904b06f2f62ca2db
Author: Pascal Terjan <pterjan@...>
Date:   Sun Apr 26 22:08:01 2015 +0000

    Run vgchange before updating the list of LVMs, not after, and even if not
    in install (should help with mga#7578).
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=1e292ec66fcad786a80a29af904b06f2f62ca2db
Comment 12 Joe Shmoe 2015-04-27 11:07:15 CEST
I booted into the installer in Mageia-5-RC-LiveCD-KDE4-en-i586-CD.iso and manually applied the patch from Comment #11. This fixed my bug.
Comment 13 Thierry Vignaud 2015-04-27 11:21:15 CEST
Closing.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.