Bug 7553 - php-5.3.x is built (in full!) four times
Summary: php-5.3.x is built (in full!) four times
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 2
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Thomas Spuhler
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on: 7618
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-23 08:59 CEST by Oden Eriksson
Modified: 2012-10-06 15:47 CEST (History)
1 user (show)

See Also:
Source RPM: php-5.3.15-1.mga2.src.rpm
CVE:
Status comment:

Attachments
spec file patch (7.17 KB, patch)
2012-09-23 09:00 CEST, Oden Eriksson 		Details | Diff
mod_php patch (5.02 KB, patch)
2012-09-23 09:00 CEST, Oden Eriksson 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Oden Eriksson 2012-09-23 08:59:37 CEST 
Hi,

php-5.2.x is built (in full!) four times. In Mandriva it's built once.

I talked about this on IRC but there seems to be low interest fixing it, so I fixed it for you (because I always uses the latest version here).

Two patches are attached to this bug, for the spec file and for fixing the mod_php.so apache module.

Please note I also changed mod_php5/mod_php in there which now triggers a bug in the /etc/httpd/conf/fileprotector.conf file:

-----
<IfDefine HAVE_PHP>
    <IfModule !mod_php4.c>
        <IfModule mod_dir.c>
            <FilesMatch "\.(php|php3|php4|php5|phps|phtml)$">
                ErrorDocument 403 "<h1>403 Forbidden: Execute Access Forbidden</h1><p>The server \
                is currently not serving php4 scripts.</p><p>This could mean the server administrator \
                is doing maintenance or has orphan php files laying around, please contact the server \
                administrator or come back later. Thank you.</p>
                Order allow,deny
                Deny from all
            </FilesMatch>
        </IfModule>
    </IfModule>
</IfDefine>
-----

You have to change mod_php4.c/mod_php.c in that file (apache-2.2.22-12.mga2.src.rpm).

Cheers.
Comment 1 Oden Eriksson 2012-09-23 09:00:03 CEST 
Created attachment 2845 [details]
spec file patch
Comment 2 Oden Eriksson 2012-09-23 09:00:37 CEST 
Created attachment 2846 [details]
mod_php patch
Oden Eriksson 2012-09-23 09:02:48 CEST

Summary: php-5.2.x is built (in full!) four times => php-5.3.x is built (in full!) four times

Comment 3 Oden Eriksson 2012-09-23 09:03:22 CEST 
I meant php-5.3.x here, sorry.
Manuel Hiebel 2012-09-23 20:37:19 CEST

Keywords: (none) => PATCH
Assignee: bugsquad => thomas

David Walser 2012-09-29 16:23:01 CEST

Depends on: (none) => 7618

Thomas Spuhler 2012-09-29 17:39:56 CEST

Status: NEW => ASSIGNED

Comment 4 Thomas Spuhler 2012-09-29 18:15:21 CEST 
What is the real problem? It's not a security issue, is it?
Often updates result in breakages.
I am not sure if we want to do this as an update as maintaining mga 1 ends in December.
Please provide some reasons.
Comment 5 Oden Eriksson 2012-09-30 08:59:21 CEST 
There are two problems:

It takes too long to build it locally for tests.

As in cauldron I fixed the build of mod_php the more correct way. Previousely in cauldron mod_php was built from the php.spec file but against an older and installed php-devel, which could mean for example php-cli-5.4.6-1 but apache-mod_php-5.4.6-1 that is really apache-mod_php-5.4.5-1.
Comment 6 Nicolas Lécureuil 2012-09-30 22:51:10 CEST 
i am all for this change.

CC: (none) => nicolas.lecureuil

Comment 7 Manuel Hiebel 2012-10-06 15:47:48 CEST 
update pushed

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.