Bug 6897 - Keypress segfaults fontforge in character view with 5 or more spline points selected.
Summary: Keypress segfaults fontforge in character view with 5 or more spline points s...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 2
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: mga2-32-ok mga2-64-ok
Keywords: PATCH, Triaged, UPSTREAM, validated_update
Depends on:
Blocks:
 
Reported: 2012-07-29 02:54 CEST by William Murphy
Modified: 2013-09-19 11:29 CEST (History)
4 users (show)

See Also:
Source RPM: fontforge-1.0-0.20110222.3.mga2.src.rpm
CVE:
Status comment:


Attachments

Description William Murphy 2012-07-29 02:54:21 CEST
Description of problem: 
Editing glyphs in character view of fontforge segfaults if 5 or more spline points have been selected and any keyboard key is pressed.

A gdb backtrace of the segfault in the x86_64 version provides no useful information, but the i586 version show the segfault happening in cvundoes.c:552
The CodeView stucture, cv, seems to be corrupted at that point and the index into cv->layerheads is out of bounds.

Version-Release number of selected component (if applicable):
fontforge-1.0-0.20110222.3.mga2.i586.rpm
fontforge-1.0-0.20110222.3.mga2.x86_64.rpm

How reproducible:
Every time.

Steps to Reproduce:
1. Open any vector based font (ttf or type1 for example) in fontforge.
2. Double click on any basic Latin character to open character view. Make sure the glyph you choose is not a reference to another glyph.
3. Either shift-click or click-drag to select 5 or more spline points, then release shift, if necessary.
4. Press any key.
Comment 1 Shlomi Fish 2012-09-11 19:22:08 CEST
I can reproduce this here (Mageia Linux 2 x86-64).

Regards,

-- Shlomi Fish

CC: (none) => shlomif

Comment 2 Shlomi Fish 2012-09-11 20:02:22 CEST
(In reply to comment #1)
> I can reproduce this here (Mageia Linux 2 x86-64).
> 
> Regards,
> 
> -- Shlomi Fish

OK, it seems to be fixed in the new fontforge package (with version 20120731-b) that I packaged for Mageia Cauldron. Please try to build the .src.rpm locally and let me know if it fixed the problem for you:

http://pkgsubmit.mageia.org/

Regards,

-- Shlomi Fish
Comment 3 Samuel Verschelde 2013-09-06 17:08:27 CEST
William Murphy, could you please answer to Shlomi Fish so that we know that it was fixed and we can issue an update candidate to fontforge in Mageia 2?

Keywords: (none) => NEEDINFO, PATCH, Triaged, UPSTREAM
CC: (none) => stormi

Comment 4 William Murphy 2013-09-07 05:55:45 CEST
(In reply to Samuel VERSCHELDE from comment #3)
> William Murphy, could you please answer to Shlomi Fish so that we know that
> it was fixed and we can issue an update candidate to fontforge in Mageia 2?

Was just reminded to turn on email in my preferences a few weeks ago. All on now. Sorry about that... :-|

> (In reply to comment #1)
> OK, it seems to be fixed in the new fontforge package (with version
> 20120731-b) that I packaged for Mageia Cauldron. Please try to build the
> .src.rpm locally and let me know if it fixed the problem for you:

> Regards,
> 
> -- Shlomi Fish

Yes, it's been working nicely since then. No more segfaults. Thank you. :)
Comment 5 Shlomi Fish 2013-09-07 08:10:07 CEST
> > (In reply to comment #1)
> > OK, it seems to be fixed in the new fontforge package (with version
> > 20120731-b) that I packaged for Mageia Cauldron. Please try to build the
> > .src.rpm locally and let me know if it fixed the problem for you:
> 
> > Regards,
> > 
> > -- Shlomi Fish
> 
> Yes, it's been working nicely since then. No more segfaults. Thank you. :)

You're welcome. I've rebuilt it for Mageia 2 in core/updates_testing and now QA should check it. See http://pkgsubmit.mageia.org/ .

Regards,

-- Shlomi Fish
Comment 6 Shlomi Fish 2013-09-07 08:29:11 CEST
Hi all,

I'm assigning this package ( fontforge ) to QA, but did not write the advisory yet because there is no easy way to list the packages and create a template of the advisory. I think there should be such a template in the "uploaded" fold of each package here:

http://pkgsubmit.mageia.org/

If you can tell me how to create a list of the right RPMs and SRPMs, please do so. Sorry for being a little spoiled.

Regards,

-- Shlomi Fish

Status: NEW => ASSIGNED
Assignee: bugsquad => qa-bugs

Comment 7 Samuel Verschelde 2013-09-07 09:19:30 CEST
(In reply to Shlomi Fish from comment #6)
> If you can tell me how to create a list of the right RPMs and SRPMs, please
> do so. Sorry for being a little spoiled.

You can get them from the rpm build logs, or wait for a few hours and produce them from http://mageia.madb.org/tools/updates, "RPMs" link
Samuel Verschelde 2013-09-07 09:19:39 CEST

Keywords: NEEDINFO => (none)

Comment 8 claire robinson 2013-09-16 11:34:54 CEST
Mageia 2

partial match


*** Arch: i586 ***

RPMs from 'core-updates_testing'
========================
fontforge-1.0-0.20120731.1.mga2.i586.rpm

SRPMs from 'core-updates_testing'
========================
fontforge-1.0-0.20120731.1.mga2.src.rpm

*** Arch: x86_64 ***

RPMs from 'core-updates_testing'
========================
fontforge-1.0-0.20120731.1.mga2.x86_64.rpm

SRPMs from 'core-updates_testing'
========================
fontforge-1.0-0.20120731.1.mga2.src.rpm
Comment 9 claire robinson 2013-09-16 15:10:41 CEST
Testing complete mga2 32

Before
------
libpng: libpng.so.2: cannot open shared object file: No such file or directory
libpng: libpng.so.2: cannot open shared object file: No such file or directory
libpng: libpng.so.2: cannot open shared object file: No such file or directory
Segmentation fault


After
-----
libpng: libpng.so.2: cannot open shared object file: No such file or directory
libpng: libpng.so.2: cannot open shared object file: No such file or directory
libpng: libpng.so.2: cannot open shared object file: No such file or directory

No segfault.

We don't appear to have libpng.so.2. Is that anything to be concerned about?

Whiteboard: (none) => mga2-64-ok

claire robinson 2013-09-16 15:10:53 CEST

Whiteboard: mga2-64-ok => mga2-32-ok

Comment 10 claire robinson 2013-09-16 17:13:54 CEST
Testing complete mga2 64

Whiteboard: mga2-32-ok => mga2-32-ok mga2-64-ok

Comment 11 claire robinson 2013-09-16 17:19:14 CEST
Validating. Advisory uploaded.

Could sysadmin please push from 2 core/updates_testing to updates

Thanks!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 12 Thomas Backlund 2013-09-19 11:29:35 CEST
Update pushed:
:http://advisories.mageia.org/MGAA-2013-0106.html

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.