Bug 6609 - impossible to complete spider solitaire game, scheme error when trying to move a full deck to the foundation
Summary: impossible to complete spider solitaire game, scheme error when trying to mov...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 2
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard: mga2-32-OK mga2-64-OK
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2012-06-28 18:52 CEST by Christian Lohmaier
Modified: 2012-06-30 20:23 CEST (History)
4 users (show)

See Also:
Source RPM: aisleriot-3.4.1-1.mga2.src.rpm
CVE:
Status comment:


Attachments

Description Christian Lohmaier 2012-06-28 18:52:53 CEST
description copied from the bgo bug:
Play spider until you have a finished stack (king down to ace of one suit) on
the tableau, then double click it. That should send the stack up to the
foundation, but instead you get a scheme exception:

Variation: spider
Scheme error:
    (#f Wrong type (expecting ~A): ~S (exact integer ((1 3 #t) (2 3 #t) (3 3
#t) (4 3 #t) (5 3 #t) (6 3 #t) (7 3 #t) (8 3 #t) (9 3 #t) (10 3 #t) (11 3 #t)
(12 3 #t) (13 3 #t) (3 1 #f) (13 0 #f))) (((1 3 #t) (2 3 #t) (3 3 #t) (4 3 #t)
(5 3 #t) (6 3 #t) (7 3 #t) (8 3 #t) (9 3 #t) (10 3 #t) (11 3 #t) (12 3 #t) (13
3 #t) (3 1 #f) (13 0 #f))))
Scheme tag:
    wrong-type-arg

Backtrace:
[visit bugs.gnome.org if you're interesting in the boring numbers)

The fix is simple, but there has not been a new release with the fix yet (although it was committed to the 3.4 branch), thus I request a patched version by mageia for the meantime.

commit 5824bce7a75df921a481c9491bdafcd67b9f2f75
Author: Vincent Povirk <madewokherd gmail com>
Date:   Mon May 28 09:29:59 2012 -0500

    api.scm: Use correct arguments to list-tail.
    
    For bug 676924.

 games/api.scm |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/games/api.scm b/games/api.scm
index f38ad1f..6249fb7 100644
--- a/games/api.scm
+++ b/games/api.scm
@@ -545,7 +545,7 @@
   (add-cards! end-slot cards))
 
 (define-public (remove-n-cards slot-id n)
-  (set-cards! slot-id (list-tail n (get-cards slot-id))))
+  (set-cards! slot-id (list-tail (get-cards slot-id) n)))
 
 (define-public (deal-cards-from-deck deck slot-list)
   (if (not (null? slot-list))
Jani Välimaa 2012-06-28 22:18:52 CEST

Status: NEW => ASSIGNED
CC: (none) => jani.valimaa
Assignee: bugsquad => jani.valimaa

Comment 1 Jani Välimaa 2012-06-28 22:38:16 CEST
Pushed new release [1] to core/updates_testing which should fix this. Please test. Happy times with playing solitaire. :)

[1] aisleriot-3.4.1-1.1.mga2

Status: ASSIGNED => NEW
Assignee: jani.valimaa => qa-bugs

Comment 2 Rémi Verschelde 2012-06-28 23:11:31 CEST
Okay, after 20 minutes of losing at Spider Solitaire I managed to reproduce the bug :P
Still testing on Mageia 2 i586.

CC: (none) => remi

Comment 3 Rémi Verschelde 2012-06-28 23:30:41 CEST
Update OK on Mageia 2 i586 and Mageia 2 x86_64.
The bug could be reproduced and is fixed by the update. No regression has been spotted while testing the Spider variant or other game variants.

--

Validating update.

--

Advisory:
=========

This update includes a patch which fixes a bug generating a scheme exception when double-clicking a complete stack on the Spider variant of the game.

See https://bugzilla.gnome.org/show_bug.cgi?id=676924 for more information.


SRPM:
=====

aisleriot-3.4.1-1.mga2.src.rpm

--

Could a sysadmin push the update from core/updates_testing to core/updates?
Thanks in advance.

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Whiteboard: (none) => mga2-32-OK mga2-64-OK

Comment 4 Christian Lohmaier 2012-06-29 01:47:53 CEST
confirm the fix - thanks a lot for the quick update
Comment 5 Thomas Backlund 2012-06-30 20:23:50 CEST
Update pushed:
https://wiki.mageia.org/en/Support/Advisories/MGAA-2012-0096

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.