Bug 65 - add btrfs in normal partitioning mode
Summary: add btrfs in normal partitioning mode
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal enhancement
Target Milestone: Mageia 3
Assignee: Thomas Backlund
QA Contact:
URL: http://svnweb.mageia.org/soft/drakx/t...
Whiteboard:
Keywords: NEEDINFO
Depends on: 4238 8644
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-16 23:45 CET by AL13N
Modified: 2013-04-07 10:57 CEST (History)
6 users (show)

See Also:
Source RPM: drakx-installer-stage2, btrfs-progs
CVE:
Status comment:


Attachments

Description AL13N 2011-02-16 23:45:33 CET
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101230 Mandriva Linux/1.9.2.13-0.2mdv2010.2 (2010.2) Firefox/3.6.13
Build Identifier: 

Description of problem:

in partitioning, you cannot choose btrfs except if you choose expert, this can easily be added if reiser, xfs, jfs, etc... are in the same list...

Reproducible: 

Steps to Reproduce:
Comment 1 Rémy CLOUARD (shikamaru) 2011-02-21 22:31:20 CET
Hello, the btrfs is still experimental and under heavy development, until it becomes stable, we should only provide it as an expert option.

Status: NEW => RESOLVED
CC: (none) => shikamaru
Resolution: (none) => WONTFIX

Comment 2 AL13N 2011-02-21 23:53:24 CET
dude, that's totally not true, btrfs has been disk-stable since iirc 2.6.27 and included in mainline kernel...

there's even distro's rolling it out as default one...

imho don't go off deciding this on your own, let's ask someone with some good kernel knowledge like pterjan or tmb...

Status: RESOLVED => REOPENED
Resolution: WONTFIX => (none)

Comment 3 Ahmad Samir 2011-02-22 00:37:46 CET
(In reply to comment #2)
> dude, that's totally not true, btrfs has been disk-stable since iirc 2.6.27 and
> included in mainline kernel...
> 
> there's even distro's rolling it out as default one...
> 
> imho don't go off deciding this on your own, let's ask someone with some good
> kernel knowledge like pterjan or tmb...

Good point; I assume you know how to use the CC function in bugzilla? no? OK, I'll CC tmb myself... (I don't know pterjan's email in LDAP, so can't CC him).

(FWIW, there's always an implicit AFAIK, just sometimes people seem to miss it).

CC: (none) => tmb

Comment 4 Rémy CLOUARD (shikamaru) 2011-02-22 10:42:33 CET
No, thatâs not right, from btrfs wiki (https://btrfs.wiki.kernel.org/index.php/Main_Page):

âBtrfs is under heavy development, but every effort is being made to keep the filesystem stable and fast. As of 2.6.31, we only plan to make forward compatible disk format changes, and many users have been experimenting with Btrfs on their systems with good results. Please email the Btrfs mailing list if you have any problems or questions while using Btrfs.

Note that Btrfs does not yet have a fsck tool that can fix errors. While Btrfs is stable on a stable machine, it is currently possible to corrupt a filesystem irrecoverably if your machine crashes or loses power on disks that don't handle flush requests correctly. This will be fixed when the fsck tool is ready. â

Many unstable things get into mainline kernel, that does not mean they are ready for production, and I bet btrfs driver is marked as experimental. Could you point me to a distribution that goes with btrfs by default ? AFAIK meego go with that, but their stable release isnât expected too come out that soon and is still under heavy development, links to prove what you say would be welcome.

As far as Iâm concerned, I prefer to go better safe than sorry, remember that the goal for first release is not to bring new features.
Comment 5 Thomas Backlund 2011-02-22 19:49:06 CET
btrfs got included upstream in 2.6.29-rc1

As of kernel 2.6.37 I do consider btrfs stable for usage, 
(it would have been 2.6.36, but due to a late git pull request to Linus, it got postponed)

but the issues are:
- missing error fixing tool
  (btrfsck finds the errors, but can not repair them yet)
- no grub/lilo support
  (can be worked around with separate /boot)


So for now I think it should stay in "expert" mode, because of the missing error fixing.... 

This can be re-evaluted if the btrfs-progs gets their needed fixes soon
(Chris Mason (btrfs maintainer) stated in Q3/2010 that he probably would work on in in the coming months, but so far nothing have happend)
Comment 6 AL13N 2011-02-22 21:34:22 CET
@ahmad: i'm sorry about the implicit AFAIK, but tbf, it did look like a bit like an uninformed drop.

@shikamaru: that wiki page is mostly unchanged since around 2.6.27 , there is a fsck tool as tmb pointed out. (and i was talking about meego, and tbf i wouldn't place it as default at all)
Also, if jfs, xfs and reiserfs is in the same list, ... even though some of those are already present for a long time, it doesn't mean they have no issues (i still hear of failures in reiserfs and xfs, and i wouldn't trust jfs with my /tmp . don't forget that last year ext4 "failed" as well.

But i understand your point

@tmb: thanks for your insight and extra info, imo, we should follow your judgement on this. perhaps we should wait until both of the issues are resolved.
Comment 7 Ahmad Samir 2011-02-22 22:08:17 CET
(In reply to comment #6)
> @ahmad: i'm sorry about the implicit AFAIK, but tbf, it did look like a bit
> like an uninformed drop.
> 

You got me wrong, I meant there's an implicit AFAIK in shikamaru's post, that's what the btrfs wiki page on kernel.org said, and he's not a kernel hacker.

[....]

> @tmb: thanks for your insight and extra info, imo, we should follow your
> judgement on this. perhaps we should wait until both of the issues are
> resolved.

There's no "perhaps", we must follow his lead since he's the kernel maintainer/hacker :)
Comment 8 AL13N 2011-02-22 23:24:46 CET
(In reply to comment #7)
> You got me wrong, I meant there's an implicit AFAIK in shikamaru's post, that's
> what the btrfs wiki page on kernel.org said, and he's not a kernel hacker.

ah, good point

> There's no "perhaps", we must follow his lead since he's the kernel
> maintainer/hacker :)

it isn't because we have no choice, that we shouldn't try to phrase this as if we did have a choice :-)

and otoh, the part i was talking about, is about the list of available options in non-expert mode, which is not in the kernel package, but is in /soft somewhere, iirc. :-P

but ok, you can close it as appropriate.
D Morgan 2011-02-25 00:03:29 CET

CC: (none) => dmorganec
Assignee: ahmadsamir3891 => bugsquad

Comment 9 Thomas Backlund 2011-02-26 14:23:39 CET
Some updates...

~2 weeks ago Chris Mason stated the new btrfsck is 90% ready and he's working fulltime on it now, so if we are lucky, it will be ready at the same time we switch to 2.6.38 kernel wich has seen some nice improvements for btrfs :)
Comment 10 AL13N 2011-02-26 17:02:39 CET
awesome news!
Thomas Backlund 2011-04-17 17:20:55 CEST

Target Milestone: --- => Mageia 2

Comment 11 AL13N 2011-05-22 10:55:27 CEST
it appears grub 1.99 now supports btrfs ; is this something that can be patched into 0.9x version?
Comment 12 Marja Van Waes 2011-09-28 23:06:28 CEST
Did the problem still exist in Mageia 1 rc? (And in Mageia 1?)

CC: (none) => m.van.waes
Source RPM: (none) => drakx-installer-stage2
Whiteboard: (none) => NEEDINFO

Comment 13 Manuel Hiebel 2011-09-28 23:11:08 CEST
Yes I think.

CC: (none) => thierry.vignaud
Whiteboard: NEEDINFO => (none)

Comment 14 AL13N 2011-09-29 04:34:06 CEST
See comment 5, 9 and 11. There could be a way to do this for cauldron (maybe). I guess it would be up to the btrfs maintainer to decide...
Comment 15 Marja Van Waes 2011-09-29 08:09:08 CEST
(In reply to comment #14)
> See comment 5, 9 and 11. There could be a way to do this for cauldron (maybe).
> I guess it would be up to the btrfs maintainer to decide...

There isn't a btrfs maintainer yet :(
Comment 16 Thomas Backlund 2011-09-29 11:12:59 CEST
Well,

the btrfs-progs that could fix any problems on filesystem level are still not available.


Last stats update by upstream on August 3, 2011:

"This part is definitely my fault.  I've gone through a bunch of
variations on bigger and smaller tools, and had to juggle the kernel
maintenance as well.

Aside from making sure the kernel code is stable, btrfsck is all I'm
working on right now.  I do expect a release in the next two weeks that
can recover your data (and many others)."


But still nothing...
Comment 17 AL13N 2011-09-29 20:11:42 CEST
that is too bad... :-( in the main time perhaps you could be a btrfs maintainer?
Comment 18 Marja Van Waes 2011-10-23 13:04:45 CEST
Added UPSTREAM keyword

Last message (oct. 10th) of Chris Mason I found in http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg12717.html:

I wish there were bigger forces at play here than me just not having it
finished yet, but that's all there is to it.

Keywords: (none) => UPSTREAM
Source RPM: drakx-installer-stage2 => drakx-installer-stage2, btrfs-progs

Comment 19 Thomas Backlund 2011-10-23 13:55:20 CEST

Yeah,
I'm monitoring the btrfs ml pretty much on a daily basis in hope of working tools ...

But at the rate it's going, I'm not even sure we will have in Mageia 2
Comment 20 AL13N 2011-10-23 14:20:36 CEST
that's too bad, i hope chris has some time to finish this, so we can get started with it for real.
Comment 21 Thomas Backlund 2011-10-27 18:47:11 CEST
Well, we finally have some movement..

Chris have now merged Hugo's integration tree (wich is mostly bugfixes / enhancements to current code)

Next up for merge is Josef's recovery tool, and then Chris metadata scanning code will be merged and a new beta will be released to testing.

I just pushed an updated snapshot with the integration tree fixes to Cauldron
Comment 22 AL13N 2011-10-27 20:26:12 CEST
awesome!
Comment 23 Marja Van Waes 2011-12-17 21:42:59 CET
@ tmb

any more news?

Please assign to yourself if upstream has come with a patch. (And then please set to the assigned status too, or, if for workflow reasons you can't do that, put OK on the whiteboard instead).
Comment 24 Marja Van Waes 2012-01-31 22:01:44 CET
last snapshot updated to was of 2011-12-01, on december 24th and tmb did another update shortly after that.

@ tmb

assigning to you now, because you clearly showed your intention to import the fixed package when it is available, and that'll be soon, if it didn't already happen :)

Please set status to assigned when you are working on this bug

Assignee: bugsquad => tmb

Comment 25 Thomas Backlund 2012-02-09 16:59:18 CET
Yep.

We are working having btrfs available as an option for Mageia 2, but it wont be used by default.

Upstream says final btrfs-progs rewrite should be available around Feb 15, 2012 (but I'll belive that when I see it)

Status: REOPENED => ASSIGNED
Depends on: (none) => 4238

Comment 26 Thierry Vignaud 2012-03-09 14:36:41 CET
Time to package a newer snapshot?
(See http://www.phoronix.com/scan.php?page=news_item&px=MTA2MDI)
Comment 27 AL13N 2012-03-09 17:41:14 CET
hmm, still, perhaps wait a bit longer... allthough obviously this could be oracle delaying it so it can have it first on their own linux...
Comment 28 Thierry Vignaud 2012-03-09 18:14:19 CET
Or more likeley they rushed in order to include it but eventually it's not that good near/past the deadline and they're painfully working on it...
Comment 29 AL13N 2012-03-09 19:49:05 CET
afaik only cmason is working on the fsck tool. and he was "nearly" finish already some time ago, which means oracle is giving him other stuff to do...
Comment 30 Thomas Backlund 2012-03-09 21:31:39 CET
Yeah, it was supposed to be released in final version around February 15th, but as usual nothing :/

I've been monitoring that "dangerdontuse" branch, and will package a newer snapshot soon, but probably not before beta2 is out...
Comment 31 Thomas Backlund 2012-05-10 17:37:30 CEST
btrfs is available

Resolution: (none) => FIXED
Status: ASSIGNED => RESOLVED

Comment 32 AL13N 2012-05-10 17:45:45 CEST
yay :-)

is it now show on the standard stuff? or do i still need to select advanced?
AL13N 2013-01-10 15:01:08 CET

Depends on: (none) => 8644

AL13N 2013-01-10 15:02:45 CET

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 33 AL13N 2013-02-09 00:06:44 CET
i'm guessing having btrfs in the standard stuff is still offlimits?, perhaps we can put this on mga4 milestone if necessary
Manuel Hiebel 2013-02-09 02:49:42 CET

Keywords: UPSTREAM => (none)
URL: (none) => http://svnweb.mageia.org/soft/drakx/trunk/perl-install/fs/type.pm?revision=6891&view=markup#l21
Target Milestone: Mageia 2 => Mageia 3
Summary: no btrfs in normal partitioning mode => add btrfs in normal partitioning mode
Severity: minor => enhancement

Comment 34 Thierry Vignaud 2013-02-09 11:06:47 CET
It should already be available providing you switch to expert mode.
Can you check that?
I did quite a lot of fixes for btrfs support but I don't remember all the details.
We could enable it in std mode if fsck works fine (Thomas?).

Keywords: (none) => NEEDINFO

Comment 35 Manuel Hiebel 2013-02-09 12:14:03 CET
yep it's already in expert mode
Comment 36 AL13N 2013-02-09 14:55:01 CET
for mga2 i already used it with expert mode
Comment 37 Jari S 2013-03-10 19:51:35 CET
In advanced partition mode you can add btrfs partitions, however the module is not loaded so mounting the partitions fail. This was tested with Mageia 3 beta 2. You can overcome this by going to console and doing "modprobe btrfs" manually, after which the installation can continue. Not tested with beta 3 since it came out 4 hours I installed my machine :)

CC: (none) => lihamakaroonilaatikko

Comment 38 AL13N 2013-03-10 20:10:37 CET
i did expert mode, right now, using mga cauldron via netbook, (should be somewhat equal to beta 3), and i had no problem making it btrfs, and continueing, formatting, ... etc...


which iso did you choose, what exact partition combination how many drives did you do, was it a virtual machine if so which type?, etc...


iow: we need an exact reproducer.
Comment 39 Jari S 2013-03-11 08:07:41 CET
Desktop, amd64+2Gb memory, 60G Kingston SSD, no other drives, NVIDIA display card

Bare metal
Boot from USB stick with Beta 2 (made with dd if⦠ofâ¦)
Advanced partition scheme (MBR)
Automatic partition layout
Separate /usr
Change /usr and /home to btrfs
Continue
Say format to all partitions
Continue installation
Results in message: "Unable to mount UUID⦠/mnt/usr"

Workaround:
Go to console
modprobe btrfs
Redo partition
Redo format all partitions
Result: installation continues normally
Comment 40 AL13N 2013-03-11 09:23:43 CET
what happens if you go to custom layout and choose btrfs there?
Comment 41 Manuel Hiebel 2013-03-11 20:03:24 CET
well debugging a beta2 is now kind of useless, try a netinstall or wait for classical isos.
Comment 42 Jari S 2013-03-20 14:31:14 CET
Looks like it is fixed in Beta3, at least in custom layout path.
Comment 43 Thomas Backlund 2013-04-06 19:39:41 CEST
(In reply to Thierry Vignaud from comment #34)
> It should already be available providing you switch to expert mode.
> Can you check that?
> I did quite a lot of fixes for btrfs support but I don't remember all the
> details.
> We could enable it in std mode if fsck works fine (Thomas?).


It should work ok, so I think we should show btrfs in standard installer mode for mga3
Comment 44 Thierry Vignaud 2013-04-07 10:57:57 CEST
Fixed in SVN

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.