Bug 6073 - phatch crash
Summary: phatch crash
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 2
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA2-32-OK mga2-64-OK
Keywords: validated_update
Depends on: 2317
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-24 21:40 CEST by aurelien werner
Modified: 2012-07-10 16:51 CEST (History)
5 users (show)

See Also:
Source RPM: phatch-0.2.7.1-2.mga2
CVE:
Status comment:


Attachments

Description aurelien werner 2012-05-24 21:40:03 CEST
Description of problem:
Error 0:Impossible d'ouvrir le fichier: /home/aurelien/Images/2012/chtipark/IMG_0785.jpg:
'module' object has no attribute 'Image'


Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/phatch/core/api.py", line 493, in get_photo
    photo = pil.Photo(info_file, info_not_file)
  File "/usr/lib/python2.7/site-packages/phatch/core/pil.py", line 457, in __init__
    layer.image)
  File "/usr/lib/python2.7/site-packages/phatch/core/pil.py", line 183, in __init__
    self.pyexiv2 = pyexiv2.Image(path)
AttributeError: 'module' object has no attribute 'Image'
*


How reproducible:
launch phatch and execute a traitement on a picture



phatch does not work with pyexiv2 >= 0.2 !!!
Comment 1 aurelien werner 2012-05-24 21:55:02 CEST
python-pyexiv2 is an optional dependencie of phatch !!!

But :
# urpmq -d phatch|grep exiv
lib64exiv2_11
python-exiv2

Without the package "python-exiv2" phatch works !
Manuel Hiebel 2012-05-27 12:19:17 CEST

Keywords: (none) => Junior_job
Assignee: bugsquad => mageia

Comment 2 Damien Lallement 2012-05-30 00:36:50 CEST
Can you please test phatch-0.2.7.1-2.mga2?

Status: NEW => ASSIGNED

Comment 3 Damien Lallement 2012-05-30 01:26:44 CEST
(In reply to comment #2)
> Can you please test phatch-0.2.7.1-2.mga2?

In fact it's: phatch-0.2.7.1-1.1.mga2
Comment 4 Damien Lallement 2012-06-18 19:16:09 CEST
Hello,

Any news on this bug?
Comment 5 aurelien werner 2012-06-21 14:26:37 CEST
phatch-0.2.7.1-2.mga2 works ! :)

The exif data are saved.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 6 Manuel Hiebel 2012-06-21 19:10:34 CEST
A package that stay on testing are useless.

So it needs to be moved in updates thought the QA and sysadmins.
Aurelien can you tell us on which architecture you are ?


For the QA:

Suggested advisory:
========================

Updated phatch fixes a crash happening when performing a treatment.

SRPM: phatch-0.2.7.1-1.1.mga2.src.rpm

Status: RESOLVED => REOPENED
CC: (none) => mageia
Resolution: FIXED => (none)
Assignee: mageia => qa-bugs
Severity: major => normal

Comment 7 user7 2012-06-23 15:59:02 CEST
testing on MGA2, i586.

CC: (none) => wassi

Comment 8 user7 2012-06-23 16:12:02 CEST
Completed testing on i586, MGA2

I could reproduce the problem and can confirm the update fixes it. However, no entry in the launch menu is created for phatch upon installation. This should be fixed IMHO.
Comment 9 Damien Lallement 2012-06-25 11:23:03 CEST
(In reply to comment #8)
> Completed testing on i586, MGA2
> 
> I could reproduce the problem and can confirm the update fixes it. However, no
> entry in the launch menu is created for phatch upon installation. This should
> be fixed IMHO.

Thanks for testing.
You didn't find an entry in the menu for phatch? That's what you mean?
Strange, I have two: "Phatch Image Inspector" and "Phatch PHoto baTCH Processor"
Comment 10 Damien Lallement 2012-06-25 11:58:11 CEST
Ok, sorry, I need to sleep. Missing a .desktop for "phatch". WIP. :-)
Comment 11 Damien Lallement 2012-06-25 12:48:01 CEST
No, I'm not drunk. No need to add .desktop. Nothing missing for me.
user7, what did you meant with your comment please?
Comment 12 Damien Lallement 2012-06-25 12:54:54 CEST
Suggested advisory:
========================

This update of phatch add a missing require and allow it to be run with python-exiv2.

SRPM: phatch-0.2.7.1-1.2.mga2.src.rpm

Source RPM: phatch-0.2.7.1-1.mga2 => phatch-0.2.7.1-2.mga2

Comment 13 user7 2012-06-25 13:43:29 CEST
> You didn't find an entry in the menu for phatch?
Yes, exactly.

I'm using KDE (standard menu), MGA2, i586. There is no entry for phatch - not in the graphics category, but also not in any other section.

Anything I should check?

Btw: I'm currently on #mageia-qa.
Comment 14 user7 2012-06-25 16:16:46 CEST
Ok, my bad. It seems that my menu configuration was not vanilla, therefore the entry was not shown (it's in a submenu that was not present).

For anybody else who runs into this problem: The KDE menu editor has an option called "Restore default settings" -> this helps you out. :)

---

Retested on i586, MGA2 - SRPM: phatch-0.2.7.1-1.2.mga2.src.rpm
I could reproduce the problem, the update fixes it. It also now pulls mlocate as a new dependency. Therefore, this could be affected by bug 2317. Whoever validates, please check this!

Thanks.

Whiteboard: (none) => MGA2-32-OK

Comment 15 Dave Hodgins 2012-07-01 22:19:14 CEST
According to the depcheck script, the following packages will require linking

mlocate-0.25-2.mga2 (Core Release (distrib1))
notification-daemon-0.7.4-1.mga2 (Core Release (distrib1))
pinentry-gtk2-0.8.1-3.mga2 (Core Release (distrib1))
pinentry-qt4-0.8.1-3.mga2 (Core Release (distrib1))
xfce4-notifyd-0.2.2-2.mga2 (Core Release (distrib1))

We still need 64 bit testing on phatch.

CC: (none) => davidwhodgins

claire robinson 2012-07-02 16:10:21 CEST

Depends on: (none) => 2317

Comment 16 claire robinson 2012-07-02 16:35:07 CEST
Testing complete x86_64

Validating

Suggested advisory:
========================

This update to phatch adds a missing require and allows it to be run with
python-exiv2.

SRPM: phatch-0.2.7.1-1.2.mga2.src.rpm

Links required to workaround bug 2317

mlocate-0.25-2.mga2 (Core Release (distrib1))
notification-daemon-0.7.4-1.mga2 (Core Release (distrib1))
pinentry-gtk2-0.8.1-3.mga2 (Core Release (distrib1))
pinentry-qt4-0.8.1-3.mga2 (Core Release (distrib1))
xfce4-notifyd-0.2.2-2.mga2 (Core Release (distrib1))

Could sysadmin please push from core/updates_testing to core/updates and do the required linking.

Thanks!

Keywords: Junior_job => validated_update
CC: (none) => sysadmin-bugs
Whiteboard: MGA2-32-OK => MGA2-32-OK mga2-64-OK

Comment 17 claire robinson 2012-07-09 16:01:00 CEST
Rechecking for tmb with new depcheck..

----------------------------------------
Running checks for "phatch" using media
"Core Release" and "Core Updates Testing".
----------------------------------------
Mageia release 2 (Official) for x86_64
Latest version found in "Core Release" is phatch-0.2.7.1-1.mga2
Latest version found in "Core Updates Testing" is phatch-0.2.7.1-1.2.mga2
----------------------------------------
The following packages will require linking:

mlocate-0.25-2.mga2 (Core 32bit Release)
mlocate-0.25-2.mga2 (Core Release)
----------------------------------------
Done.
Comment 18 Thomas Backlund 2012-07-10 16:51:34 CEST
Update pushed:
https://wiki.mageia.org/en/Support/Advisories/MGAA-2012-0103

Status: REOPENED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.