Bug 6035 - check the option of mgaapplet-upgrade-helper before the launch
Summary: check the option of mgaapplet-upgrade-helper before the launch
Status: REOPENED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard: MGA2TOO
Keywords: Junior_job
Depends on:
Blocks:
 
Reported: 2012-05-23 08:07 CEST by Jeff Robins
Modified: 2017-03-29 08:09 CEST (History)
3 users (show)

See Also:
Source RPM: mgaonline
CVE:
Status comment:


Attachments

Description Jeff Robins 2012-05-23 08:07:55 CEST
Running the following as root clears the RPM sources, downloads new ones and displays a Congratulations window saying that the "Upgrade to Mageia  release was successfull." (I left in the extra space and spelling error).

#mgaapplet-upgrade-helper --new_distribution_version=2

It does not upgrade to Mageia 2 however, nor does it give an error.  It sets all of the sources to the Mageia 1 sources.  Using the argument "new_distro_version" does work.

Thank you,

Jeff
Comment 1 Manuel Hiebel 2012-05-23 08:16:12 CEST
indeed it was working fine yesterday :/

sysadmin, any change in the api ?

Priority: Normal => High
Assignee: bugsquad => sysadmin-bugs
Severity: normal => major

Manuel Hiebel 2012-05-23 08:23:04 CEST

CC: (none) => mageia-webteam

Comment 2 Nicolas Vigier 2012-05-23 10:25:39 CEST
Release 2 has been added to api now. Can you try again ?

CC: (none) => boklm

Comment 3 Jeff Robins 2012-05-23 10:41:51 CEST
Unfortunately I needed to start the upgrade and the upgrade worked once I used the proper switch/option, so I started the upgrade process.  I'd rather not take a chance and quit the process.  I'm on package 1374 of 2210.

After looking at Manuel's post he may have missed that I used the wrong switch/option when I ran it initially (I spelled out the whole word "distribution").  I'm just reporting that the program doesn't provide an error and provides a misleading output when the wrong switches/options are used.

I had a look at the mgaapplet-upgrade-helper script and it just looks like there is no check for invalid switches/options. 

Thank you,

Jeff
Comment 4 Manuel Hiebel 2012-05-23 11:00:45 CEST
My bad, it seems the option was changed since 2010.2 sorry :/

http://svnweb.mageia.org/soft/mgaonline/trunk/mgaapplet-upgrade-helper?revision=4158&view=markup

48 	$::rpmdrake_options{$1}[0] = $2;
49 	} elsif ($opt =~ /--new_distro_version=(.*)/) {
50 	$new_distro_version = $1;

with mgaapplet-upgrade-helper --new_distro_version=2 it works fine 

/me change the wiki
Comment 5 Manuel Hiebel 2012-05-23 11:03:21 CEST
ok sorry all

Keywords: (none) => Junior_job
Priority: High => Normal
CC: mageia-webteam => thierry.vignaud
Assignee: sysadmin-bugs => bugsquad
Summary: mgaapplet-upgrade-helper --new_distribution_version=2 no upgrade or error => check the option of mgaapplet-upgrade-helper before the launch
Source RPM: (none) => mgaonline
Severity: major => enhancement

Comment 6 Thierry Vignaud 2012-05-23 12:09:56 CEST
What are you saying? The --new_distro_version option never changed and is named this since its introduction in 2008
Comment 7 Manuel Hiebel 2012-05-23 12:12:02 CEST
yes sorry, I was wrong at any point on this bug...
Comment 8 Thierry Vignaud 2012-05-23 14:14:33 CEST
Closing then

Status: NEW => RESOLVED
Resolution: (none) => INVALID

Comment 9 Jeff Robins 2012-05-23 19:02:13 CEST
I still think there is a problem because the script will run without checking for required arguments.  I did not supply "new_distro_version" and the script still ran like I did and gave me a congratulations message.

Also, we should probably fix the spelling of successful.

--Jeff

Status: RESOLVED => REOPENED
Resolution: INVALID => (none)

Comment 10 Thierry Vignaud 2012-05-24 08:19:45 CEST
You're not supposed to run it anyway.
Mgapplet is the one that starts it.
Comment 11 Jeff Robins 2012-05-24 08:45:02 CEST
There are instructions for running it manually in the Release Notes, which I freely admit I screwed up. If we never provided instructions on how to run the 
program manually, then I could see the argument for not checking the arguments.  

TBH, I would add argument checking anyway because it shouldn't be too much work and the program isn't time critical.

Providing some documentation on the script would also be helpful, even if it's just with the "--help" argument.

--Jeff
Manuel Hiebel 2012-10-31 20:15:05 CET

Version: 1 => Cauldron
Whiteboard: (none) => MGA2TOO

Nicolas Vigier 2014-03-24 10:52:23 CET

CC: boklm => (none)

Florian Hubold 2015-11-24 17:39:52 CET

CC: (none) => doktor5000

Comment 12 Samuel Verschelde 2015-11-24 18:10:31 CET
Assigning to tv who, I believe, is the maintainer for mgaonline. Are you? If so, please update the maintainers database.

Assignee: bugsquad => thierry.vignaud

Marja Van Waes 2017-03-29 08:09:55 CEST

CC: (none) => marja11
Assignee: thierry.vignaud => mageiatools


Note You need to log in before you can comment on or make changes to this bug.