Bug 5525 - DKMS module iscsi target does not compile under 2_b3
Summary: DKMS module iscsi target does not compile under 2_b3
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 2
Hardware: i586 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA2-64-OK MGA2-32-OK
Keywords: PATCH, validated_update
Depends on:
Blocks: 7057
  Show dependency treegraph
 
Reported: 2012-04-20 22:47 CEST by mnaud mnaud
Modified: 2012-09-23 18:39 CEST (History)
5 users (show)

See Also:
Source RPM: iscsitarget
CVE:
Status comment:


Attachments
installation and compilation logs file. (2.96 KB, text/plain)
2012-04-20 22:47 CEST, mnaud mnaud
Details
make.log for iscsitarget (1.15 KB, text/plain)
2012-08-17 23:47 CEST, Dave Hodgins
Details

Description mnaud mnaud 2012-04-20 22:47:37 CEST
Created attachment 2056 [details]
installation and compilation logs file.

the initial installation of dkms-iscsitarget-1.4.20.3-1.mga2.i586.rpm failed.

the module does not compile.

cf attachment for more details.
Manuel Hiebel 2012-04-22 00:53:46 CEST

CC: (none) => ennael1, thierry.vignaud, tmb
Source RPM: (none) => iscsitarget

Comment 1 Marja Van Waes 2012-05-26 13:06:48 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Comment 2 Dave Hodgins 2012-08-17 23:47:15 CEST
Created attachment 2655 [details]
make.log for iscsitarget

This bug is present in Mageia 2.
Dave Hodgins 2012-08-17 23:48:00 CEST

Keywords: NEEDINFO => (none)
CC: (none) => davidwhodgins
Blocks: (none) => 7057

Comment 3 Dave Hodgins 2012-08-18 04:35:41 CEST
The same error occurs in Mageia 1.

Whiteboard: (none) => MGA1TOO

Comment 4 José Jorge 2012-09-11 13:52:07 CEST
Confirmed here on Mageia 2.

CC: (none) => lists.jjorge

Comment 5 José Jorge 2012-09-11 14:01:29 CEST
This patch fixed the bug for me in MGA2 x86_64 :

http://iscsitarget.svn.sourceforge.net/viewvc/iscsitarget/trunk/kernel/wthread.c?r1=444&r2=471

but I don't understand the way patches are applied in the Makefile of this package?
Thierry Vignaud 2012-09-11 16:47:00 CEST

Keywords: (none) => PATCH

Comment 6 José Jorge 2012-09-17 14:06:21 CEST
Ok, patch done, I will upload it to testing tonight

Status: NEW => ASSIGNED

José Jorge 2012-09-17 14:06:35 CEST

Assignee: bugsquad => lists.jjorge

Comment 7 José Jorge 2012-09-17 22:00:26 CEST
Suggested advisory:
========================

Updated iscsitarget packages fix dkms build:

The package provided in MGA2 could not build against recent linux kernels. 

This update uses upstream trunk fixes, not released as a new version for now.

========================

Updated packages in core/updates_testing:
========================
iscsitarget-1.4.20.3-1.1.mga2.x86_64.rpm
dkms-iscsitarget-1.4.20.3-1.1.mga2.x86_64.rpm
iscsitarget-debug-1.4.20.3-1.1.mga2.x86_64.rpm

Source RPM: 
iscsitarget-1.4.20.3-1.1.mga2.src.rpm
José Jorge 2012-09-17 22:01:05 CEST

Assignee: lists.jjorge => qa-bugs

Comment 8 Samuel Verschelde 2012-09-18 22:51:38 CEST
What about Mageia 1? Will there be an update too?

Version: Cauldron => 2

Comment 9 Dave Hodgins 2012-09-19 02:00:04 CEST
Testing complete on Mageia 2 x86-64.

I'm using an unmounted partition on sda9, and open-iscsi for testing ...
$ tail -n 3 /etc/ietd.conf
Target iqn.2012-08.x2.hodgins.homeip.net:storage.homeShare
Lun 0 Path=/dev/sda9,Type=blockio

$ cat /etc/iscsi/initiatorname.iscsi
# Set an InitiatorName here
InitiatorName=iqn.2012-08.x2.hodgins.homeip.net:storage.homeShare

Not sure if it's needed, but based on various tutorials I set
# grep ^node.startup /etc/iscsi/iscsid.conf
node.startup = automatic

I can see the iscsi device as shown by ...
# iscsiadm -m discovery -t st -p 192.168.10.102
192.168.10.102:3260,1 iqn.2012-08.x2.hodgins.homeip.net:storage.homeShare

I can login to the iscsi target ...
# iscsiadm -m node --target "iqn.2012-08.x2.hodgins.homeip.net:storage.homeShare" --portal "192.168.10.102:3260" --login
Logging in to [iface: default, target: iqn.2012-08.x2.hodgins.homeip.net:storage.homeShare, portal: 192.168.10.102,3260]
Login to [iface: default, target: iqn.2012-08.x2.hodgins.homeip.net:storage.homeShare, portal: 192.168.10.102,3260]: successful

From /var/log/syslog ...
Sep 18 19:44:34 x2 kernel: [ 1329.745455] scsi10 : iSCSI Initiator over TCP/IP
Sep 18 19:44:34 x2 kernel: [ 1330.002740] scsi 10:0:0:0: Direct-Access     IET      VIRTUAL-DISK     0    PQ: 0 ANSI: 4
Sep 18 19:44:34 x2 kernel: [ 1330.004544] sd 10:0:0:0: [sdb] 1024000 512-byte logical blocks: (524 MB/500 MiB)
Sep 18 19:44:34 x2 kernel: [ 1330.006360] sd 10:0:0:0: [sdb] Write Protect is off
Sep 18 19:44:34 x2 kernel: [ 1330.006368] sd 10:0:0:0: [sdb] Mode Sense: 77 00 00 08
Sep 18 19:44:34 x2 kernel: [ 1330.006654] sd 10:0:0:0: [sdb] Write cache: disabled, read cache: disabled, doesn't support DPO or FUA
Sep 18 19:44:34 x2 kernel: [ 1330.008281]  sdb:
Sep 18 19:44:34 x2 kernel: [ 1330.009096] sd 10:0:0:0: [sdb] Attached SCSI disk
Sep 18 19:44:34 x2 iscsid: connection1:0 is operational now

I can then mount the device with
mount -t auto /dev/sdb /mountpoint
and view the contents in /mountpoint.

I'll test Mageia 2 i586 shortly.

Whiteboard: MGA1TOO => MGA1TOO MGA2-64-OK

Comment 10 Dave Hodgins 2012-09-19 02:26:22 CEST
Testing complete on Mageia 2 i586.

José, Would you prefer to have this update validated, and a new bug
report opened for Mageia 1, or wait until Mageia 1 is updated too?

Whiteboard: MGA1TOO MGA2-64-OK => MGA1TOO MGA2-64-OK MGA2-32-OK feedback

Comment 11 José Jorge 2012-09-19 14:49:18 CEST
(In reply to comment #10)
> Testing complete on Mageia 2 i586.
> 
> José, Would you prefer to have this update validated, and a new bug
> report opened for Mageia 1, or wait until Mageia 1 is updated too?

I have no MGA1 to test if this fix is compatible with kernel < 3.x . But if you can try to install this MGA2 dkms into a MGA1 system, I can submit it into mga1/updates_testing ;-)
Comment 12 Dave Hodgins 2012-09-19 17:52:55 CEST
It fails.  From /var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/make.log

CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/kernel/wthread.o
/var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/kernel/wthread.c: In function âworker_threadâ:
/var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/kernel/wthread.c:76:3: error: implicit declaration of function âget_task_io_contextâ
/var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/kernel/wthread.c:76:21: warning: assignment makes pointer from integer without a cast
make[1]: *** [/var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/kernel/wthread.o] Error 1
make: *** [_module_/var/lib/dkms/iscsitarget/1.4.20.3-1.1.mga2/build/kernel] Error 2
make: Leaving directory `/usr/src/linux-2.6.38.8-server-10.mga'

# uname -a
Linux x1v.hodgins.homeip.net 2.6.38.8-server-10.mga #1 SMP Wed Jan 25 10:58:50 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux

Is the lack of a cast something that's easy to fix, or should
I validate the update and open a separate bug report
for Mageia 1?
Thierry Vignaud 2012-09-19 19:01:07 CEST

CC: thierry.vignaud => (none)

Comment 13 José Jorge 2012-09-20 20:02:18 CEST
(In reply to comment #12)
error:
> implicit declaration of function âget_task_io_contextâ

> 
> Is the lack of a cast something that's easy to fix, or should
> I validate the update and open a separate bug report
> for Mageia 1?

The error is in fact that the function get_task_io_context was named get_io_context
so please let's open a separate bug report and assign it to me...
Comment 14 Dave Hodgins 2012-09-22 17:53:48 CEST
Bug 7546 opened for dkms-iscsitarget under Mageia 1.

Could someone from the sysadmin team push the srpm
iscsitarget-1.4.20.3-1.1.mga2.src.rpm
from Mageia 2 Core Updates Testing to Core Updates.

Advisory: Updated iscsitarget packages fix dkms build:
The package provided in MGA2 could not build against recent linux kernels. 
This update uses upstream trunk fixes, not released as a new version for now.

https://bugs.mageia.org/show_bug.cgi?id=5525

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Whiteboard: MGA1TOO MGA2-64-OK MGA2-32-OK feedback => MGA2-64-OK MGA2-32-OK

Comment 15 Thomas Backlund 2012-09-23 18:39:42 CEST
Update pushed:
https://wiki.mageia.org/en/Support/Advisories/MGAA-2012-0197

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.