Bug 5131 - Add a patch to imageshack uploader rpm
Summary: Add a patch to imageshack uploader rpm
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal minor
Target Milestone: ---
Assignee: Dimitrios Glentadakis
QA Contact:
URL: http://svnweb.mageia.org/packages/cau...
Whiteboard:
Keywords: Junior_job, NEEDINFO, PATCH
Depends on:
Blocks:
 
Reported: 2012-03-27 16:30 CEST by Dimitrios Glentadakis
Modified: 2013-12-01 10:23 CET (History)
3 users (show)

See Also:
Source RPM: imageshack-uploader
CVE:
Status comment:


Attachments
# this patch adds Greek translation for the desktop file and adds imageshack-uploader in images MIME types (jpg, png etc) (847 bytes, patch)
2012-03-27 16:31 CEST, Dimitrios Glentadakis
Details | Diff
build log (32.42 KB, application/octet-stream)
2012-04-02 11:36 CEST, Oliver Burger
Details
Tentative to compile with ffmpeg 0.10-2 (cauldron) (1.03 KB, patch)
2012-04-02 18:35 CEST, Dimitrios Glentadakis
Details | Diff

Description Dimitrios Glentadakis 2012-03-27 16:30:04 CEST
I'd like to add a patch for the imageshack-uploader
It adds the Greek translation in the desktop file and adds imageshack-uploader in the images MIME types

However, this program needs a patch for ffmpeg which is implemented directly in sources. I think that is more judicious to add the patch in the spec file and apply it with %apply_patches

I dont know at whom i have to assign the report as the member who committed the rpm is vaci0 and i dont have his email address.
Comment 1 Dimitrios Glentadakis 2012-03-27 16:31:46 CEST
Created attachment 1872 [details]
# this patch adds Greek translation for the desktop file and adds imageshack-uploader in images MIME types (jpg, png etc)
Dimitrios Glentadakis 2012-03-27 16:32:18 CEST

CC: (none) => oliver.bgr

Comment 2 Manuel Hiebel 2012-03-29 14:45:23 CEST
> I dont know at whom i have to assign the report as the member who committed the
> rpm is vaci0 and i dont have his email address.

me too...

the packages in not in the reposity, so feel free to build

Keywords: (none) => Junior_job, PATCH
Source RPM: (none) => imageshack-uploader
Severity: normal => minor

Comment 3 Dimitrios Glentadakis 2012-03-29 16:55:46 CEST
- I uploaded a clean tarball 
- I added the patch for ffmpeg and applied it in the spec file with %apply_patches
- I added a patch to add to the desktop file the Greek translation and the MIME type for images

- Oliver, when you will find some time, could you verify that everything is ok please ?
Comment 4 Oliver Burger 2012-04-02 10:15:17 CEST
Well, aside from not building locally :/

The last commits to its mercurial was from 2009 if I see that correctly. The question is, if it's maintained upstream.

If not, are you willing to fix any problems that might come along? We can't have unmaintained software in our repos.
Comment 5 Dimitrios Glentadakis 2012-04-02 10:56:09 CEST
I use it without any problem 2 years now and i have just seen that it was already imported since 6 months in mageia packages but not sent to the build system.

I tried also yesterday, it builds locally without any problem for both arch

In the past there was a problem to compile with ffmpeg and i asked to a C developer to make a patch for me.

If i will have a problem like this in the future i will ask again for help.

I don't know if the program is abandoned probably yes if the last update was the 2009

If there is no really need for this program i can continue keep it in the local repository
http://mageia-gr.org/rpm/1/

there is no problem at all for me.
Comment 6 Oliver Burger 2012-04-02 11:36:37 CEST
Created attachment 1901 [details]
build log

Here is the build log on Cauldron x86_64.

Might be an API incompatibility between 1 and Cauldron.

Did you build only on 1 or on Cauldron as well?
Comment 7 Dimitrios Glentadakis 2012-04-02 11:51:57 CEST
No i tried only in Mageia 1, i don't have a Cauldron installation.
If it is needed i can umpload a log from the local build
Comment 8 Dimitrios Glentadakis 2012-04-02 12:15:59 CEST
May be now with the current version of ffmpeg in Cauldron we have to drop the patch for ffmpeg_fas.c ?
Comment 9 Dimitrios Glentadakis 2012-04-02 18:24:38 CEST
I think that here is the solution, due to the api change of ffmpeg:
https://github.com/bluecherrydvr/solo6x10/issues/16

"Yes, this is an API change. CODEC_TYPE_VIDEO is now AVMEDIA_TYPE_VIDEO, and PKT_FLAG_KEY is now AV_PKT_TYPE_KEY. The other messages are harmless."
Comment 10 Oliver Burger 2012-04-02 18:31:31 CEST
Ok, then, if you can create a patch for it, I'll submit it...
Comment 11 Dimitrios Glentadakis 2012-04-02 18:35:05 CEST
Created attachment 1906 [details]
Tentative to compile with ffmpeg 0.10-2 (cauldron)
Comment 12 Dimitrios Glentadakis 2012-04-02 18:43:57 CEST
Maybe it is nt very clear about the history of the project. Here it shows that the last commit was the 27 April 2010: 

http://code.google.com/p/imageshack-uploader/source/list

but if you think that even it is too old we can exclude it from mageia (even if it finaly builts)
Comment 13 Oliver Burger 2012-04-02 18:49:04 CEST
Did you commit your patch to the svn?

Well, if it builds and works, we can package it. It's actually up to you. Although formally as your mentor, I will be the official maintainer for the time being, it's your package.
If you think, you are up to maintaining it, let's go ahead.

If it won't work any more at some point in the future, we can remove it again.
Comment 14 Dimitrios Glentadakis 2012-04-02 19:12:15 CEST
Ok, i committed it just now, let's see ...

http://svnweb.mageia.org/packages/cauldron/imageshack-uploader/current/
Comment 15 Oliver Burger 2012-04-02 19:32:11 CEST
No go...

Can you somehow install Cauldron locally? Maybe in a VM?
I think it will be easier, if you can work it out without having to pass it to me every time.
Comment 16 Dimitrios Glentadakis 2012-04-02 19:49:10 CEST
ok, i will install in a vm cauldron
Comment 17 Dimitrios Glentadakis 2012-04-04 07:03:38 CEST
I have a cauldron in the virtualbox and it builds fine here.

- I added all the modifications from here:
http://code.google.com/p/imageshack-uploader/issues/detail?id=236

- I kept one patch with all modifications (the old patch with the current modifications)

- I changed the version to 2.3.0 as i show in the compile messages:

g++ -c -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -O2 -Wall -W -D_REENTRANT -DUNIX_TRANSLATIONS_DIR=\"/usr/share/imageshack-uploader/translations\" -DVERSION=\"2.3.0\" -DDEVELOPER_KEY=\"38GHPTVX530ddbb2d8b3bb1b0cd7109c5c428ec0\"
Comment 18 Marja Van Waes 2012-05-26 13:02:51 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Comment 19 Oliver Burger 2012-07-11 08:49:28 CEST
It doesn't build on the bs (does locally though). Could you have a look at it?
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20120711064546.obgr_seneca.valstar.21949/log/botcmd.1341989159.jonund.log
Comment 20 roelof Wobben 2013-01-02 19:27:52 CET
@dimitrois  : Can you look at the error log otherwise we have to close this bug.

CC: (none) => r.wobben

Comment 21 Dimitrios Glentadakis 2013-01-02 20:34:39 CET
There is a problem with the ffmpeg again
There is an open issue :
http://code.google.com/p/imageshack-uploader/issues/detail?id=245&sort=-id

You can close the bug and when there will be a fix available i will apply it.
Comment 22 Samuel Verschelde 2013-08-26 17:52:33 CEST
Closing per comment 21

Status: NEW => RESOLVED
Resolution: (none) => WONTFIX

Comment 23 Dimitrios Glentadakis 2013-08-31 17:53:41 CEST
I patched it and now it builds (in my system "Mageia 3 64bit")

http://svnweb.mageia.org/packages?view=revision&revision=473733

If anyone wants to test it:
http://www.mageia-gr.org/rpm/3/x86_64/imageshack-uploader-2.3.0-1mgr3.x86_64.rpm

Status: RESOLVED => REOPENED
Resolution: WONTFIX => (none)

Dimitrios Glentadakis 2013-12-01 10:20:15 CET

Assignee: bugsquad => dglent

Dimitrios Glentadakis 2013-12-01 10:21:07 CET

CC: (none) => shlomif

Comment 24 Dimitrios Glentadakis 2013-12-01 10:23:12 CET
For mga4 i had do update the patch for ffmpeg again.
Submitted for mga4
I close the bug

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.