Bug 501 - thunderbird doesn't know how to deal with http/https
Summary: thunderbird doesn't know how to deal with http/https
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-23 12:37 CET by Frank Griffin
Modified: 2011-03-26 23:25 CET (History)
2 users (show)

See Also:
Source RPM: mozilla-thunderbird-3.1.9-10.mga1.x86_64.rpm
CVE:
Status comment:


Attachments

Description Frank Griffin 2011-03-23 12:37:45 CET
This may be tied in with bug#400, which was fixed.  The newest Mar21 thunderbird now puts up a prompt when you click on either an http or an https link in a message asking what application you want to use for filetypes of http or https.

If you respond with "/usr/bin/firefox", things work fine.  But this (or $BROWSER, or /etc/alternatives, or whatever we do these days) should be built into the thunderbird preferences from the start; the user shouldn't have to configure this.

I recall a post saying that thunderbird no longer uses gvfs by default, and gvfs is what bug#400 fixed for http/https.  Possibly the newest thunderbird was built to *not* use gvfs, and the default applications were not set correctly ?

Reproducible: 

Steps to Reproduce:
Comment 1 Frank Griffin 2011-03-23 12:41:31 CET
I should mention that this was on an existing ID which had been using thunderbird previously.  If the new build does require application helper metadata that wasn't needed for gvfs-open, maybe the existence of the .thunderbird preferences prevented addition of the new entries ?
Comment 2 Ahmad Samir 2011-03-23 19:19:17 CET
(In reply to comment #0)
> This may be tied in with bug#400, which was fixed.  The newest Mar21
> thunderbird now puts up a prompt when you click on either an http or an https
> link in a message asking what application you want to use for filetypes of http
> or https.
> 
> If you respond with "/usr/bin/firefox", things work fine.  But this (or
> $BROWSER, or /etc/alternatives, or whatever we do these days) should be built
> into the thunderbird preferences from the start; the user shouldn't have to
> configure this.
> 
> I recall a post saying that thunderbird no longer uses gvfs by default, and
> gvfs is what bug#400 fixed for http/https.  Possibly the newest thunderbird was
> built to *not* use gvfs, and the default applications were not set correctly ?
> 

You're mixing issues here, thunderbird was never set to use gvfs-open to handle links, it's _always_ been set to use xdg-open.

And no, thunderbird is not built to *not* use gvfs. The latest build enables gio support and disables gnomevfs support, that might be the issue and we might have to adapt thunderbird to the change..

I'll try and look into the issue.
Comment 3 Frank Griffin 2011-03-23 20:55:03 CET
I tried this on a new ID after removing .mozilla and verifying that .thunderbird wasn't there to start with, and it had the same behavior.
Comment 4 Ahmad Samir 2011-03-24 00:36:03 CET
I think I now got http/https links to work for new profiles... but not for existing ones.

I plan to patch mimeTypes.rdf to make http/https/ft links use /usr/bin/xdg-open, but that won't affect already existing profiles.
Comment 5 Ahmad Samir 2011-03-24 01:33:16 CET
The actual issue is that disabling gnomevfs support seems to have made thunderbird not get the http/https handler prefs from gconf.
Comment 6 Ahmad Samir 2011-03-24 01:36:03 CET
hmm, GConf2-devel doesn't get installed in the chroot, (gnome-vfs devel required it).

I am testing now building tb with Gconf2-devel.
Comment 7 Ahmad Samir 2011-03-24 02:01:33 CET
(In reply to comment #6)
> hmm, GConf2-devel doesn't get installed in the chroot, (gnome-vfs devel
> required it).
> 
> I am testing now building tb with Gconf2-devel.

Disregard, Gconf2-devel was installed in the chroot on the BS.
Comment 8 Ahmad Samir 2011-03-24 06:37:22 CET
After trawling the internet some more (thanks to google :)), I think we should go back to gnomevfs support, GIO support is supposed to work like with gvfs-open, i.e. just setting an x-scheme-handler/http should work, and it does work with gvfs-open, but not with tb. (I'll sleep on it)..
Comment 9 Luc Menut 2011-03-24 08:50:44 CET
(In reply to comment #8)
> After trawling the internet some more (thanks to google :)), I think we should
> go back to gnomevfs support, GIO support is supposed to work like with
> gvfs-open, i.e. just setting an x-scheme-handler/http should work, and it does
> work with gvfs-open, but not with tb. (I'll sleep on it)..

just a quick response for now.
In fact, enable-gio in the thunderbird 3.1.9 configure is a trap; there isn't any GIO support in thunderbird for now. If you disable gnomevfs, you lost any integration with the system.

CC: (none) => lmenut

Comment 10 D Morgan 2011-03-24 09:39:52 CET
this is strange, so what do they have a configure check ?
$ ./configure --help  | grep gio
  --enable-gio            Enable GIO support (default: disabled)


if so we will revert this part btw.

CC: (none) => dmorganec

Comment 11 Ahmad Samir 2011-03-24 17:00:08 CET
(In reply to comment #9)
> (In reply to comment #8)
> > After trawling the internet some more (thanks to google :)), I think we should
> > go back to gnomevfs support, GIO support is supposed to work like with
> > gvfs-open, i.e. just setting an x-scheme-handler/http should work, and it does
> > work with gvfs-open, but not with tb. (I'll sleep on it)..
> 
> just a quick response for now.
> In fact, enable-gio in the thunderbird 3.1.9 configure is a trap; there isn't
> any GIO support in thunderbird for now. If you disable gnomevfs, you lost any
> integration with the system.

I am beginning to think so :)

But, note that Fedora compile with --enable-gio and disable-gnomevfs. Also note the with --enable-gnomevfs, there's only integration with GNOME, as it uses gconf settings to set http/https url handlers (which worked in a default install as gconf is set to www-browser).

Also the /usr/bin/xdg-open settings we add to thunderbird prefs are null, i.e. they don't work for a long time (there was a huge bug report in Mandriva bugzilla).

I think we should just --enable-gnomevfs, for the time being, there's no hurry to --enable-gio before GNOME3, IIUC.
Comment 12 Luc Menut 2011-03-26 22:57:23 CET
(In reply to comment #11)

Sorry to reply so late.

> I am beginning to think so :)
> 
> But, note that Fedora compile with --enable-gio and disable-gnomevfs.

Have you tried their package? Is it working???

> Also note
> the with --enable-gnomevfs, there's only integration with GNOME, as it uses
> gconf settings to set http/https url handlers (which worked in a default
> install as gconf is set to www-browser).

Yes, but with gnomevfs we have a minimal support of mime-type, even if it doesn't follow changes made by the user (gnomevfs uses the old defaults.list instead of mimeapps.list)

> 
> Also the /usr/bin/xdg-open settings we add to thunderbird prefs are null, i.e.
> they don't work for a long time (there was a huge bug report in Mandriva
> bugzilla).
> 
> I think we should just --enable-gnomevfs, for the time being, there's no hurry
> to --enable-gio before GNOME3, IIUC.

yes and no!! GNOME has declared GnomeVFS deprecated in favour of GVFS and GIO since 2008, requesting that developers not use it in new applications.[1][2]
KDE systemsettings and Gnome Nautilus save user's preferences for mime-type in mimeapps.list, so that Thunderbird can't use this preferences for the application helper with gnomevfs.

Mozilla added GIO support only with Firefox 4 = Xulrunner 2.0.
The main changeset for GIO support was 31951:2572312e17df [3], with discussion on bug 402892 [4]. Among others changes, it add nsGIOService.cpp, nsGIOService.h, and nsIGIOService.idl.

Thunderbird shares part of its code with Firefox 3.6 which doesn't support GIO, so I'm not surprised that GIO doesn't work with Thunderbird 3.1.9 (and I wonder why they add enable-gio in the configure).

(btw, adding the support for the deprecated defaults.list in KDE 4 is only a 5 lines patch!! I never proposed it upstream because I don't think they want to support a deprecated feature.!!)


[1] http://en.wikipedia.org/wiki/GnomeVFS
[2] http://library.gnome.org/misc/release-notes/2.22/index.html.en#sect:gvfs-gio
[3] http://hg.mozilla.org/mozilla-central/rev/2572312e17df
[4] https://bugzilla.mozilla.org/show_bug.cgi?id=402892
Comment 13 Ahmad Samir 2011-03-26 23:25:27 CET
(In reply to comment #12)
> (In reply to comment #11)
> 
> Sorry to reply so late.
> 
> > I am beginning to think so :)
> > 
> > But, note that Fedora compile with --enable-gio and disable-gnomevfs.
> 
> Have you tried their package? Is it working???
> 

Tried, but couldn't find the package even in rawhide/FC15 repos, the changes seem to be only in Fedora GIT...

> > Also note
> > the with --enable-gnomevfs, there's only integration with GNOME, as it uses
> > gconf settings to set http/https url handlers (which worked in a default
> > install as gconf is set to www-browser).
> 
> Yes, but with gnomevfs we have a minimal support of mime-type, even if it
> doesn't follow changes made by the user (gnomevfs uses the old defaults.list
> instead of mimeapps.list)
> 

Yes, and we can use gnomevfs for as long as possible, the fact that disabling gnomevfs support will break old tb profiles is an annoying regression (though easily fixed, assuming the user knows executables are in /usr/bin... ).

> > 
> > Also the /usr/bin/xdg-open settings we add to thunderbird prefs are null, i.e.
> > they don't work for a long time (there was a huge bug report in Mandriva
> > bugzilla).
> > 
> > I think we should just --enable-gnomevfs, for the time being, there's no hurry
> > to --enable-gio before GNOME3, IIUC.
> 
> yes and no!! GNOME has declared GnomeVFS deprecated in favour of GVFS and GIO
> since 2008, requesting that developers not use it in new applications.[1][2]
> KDE systemsettings and Gnome Nautilus save user's preferences for mime-type in
> mimeapps.list, so that Thunderbird can't use this preferences for the
> application helper with gnomevfs.
> 
> Mozilla added GIO support only with Firefox 4 = Xulrunner 2.0.
> The main changeset for GIO support was 31951:2572312e17df [3], with discussion
> on bug 402892 [4]. Among others changes, it add nsGIOService.cpp,
> nsGIOService.h, and nsIGIOService.idl.
> 
> Thunderbird shares part of its code with Firefox 3.6 which doesn't support GIO,
> so I'm not surprised that GIO doesn't work with Thunderbird 3.1.9 (and I wonder
> why they add enable-gio in the configure).
> 
> (btw, adding the support for the deprecated defaults.list in KDE 4 is only a 5
> lines patch!! I never proposed it upstream because I don't think they want to
> support a deprecated feature.!!)
> 
> 
> [1] http://en.wikipedia.org/wiki/GnomeVFS
> [2]
> http://library.gnome.org/misc/release-notes/2.22/index.html.en#sect:gvfs-gio
> [3] http://hg.mozilla.org/mozilla-central/rev/2572312e17df
> [4] https://bugzilla.mozilla.org/show_bug.cgi?id=402892

That's very interesting, thanks for the explanations :)

I've re-enabled gnomevfs support back in mozilla-thunderbird-3.1.9-11.mga1 (available since a couple of days).

So closing..

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.