Bug 3329 - bad completion of xv openable files
Summary: bad completion of xv openable files
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal major
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard:
Keywords: Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2011-11-12 18:53 CET by Claire Revillet
Modified: 2011-12-20 18:23 CET (History)
4 users (show)

See Also:
Source RPM: bash-completion
CVE:
Status comment:


Attachments

Description Claire Revillet 2011-11-12 18:53:19 CET
Description of problem:
'xv' is a graphic file viewer. It is able to open eps files, but bash-completion dont propose them. Example :
[grenoya@enee images]$ evince fo
fo_padding.eps                                                         forme_integree_pentes_08_04_0.35_2048_2048_Lvue06_surface10.eps
fo_padding.jpg                                                         forme_integree_pentes_08_04_0.35_2048_2048_Lvue06_surface30.eps
fo_pente_Prestige.eps                                                  forme_integree_pentes_08_04_0.35_2048_2048_Lvue06_surface_mfwam15.eps
fo_pente_Prestige.jpg                                                  forme_onde.jpg
fo_pente_swell.eps                                                     forme_onde_old.jpg
fo_pente_Swell.jpg                                                     fo_sspadding.eps
fo_pente_WindSea.eps                                                   fo_sspadding.jpg
fo_pente_WindSea.jpg                                                   
[grenoya@enee images]$ xv fo
fo_padding.jpg         fo_pente_Swell.jpg     forme_onde.jpg         fo_sspadding.jpg       
fo_pente_Prestige.jpg  fo_pente_WindSea.jpg   forme_onde_old.jpg     




Version-Release number of selected component (if applicable):
bash-completion-1.90-1.mga2
Comment 1 Manuel Hiebel 2011-11-12 19:12:05 CET
Hi, thanks for reporting this bug.

I can confirm this bug.
In bash without bash-completion it works, in zsh with bash-completion too.

Assigned to the package maintainer.

Keywords: (none) => Triaged
Version: Cauldron => 1
Assignee: bugsquad => doktor5000

Comment 2 Florian Hubold 2011-12-15 22:23:27 CET
Culprit identified:

$ grep -b xv /etc/bash_completion
3109:complete -f -X '!*.@(gif|jp?(e)g|tif?(f)|png|p[bgp]m|bmp|x[bp]m|rle|rgb|pcx|fits|pm)' xv qiv

I've added said completion and will report this upstream. Updated package is on it's way.

Status: NEW => ASSIGNED

Comment 3 Florian Hubold 2011-12-16 18:27:21 CET
Just for reference, reported upstream: https://alioth.debian.org/tracker/index.php?func=detail&aid=313477&group_id=100114&atid=413095
Comment 4 Dave Hodgins 2011-12-16 22:30:03 CET
With bash-completion-2:1.3-2.1.mga1.noarch installed,

Entering
xv /usr/share/texmf-dist/tex/latex/bclogo/bcbash
and then pressing the tab key, I get ...
: eval: line -849: syntax error near unexpected token `)'
bash: eval: line -849: `compgen -f -X !!(|?(e)ps|?(E)PS)||?(E)PS|?(E)PS)) -- $(quote_readline $cur)'

CC: (none) => davidwhodgins

Comment 5 Florian Hubold 2011-12-17 02:18:15 CET
Sorry, you were just too fast and got an faulty-in-between-update, had to wait for the submission by my mentor. Also i've not reassigned this to QA ;)
So here it goes:

There is now bash-completion-1.3-2.2.mga1 in core/updates_testing to validate
-------------------------------------------------------

Suggested advisory:
-------------------
This update addresses the following issue:

bash-completion was missing a completion for (e)ps files for xv, a picture viewer. The completion has now been added for xv.

-------------------------------------------------------
Steps to reproduce:

- install/update to update candidate
- check that the completion works ok, for example by entering
"xv /usr/share/ghostscript/9.02/examples/g" into a terminal an pressing tab, it should offer you two files, golfer.eps and grayalph.ps and when entering the following letter from one of those two it should complete to one of those filenames.

Assignee: doktor5000 => qa-bugs

Comment 6 Claire Revillet 2011-12-17 09:46:32 CET
It's still not working in Cauldron ! This bug was originally opened for cauldron and even if someone changed it for 1/ the bug should be corrected in cauldron before pushing update in 1/ .
Comment 7 Claire Revillet 2011-12-17 16:22:59 CET
forgot to but back Florian in copy for previous comment

CC: (none) => doktor5000

Comment 8 Florian Hubold 2011-12-17 16:29:46 CET
Shlomi Fish submitted the fix for cauldron (as for mga1 after my first one didn't fix it properly) which is different than mine, and i needed to push another fix because it spew out errors like Dave mentioned, sorry but i haven't tested for Cauldron. Tomorrow i can push my commit also to cauldron after testing it there.

But this does not block the validation of the update candidate for mga1.
Comment 9 Dave Hodgins 2011-12-17 20:39:44 CET
Testing complete on i586 for the srpm
bash-completion-1.3-2.2.mga1.src.rpm
xv /usr/share/texmf-dist/tex/latex/bclogo/bc
followed by a tab now shows the eps files.
Comment 10 claire robinson 2011-12-17 23:27:33 CET
Testing x86_64

Before
------
# grep -b xv /etc/bash_completion
grep: /etc/bash_completion: No such file or directory

bash-completion not installed, which is strange, it seems to be on my i586 system.

After installing it and restarting...

$ grep -b xv /etc/bash_completion
3109:complete -f -X '!*.@(gif|jp?(e)g|tif?(f)|png|p[bgp]m|bmp|x[bp]m|rle|rgb|pcx|fits|pm)' xv qiv

Doesn't list pdf's


After
-----

$ grep -b xv /etc/bash_completion
3199:complete -f -X '!*.@(gif|jp?(e)g|tif?(f)|png|p[bgp]m|bmp|x[bp]m|rle|rgb|pcx|fits|pm|?(e)ps|?(E)PS)' xv


Tested i586 too.


Update validated

Advisory:
-------------------
This update addresses the following issue:

bash-completion was missing a completion for (e)ps files for xv, a picture
viewer. The completion has now been added for xv.

-------------------

SRPM: bash-completion-1.3-2.2.mga1.src.rpm


Could sysadmin please push from core/updates_testing to core/updates.

Thankyou!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Hardware: x86_64 => All

Comment 11 Florian Hubold 2011-12-18 13:15:07 CET
FWIW, bash-completion is not included in a default install. Also xv is not good for opening PDFs (or any multipage document).
Comment 12 claire robinson 2011-12-18 14:19:01 CET
Yep it's OK. I edited the posting and deleted a line that related to where it would have made sense :\

Without it installed it was listing everything, even pdf's. Still full of cold and my head isn't working properly.
Comment 13 Florian Hubold 2011-12-18 22:10:21 CET
(In reply to comment #6)
> It's still not working in Cauldron !

FYI, should now be also fixed in cauldron with bash-completion-1.90-5.mga2
Please report whether it works now.
Comment 14 Claire Revillet 2011-12-18 22:11:30 CET
(In reply to comment #13)

> FYI, should now be also fixed in cauldron with bash-completion-1.90-5.mga2
> Please report whether it works now.

It works ! thanks Florian :)
Comment 15 Thomas Backlund 2011-12-20 18:23:43 CET
Update pushed.

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.