Bug 32978 - Lutris update request, to fix an error after exiting a steam game launched via lutris
Summary: Lutris update request, to fix an error after exiting a steam game launched vi...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 9
Hardware: All Linux
Priority: Normal minor
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard:
Keywords: advisory, feedback
Depends on:
Blocks:
 
Reported: 2024-03-17 21:53 CET by Cyril Levet
Modified: 2024-04-10 16:14 CEST (History)
5 users (show)

See Also:
Source RPM: lutris-0.5.12-1.mga9.src.rpm
CVE:
Status comment:


Attachments

Description Cyril Levet 2024-03-17 21:53:19 CET
Description of problem: 
When launching a steam game through lutris, quitting it and quitting steam, lutris display the following error messages: 
ERROR    2024-03-17 21:43:58,301 [lutriswindow.on_game_error:718]:Crusader Kings III (steam) has encountered an error: can only concatenate str (not "float") to str
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/lutris/exceptions.py", line 80, in wrapper
    result = function(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/lutris/game.py", line 694, in beat
    self.on_game_quit()
  File "/usr/lib/python3.10/site-packages/lutris/game.py", line 731, in on_game_quit
    self.stop()
  File "/usr/lib/python3.10/site-packages/lutris/game.py", line 712, in stop
    self.stop_game()
  File "/usr/lib/python3.10/site-packages/lutris/game.py", line 675, in stop_game
    self.playtime += self.timer.duration / 3600

According to this bug upstream, it is fixed in the 0.5.13 version and Mageia 9 is running the 0.5.12 version. It seems, it is fixed in this commit : https://github.com/lutris/lutris/pull/4650/commits/d57d50c36f747bc4aa99dc85f2b20cf616fe79fb


Version-Release number of selected component (if applicable): lutris-0.5.12-1


How reproducible: Always


Steps to Reproduce:
1. Launch a Steam game through Lutris
2. Exit the game and Steam.
Comment 1 Morgan Leijström 2024-03-18 20:07:02 CET
Thank you for reporting.
Lutris seem to be handled by varying packagers.

CC: (none) => fri
Assignee: bugsquad => pkg-bugs
Summary: Lutris display an error message after exiting a steam game launched via lutris => Lutris update request, to fix an error after exiting a steam game launched via lutris

Comment 2 Morgan Leijström 2024-03-18 20:13:49 CET
Last handled by daviddavid, but most often by akien.

Assignee: pkg-bugs => rverschelde

Comment 3 papoteur 2024-03-26 09:07:48 CET
Submitting:
lutris-0.5.16-1.mga9

Sources:
lutris-0.5.16-1.mga9

Assignee: rverschelde => qa-bugs
CC: (none) => yvesbrungard

PC LX 2024-03-26 16:29:15 CET

CC: (none) => mageia

katnatek 2024-03-26 17:24:06 CET

Keywords: (none) => advisory

Comment 4 Dan Fandrich 2024-03-26 18:33:00 CET
The advisory text for this bug doesn't match the bug title and comments and might be a cut-and-paste error.

CC: (none) => dan

Comment 5 katnatek 2024-03-26 18:39:30 CET
(In reply to Dan Fandrich from comment #4)
> The advisory text for this bug doesn't match the bug title and comments and
> might be a cut-and-paste error.

The text come from https://github.com/lutris/lutris/releases/tag/v0.5.16 , I think is more accurate information of what fix the bug, thank you for your interest
Comment 6 katnatek 2024-03-26 18:45:10 CET
(In reply to Dan Fandrich from comment #4)
> The advisory text for this bug doesn't match the bug title and comments and
> might be a cut-and-paste error.

Just in case, the subject come from https://github.com/lutris/lutris/pull/4650/commits/d57d50c36f747bc4aa99dc85f2b20cf616fe79fb
Comment 7 katnatek 2024-03-27 18:29:30 CET
 Cyril Levet , can you test if the package in testing fix the issue?
Comment 8 Cyril Levet 2024-03-27 20:03:02 CET
I will test the version in testing this weekend.
Comment 9 papoteur 2024-04-01 15:57:03 CEST
Some packages are needed:
RPMS:
python3-moddb-0.10.0-1.mga9.noarch
python3-pyrate-limiter-3.3.0-1.mga9.noarch
SRPMS:
python-moddb-0.10.0-1.mga9
python-pyrate-limiter-3.3.0-1.mga9
Comment 10 katnatek 2024-04-01 20:19:12 CEST
(In reply to papoteur from comment #9)
> Some packages are needed:
> RPMS:
> python3-moddb-0.10.0-1.mga9.noarch
> python3-pyrate-limiter-3.3.0-1.mga9.noarch
> SRPMS:
> python-moddb-0.10.0-1.mga9
> python-pyrate-limiter-3.3.0-1.mga9

Advisory updated to include the src.rpms
Comment 11 PC LX 2024-04-04 14:06:47 CEST
I'm encountering several issue with this Lutris update.
I don't use Lutris so I don't know if these are regressions or not but major features don't work.
As is Lutris is useless to me.



=== First issue ===

When loading/updating the Steam games list the following messages are shown in the terminal and the list is not properly loaded/updated.
The list of games is displayed but the game thumbnail is a grey gradient and no games are recognized a already being installed.

"""
2024-04-04 12:47:06,842: Error while completing task <function BaseService.start_reload.<locals>.do_reload at 0x7fb205a62830>: <class 'TypeError'> 'NoneType' object is not subscriptable
  File "/usr/lib/python3.10/site-packages/lutris/util/jobs.py", line 31, in target
    result = self.function(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/lutris/services/base.py", line 145, in do_reload
    self.load()
  File "/usr/lib/python3.10/site-packages/lutris/services/steam.py", line 108, in load
    self.match_games()
  File "/usr/lib/python3.10/site-packages/lutris/services/base.py", line 246, in match_games
    self.match_game(service_games.get(provider_game["slug"]), lutris_game)
  File "/usr/lib/python3.10/site-packages/lutris/services/steam.py", line 115, in match_game
    for game in get_games(filters={"service": self.id, "service_id": service_game["appid"]}):
"""



=== Second issue ===

Can't login to the Epic Games Store from Lutris and the games list is not loaded.

When I click the "connect" icon for the "Epic Games Store" a login window opens, I enter my "Epic Games Store" account email and click continue but nothing happens. It just stays like that and I'm never able to enter the password.



=== Thrid issue ===

It crashed once. I don't know what caused or how to trigger the crash.


# journalctl -b0 | grep lutris
abr 04 12:47:46 jupiter-vm-mageia-9-jogos kernel: traps: lutris[2250] general protection fault ip:7fb217950cd7 sp:7ffc50fdcf98 error:0 in libgtk-3.so.0.2406.32[7fb217887000+363000]
Comment 12 PC LX 2024-04-04 14:09:47 CEST
Continuation of comment 11.

System: Mageia 9, x86_64, LXQt DE, QEMU/KVM VM, AMD Ryzen 5 5600G with Radeon Graphics, PCI pass through of GPU Radeon RX 6500 XT using amdgpu driver.

$ uname -a
Linux jupiter-vm-mageia-9-jogos 6.6.22-desktop-1.mga9 #1 SMP PREEMPT_DYNAMIC Sun Mar 17 18:04:51 UTC 2024 x86_64 GNU/Linux
$ rpm -q lutris python3-moddb python3-pyrate-limiter
lutris-0.5.16-1.1.mga9
python3-moddb-0.10.0-1.mga9
python3-pyrate-limiter-3.3.0-1.mga9
Comment 13 Cyril Levet 2024-04-04 14:33:51 CEST
I ran this update without issue but found a warning about a missing program at startup so I asked papoteur to add this as a dependency.
Son far I have tested without issue :
- Running a Steam Game
- Installing a Steam game
- Running a Windows game from a CD using wine in Lutris. This game was installed by Lutris.

@PC LX : Does your Steam Account (List of games) is set to public ?
Comment 14 katnatek 2024-04-04 20:42:25 CEST
(In reply to PC LX from comment #11)
Did you include the extra packages in comment#9 ?
Comment 15 Cyril Levet 2024-04-04 21:21:36 CEST
(In reply to PC LX from comment #11)
> When loading/updating the Steam games list the following messages are shown
> in the terminal and the list is not properly loaded/updated.
> The list of games is displayed but the game thumbnail is a grey gradient and
> no games are recognized a already being installed.
> 
I can't reproduce your reloading steam game list bug. Aside from setting your profile visibility to Everybody (in your account confidentiality option), you can try to modify the default installation folder for Steam runner in Lutris. In my computer it is : /home/myName/.local/share/Steam/steamapps/common

I have installed the last version from testing with the last fix and everything runs fine. So, OK for me.
Comment 16 PC LX 2024-04-04 22:47:47 CEST
(In reply to Cyril Levet from comment #13)
> @PC LX : Does your Steam Account (List of games) is set to public ?

I normally have it set to private and Lutris warned me about it so i set it to public while testing Lutris. The first issue in comment 11 is with my Steam profile set to public.
Comment 17 PC LX 2024-04-04 22:50:30 CEST
(In reply to katnatek from comment #14)
> (In reply to PC LX from comment #11)
> Did you include the extra packages in comment#9 ?

Yes, the packages in comment 9 were installed. Please rpm output in comment 12.
Comment 18 PC LX 2024-04-04 23:48:30 CEST
I deleted all Lutris related files from my home directory just in case something was issues, tested again, and the problems mentioned in comment 11 remain.

I was also been able to trigger several crashes. I don't know the steps to trigger a crash but clicking around for a while sometimes will end in a crash. If it does not crash in a minute or so of clicking around I restart Lutris and repeat the process. Something is definitely not working well in Lutris.

$ dmesg | grep lutris
[  611.407064] lutris[3423]: segfault at 0 ip 0000000000000000 sp 00007fffaae217d8 error 14 in python3.10[400000+1000] likely on CPU 10 (core 10, socket 0)
[  893.729558] lutris[4733]: segfault at 21 ip 0000000000000021 sp 00007ffe96190698 error 14 in python3.10[400000+1000] likely on CPU 6 (core 6, socket 0)
[  909.348291] lutris[4907]: segfault at 0 ip 0000000000000000 sp 00007ffffd57c218 error 14 in python3.10[400000+1000] likely on CPU 6 (core 6, socket 0)
[ 1641.229756] traps: lutris[5190] general protection fault ip:7ff60cb50cd7 sp:7ffee50b9ab8 error:0 in libgtk-3.so.0.2406.32[7ff60ca87000+363000]
[ 2062.519517] lutris[7290]: segfault at 7f2cb63b3c16 ip 00007f2cb5d12834 sp 00007ffe9abef9b0 error 7 in libgtk-3.so.0.2406.32[7f2cb5c87000+363000] likely on CPU 6 (core 6, socket 0)
[ 2763.040544] lutris[7685]: segfault at 21 ip 0000000000000021 sp 00007ffdf748bdf8 error 14 in python3.10[400000+1000] likely on CPU 1 (core 1, socket 0)
katnatek 2024-04-05 00:02:06 CEST

Keywords: (none) => feedback

Comment 19 Cyril Levet 2024-04-05 08:18:50 CEST
(In reply to PC LX from comment #18)
Have you tried downgrading to Lutris 0.5.12 to see if the bugs disappear ? Lutris is quite erratic. The bugs you encounter may already be present in the current version.

For Epic game Store connection issue, I found: https://github.com/lutris/lutris/issues/5361
Comment 20 PC LX 2024-04-05 16:21:56 CEST
(In reply to Cyril Levet from comment #19)
> (In reply to PC LX from comment #18)
> Have you tried downgrading to Lutris 0.5.12 to see if the bugs disappear ?
> Lutris is quite erratic. The bugs you encounter may already be present in
> the current version.

I have downgraded the Lutris package to the current version in core/updates and deleted all Lutris files in the home directory.

$ rpm -q lutris python3-moddb python3-pyrate-limiter
lutris-0.5.12-1.mga9
python3-moddb-0.10.0-1.mga9
python3-pyrate-limiter-3.3.0-1.mga9


After the downgrade the situation is as follow:

- The first issue in comment 11 is not present and the Steam games list is loaded correctly.
- The second issue in comment 11 is still present and still can't login to Epic Games Store.
- The third issue in comment 11 is not present and there were no crashes despite me trying to make it crash.

In summary, one issue is present in a previous version and is not a regression but the two other issues are regressions.


> For Epic game Store connection issue, I found:
> https://github.com/lutris/lutris/issues/5361

That issue does not seem to apply to my case since I don't have a HTTP proxy setup and I didn't see the error message reported in that issue.
Comment 21 Cyril Levet 2024-04-05 20:32:53 CEST
Your problem with Steam is similar to one I had with older versions of Lutris. However, it works in 0.5.12 and 0.5.16.

I can't reproduce your third issue, even by clicking around inside Lutris for a while. Could it be hardware dependent ?

My configuration : 
$ uname -a
Linux mageia.maison 6.6.22-desktop-1.mga9 #1 SMP PREEMPT_DYNAMIC Sun Mar 17 18:04:51 UTC 2024 x86_64 GNU/Linux
System :  Mageia 9, x86_64, KDE/Plasma DE
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-4790 CPU @ 3.60GHz
Memory: 15.6 Gio of RAM
Graphics Processor: NVIDIA GeForce RTX 3060/PCIe/SSE2
Graphics Driver : Nvidia 550.54.14
Manufacturer: MSI
Product Name: MS-7850
System Version: 1.0
Comment 22 PC LX 2024-04-05 21:01:55 CEST
(In reply to Cyril Levet from comment #21)
> Your problem with Steam is similar to one I had with older versions of
> Lutris. However, it works in 0.5.12 and 0.5.16.
> 
> I can't reproduce your third issue, even by clicking around inside Lutris
> for a while. Could it be hardware dependent ?

I don't think so. Only Lutris 0.5.16 is crashing with segment/protection faults. Lutris 0.5.12 didn't crash so either it is something in Lutris' new code or there is a build issue.
Comment 23 papoteur 2024-04-06 21:34:58 CEST
There is now a new build to test:
lutris-0.5.16-2.2.mga9.noarch
I changed the build method and an upstream patch.
Comment 24 katnatek 2024-04-06 23:34:59 CEST
(In reply to papoteur from comment #23)
> There is now a new build to test:
> lutris-0.5.16-2.2.mga9.noarch
> I changed the build method and an upstream patch.

Advisory updated
Comment 25 katnatek 2024-04-09 02:40:26 CEST Comment hidden (obsolete)
Comment 26 katnatek 2024-04-09 02:42:46 CEST
RPMS:
lutris-0.5.16-2.2.mga9.noarch
python3-moddb-0.10.0-1.mga9.noarch
python3-pyrate-limiter-3.3.0-1.mga9.noarch

SRPMS:
lutris-0.5.16-2.2.mga9
python-moddb-0.10.0-1.mga9
python-pyrate-limiter-3.3.0-1.mga9

Cyril Levet &  PC LX , please test the new package, I put together the packagesin this comment
Comment 27 PC LX 2024-04-09 11:46:41 CEST
Installed the updated packages and tested.

$ LANGUAGE=C rpm -q lutris python3-moddb python3-pyrate-limiter
lutris-0.5.16-2.2.mga9
python3-moddb-0.10.0-1.mga9
python3-pyrate-limiter-3.3.0-1.mga9



Lets go through the issues in order:


=== First issue ===

This issue seems to be resolved.
The Steam games list now updates without any problems. 


=== Second issue ===

This issues is NOT resolved. It is actually worse.
With the previous version (lutris-0.5.12-1.mga9) and update (lutris-0.5.16-1.1.mga9) a login form would show up but with this update (lutris-0.5.16-2.2.mga9) a blank window without a login form is shown and, obviously, can't login to the Epic Games Store.

Note that using the Epic Games Store application I can login without issues, see my games library and use all the other functionalities.


=== Thrid issue ===

Still crashes. Got a crash while I was testing other features and it also aborted once.

$ dmesg | grep -i lutris
[  905.890680] traps: lutris[10603] general protection fault ip:7fbb667fa49e sp:7fffde631090 error:0 in libpixman-1.so.0.42.2[7fbb667ac000+83000]
Comment 28 Cyril Levet 2024-04-09 12:03:23 CEST
Works well for me.

> === Thrid issue ===
> 
> Still crashes. Got a crash while I was testing other features and it also
> aborted once.
> 
> $ dmesg | grep -i lutris
> [  905.890680] traps: lutris[10603] general protection fault ip:7fbb667fa49e
> sp:7fffde631090 error:0 in libpixman-1.so.0.42.2[7fbb667ac000+83000]
Could you launch lutris -d in a terminal. It could be more useful than dmseg. I try to click everywhere and never succeed to crash it.
Comment 29 vinceff 2024-04-09 18:23:53 CEST
(In reply to PC LX from comment #27)
> Installed the updated packages and tested.
> 
> $ LANGUAGE=C rpm -q lutris python3-moddb python3-pyrate-limiter
> lutris-0.5.16-2.2.mga9
> python3-moddb-0.10.0-1.mga9
> python3-pyrate-limiter-3.3.0-1.mga9
> 
> 
> 
> Lets go through the issues in order:
> 
> 
> === First issue ===
> 
> This issue seems to be resolved.
> The Steam games list now updates without any problems. 
> 
> 
> === Second issue ===
> 
> This issues is NOT resolved. It is actually worse.
> With the previous version (lutris-0.5.12-1.mga9) and update
> (lutris-0.5.16-1.1.mga9) a login form would show up but with this update
> (lutris-0.5.16-2.2.mga9) a blank window without a login form is shown and,
> obviously, can't login to the Epic Games Store.
> 
> Note that using the Epic Games Store application I can login without issues,
> see my games library and use all the other functionalities.
> 
> 
> === Thrid issue ===
> 
> Still crashes. Got a crash while I was testing other features and it also
> aborted once.
> 
> $ dmesg | grep -i lutris
> [  905.890680] traps: lutris[10603] general protection fault ip:7fbb667fa49e
> sp:7fffde631090 error:0 in libpixman-1.so.0.42.2[7fbb667ac000+83000]

Hi there,

I confirm the second issue, 
May the lutris log can help you to resolve the issue :
'DEBUG    2024-04-09 18:21:48,547 [base.wipe_game_cache:435]:Deleting egs cache /home/vinceff/.cache/lutris/egs-library.json
DEBUG    2024-04-09 18:21:48,548 [base.wipe_game_cache:178]:Deleting games from service-games for egs
WARNING  2024-04-09 18:21:48,548 [egs.load:315]:EGS Token expired
ERROR    2024-04-09 18:21:48,548 [jobs.target:33]:Error while completing task <function BaseService.start_reload.<locals>.do_reload at 0x7f31f84cf910>: <class 'lutris.services.base.AuthTokenExpiredError'> EGS Token expired
  File "/usr/lib/python3.10/site-packages/lutris/util/jobs.py", line 31, in target
    result = self.function(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/lutris/services/base.py", line 145, in do_reload
    self.load()
  File "/usr/lib/python3.10/site-packages/lutris/services/egs.py", line 316, in load
    raise AuthTokenExpiredError("EGS Token expired") from ex
DEBUG    2024-04-09 18:21:48,552 [base.wipe_game_cache:435]:Deleting egs cache /home/vinceff/.cache/lutris/egs-library.json
DEBUG    2024-04-09 18:21:48,552 [base.wipe_game_cache:178]:Deleting games from service-games for egs
DEBUG    2024-04-09 18:21:48,553 [base.logout:450]:logged out from egs
DEBUG    2024-04-09 18:21:48,554 [base.login:424]:Connecting to Epic Games Store'

The login of Epic Games store is blank. But we can make the login directly in opeing the launcher. 

For the first & third issue, i don't have it.

CC: (none) => vinceff

Comment 30 PC LX 2024-04-09 19:43:24 CEST
Tested with debug enabled and below is the output of a crash.

I don't know if it was because of debug being enabled or if I was just unlucky but it took several minutes of clicking around to get it to crash.
After the crash I restarted Lutris and noticed that the list in Sources/Steam was empty but the Runners/Steam still had the installed Steam games.
The Lutris files in the home directory are probably borked so to do more testing I will have to clean up all the Lutris files again.

"""
$ lutris --debug
INFO     2024-04-09 18:32:23,099 [application.do_command_line:479]:Starting Lutris 0.5.16
INFO     2024-04-09 18:32:23,101 [startup.get_drivers:67]:Running Mesa Mesa driver 23.3.6 on llvmpipe (LLVM 15.0.6, 256 bits) (0xffffffff)
INFO     2024-04-09 18:32:23,101 [display.display_gpu_info:78]:GPU: 1AF4:1050 1AF4:1100 (virtio-pci drivers)
DEBUG    2024-04-09 18:32:23,217 [xrandr._get_vidmodes:16]:Retrieving video modes from XrandR
DEBUG    2024-04-09 18:32:23,293 [lutris.get_missing_game_ids:206]:Checking for missing games
DEBUG    2024-04-09 18:32:29,864 [application.show_window:392]:Showing window RunnerConfigDialogsteam
DEBUG    2024-04-09 18:32:32,367 [application.on_app_window_destroyed:419]:Removed window RunnerConfigDialogsteam
DEBUG    2024-04-09 18:32:40,384 [lutriswindow.on_toggle_viewtype:983]:View type changed to grid
free(): invalid pointer
*** BUG ***
In pixman_region_append_non_o: The expression y1 < y2 was false
Set a breakpoint on '_pixman_log_error' to debug

Aborted (core dumped)
"""
Comment 31 papoteur 2024-04-10 09:00:22 CEST
According https://github.com/lutris/lutris/issues/4783#issuecomment-1739995110
can you try by starting:
WEBKIT_DISABLE_DMABUF_RENDERER=1 lutris --debug
Comment 32 PC LX 2024-04-10 16:14:58 CEST
Tested with the environment variable set but there was no change from comment 27.

$ env WEBKIT_DISABLE_DMABUF_RENDERER=1 lutris --debug
<SNIP A LOT OF OUTPUT>
DEBUG    2024-04-10 14:49:08,670 [command.on_stop:219]:Process 9262 has terminated with code 0
DEBUG    2024-04-10 14:49:09,660 [game.beat:853]:Game thread stopped
WARNING  2024-04-10 14:49:09,661 [game.on_game_quit:890]:Game still running (state: running)
INFO     2024-04-10 14:49:09,661 [game.stop:864]:Stopping Ticket to Ride (steam)
DEBUG    2024-04-10 14:49:09,661 [game.stop_game:820]:Ticket to Ride (steam) has run for 2 seconds
WARNING  2024-04-10 14:49:09,661 [game.stop_game:822]:The game has run for a very short time, did it crash?
DEBUG    2024-04-10 14:49:09,661 [application.on_game_stop:801]:Removing 7 from running IDs
DEBUG    2024-04-10 14:49:09,667 [game.stop_game:832]:Playtime: Less than a minute
DEBUG    2024-04-10 14:49:09,668 [game.on_game_quit:908]:Ticket to Ride stopped at qua, 10 abr 2024 14:49:09
DEBUG    2024-04-10 14:49:09,695 [lutris.add_to_path_cache:164]:Adding Ticket to Ride (steam) to path cache
WARNING  2024-04-10 14:49:09,695 [lutris.get_path_from_config:131]:No path found in LutrisConfig(level=game, game_config_id=steam-108200-1712756528, runner=steam)
WARNING  2024-04-10 14:49:09,695 [lutris.add_to_path_cache:167]:No path for Ticket to Ride (steam)
Segmentation fault (core dumped)
$ date
2024-04-10T15:09:30+01:00
$ dmesg | grep lutris
[ 1851.351221] lutris[9538]: segfault at 8 ip 00007f44268194a7 sp 00007f44137fc440 error 6 in libpixman-1.so.0.42.2[7f44267cb000+83000] likely on CPU 3 (core 3, socket 0)

Note You need to log in before you can comment on or make changes to this bug.