Description of problem: When starting FreeFileSync and choosing "compare" FreeFileSync exits Version-Release number of selected component (if applicable): freefilesync-11.22-1.mga9.src.rpm How reproducible: - Every time it uses "compare" Steps to Reproduce: 1. Start FreeFileSync 2. Choose two folders to compare 3. Click on "Compare" 4. FreeFileSync exits 5. In konsole it shows "Speicherzugriffsfehler (Speicherabzug geschrieben)"
1. On starting it, error: "13:51:26: can't open file '/usr/share/FreeFileSync/Animal.dat' (error 2: No such file or directory)" 13:51:26: Failed to load image from file "/usr/share/FreeFileSync/Animal.dat". 2. Main window LH toolbar: New & Save lack icons 3. Confirm fault as described above. From terminal: $ FreeFileSync ATTENTION: default value of option mesa_glthread overridden by environment. Missing chrome or resource URL: resource://gre/modules/UpdateListener.jsm Missing chrome or resource URL: resource://gre/modules/UpdateListener.sys.mjs (FreeFileSync:19707): Gtk-WARNING **: 13:59:48.119: Negative content width -5 (allocation 1, extents 3x3) while allocating gadget (node button, owner GtkButton) (FreeFileSync:19707): Gtk-WARNING **: 13:59:48.119: Negative content height -6 (allocation 1, extents 3x4) while allocating gadget (node button, owner GtkButton) Segmentation fault (core dumped) [lewis@localhost ~]$ Missing chrome or resource URL: resource://gre/modules/UpdateListener.jsm Missing chrome or resource URL: resource://gre/modules/UpdateListener.sys.mjs Assigning this to wally who has nursed this pkg for a long time. Re-assign if you want to.
Assignee: bugsquad => jani.valimaa
Now made a test with FreeFileSync newest version from the website: - Download from "https://freefilesync.org/" - https://freefilesync.org/download/FreeFileSync_12.3_Linux.tar.gz - Expanded the archive => "FreeFileSync_12.3_Install.run" - Opened konsole and did "su" - Started "./FreeFileSync_12.3_Install.run" - Let the installation-process run through: ---------- 1. Install for all users: YES (requires root password) 2. Installation directory: /opt/FreeFileSync 3. Create desktop shortcuts: YES _____________________________ Press a number [1-3] to change settings, ENTER to begin installation: -> Installing to: /opt/FreeFileSync -> New console command: freefilesync -> Registering file extensions: *.ffs_gui, *.ffs_batch, *.ffs_real All done! ---------- - After successful installation: started FreeFileSync - gave two folders to compare - compared them (This was the part the mga-version exited before): no problem - synchronized them: Successful!
(In reply to Uli Selle from comment #2) > Now made a test with FreeFileSync newest version from the website: > - Download from "https://freefilesync.org/" > - https://freefilesync.org/download/FreeFileSync_12.3_Linux.tar.gz > - Expanded the archive => "FreeFileSync_12.3_Install.run" > - Opened konsole and did "su" > - Started "./FreeFileSync_12.3_Install.run" Be careful using just "su". Always use "su --login" which can be shortened to "su -". Using just "su" can leave files in your home directory owned by root. https://wiki.mageia.org/en/Never_use_just_su
CC: (none) => davidwhodgins
Hello, After the Release from Mageia 9 this bug affected all users of Mageia. The Bugreport is from may, now it is september. Can someone please update the FreeFileSync version in den repositories? Thanks.
CC: (none) => andreas.pestel
CC: (none) => friSeverity: normal => majorWhiteboard: (none) => MGA9TOO
No response from wally since assigned 4 months ago. => Assigning to all packagers. Cc Olav - next latest committer BTW do we know if our mga8 package works?
CC: (none) => jani.valimaa, olavAssignee: jani.valimaa => pkg-bugs
The same happens to me in Mageia 9: FreeFileSync exists after "Compare". My logs are identical to Lewis Smith's. On the other hand, this package is very outdated (v11.22). It would be nice if someone packaged the current version 13. Thanks!
CC: (none) => squalus
I see freefilesync-13.0-1.mga10 pushed by wally/jani built successfully for cauldron yesterday.
(In reply to Morgan Leijström from comment #5) > No response from wally since assigned 4 months ago. > => > Assigning to all packagers. > Cc Olav - next latest committer > > BTW do we know if our mga8 package works? Hi I confirm that Freefilesync works inside Mageia8 And confirm that in Mageia9 it crashes when beginning to compare NB there's a warning when it starts, complaining about a missing file : the same "Animal.dat" as for Lewis in https://bugs.mageia.org/show_bug.cgi?id=31905#c1 Maybe it would be useful to propose freefilesync-13.0-1 to Mageia9 updates-testing so that we can test if it corrects this bug
CC: (none) => philippedidier
PS Not so simple to build for Mageia9 ! I tried with mock I only had to modify the spec file from BuildRequires:ssh2-devel >= 1.11.0 to BuildRequires:ssh2-devel >= 1.10.0 for satisfying this version present in Mageia9 lower than in Mageia10 But the build stops with errors (these errors seem to come from mock itself) RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.k96RmH (%build) Bad exit status from /var/tmp/rpm-tmp.k96RmH (%build) Child return code was: 1 EXCEPTION: [Error("Command failed: \n # bash --login -c '/usr/bin/rpmbuild -bb --noclean --target x86_64 --nodeps /builddir/build/originals/freefilesync.spec'\n", 1)] Traceback (most recent call last): File "/usr/lib/python3.10/site-packages/mockbuild/trace_decorator.py", line 93, in trace result = func(*args, **kw) File "/usr/lib/python3.10/site-packages/mockbuild/util.py", line 597, in do_with_status raise exception.Error("Command failed: \n # %s\n%s" % (cmd_pretty(command, env), output), child.returncode) mockbuild.exception.Error: Command failed: # bash --login -c '/usr/bin/rpmbuild -bb --noclean --target x86_64 --nodeps /builddir/build/originals/freefilesync.spec'
(In reply to Philippe Didier from comment #9) > I only had to modify the spec file > from BuildRequires:ssh2-devel >= 1.11.0 > to BuildRequires:ssh2-devel >= 1.10.0 > for satisfying this version present in Mageia9 lower than in Mageia10 One shouldn't alter versioned BRs. There's a reason to have them in .spec. Having versioned BR usually means that the pkg build will fail when building with the older version than indicated.
So need ssh2 be updated instead?
(In reply to Jani Välimaa from comment #10) > (In reply to Philippe Didier from comment #9) > > I only had to modify the spec file > > from BuildRequires:ssh2-devel >= 1.11.0 > > to BuildRequires:ssh2-devel >= 1.10.0 > > for satisfying this version present in Mageia9 lower than in Mageia10 > > One shouldn't alter versioned BRs. There's a reason to have them in .spec. > Having versioned BR usually means that the pkg build will fail when building > with the older version than indicated. Hi Jani Thanks for your reply Sorry for my lack of skill Indeed I tried to find a way to have a working Freefilesync inside Mageia9, and when I discovered that it couldn't build because of a missing BR (lower version of ssh2 in Mageia9) I supposed it was simple to modify this version in the BR. No solution this way !. What can we do then to have a working Freefilesync for Mageia9 ? - Revert back to the previous Freefilesync working version (11.3) from Mageia8 ? - try to use an older source than 13.0 ? (12.3 ? 12.4 ? 12.5 ?) - update ssh2 (and rebuild everything depending on it inside Mageia9 ?) PS I tested lots of things of the betas versions of Mageia9, but forgot to test Freefilesync before the final Release ... I should have tested it !
Some news I upgraded my second computer (a laptop) from Mageia8 to Mageia9... all the rpms were not updated by this upgrade, Particularly Freefilesync remained with its Mageia8 version (freefilesync-11.3-2.1.mga8.x86_64.rpm) I tried to use this version of FreeFilesync inside this upgraded Mageia9 : it works ! even for huge comparison and synchronization (29 727 files, 252.7Go) One solution may be to come back to this working version inside Mageia9
PS correcting my last comment That's only possible in an upgraded version from Mageia8 to Mageia9 : The old libs remain (openssl-1.1.1 which is needed by freefilesync-11.3-2. remains beside openssl-3.0.9) In a fresh install of Mageia9 there's only openssl-3.0.9 and we can't install the Mageia8's rpm of freefilesync The only way to correct this bug seems to try to build these versions for Mageia9 (12.3 ? 12.4 ? 12.5 ?) and test them That must need some changes in the spec file ...
One view: So far there is no mga9 packaged FriFileSync that works, so it would be great to take the chance to move to 13.x (if possible without too much work)
1) I tried without any success to build with mock rpms for versions 12.3 , 12.4 , 12.5 of freefilesync on the basis of the spec file of 11.3 version No way for me : the spec file includes lots of lines with "sed blabla" that I am not able to adjust 2) Since I could experiment that I have a working freefilesync-11.3-2.1 (fortunately not automatically updated) on my computer upgraded from Mageia8 to Mageia9 I tried to install on the computer with a fresh install of Mageia9 the mageia8 rpms of freefilesync-11.3-2.1 with some of its known dependencies from mageia8 (in my upgraded second computer they coexist beside their new version without any problem) lib64openssl1.1-1.1.1i-1 lib64tiff5-4.2.0-1 wxgtk-3.1-3.1.5 lib64wx_baseu3.1_5-3.1.5 lib64wx_gtk3u_core3.1_5-3.1.5 lib64wx_gtk3u_aui3.1_5-3.1.5 But no way ! some hidden dependency is missing and freefilesync can't even start on the fresh installed Mageia9 3) Is it possible to provide ssh2 version 1.12 inside Mageia9 ? and then build freefilesync with version 13.x (hoping it works) Is it possible to have 2 versions of ssh2 side by side ? If the answer is no, the remaining question is how many spec files have a BuildRequires ssh2-devel ? and how many rpms need to be rebuilt (with the risk that they are not compliant with this new version of ssh2 !...) This seems to be a big work indeed
PS in this comment https://bugs.mageia.org/show_bug.cgi?id=31905#c2 Uli Selle installed the prebuilt version 12.3 from freefilesync.org and it works It may be possible to build it from source for Mageia9 but that needs a skilled packager
Another try to build freefilesync-13.0 I used the same sources and spec file as Jani I only modified the spec file : from BuildRequires:ssh2-devel >= 1.11.0 to BuildRequires:ssh2-devel >= 1.10.0 and added a patch (from Debian) to allow the use of ssh2 1.10 (I will attach this patch in the next comment) Now I can build FreeFileSync... I installed this rpm, I launched freefilesync starting a comparison but freefilesync crashed before the comparison is finished (segmentation fault core dumped) NB when it is launched from a console we get some warnings (FreeFileSync:263121): Gtk-WARNING **: 17:35:05.888: Negative content width -11 (allocation 1, extents 6x6) while allocating gadget (node button, owner GtkButton)
Created attachment 14080 [details] patch to allow build with ssh2-1.10.0 This patch from Debian allowed to build with ssh2-1.10.0 instead of ssh2-1.11.0 But unfortunately I got a segfault when using this built program (in the past I got such segfault for other program because of the wxgtk version used to build them...)
I am curious to know if FreeFileSync 13.0 works inside Cauldron, for which it has been built ? Or does it induce segfault there too ?
Last try I just tried to build freefilesync-11.3 for Mageia9 (this version works inside Mageia8 ) I added a patch to use ssh2-1.10 (one line inspired from the debian patch https://bugs.mageia.org/attachment.cgi?id=14080&action=diff) Build fails We don't have yet a working rpm for Mageia9 (when we had for Mageia8) Will there ever be an other way than installing the binaries from freefilesync.org ?
(In reply to Philippe Didier from comment #21) > Will there ever be an other way than installing the binaries from > freefilesync.org ? Just installed via flatpak, on mga9. It launches OK. Ver 13.0. Maybe it works the same on mga8. Have not tried using. https://wiki.mageia.org/en/Flatpak
Hi Morgan 1) the rpm of FreeFileSync-11.3 worked perfectly inside Mageia8 2) I only wait for a working rpm of FreeFileSync for Mageia9 I have tried several ways to build it for Mageia9 but didn't succeed (not skilled enough) 3) About flatpak I maintain OpenCPN for which it's harder and harder to build packages since its devs promote the use of flatpak for Linux distributions (except Debian and Ubuntu for which they create the main package and use a cloud to manage its prebuilt plugins) I collaborate with them and could find a workaround to continue to create rpms of OpenCPN and its plugins for Mageia9 Besides this I installed Flatpak and the Flatpak's version of OpenCPN to test it, correct it and improve it since I was not sure to provide rpms for Mageia Flatpak is a heavy sandbox engine that has not access to all your directories (I had to create a script for launching OpenCPN to allow OpenCPN the access to my Charts in a directory inside an extra partition) For this reason I think you can't simply synchronize all that you want (you shall perhaps need to write some paths in the script to launch Flatpak !) Even worse : since I use Flatpak for Mageia8 to test OpenCPN I have had to download 5Go in 2 years to simply have Flatpak up to date ! (Freedesktop Platform , Mesa , Mesa (extra) , org.freedesktop.Platform.locale , org.freedesktop.platform.GL.nvidia) when the weight of the updates of the rpms of OpenCPN for Mageia8 was only 33Mo To conclude as a summary about the use of Flatpak Why ask for a semi-trailer when you can simply use a luggage carrier on your bike !
To control permissions i have earlier used flatseal (itself a flatpak application), but when I try it now it does not paint its own window...
I finally found a workaround to use FreeFileSync inside Mageia9: I had seen that in my computer upgraded from Mageia8 to Mageia9 freefilesync had not been updated Besides this some libraries from Mageia8 coexisted with the ones from Mageia9 So I downloaded from a mirror (core/updates/) those rpms, and installed them one by one in this order : lib64tiff5-4.2.0-1.15.mga8.x86_64 lib64openssl1.1-1.1.1v-1.mga8.x86_64 wxgtk3.1-3.1.5-1.mga8.x86_64 lib64wx_baseu3.1_5-3.1.5-1.mga8.x86_64 lib64wx_baseu_xml3.1_5-3.1.5-1.mga8.x86_64 lib64wx_gtk3u_core3.1_5-3.1.5-1.mga8.x86_64 lib64wx_gtk3u_aui3.1_5-3.1.5-1.mga8.x86_64 lib64wx_gtk3u_html3.1_5-3.1.5-1.mga8.x86_64 lib64wx_gtk3u_qa3.1_5-3.1.5-1.mga8.x86_64 lib64wx_gtk3u_wxsqlite3_3.1_0-4.6.4-1.1.mga8.x86_64 freefilesync-11.3-2.1.mga8.x86_64 FreeFileSync 11.3 installed this way works perfectly It's absolutely not a good way to solve the problem, but nevertheless that works !
PS the mirror is of course Mageia8/core/updates !!!
Hi everybody I finally managed to build a rpm with a working 12.5 version of FreeFileSync I used modified patches from Debian I will attach all what is necessary to build this (spec file, patches and so on) I let someone more skilled than me try this build in mock or iurt install the rpm and test FreeFileSync If it's OK this would provided to Mageia9 by a clever packager
Created attachment 14094 [details] spec file for freefilesync 12.5 for Mageia9 spec file for freefilesync 12.5 for Mageia9
Attachment 14080 is obsolete: 0 => 1
Created attachment 14095 [details] 1st patch
Created attachment 14096 [details] 1st patch : ffs_devuan_gtk3.patch
Attachment 14095 is obsolete: 0 => 1
Created attachment 14097 [details] 2nd patch : ffs_icon_loader.patch
Created attachment 14098 [details] 3rd patch : ffs_no_check_updates.patch
Created attachment 14099 [details] 4th patch : ffs_sftp.patch
Created attachment 14100 [details] 5th patch : libssh2_relax_dep.patch
Created attachment 14101 [details] 6th patch : revert_buggy_gtk3_change_in_12.1.patch
Created attachment 14102 [details] FreeFileSync.desktop
Created attachment 14103 [details] RealTimeSync.desktop
Created attachment 14104 [details] FreeFileSync.png
Created attachment 14105 [details] RealTimeSync.png
and here is the address of the source : https://freefilesync.org/download/FreeFileSync_12.5_Source.zip Have fun !
PS I already installed this rpm I already tested this FreeFileSync 12.5 comparing and synchronizing huge directories from an onboard HDD to an USB external HDD It works fluently (thanks to Debian who created patches for this version that I adapted for Mageia9 ... it was not a piece of cake !)
Last questions : 1) Is it possible to provide FreeFileSync-12.5 as an update for Mageia9 without providing it to Cauldron ? Because in Cauldron there's already FreeFileSync 13.0... and for this reason it won't be possible to push FreeFileSync-12.5 inside Cauldron 2) If there were one way to erase FreeFileSync-13.0 from Cauldron (?), pushing FreeFileSync-12.5 inside Cauldron would need some adjustments of the spec file and of some patches... who can do this ?
Cauldron should remain at version 13+ It is OK to have lower version in earlier Mageia release
Better than sending 11 attached files I would prefer have sent the srpm so that anyone could test it but its weight is 2.6 Mo... Here is a link to download the freefilesync-12.5-1.mga9.src.rpm (valid for 2 weeks) https://transfert.free.fr/ddgYWJ6 If it builds OK, installs well, and works well too and if noone else want to submit this I may try to use mgarepo sync and then submit myself (if I have always my right to do that : I'm not sure to have everything needed on this fresh install of Mageia9 even if I have copied what I could from my /home/myname directory from Mageia8.
If somebody want to install the rpm without having to build it and test freefilesync-12.5 inside Mageia9, here is the link to download freefilesync-12.5-1.mga9.x86_64.rpm https://transfert.free.fr/P2cVm0V Before going forward it may be good to have some feedback !
Well I have just submitted this to Mageia9/core/updates_testing It has been built for each arch Let's test now to verify that it corrects this 5 months old bug report Assigning to QA, Packages in 9/Core/Updates_testing: ====================== freefilesync-12.5-1.mga9 From SRPMS: freefilesync-12.5-1.mga9.src.rpm Advisory suggested : This version 12.5 correct the bug 31905 (crash when launching comparison with version 11.22)
Whiteboard: MGA9TOO => MGA9 only
Thank you for all the work, Philippe! Cauldron is solved by version 13. Setting to mga9 only. Really assigning to QA.
Version: Cauldron => 9Assignee: pkg-bugs => qa-bugsWhiteboard: MGA9 only => (none)
Hi Morgan Thanks for having corrected this About version 13 : has it been tested inside Cauldron (I can't since I don't have Cauldron on my computer) ? I know it can be built for Cauldron... that is not enough to know if it works inside Cauldron I could build version 13 for Mageia9 with a patch but I got segfault when launching it, (look at https://bugs.mageia.org/show_bug.cgi?id=31905#c19) ... the problem seemed linked to wxgtk I hope this doesn't occur for Cauldron !
Main goal is to push a better working package on stable release, Mageia 9, ASAP. If the version 13 in Cauldron does not work as is, we can work on it later, it is long until Mageia 10 is near release. But we should not forget to test it. We can later work on updating the mga9 version of FreeFileSync to 13, after we know it works in Cauldron. BTW, I see 13.1 is released upstream.
Status comment: (none) => Need test also on Cauldron
(In reply to Philippe Didier from comment #46) > Well > > I have just submitted this to Mageia9/core/updates_testing > It has been built for each arch > > Let's test now to verify that it corrects this 5 months old bug report > This new release removed the usage of our compiler and linker flags. That's why there's a need for disabling debug pkgs. It's wrong and needs to be fixed.
Assignee: qa-bugs => philippedidier
Hi Jani I've tried several ways to build a rpm to create a working freefilesync... (with several versions from the one in Mageia8 to the latest 13.0) adapting the spec files used for Mageia When I succeed to build and install the rpm I got segfault !!! The only rpm that worked is this one with its non orthodox spec file and patches. This bug report being 5 months old, and this bug preventing me to use FreeFileSync that missed me a lot... As nobody had taken charge of this, I tried my best (instead of using the ugly workaround that I explained in this comment https://bugs.mageia.org/show_bug.cgi?id=31905#c25 ) and spent hours to find a working solution At the end I was warned by mock that the debug packages couldn't be created because the debug-lists were empty... That's the reason why I had to add %global debug_package %{nil} in the first lines of the spec file ! Whatever, it works now !!! and that's at least a way to close this long lasting bug report ! You may criticize if you want But about the missing Debug packages : If you look at the Source you will see that the Makefile for FreeFileSync and the Makefile for RealTimeSync contain both of them --debug=no twice in their first lines : I didn't modify this part of the Makefiles with any patch. I'm not able to do better than what I did, and if someone more skilled may obtain a rpm installing a working freefilesync and create besides it these missing debug packages... I won't be upset and I will learn how he does what I was not able to do (looking at the spec file and patches that he will have modified) waiting for this improvement, let us have at least a working FreeFileSync in Mageia9 (Mageia9 is out and has been missing this for 2 months)
Building and installation might work, but the pkg isn't following our pkg'ing guidelines. Missing debug pkg is also a regression. Using our compiler and linker flags is not only about getting debug packages, but also getting better system security. Our compiler flags improves security by detecting e.g. buffer overflows and string format security flaws. And as a friendly note. Hurry is the worst excuse to get the pkg through QA.
Please test freefilesync-12.5-1.2.mga9 from core/updates_testing. It's built using our compiler and linker flags, and debug pkgs are also enabled again.
Assignee: philippedidier => qa-bugs
Hi Jani Sorry about my hurry but as no one did anything to correct this bug I thought it would be useful to have something working awaiting a better packager correct my draft spec and patches Thanks for having created and added your patch so quickly I downloaded freefilesync-12.5-1.2.mga9, installed it (updating the previous version) I tested it and it works : no crash ... same way as freefilesync-12.5-1.mga9 even if it didn't follow the guidelines (launched from a console we get no warning about gtk same as freefilesync-12.5-1.mga9) NB each time I got a crash with other versions I had successfully built for Mageia9 I got warning about gtk Maybe now you may assign it yourself to QA Packages in 9/Core/Updates_testing: ====================== freefilesync-12.5-1.2.mga9 From SRPMS: freefilesync-12.5-1.2.mga9.src.rpm Advisory suggested : This version 12.5 correct the bug 31905 (crash when launching comparison with version 11.22)
PS For information the patches from debian sid had been found here : http://deb.debian.org/debian/pool/main/f/freefilesync/freefilesync_12.5-1.debian.tar.xz As you may see I didn't use all the patches from Debian (some of them were debian specific) I had to rewrite partly some of them or to gather two of them in only one patch : ffs_devuan.patch and ffs_devuan_gtk3.patch became ffs_devuan_gtk3.patch Debian is one of the rare distribution to compile freefilesync from a recent source 12.5 Fedora provides only 9.6 version Ubuntu 12.0 Some (few) distributions only propose to install the prebuilt binaries from freefilesync.org ! I tried to adapt the 13.0 version from Cauldron or OpenSuse to Mageia9 so that I could build a rpm with a patch... but I got crashes when using version 13.0
(In reply to Philippe Didier from comment #54) > Hi Jani > > Sorry about my hurry but as no one did anything to correct this bug I > thought it would be useful to have something working awaiting a better > packager correct my draft spec and patches > > Thanks for having created and added your patch so quickly > > I downloaded freefilesync-12.5-1.2.mga9, installed it (updating the previous > version) > > I tested it and it works : no crash ... same way as freefilesync-12.5-1.mga9 > even if it didn't follow the guidelines > (launched from a console we get no warning about gtk same as > freefilesync-12.5-1.mga9) > > NB each time I got a crash with other versions I had successfully built for > Mageia9 I got warning about gtk > > > Maybe now you may assign it yourself to QA > > > Packages in 9/Core/Updates_testing: > ====================== > freefilesync-12.5-1.2.mga9 > > From SRPMS: > freefilesync-12.5-1.2.mga9.src.rpm > > Advisory suggested : > This version 12.5 correct the bug 31905 > (crash when launching comparison with version 11.22) Hello, installed this rpm and it works, as expected! Thank you for repairing this! Uli
mga9-64 OK here too. Tested two-way sync between two discs, added, edited, removed files. All working nicely. This is a wonderful tool. Thank you Philippe and Jani for your work on it, and Uli for reporting and testing This is good to go. Sidenote: In Cauldron it would be good to test operation of FrieeFileSync 13(+) @Marja: Advisory proposal in Comment 54.
CC: (none) => marja11, sysadmin-bugsWhiteboard: (none) => MGA9-64-OKKeywords: (none) => validated_updateStatus comment: Need test also on Cauldron => Regardless this bug: Please also test in Cauldron
Advisory from comment 54 added to SVN.
Keywords: (none) => advisory
An update for this issue has been pushed to the Mageia Updates repository. https://advisories.mageia.org/MGAA-2023-0113.html
Resolution: (none) => FIXEDStatus: NEW => RESOLVED
Thank you all for your work :-)