Bug 31808 - Provide --no-vcs in mgarepo sync for mga8
Summary: Provide --no-vcs in mgarepo sync for mga8
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 8
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 8
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA8-64-OK
Keywords: advisory, has_procedure, validated_update
Depends on:
Blocks:
 
Reported: 2023-04-17 20:58 CEST by Dan Fandrich
Modified: 2023-04-24 02:21 CEST (History)
5 users (show)

See Also:
Source RPM: mgarepo-1.14.2-3.mga8.src.rpm
CVE:
Status comment:


Attachments

Description Dan Fandrich 2023-04-17 20:58:20 CEST
mgarepo 1.4.4 added the --no-vcs option to replace functionality lost when the operation of --dry-run was changed. The stable version of mgarepo in mga8 should have that option added to provide a smooth upgrade path for people & scripts that relied on the old behaviour.
Comment 1 Dan Fandrich 2023-04-17 21:13:12 CEST
mgarepo-1.14.2-4.mga8 is available in core/updates_testing with the --no-vcs option backported.

Test procedure (works for 1.14.2-4 only):

1. Use "mgarepo co X; cd X" to check out just about any package
2. "rm SOURCES/*z" to delete the source tarball
3. "sed -i 1iPatch999:foobar SPECS/*spec && echo foo > SOURCES/foobar" to add a fake patch to the spec file
4. "mgarepo sync --dry-run -d && svn status" should show the missing file, then download it, then, for the last mention of foobar, show "?   SOURCES/foobar" to show that it hasn't been added to svn. This validates the existing behaviuor. 
5. Repeat step 2.
6. "mgarepo sync --no-vcs -d && svn status" should have exactly the same behaviour as step 4.
7. "mgarepo sync && svn status" should show "A   SOURCES/foobar" for both mentions of foobar, to show that foobar has been added to svn.

Keywords: (none) => has_procedure
Status: NEW => ASSIGNED

Dan Fandrich 2023-04-17 21:19:46 CEST

Assignee: dan => qa-bugs
CC: (none) => dan
Target Milestone: --- => Mageia 8

Comment 2 Len Lawrence 2023-04-18 19:28:18 CEST
Mageia8, x86_64
Checked out rust for this test, before and after updating.
For mgarepo-1.14.2-3.mga8 no --no-cvs option.

After update:
$ ls SOURCES
0001-Use-lld-provided-by-system-for-wasm.patch
macros.rust-toolset
rustc-1.50.0-allow_fail-armv7-instruction_set.patch
rustc-1.61.0-rust-gdb-substitute-path.patch
rustc-1.65.0-disable-libssh2.patch
rustc-1.65.0-no-default-pie.patch
rustc-1.68.0-disable-http2.patch
sha1.lst
$ ls .svn
entries  format  pristine/  tmp/  wc.db  wc.db-journal
$ sed -i 1iPatch999:foobar SPECS/*spec && echo foo > SOURCES/foobar
$ mgarepo sync --dry-run -d && svn status
A	./SOURCES/wasi-libc-wasi-sdk-19.tar.gz
A	./SOURCES/rustc-1.68.0-src.tar.xz
A	./SOURCES/foobar
?       SOURCES/foobar
?       SOURCES/rustc-1.68.0-src.tar.xz
?       SOURCES/wasi-libc-wasi-sdk-19.tar.gz
M       SPECS/rust.spec

$ rm -f SOURCES/*z
$ sed -i 1iPatch999:foobar SPECS/*spec && echo foo > SOURCES/foobar
$ mgarepo sync --no-vcs -d && svn status
...........
A	./SOURCES/wasi-libc-wasi-sdk-19.tar.gz
A	./SOURCES/rustc-1.68.0-src.tar.xz
A	./SOURCES/foobar
?       SOURCES/foobar
?       SOURCES/rustc-1.68.0-src.tar.xz
?       SOURCES/wasi-libc-wasi-sdk-19.tar.gz
M       SPECS/rust.spec

Hope that this is all correct.  Looks like it to me.

CC: (none) => tarazed25

Comment 3 Len Lawrence 2023-04-18 19:34:35 CEST
Referring to comment 2:  s/--no-cvs/--no-vcs/
Comment 4 Dan Fandrich 2023-04-18 19:59:17 CEST
Those test results look good. Making that particular Freudian slip in the option name really shows my age... At least I didn't say --no-sccs
Comment 5 Len Lawrence 2023-04-18 22:58:58 CEST
Thanks for the procedure Dan.  Sending this on.

Whiteboard: (none) => MGA8-64-OK

Comment 6 Thomas Andrews 2023-04-18 23:41:37 CEST
Validating.

Keywords: (none) => validated_update
CC: (none) => andrewsfarm, sysadmin-bugs

Dave Hodgins 2023-04-24 00:23:13 CEST

Keywords: (none) => advisory
CC: (none) => davidwhodgins

Comment 7 Mageia Robot 2023-04-24 02:21:44 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2023-0036.html

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.