Bug 31676 - fileroller: crash if filename is absolute
Summary: fileroller: crash if filename is absolute
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: GNOME maintainers
QA Contact:
URL:
Whiteboard:
Keywords: IN_ERRATA9, UPSTREAM
Depends on:
Blocks:
 
Reported: 2023-03-15 11:14 CET by Marc Krämer
Modified: 2023-04-16 10:05 CEST (History)
4 users (show)

See Also:
Source RPM: file-roller-43.0-1.mga9.src.rpm
CVE:
Status comment: To be reported/commented upstream


Attachments

Description Marc Krämer 2023-03-15 11:14:24 CET
run file-roller. Create a new archive and write e.g. /tmp/test
as filename.
It crashes with the following error:
(file-roller:6529): GLib-GIO-CRITICAL **: 11:11:25.269: g_file_get_child: assertion '!g_path_is_absolute (name)' failed
Segmentation fault (core dumped)


Before mga9 this worked perfect.
Comment 1 Marc Krämer 2023-03-15 11:15:03 CET
using relative filenames works... but it is quite common to just enter a full path...
Comment 2 David GEIGER 2023-03-16 04:10:05 CET
Could you report this issue upstream at https://gitlab.gnome.org/GNOME/file-roller/-/issues ?

CC: (none) => geiger.david68210

Comment 3 Marc Krämer 2023-03-16 09:57:37 CET
grrr. just the next account and bugtracker:
"Signing in using your GitHub account without a pre-existing GitLab account is not allowed. Create a GitLab account first, and then connect it to your GitHub account."
Comment 4 Lewis Smith 2023-03-16 21:23:10 CET
I reproduce this easily on a Cauldron system, but I see why it has not surfaced before:
On starting file-roller, empty window.
Click the schematic menu icon, choose 'New Archive'.
The dialogue it pops comprises two fields:
- a filename for the archive
- a location for that file, default HOME
A filename is not a pathname. Clearly the usage of this thing for Marc's example requires:
- a filename of 'test' (it adds a suitable suffix)
- choose location '/tmp'
The crash happens if you give an absolute pathname for the archive file (which makes the following location field redundant) on clicking 'create', regardless of 'location'; although if you were able to specify an absolute pathname for the archive, you would have to choose 'Filesystem' for its location.

True, the crash should not happen, rather an error message.
As for posting the bug upstream, a search for 'file-roller' issues shows little activity on them...

(In reply to Marc Krämer from comment #1)
> it is quite common to just enter a full path...
Given the file-roller user interface, which clearly separates *filename* from its *location*, this cannot be true for this particular application. For others, perhaps.

CC: (none) => lewyssmith
Keywords: (none) => FOR_ERRATA9, UPSTREAM

Comment 5 Marc Krämer 2023-03-18 11:51:35 CET
@Lewis: e.g. in mate almost every file dialog has a chooser for directories, favorites and so on. It always worked, just to write an absolute filename to it.
But in any case, you're right - it should not just crash.
Morgan Leijström 2023-03-18 20:28:58 CET

CC: (none) => fri
Status comment: (none) => To be reported/commented upstream

Comment 6 Lewis Smith 2023-03-18 21:04:22 CET
@Marc
If you do persevere with an upstream bug report, please put that URL in this bug URL field.

This may have to remain open even though there is nothing we can do about it - until & if upstream fix it. I suppose it could/should be closed 'wontfix' meaning 'cannot fix'; not for us to decide. In Errata it will be found.

Assigning to Gnome despite this; no point in it remaining with Bugsquad.
CC'ing Olave who has mostly updated file-roller; and Thierry who has also touched it recently. DavidG has already commented. Over to one of you.

Assignee: bugsquad => gnome
CC: lewyssmith => olav, thierry.vignaud

Lewis Smith 2023-04-16 10:05:14 CEST

Keywords: FOR_ERRATA9 => IN_ERRATA9


Note You need to log in before you can comment on or make changes to this bug.