Bug 30652 - xdelta3 produces error from being compiled without LZMA
Summary: xdelta3 produces error from being compiled without LZMA
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 8
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA8-64-OK
Keywords: advisory, validated_update
Depends on:
Blocks:
 
Reported: 2022-07-19 07:48 CEST by Ken Arromdee
Modified: 2022-07-25 23:43 CEST (History)
6 users (show)

See Also:
Source RPM: xdelta3-3.0.11-3.mga8.src.rpm
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ken Arromdee 2022-07-19 07:48:19 CEST 
Description of problem:
Trying to use xdelta3 with a patch containing lzma fails because it was compiled without lzma.

Version-Release number of selected component (if applicable):
3.0.11

How reproducible:
Always

Steps to Reproduce:
1. Get and extract the patch from https://www.romhacking.net/translations/6462/ to get srww.xdelta.
2. Try xdelta3 on a nonexistent file a.ds (you don't need a pirated ROM to test it)

xdelta3 -d -s a.ds /tmp/srww.xdelta a.ds
xdelta3: unavailable secondary compressor: LZMA: XD3_INTERNAL

3. Download from xdelta.org, compile 3.0.11 myself, and it works:

% /usr/local/src/xdelta*/xdelta3/xdelta3 -d -s a.ds /tmp/srww.xdelta a.ds
xdelta3: file open failed: read: a.ds: No such file or directory
(or a different error if the a.ds file exists but is bad)

I accidentally posted this in #17853 which is a different XD3_INTERNAL xdelta bug.
Comment 1 Morgan Leijström 2022-07-19 20:46:06 CEST 
Thank you for the report.
I see nobody is registered maintainer for xdelta3.
I see wally built xdelta3-3.0.11-5.mga9 in Cauldron just now, with:

http://svnweb.mageia.org/packages?view=revision&revision=1869426
Log Message: 	
- enable liblzma support (mga#30652)
- build using our linker flags

I just dont remember who wally is, intended to CC...

CC: (none) => fri

Comment 2 sturmvogel 2022-07-19 21:13:58 CEST 
@Morgan: It's Jani :D

CC: (none) => jani.valimaa

Comment 3 Jani Välimaa 2022-07-21 20:13:06 CEST 
Please test with xdelta3-3.0.11-3.1.mga8 from mga8 core/updates_testing.

Assignee: bugsquad => qa-bugs

Comment 4 Jani Välimaa 2022-07-21 20:13:53 CEST 
SRPMS/RPMS:
xdelta3-3.0.11-3.1.mga8
Comment 5 Ken Arromdee 2022-07-21 22:01:55 CEST 
This appears to fix the problem.
Comment 6 Len Lawrence 2022-07-22 13:25:28 CEST 
mga8, x64
Thanks Ken for the confirmation.
Just going through the motions so we can add QA's stamp.
Checked the current version using the procedure in bug 17713.  No problems there.  Copied the xdelta3 binary to the local directory and ran `xdelta3 test` which completed successfully.

Ran the same tests again after updating:
Regenerated the patch file and applied it to one of the test binaries, effectively replacing its functionality with that of the other binary.  The resultant binary worked as expected.  Copied the new xdelta3 from /usr/bin and ran the test command.  All good.

Whiteboard: (none) => MGA8-64-OK
CC: (none) => tarazed25

Comment 7 Thomas Andrews 2022-07-22 14:00:42 CEST 
Validating.

Keywords: (none) => validated_update
CC: (none) => andrewsfarm, sysadmin-bugs

Dave Hodgins 2022-07-25 20:38:25 CEST

Keywords: (none) => advisory
CC: (none) => davidwhodgins

Comment 8 Mageia Robot 2022-07-25 23:43:08 CEST 
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2022-0106.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.