Bug 30554 - Added systemd files that are incorrect, webmin will not run.
Summary: Added systemd files that are incorrect, webmin will not run.
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 8
Hardware: All Linux
Priority: Normal critical
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA8-64-OK
Keywords: advisory, validated_update
Depends on:
Blocks:
 
Reported: 2022-06-16 03:22 CEST by james Whitby
Modified: 2022-06-18 23:31 CEST (History)
5 users (show)

See Also:
Source RPM: webmin-1.994-1.mga8.src.rpm
CVE:
Status comment:


Attachments
Patch to fix location of pid file in /usr/share/webmin/webmin-systemd (349 bytes, patch)
2022-06-16 05:17 CEST, Dave Hodgins
Details | Diff

Description james Whitby 2022-06-16 03:22:54 CEST
Description of problem:

Install new version of webmin.
reboot.
webmin will not run.

The systemd control file has
/etc/webmin/.start-init
and .stop-init as start and stop functions.

These files do not exist in the webmin dir

Attempting to run from init.d will not work either.

Cure is to downgrade webmin to 1990.1

As always, more info? just let me know.
Comment 1 Dave Hodgins 2022-06-16 04:15:22 CEST
Just installed it.
# ll /etc/webmin/.s*-init
-rwxr-xr-x 1 root root 221 Jun 15 21:47 /etc/webmin/.start-init*
-rwxr-xr-x 1 root root 677 Jun 15 21:47 /etc/webmin/.stop-init*

Note the file names start with a period so showing hidden files must be turned
on to see them.

Webmin in Mageia 8 has not been changed to use systemd control files. It still
uses /etc/rc.d/init.d/webmin

# chkconfig 2>/dev/null|grep webmin
webmin          0:off   1:off   2:on    3:on    4:on    5:on    6:off

Start webmin with "/etc/rc.d/init.d/webmin start" (as root) or reboot.
webmin starts and I can access it using https://localhost:10000/
(login as root with root's password).

Closing as invalid. Feel free to add more comments, and reopen if appropriate.

CC: (none) => davidwhodgins
Status: NEW => RESOLVED
Resolution: (none) => INVALID

Comment 2 Dave Hodgins 2022-06-16 04:17:07 CEST
# rpm -q webmin
webmin-1.994-1.mga8
Comment 3 Dave Hodgins 2022-06-16 04:25:29 CEST
Reopening myself. While it does start and works, there are some errors showing
that should be fixed.

# systemctl status webmin.service
● webmin.service - Webmin server daemon
     Loaded: loaded (/usr/lib/systemd/system/webmin.service; disabled; vendor preset: disabled)
     Active: failed (Result: timeout) since Wed 2022-06-15 21:50:29 EDT; 28min ago
    Process: 57069 ExecStart=/etc/webmin/.start-init (code=exited, status=0/SUCCESS)
        CPU: 4.495s

Jun 15 21:48:59 x3.hodgins.homeip.net perl[57069]: pam_unix(webmin:auth): authentication failure; logname= uid=0 euid=0 tty= ruser= rhost=  user=root
Jun 15 21:49:01 x3.hodgins.homeip.net webmin[57069]: Webmin starting
Jun 15 21:49:01 x3.hodgins.homeip.net systemd[1]: webmin.service: Can't open PID file /var/webmin/miniserv.pid (yet?) after start: Operation not permitted
Jun 15 21:50:29 x3.hodgins.homeip.net systemd[1]: webmin.service: start operation timed out. Terminating.
Jun 15 21:50:29 x3.hodgins.homeip.net systemd[1]: webmin.service: Failed with result 'timeout'.
Jun 15 21:50:29 x3.hodgins.homeip.net systemd[1]: webmin.service: Unit process 57077 (miniserv.pl) remains running after unit stopped.
Jun 15 21:50:29 x3.hodgins.homeip.net systemd[1]: Failed to start Webmin server daemon.
Jun 15 21:50:29 x3.hodgins.homeip.net systemd[1]: webmin.service: Consumed 4.495s CPU time.
Jun 15 22:04:18 x3.hodgins.homeip.net perl[58855]: pam_unix(webmin:auth): authentication failure; logname= uid=0 euid=0 tty=10000 ruser= rhost=127.0.0.1  user=root
Jun 15 22:04:20 x3.hodgins.homeip.net webmin[58855]: Invalid login as root from 127.0.0.1

Status: RESOLVED => REOPENED
Resolution: INVALID => (none)

Comment 4 Dave Hodgins 2022-06-16 04:54:13 CEST
webmin uses /run/webmin/miniserv.pid, not /var/webmin/miniserv.pid
I'm not sure where systemd is getting /var/webmin from.
Comment 5 Dave Hodgins 2022-06-16 05:17:24 CEST
Created attachment 13298 [details]
Patch to fix location of pid file in /usr/share/webmin/webmin-systemd

Patch to fix location of pid file in /usr/share/webmin/webmin-systemd

After applying the patch and running "killall miniserv.pl" to end the already
running webmin, "systemctl start webmin.service" works.

# systemctl status webmin.service |grep Active:
     Active: active (running) since Wed 2022-06-15 23:15:11 EDT; 33s ago
Comment 6 Dave Hodgins 2022-06-16 05:20:38 CEST
Assigning to all packagers as webmin doesn't have an assigned maintainer.
Adding luigiwalser to cc list as the packager who did the most recent changes.
See comment 5 for the patch.

Assignee: bugsquad => pkg-bugs
CC: (none) => luigiwalser

Comment 7 james Whitby 2022-06-16 06:07:10 CEST
All I'm sure of is when I did ls -a /etc/webmin
There were not any .start or .stop files.

Where they went I dunno.

The init.d webmin contains
/var/run/webmin/miniserv.pid

not /run/webmin/miniserv.pid

Having modified the systemd and init.d/webmin files, it works from init.d/webmin and systemctl.
Comment 8 Dave Hodgins 2022-06-16 06:12:43 CEST
# ls -l /var/run
lrwxrwxrwx 1 root root 6 Jul 31  2020 /var/run -> ../run/

/var/run/webmin and /run/webmin are the same directory.
Comment 9 james Whitby 2022-06-16 06:24:13 CEST
them damn syslinks.... get ya everytime.
Comment 10 David Walser 2022-06-16 23:46:41 CEST
webmin-1.994-1.1.mga8 submitted to fix this.

Assignee: pkg-bugs => qa-bugs

Comment 11 Herman Viaene 2022-06-17 11:20:06 CEST
MGA8-64 Plasma on Acer Aspire 5253
No installation issues.
Checked System- Software package updates, none found, which is correct.
System- Users and groups:looks OK
Servers: checked that apache, mysql could be started and stopped, checked using systemctl
Tools: checked System and Server Status
Networking: checked Network Configuration, Network Utilities and Shorewall Firewall
All looks OK with valid and expected values.

CC: (none) => herman.viaene
Whiteboard: (none) => MGA8-64-OK

Comment 12 Thomas Andrews 2022-06-17 15:51:14 CEST
Validating.

Keywords: (none) => validated_update
CC: (none) => andrewsfarm, sysadmin-bugs

Dave Hodgins 2022-06-18 21:27:58 CEST

Keywords: (none) => advisory

Comment 13 Mageia Robot 2022-06-18 23:31:46 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2022-0086.html

Resolution: (none) => FIXED
Status: REOPENED => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.