Bug 30007 - firejail new security issue fixed upstream in 0.9.68
Summary: firejail new security issue fixed upstream in 0.9.68
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 8
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact: Sec team
URL:
Whiteboard: MGA8-64-OK
Keywords: advisory, validated_update
Depends on:
Blocks:
 
Reported: 2022-02-06 17:31 CET by David Walser
Modified: 2022-02-09 21:47 CET (History)
5 users (show)

See Also:
Source RPM: firejail-0.9.66-1.mga9.src.rpm
CVE:
Status comment:


Attachments

Description David Walser 2022-02-06 17:31:01 CET
Firejail 0.9.68 has been released today (February 6):
https://github.com/netblue30/firejail/releases/tag/0.9.68

It fixes a security issue:
https://github.com/netblue30/firejail/issues/4780

We should backport the fix to Mageia 8:
https://github.com/netblue30/firejail/commit/d2e10f8b728eb83f05c1c57cf06a28a6cd48f58f
David Walser 2022-02-06 17:31:11 CET

Whiteboard: (none) => MGA8TOO

Comment 1 Nicolas Lécureuil 2022-02-07 15:08:15 CET
new version pushed in mga9.


For mageia what about updating to the new version too ?

CC: (none) => mageia
Version: Cauldron => 8
Whiteboard: MGA8TOO => (none)

Comment 2 David Walser 2022-02-07 16:21:58 CET
IIRC, there was a reason we didn't upgrade it before, some removed features or something.
Comment 3 Nicolas Lécureuil 2022-02-08 09:23:04 CET
patch added in mga8:

src:
    - firejail-0.9.64-1.2.mga8

CC: (none) => jani.valimaa
Assignee: jani.valimaa => qa-bugs

Comment 4 Morgan Leijström 2022-02-08 18:15:32 CET
Mageia 8 
Test copied from Dave H in https://bugs.mageia.org/show_bug.cgi?id=27059#c4 :

The main use of firejail is used to limit which files on the local system can
be accessed.

$ echo test>test

$ firefox ~/test &
shows the contents of the file file:///home/dave/test
After closing the tab and firefox ...

$ firejail firefox ~/test &

shows ...
File not found


So far so good - BUT:
If i in firefox tell it to enter /// it lists my root!
And I can browse the file system
I can also tell it to list ///home/morgan

Neither is in a whitelist line in /etc/firejail/firefox.profile

It was also the same before update, so no regression from previous version on my system, but still something is wrong, IMO.

According to Herman V in https://bugs.mageia.org/show_bug.cgi?id=27059#c3
that version blocked /// if i understand him correctly, and I remember one test I did myself long ago with that result.
I am not sure about if home was blocked in earlier version.

CC: (none) => fri

Comment 5 Morgan Leijström 2022-02-08 18:29:44 CET
(In reply to David Walser from comment #2)
> IIRC, there was a reason we didn't upgrade it before, some removed features
> or something.

I remember for mga7 we kept it at .56 due to dropped support of snap, possibly more, but we advanced firejail to .64 (64.4 overlayfs fix) in mga8 Bug 28322 and I cant see something that seem important that got dropped since then.
But more eyes should check.
https://github.com/netblue30/firejail/releases
Comment 6 David Walser 2022-02-08 18:45:54 CET
Ahh, that's probably what I was remembering.
Comment 7 Dave Hodgins 2022-02-08 19:26:17 CET
(In reply to Morgan Leijström from comment #4)
> Mageia 8 
> Test copied from Dave H in https://bugs.mageia.org/show_bug.cgi?id=27059#c4 :
> 
> The main use of firejail is used to limit which files on the local system can
> be accessed.
> 
> $ echo test>test
> 
> $ firefox ~/test &
> shows the contents of the file file:///home/dave/test
> After closing the tab and firefox ...
> 
> $ firejail firefox ~/test &
> 
> shows ...
> File not found
> 
> 
> So far so good - BUT:
> If i in firefox tell it to enter /// it lists my root!
> And I can browse the file system

The parent directories must be accessible or the lower level directories
would not be able to be accessed.

> I can also tell it to list ///home/morgan

However the list of files/directories in /home/morgan is restricted. See
"grep HOME /etc/firejail/*|grep firefox"
 
> Neither is in a whitelist line in /etc/firejail/firefox.profile

The files in / are neither in a whitelist or blacklist, so apparently are
allowed. That's an oversight in the default profile for firefox, imho.

CC: (none) => davidwhodgins

Comment 8 Dave Hodgins 2022-02-08 19:27:06 CET
Validating the update.

Keywords: (none) => validated_update
Whiteboard: (none) => MGA8-64-OK
CC: (none) => sysadmin-bugs

Dave Hodgins 2022-02-09 20:57:35 CET

Keywords: (none) => advisory

Comment 9 Mageia Robot 2022-02-09 21:47:06 CET
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGASA-2022-0055.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.