Bug 29634 - Package ready for chromium-95.0.4638.69 on MGA8, built with clang and without python2 anymore
Summary: Package ready for chromium-95.0.4638.69 on MGA8, built with clang and without...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: New RPM package request (show other bugs)
Version: 8
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Christiaan Welvaart
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-07 16:38 CET by christian barranco
Modified: 2022-03-16 20:10 CET (History)
4 users (show)

See Also:
Source RPM: chromium-browser-stable-94.0.4606.61-1.mga8.x86_64
CVE:
Status comment:


Attachments
spec file diff (14.80 KB, patch)
2021-11-07 16:43 CET, christian barranco
Details | Diff
all adjusted or added patches, as described in the report (65.99 KB, application/gzip)
2021-11-07 16:44 CET, christian barranco
Details
log file of the rpmbuild execution (583.02 KB, application/gzip)
2021-11-08 17:14 CET, christian barranco
Details

Description christian barranco 2021-11-07 16:38:28 CET
Hi

I just built chromium-95.0.4638.69 for MGA8, using clang and removing the need to use python2 (python 3 only then).

I used our MGA8 spec file as a base, I tested it and the src.rpm is available.

I moved to clang because using gcc leads to quite some work to patch the code and the chromium teams doesn't provide any support: https://bugs.chromium.org/p/chromium/issues/detail?id=1263993
Then, it was required to manage that Chromium has moved to clang13 and MGA8 still uses clang11.

As python2 is not supported by Mageia anymore and as Chromium fully supports python3, I thought it would be a good idea to do the switch now.

Changes made:
* chromium-browser-stable.spec: of course, updated with the new patches and additional adjustments for python3, clang and deprecated part of the source. -> chromium-browser-stable-spec.patch

* chromium-compiler-r4.patch -> chromium-95-compiler-r4.patch, 
**to accommodate code change.

* chromium-norar.patch -> chromium-95_69-norar.patch 
**same purpose but to handle code changes and to remove rar_analyzer as a dep for safe_browsing.

* chromium-55-extra-media.patch -> chromium-95-extra-media.patch
  chromium-40-wmvflvmpg.patch -> chromium-95-wmvflvmpg.patch
  chromium-40-sorenson-spark.patch -> chromium-95-sorenson-spark.patch
  chromium-extra-media-video-profiles.patch -> chromium-95-extra-media-video-profiles.patch
**to handle code changes some parts have been reworked and removed from original patches, to be added into chromium-95-extra-media.patch instead

* chromium-45-no-external-components.patch -> chromium-95-no-external-components.patch
**same purpose but to handle code changes

* chromium-77-python2.patch -> deprecated moving to python3

* chromium-gcc-includes.patch -> chromium-95-gcc-includes.patch
  chromium-gcc-type-errors.patch -> chromium-95-gcc-type-errors.patch
**removed applied patches 

* chromium-gcc-character-literals.patch -> chromium-95-gcc-character-literals.patch
  chromium-gcc-anonymous-namespace.patch -> chromium-95-gcc-anonymous-namespace.patch
  chromium-gcc-unsorted.patch -> chromium-95-gcc-unsorted.patch
  chromium-gcc-disabled-warnings.patch -> chromium-95-gcc-disabled-warnings.patch
  chromium-gcc-braces.patch -> chromium-95-gcc-braces.patch
**same purpose but to handle code changes

* chromium-95-system-zlib.patch -> additional fix build with system zlib for Chromium 95
**new patch

* chromium-89-EnumTable-crash.patch -> removed as it leads to enum_table.h:359:18: error: no template named 'vector' in namespace 'std' (because of 95 version or because of clang 13?)

* chromium-95-clang_compiler.patch
  chromium-clang-nomerge.patch
**new patches to use clang11 instead of clang13 (unknown option -ffile-compilation-dir), from opensuse.

* chromium-95-maldoca-zlib.patch
**new patch from Arch. Fix system zlib_common_header error with maldoca

* chromium-95-BitstreamReader-namespace.patch
** new patch from Chromium "upstream"

Nicolas, I cc you as you are the mentor. 

Let me know what else I could do.
Comment 1 christian barranco 2021-11-07 16:43:45 CET
Created attachment 12976 [details]
spec file diff
Comment 2 christian barranco 2021-11-07 16:44:45 CET
Created attachment 12977 [details]
all adjusted or added patches, as described in the report
christian barranco 2021-11-07 16:45:05 CET

CC: (none) => mageia

Comment 3 Morgan Leijström 2021-11-07 17:24:12 CET
Good initiative!
Also good you announced it on dev mail list :)

CC Chromium-browser packager Christiaan Welvaart

(from https://madb.mageia.org/package/show/name/chromium-browser-stable )

CC: (none) => cjw, fri

David Walser 2021-11-08 15:17:33 CET

CC: (none) => luigiwalser
See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=29541

David Walser 2021-11-08 15:17:48 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=28420

David Walser 2021-11-08 15:18:12 CET

CC: luigiwalser => (none)

Comment 4 christian barranco 2021-11-08 17:14:26 CET
Created attachment 12979 [details]
log file of the rpmbuild execution

compressed log file
Comment 5 Frank Griffin 2021-11-12 00:31:54 CET
Assigning to current maintainer.

Assignee: bugsquad => cjw
CC: (none) => ftg

Comment 6 christian barranco 2022-03-16 20:02:02 CET
Hi. Based on https://bugs.mageia.org/show_bug.cgi?id=29988 for instance, this report can be closed.
Do you want me to do it? What would be the suitable status?
Comment 7 Morgan Leijström 2022-03-16 20:10:06 CET
I would say: Fixed by bug 29988

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.