Bug 2950 - CVE-2011-2724 cifs-utils: mount.cifs incorrect fix for CVE-2010-0547
Summary: CVE-2011-2724 cifs-utils: mount.cifs incorrect fix for CVE-2010-0547
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard:
Keywords: validated_update
Depends on:
Blocks: 2949
  Show dependency treegraph
 
Reported: 2011-10-06 01:40 CEST by Nicolas Vigier
Modified: 2012-01-09 15:41 CET (History)
7 users (show)

See Also:
Source RPM: mount-cifs, samba
CVE:
Status comment:


Attachments

Description Nicolas Vigier 2011-10-06 01:40:15 CEST
Redhat bug :
https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2011-2724

This can maybe be fixed in the same package updates as #2949.
Nicolas Vigier 2011-10-06 01:41:12 CEST

Blocks: (none) => 2949

Manuel Hiebel 2011-10-06 01:51:33 CEST

CC: (none) => bgmilne, bgmilne, ennael1, thierry.vignaud

Comment 1 Manuel Hiebel 2011-10-19 22:52:00 CEST
duplicate of bug 2949 if not please reopen

*** This bug has been marked as a duplicate of bug 2949 ***

Status: NEW => RESOLVED
Resolution: (none) => DUPLICATE

Comment 2 Nicolas Vigier 2011-10-19 23:13:34 CEST
I think it's not a duplicate: it's a different CVE, with a different patch, and it doesn't look like it was fixed in bug 2949 (at least not mentioned in changelog).

The patch for this issue according to redhat bug :
http://thread.gmane.org/gmane.linux.kernel.cifs/3827

Status: RESOLVED => REOPENED
Resolution: DUPLICATE => (none)

Comment 3 Manuel Hiebel 2011-11-11 01:37:21 CET
So ping ?
Comment 4 Manuel Hiebel 2011-12-06 02:02:59 CET
Ping ?
Comment 5 David Walser 2011-12-30 23:22:41 CET
Has Buchan left us?

CC: (none) => luigiwalser

Comment 6 David Walser 2012-01-01 03:43:25 CET
Turns out there's even more CVEs we haven't fixed.  Superceding this one with Bug 3980.

*** This bug has been marked as a duplicate of bug 3980 ***

Status: REOPENED => RESOLVED
Resolution: (none) => DUPLICATE

Comment 7 Buchan Milne 2012-01-03 10:07:50 CET
I am still contributing here, but with limited time, and the 'provide your own system to test builds' is a bit limiting to those with limited bandwidth.

Note that bug #3980 does not actually list this CVE, so I am re-opening.

In the case of cifs-utils, I would actually prefer to ship a current version, rather than an old version with lots of patches, some of which obsolete older patches, with no site that actually covers which are the correct security patches, but the updates policy (https://wiki.mageia.org/en/Updates_policy) seems a bit strict for this.

I have updated cifs-utils in svn (r189827) for *this* CVE. I note that Mandriva has an additional patch (http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/updates/2010.1/cifs-utils/current/SOURCES/mount.cifs-fix-test-for-strtoul-failure-in-mount.cif.patch?revision=704390&view=markup), I have added this too.

New package in updates_testing.

Status: RESOLVED => REOPENED
Resolution: DUPLICATE => (none)

Comment 8 Buchan Milne 2012-01-03 10:48:27 CET
Package is available in updates_testing

[changelog] [RPM] 1 core/updates_testing cifs-utils-4.8.1-1.2.mga1

https://ml.mageia.org/l/arc/changelog/2012-01/msg00073.html

Status: REOPENED => ASSIGNED
Assignee: bugsquad => qa-bugs

Comment 9 claire robinson 2012-01-03 13:03:05 CET
This bug is a bit of a mess and not clear what has been updated or what it pertains to. The ml url above isn't directly accessible so I have found it and pasted below.

Please refer to https://wiki.mageia.org/en/Updates_policy#Maintainer_.28or_any_interested_packager.29

Thankyou.

I think this bug is for cifs-utils and bug 3980 is actually for samba and not strictly a duplicate.

------------------------------------------
Name : cifs-utils Relocations: (not relocatable)
Version : 4.8.1 Vendor: Mageia.Org
Release : 1.2.mga1 Build Date: Tue Jan 3 10:07:19 2012
Install Date: (not installed) Build Host: ecosse
Group : Networking/Other Source RPM: (none)
Size : 333813 License: GPLv3
Signature : (none)
Packager : buchan <buchan>
URL : http://www.samba.org/linux-cifs/cifs-utils/
Summary : Tools for Managing Linux CIFS Client Filesystems
Description :
Tools for Managing Linux CIFS Client Filesystems.

buchan <buchan> 4.8.1-1.2.mga1:
+ Revision: 189829
- Add patch fixing error checking of strtoul
- Add patch for CVE-2011-2724
- Add patch for CVE-2011-1678

    [changelog] [RPM] 1 core/updates_testing cifs-utils-4.8.1-1.2.mga1, buchan, 01/03/2012 
-------------------------------------------
Comment 10 claire robinson 2012-01-03 13:08:09 CET
Testing procedure here:

https://bugs.mageia.org/show_bug.cgi?id=2949#c7
Comment 11 claire robinson 2012-01-03 13:26:12 CET
Testing complete x86_64 using the above procedure.

Remember to create the samba user, then the share and (re)start the server on the host.

# mount -t cifs //192.168.1.60/testshare -o user=MGAGROUP/testuser%testpass /media/test

# ls /media/test
10.png
11.png
12.png
13.png
14.png
15.png
16.png
17.png
1.png
2.png

$ cd /media/test
$ touch test
$ rm test
rm: remove regular empty file `test'? y
Comment 12 Buchan Milne 2012-01-03 13:39:35 CET
The fix for samba is taken care of by bug #3980, commit 189530, let's split these bugs, so this one is strictly for cifs-utils, for which only one of the CVEs dealt with in #3890 applies.

Summary: CVE-2011-2724 samba, cifs-utils: mount.cifs incorrect fix for CVE-2010-0547 => CVE-2011-2724 cifs-utils: mount.cifs incorrect fix for CVE-2010-0547

Thierry Vignaud 2012-01-03 18:05:18 CET

CC: thierry.vignaud => (none)

Comment 13 Dave Hodgins 2012-01-09 01:20:12 CET
Testing complete on i586 using a windows share from a vb guest.

Could someone from the sysadmin team push the srpm
cifs-utils-4.8.1-1.2.mga1.src.rpm
from Core Updates Testing to Core Updates.

Advisory:  This security update for cifs-utils addresses two security
 issues.

CVE-2011-2724 - The check_mtab function in client/mount.cifs.c in
 mount.cifs in smbfs in Samba 3.5.10 and earlier does not properly
 verify that the (1) device name and (2) mountpoint strings are
 composed of valid characters, which allows local users to cause a
 denial of service (mtab corruption) via a crafted string.  NOTE:
 this vulnerability exists because of an incorrect fix for CVE-2010-0547

CVE-2011-1678 - smbfs in Samba 3.5.8 and earlier attempts to use (1)
 mount.cifs to append to the /etc/mtab file and (2) umount.cifs to
 append to the /etc/mtab.tmp file without first checking whether
 resource limits would interfere, which allows local users to trigger
 corruption of the /etc/mtab file via a process with a small
 RLIMIT_FSIZE value, a related issue to CVE-2011-1089.

https://bugs.mageia.org/show_bug.cgi?id=2950

Keywords: (none) => validated_update
CC: (none) => davidwhodgins, sysadmin-bugs

Comment 14 Thomas Backlund 2012-01-09 15:41:54 CET
update pushed.

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.