Bug 28839 - uncompress2 not present in zlib-1.2.11
Summary: uncompress2 not present in zlib-1.2.11
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: All Packagers
QA Contact:
URL: https://savannah.gnu.org/bugs/?60450
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 09:37 CEST by Philip Nienhuis
Modified: 2024-02-28 22:32 CET (History)
5 users (show)

See Also:
Source RPM: lib64zlib-devel-1.2.11-9.mga8.x86_64.rpm
CVE:
Status comment:


Attachments

Description Philip Nienhuis 2021-04-26 09:37:35 CEST
The GNU Octave development version now needs the uncompress2 function in zlib (see URL of bug report above, comments #5 - #11). However in Mageia uncompress2 been removed from zlib-1.2.10 already early 2017:
http://sophie.zarb.org/rpms/808f21768738fc8ffb1a1332c3cb7dbe/changelog
We haven't been able to track down why; but GNU Octave core devs mention that in their distros zlib does contain uncompress2.

Could uncompress2 please be reinstated? Or do I need to build zlib from source?
Comment 1 Aurelien Oudelet 2021-04-30 10:22:46 CEST
Hi, unsure why this was removed.

Adding David W. who removed it according to above changelog.

CC: (none) => luigiwalser, ouaurelien
Status: NEW => NEEDINFO

Comment 2 David Walser 2021-05-03 01:03:22 CEST
My only guess is the addition of this function broke the build of other packages, as we were preparing the Mageia 6 release.  Hopefully more than four years later, whatever packages were having an issue with it would have adapted by now.  We should remove the patch in Cauldron and see what happens.

Version: 8 => Cauldron

Comment 3 David GEIGER 2021-05-03 05:33:59 CEST
Done for Cauldron!

CC: (none) => geiger.david68210

Comment 4 Aurelien Oudelet 2021-05-03 15:53:54 CEST
Assigning globally.

@ reporter, it seems it was build for Cauldron. Can you try it in a VM with Cauldron?

Assignee: bugsquad => pkg-bugs

Comment 5 Philip Nienhuis 2021-05-03 18:42:18 CEST
Thanks very much dear maintainers. I'm impressed by the speedy follow-up.

Sure I can try along the way you sketched, BUT:
1. First installing a complete Mageia Cauldron,
2. Next, installing all of Octave's dependencies + building Octave,
is a bit beyond available time ATM; within a few days I'll be away until May 17. Somewhere in that week I can do it.

Would it be possible to just replace the lib64zlib.so.<version> library + include/zlib.h in installed Mageia-8, without provoking a kernel panic? (I suppose zlib is required to uncompress the kernel?)
Comment 6 David Walser 2021-05-03 19:38:23 CEST
That should be possible, or you can rebuild it Mageia 8 zlib package without the patch locally on your system.  As we won't be updating Octave on Mageia 8, I don't see the need to officially backport this change, so we can probably close this once we've confirmed that it fixes your issue without causing any others.
Comment 7 Philip Nienhuis 2021-05-04 09:53:38 CEST
OK I'll see what's the easiest for me in available time. Could be 2nd half of May before I get back.
I think you're quite right there's no reason for a zlib backport yet. No one seems to have needed uncompress2 for > 4 years anyway :-)
Comment 8 Philip Nienhuis 2021-05-05 00:13:41 CEST
Right, I rebuilt zlib from source PM and replaced libz.so.1.2.11 (+ zlib.h & zconf.h).
Result: Octave-7.0.0 could be built fine.
But also KDE/Plasma seemed to become less stable; AFAICS notably with screen locking or refreshing screen background. The rest of Mageia seemed to run fine while Octave got built (and then cross-built for windows using mxe-octave).

Obviously replacing a vital core library is risky, so it would be better to try with Cauldron but I can do that only later this month.
Comment 9 Philip Nienhuis 2021-08-06 12:21:07 CEST
Until now I've had no opportunity to install cauldron somewhere; one issue is that my systems simply have insufficient space for a (another) VM.
I've installed the fixed libz both on my desktop (see comment #8) and on a laptop some months ago. The KDE/Plasma effects mentioned above might be related to other issues with configuring dual screens on that box [*], on my laptop I haven't seen any adverse effects.

BTW are there any live media for Cauldron? or are live media made only for formal releases?

[*] https://forums.mageia.org/en/viewtopic.php?t=13853
Comment 10 David Walser 2021-08-06 20:11:56 CEST
No there's no live media until we get into the release process.  Maybe some day with a newer build system we could have some continuous integration thing spitting out Live media periodically, but that's just a dream at this point.

The best ways to install Cauldron are to install Mageia 8 and upgrade to Cauldron or to do a "netinstall" (using the boot.iso / all.img stage 1 of the installer to bootstrap the rest over the network).

Cauldron is a bit broken at the moment however, since webkit2 won't build.
Comment 11 Philip Nienhuis 2021-08-07 13:09:49 CEST
OK, thanks, I was busy freeing up space but I'll wait a little then until Cauldron is more stable.
Apart from that last verification step, I've built dev Octave regularly the last months so maybe this bug report can be closed? I suppose that *if* the "un"patched libz (= incl. uncompress2) didn't provoke any issues in the Cauldron builds lately it does no harm.
That said, I'm still willing to try Cauldron at some point if you wish so.
Comment 12 Philip Nienhuis 2021-08-07 13:15:18 CEST
BTW, before I forget: my desktop has Mageia-8, my laptop still runs Mageia-7. Both have the libz incl. uncompress2. On my laptop I haven't noted anything unusual, on my desktop I see some Plasma issues but again those may well be unrelated.
Comment 13 David Walser 2021-08-12 03:58:14 CEST
OK, webkit2, qtwebengine5, and digikam have all been fixed, so once the fixed packages get out to the mirrors (should be good by tomorrow), Cauldron should be safe to install again.
Comment 14 Philip Nienhuis 2021-08-16 16:30:15 CEST
Cauldron (netinstall CD d/led today) won't install in VBox, gives a popup "26 installation transactions failed" followed (after clicking OK) by a message along the lines of "ldconfig failed" or "ldconfig error".
AFAIK I've set disk size to dynamic so it shouldn't be space issue.
Hmm ...

Anyway what was the whole idea behind asking me to "try it in a VM with Cauldron" (comment #4)? Attempting to build dev Octave? that'll be a little biggie compared to just trying some random piece of SW as Octave needs quite a few dependencies & build tools.
Comment 15 David Walser 2021-08-16 17:21:36 CEST
Yes, we wanted to confirm that we've fixed your issue without causing others.  So, you can try building Octave in a Cauldron installation, or if you're packaging it as an rpm, you could use mock to build it for Cauldron from Mageia 8.  We'll need to check the autobuild logs to make sure it hasn't broken anything.
Comment 16 Thierry Vignaud 2021-10-05 21:47:04 CEST
(In reply to David Walser from comment #2)
> My only guess is the addition of this function broke the build of other
> packages, as we were preparing the Mageia 6 release.  Hopefully more than
> four years later, whatever packages were having an issue with it would have
> adapted by now.  We should remove the patch in Cauldron and see what happens.

For once it broke swish-e:
https://pkgsubmit.mageia.org/autobuild/history.php?package=swish-e

I've fixed the symbols clash in swish-e:
http://svnweb.mageia.org/packages/cauldron/swish-e/current/SOURCES/fix-build-with-zlib.patch?view=markup&pathrev=1749653

But there might be other breakages lurking..
One could look at the other "new" breakages from https://pkgsubmit.mageia.org/autobuild/results.php?run=2021-04-27

CC: (none) => thierry.vignaud

Comment 17 Philip Nienhuis 2021-10-06 19:52:41 CEST
I've tried a few times to install cauldron in a Virtual Box VM but it didn't work, it hang somewhere before the choice of packages.

Anyway I've installed the unpatched libz.so (that is w/o the removal-of-uncompress2-patch) in two Mageia-8 (and before that in two Mageia-7) installations and I didn't note any failures. But of course that's n=1.

As uncompress2 is contained in libz.so in several other Linux distros I've been trying lately I wonder what breakages could be related to it.
For me it just works now.
Comment 18 David Walser 2021-10-11 04:56:59 CEST
(In reply to Thierry Vignaud from comment #16)
> (In reply to David Walser from comment #2)
> > My only guess is the addition of this function broke the build of other
> > packages, as we were preparing the Mageia 6 release.  Hopefully more than
> > four years later, whatever packages were having an issue with it would have
> > adapted by now.  We should remove the patch in Cauldron and see what happens.
> 
> For once it broke swish-e:
> https://pkgsubmit.mageia.org/autobuild/history.php?package=swish-e
> 
> I've fixed the symbols clash in swish-e:
> http://svnweb.mageia.org/packages/cauldron/swish-e/current/SOURCES/fix-build-
> with-zlib.patch?view=markup&pathrev=1749653
> 
> But there might be other breakages lurking..
> One could look at the other "new" breakages from
> https://pkgsubmit.mageia.org/autobuild/results.php?run=2021-04-27

Right idea, but the one to look at is actually this one:
https://pkgsubmit.mageia.org/autobuild/results.php?run=2017-01-05

Unfortunately most of the build logs are gone, and the only other ones besides swish-e that look zlib related are R-base and clamav, but those are only because the zlib version changed for the first time in forever and the version detection code in those packages' build systems was broken (they were expecting a single digit for the third component which had just become 1.2.10).
Comment 19 papoteur 2024-02-28 16:13:19 CET
Closing as the feature is said to be included.

Resolution: (none) => FIXED
Status: NEEDINFO => RESOLVED
CC: (none) => yvesbrungard

Comment 20 Philip Nienhuis 2024-02-28 22:32:44 CET
OP here.
Thanks for fixing!

Note You need to log in before you can comment on or make changes to this bug.