Bug 26139 - %triggerun samba-client syntax error near `==0'
Summary: %triggerun samba-client syntax error near `==0'
Status: RESOLVED DUPLICATE of bug 25903
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 7
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: RPM stack maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-28 14:57 CET by Bit Twister
Modified: 2020-10-14 23:34 CEST (History)
1 user (show)

See Also:
Source RPM: samba-client-4.10.11-1.mga7.x86_64
CVE:
Status comment:


Attachments

Description Bit Twister 2020-01-28 14:57:05 CET
Description of problem: mga7

     1/52: removing lib64webkit2gtk-gir4.0-2.26.2-1.1.mga7.x86_64
                                 ##############################
/var/tmp/rpm-tmp.XfYrA9: line 1: conditional binary operator expected
/var/tmp/rpm-tmp.XfYrA9: line 1: syntax error near `==0'
/var/tmp/rpm-tmp.XfYrA9: line 1: `[[ $1 ==0 || $2 == 0 ]]  && rm -f /usr/lib/cups/backend/smb'
warning: %triggerun(samba-client-4.10.11-1.mga7.x86_64) scriptlet failed, exit status 2
ERROR: 'script' failed for samba-client-4.10.11-1.mga7.x86_64
     2/52: removing samba-client-4.10.11-1.mga7.x86_64
                                 ##########################

Version-Release number of selected component (if applicable):


How reproducible: Always


Steps to Reproduce:

As root
1. urpmi_args="--wait-lock --replacefiles --auto-update --auto --download-all"
2. script -c "urpmi $dl_args $urpmi_args"  install_updates.log
3. grep -E "conditional|error|warning" install_updates.log
3.
Comment 1 Lewis Smith 2020-01-28 15:27:06 CET
Thank you for reporting this. So the command you actually did was (or = to):
 # urpmi --wait-lock --replacefiles --auto-update --auto --download-all

This looks like a failure removing the just superseded samba-client pkg
 from 4.10.11-1.mga7
 to   4.10.12-1.mga7
which coincidentally I have just done from the normal 'update' Systray icon; *without* visible error; but that was GUI, not terminal.
However, the syntax error is clear enough; $1 ==0 rather than $1 == 0

Assigning to rpm stack people. Unsure whether the exact SRPM version matters, the old or the new.

Assignee: bugsquad => rpmstack

Comment 2 Bit Twister 2020-01-28 16:13:50 CET
(In reply to Lewis Smith from comment #1)
> Thank you for reporting this. 

Problem was also in previous version, but I did not report it, thinking
QA/DEV/Packager would catch it on next update/release.

> This looks like a failure removing the just superseded samba-client pkg
>  from 4.10.11-1.mga7
>  to   4.10.12-1.mga7
> which coincidentally I have just done from the normal 'update' Systray icon;
> *without* visible error; but that was GUI, not terminal.

I wondered how the bug sneaked through QA.
Sounds like someone should open a bug report about the gui did not flag
the problem.  :)

> However, the syntax error is clear enough; $1 ==0 rather than $1 == 0
> 
> Assigning to rpm stack people. 

> Unsure whether the exact SRPM version matters, the old or the new.

Agree it appears to be just bad code in trigger.
Comment 3 Florian Hubold 2020-01-28 17:04:59 CET
(In reply to Lewis Smith from comment #1)

> Assigning to rpm stack people.

Why not to the samba maintainer? This is not something special to the rpm stack, it's just a typo in a %post scriptlet, which has already been removed from the cauldron package.

CC: (none) => doktor5000

Comment 4 David Walser 2020-01-28 18:34:04 CET
Already reported and taken care of in another bug.  Will be fixed in the next Samba update.

*** This bug has been marked as a duplicate of bug 25903 ***

Status: NEW => RESOLVED
Resolution: (none) => DUPLICATE

Comment 5 Lewis Smith 2020-01-28 20:43:14 CET
(In reply to Florian Hubold from comment #3)
> > Assigning to rpm stack people.
> Why not to the samba maintainer? This is not something special to the rpm
> stack, it's just a typo in a %post scriptlet, which has already been removed
> from the cauldron package.
My mistake; a fair cop. Hope you told me privately (like I asked of devs in such situations). Just chance I re-visited this bug & saw this comment.

(In reply to David Walser from comment #4)
> Already reported and taken care of in another bug.  Will be fixed in the
> next Samba update.
> *** This bug has been marked as a duplicate of bug 25903 ***
Another mistake! I took it as applying just to the latest samba update. Also, BitTwister being one of our experienced helpers, I just believed it.
I must tighten up my duplicate checking...
Morgan Leijström 2020-10-14 17:38:33 CEST

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=27414

Morgan Leijström 2020-10-14 23:34:33 CEST

See Also: https://bugs.mageia.org/show_bug.cgi?id=27414 => (none)


Note You need to log in before you can comment on or make changes to this bug.