From Akien: We could maybe add an alias in mgarepo, e.g. `mgarepo logedit rXXX`. $ cat /usr/local/bin/propedit #!/bin/sh svn propedit --revprop svn:log -r $@ Question: Which parameters have to be recognized?
CC: (none) => rverschelde
Only parameter needed is the revision number. $ cat .bin/propedit #!/bin/bash if [[ $# -ne 1 ]]; then echo "Usage: $(basename $0) [revision]" else EDITOR=${EDITOR:-nano} svn propedit --revprop -r $1 svn:log svn+ssh://svn.mageia.org/svn/packages fi
CC: (none) => jani.valimaa
In my updated script I'm using nano as a default EDITOR if it's not defined to something else. The default can be what ever is decided, but anyway I think it would be nice to use EDITOR that one has set.
(In reply to Jani Välimaa from comment #2) > In my updated script I'm using nano as a default EDITOR if it's not defined > to something else. The default can be what ever is decided, but anyway I > think it would be nice to use EDITOR that one has set. Forget this one, svn uses EDITOR env variable anyway if it's exported.
What about the already existing command "editlog"? : Usage: mgarepo editlog [OPTIONS] [URL] REVISION Options: -h Show this message Examples: mgarepo editlog 14800 mgarepo editlog https://repos/svn/cnc/snapshot 14800
Created attachment 11482 [details] Unusable nano instance when using mgarepo editlog Ah indeed, I had never noticed this option :O It's not listed in `mgarepo --help`. Moreover, it seems to work but the way it opens `EDITOR` seems broken. My `EDITOR` is `nano`, and it does open it, but I can't interact with it normally. See attached screenshot (I tried to quit with Ctrl+X, and move to the right with the arrow key, which added these `^X^[OC`. I have to kill the session to exit nano). I'll rename the issue to cater to the newly found issues.
Summary: add an alias in mgarepo for logedit => mgarepo editlog doesn't appear in --help output, incorrectly opens defined EDITOR
Here it works fine opening kwrite and do a test: $ mgarepo log opencv r1482863 | daviddavid | 2020-01-25 13:17:33 +0100 (sam. 25 janv. 2020) | 3 lignes SILENT: fix for: "error: Not a directory" SILENT: test for mgarepo editlog $
CC: (none) => geiger.david68210
(In reply to Rémi Verschelde from comment #5) > Created attachment 11482 [details] > Unusable nano instance when using mgarepo editlog > > Ah indeed, I had never noticed this option :O > > It's not listed in `mgarepo --help`. > > Moreover, it seems to work but the way it opens `EDITOR` seems broken. My > `EDITOR` is `nano`, and it does open it, but I can't interact with it > normally. See attached screenshot (I tried to quit with Ctrl+X, and move to > the right with the arrow key, which added these `^X^[OC`. I have to kill the > session to exit nano). > mgarepo editlog works fine for me with EDITOR=nano/vim/mousepad. Perhaps issues with terminal emulator? What's the output of 'echo $TERM'?
(In reply to Jani Välimaa from comment #7) > mgarepo editlog works fine for me with EDITOR=nano/vim/mousepad. Perhaps > issues with terminal emulator? What's the output of 'echo $TERM'? Might be specific to my terminal yeah. I use yakuake on KDE, `$TERM` is `xterm-256color`.
Hello, I pushed an update to add the command editlog in man page and help. Do you think it has to be released now?
Should be fixed in Cauldron with new release 1.14.2!
I removed the part about `nano` quirks in yakuake as it seems specific to my setup. I'll open a new bug report about it.
Summary: mgarepo editlog doesn't appear in --help output, incorrectly opens defined EDITOR => mgarepo editlog doesn't appear in --help output
Fixed with version 1.14.2.
Status: NEW => RESOLVEDResolution: (none) => FIXED
I think we can update it for mga7 too, WDYT?
Assigning to QA, Advisory: ============================= This new update adds command editlog in help, man page and bash completion. ============================= Packages in 7/core/updates_testing: ======================== mgarepo-1.14.2-1.mga7.noarch.rpm mgarepo-ldap-1.14.2-1.mga7.noarch.rpm Source RPM: ======================== mgarepo-1.14.2-1.mga7.src.rpm
Source RPM: mgarepo => mgarepo-1.14.1-1.mga7.src.rpmVersion: Cauldron => 7Assignee: mageiatools => qa-bugsResolution: FIXED => (none)Status: RESOLVED => REOPENED
As i use mgarepo everyday I can confirm that this new update added properly the command editlog in help, man page and bash completion on my mga7 for x86_64 system.
Whiteboard: (none) => MGA7-64-OK
That simplifies things, David. Thanks. Validating. Advisory in Comment 14.
Keywords: (none) => validated_updateCC: (none) => andrewsfarm, sysadmin-bugs
CC: (none) => tmbKeywords: (none) => advisory
An update for this issue has been pushed to the Mageia Updates repository. https://advisories.mageia.org/MGAA-2020-0041.html
Resolution: (none) => FIXEDStatus: REOPENED => RESOLVED