Bug 2583 - a space needed in a drakguard string
Summary: a space needed in a drakguard string
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard:
Keywords: Junior_job
Depends on:
Blocks:
 
Reported: 2011-09-01 08:37 CEST by Dimitrios Glentadakis
Modified: 2014-01-19 17:06 CET (History)
9 users (show)

See Also:
Source RPM: drakguard
CVE:
Status comment:


Attachments
A screenshot for this report (72.94 KB, image/png)
2012-04-21 15:01 CEST, Dimitrios Glentadakis
Details

Description Dimitrios Glentadakis 2011-09-01 08:37:15 CEST
Here:

#: ../bin/drakguard:309
#, c-format
msgid "The support for Access Control Lists was enabled."

#: ../bin/drakguard:309 ../bin/drakguard:317
#, c-format
msgid "It is necessary to restart your computer to activate it."


The two messages are shown without space between them after the dot.



The message in the window is shown like this:
"The support for Access Control Lists was enabled.It is necessary to restart your computer to activate it."
Manuel Hiebel 2011-09-01 13:12:49 CEST

Source RPM: (none) => drakguard

Manuel Hiebel 2011-11-20 00:59:47 CET

Keywords: (none) => Junior_job

Comment 1 Damien Lallement 2011-12-28 15:11:08 CET
Fixed in SVN.

CC: (none) => mageia

Comment 2 Manuel Hiebel 2011-12-28 15:48:37 CET
We need also a fix in the po file iirc

Assignee: dmorganec => mageia-i18n

Comment 3 Damien Lallement 2011-12-29 10:56:32 CET
Oliver, can you please edit the source file on transiflex to add a carriage return please?

CC: (none) => oliver.bgr

Comment 4 Oliver Burger 2012-01-05 02:11:45 CET
Will do.
I just read this, sorry for the delay.
Comment 5 Oliver Burger 2012-01-08 10:24:39 CET
The pot file (as well in trunk as in branches/1) were not changed in the last few months.

So what should I fix? I'm a bit puzzled...
Comment 6 Damien Lallement 2012-01-09 17:42:15 CET
Oliver, in fact I added a carriage return in the cauldron pot file... I thought it was a "cauldron only" bug.
Comment 7 Oliver Burger 2012-01-10 07:18:19 CET
That's the problem. According to the svn, you did not.
Did you by any chance forget to commit it?

http://svnweb.mageia.org/soft/drakguard/trunk/po/drakguard.pot?view=log
Comment 8 D Morgan 2012-01-10 07:23:54 CET
(In reply to comment #6)
> Oliver, in fact I added a carriage return in the cauldron pot file... I thought
> it was a "cauldron only" bug.

hum this is wrong, you need to modify the code too or the string will never be used by drakguard iirc

CC: (none) => dmorganec

Dan Joita 2012-03-07 11:14:06 CET

CC: (none) => djmarian4u
Summary: A space needed in drakguard.po => a space needed in drakguard.po

Comment 9 Dimitrios Glentadakis 2012-04-21 15:01:47 CEST
Created attachment 2059 [details]
A screenshot for this report

Still present in Mageia 2 beta 3
Comment 10 Rémi Verschelde 2012-04-21 17:42:45 CEST
Removing assignment to mageia-i18n, since this is not a translation bug. According to Sophie, the package has no maintainer, so I don't know whom to assign the bug to.

A space or carriage return must be added in the source code IINM, and the po files wouldn't have to be changed.

CC: (none) => remi
Assignee: mageia-i18n => bugsquad
Summary: a space needed in drakguard.po => a space needed in a drakguard string
Severity: minor => enhancement

Manuel Hiebel 2012-04-21 22:43:46 CEST

CC: (none) => ennael1

Comment 11 Manuel Hiebel 2012-04-21 22:44:35 CEST
>According to Sophie, the package has no maintainer, so I don't know whom to
>assign the bug to.

I have added all committer of the package (only two)
Manuel Hiebel 2012-10-31 20:11:36 CET

Version: 1 => Cauldron

Comment 12 Rémi Verschelde 2013-09-26 14:33:05 CEST
Pinging contributors who fixed things in drakguard, you might be able to fix this bug pretty easily.


The line which should be changed is this one:

$in->ask_warn(N("Warning"), N("The support for Access Control Lists was enabled.") . N("It is necessary to restart your computer to activate it."));

There is an other occurence following the same scheme, it might lack a space too:

$in->ask_warn(N("Warning"), N("The support for Access Control Lists, required by the Block programs feature, is enabled, but not yet activated.") . N("It is necessary to restart your computer to activate it."), $acl_active = 0);


I don't know Perl so I can't say how to hardcode the carriage return. It can also be added *inside* the first string, but then the pot and po files have to be regenerated and fixed without fuzzying the translations, so I think changing the code is better.

CC: (none) => derekjenn, jani.valimaa

Comment 13 Mageia Robot 2014-01-19 17:06:39 CET
commit 972ac98bcd891bf6f7eda1b3462a13726bc6a8e2
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Sun Jan 19 17:05:54 2014 +0100

    add missing spaces (mga#2583)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakguard/commit/?id=972ac98bcd891bf6f7eda1b3462a13726bc6a8e2
Comment 14 Thierry Vignaud 2014-01-19 17:06:53 CET
Fixed in git

Status: NEW => RESOLVED
CC: (none) => thierry.vignaud
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.