Bug 25009 - Update of grub on jfs crashes and fails to boot
Summary: Update of grub on jfs crashes and fails to boot
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 7
Hardware: All Linux
Priority: High critical
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA7-64-OK
Keywords: IN_ERRATA7, advisory, validated_update
Depends on:
Blocks:
 
Reported: 2019-06-26 14:01 CEST by Marc Krämer
Modified: 2019-07-10 12:45 CEST (History)
7 users (show)

See Also:
Source RPM: grub-0.97-48.mga7.src.rpm
CVE:
Status comment:


Attachments

Description Marc Krämer 2019-06-26 14:01:56 CEST
Both on real hardware and Virtualbox the update to mga7 fails to boot if jfs is used as filesystem.
Grub stops to load at stage 1.5 and if installed on VirtualBox, it raises an fatal error.
This issue is already been discussed on dev ml. I've checked the changelog, it might be the change of optimization level?

Btw. using grub2 works, but anyone using grub and jfs and not having switched to grub2 will fail to boot!
Comment 1 Marc Krämer 2019-06-26 14:04:49 CEST
most changes come from "tv" and "pterjan".
Comment 2 Marja Van Waes 2019-06-26 19:43:54 CEST
(In reply to Marc Krämer from comment #0)
> Both on real hardware and Virtualbox the update to mga7 fails to boot if jfs
> is used as filesystem.
> Grub stops to load at stage 1.5 and if installed on VirtualBox, it raises an
> fatal error.
> This issue is already been discussed on dev ml. I've checked the changelog,
> it might be the change of optimization level?
> 
> Btw. using grub2 works, but anyone using grub and jfs and not having
> switched to grub2 will fail to boot!

Shouldn't we start to inform users that we'll obsolete grub by the time Mageia 8 is released? On the grub website it says 

  "GRUB Legacy is no longer being developed."


(In reply to Marc Krämer from comment #1)
> most changes come from "tv" and "pterjan".

Assigning to all packagers collectively, because we have no registered grub maintainer and CC'ing tv and pterjan.

CC: (none) => marja11, pterjan, thierry.vignaud
Assignee: bugsquad => pkg-bugs

Comment 3 Marc Krämer 2019-06-26 19:47:00 CEST
I have already switched to grub2, but other users will have an unbootable system after the update, so we can force the transition to grub2, or at least have this documented in errata. But at the moment we ship grub and older systems have this installed.
Comment 4 Martin Whitaker 2019-06-29 13:56:45 CEST
Rebuilding the grub package locally appears to fix this bug. Maybe a GCC bug that has since been fixed. I'll try a rebuild on the build system.

CC: (none) => mageia

Comment 5 Morgan Leijström 2019-06-29 14:51:09 CEST
Than you Martin

As isos are being released we need to have this in Errata, so I added
https://wiki.mageia.org/en/Mageia_7_Errata#GRUB_fail_to_boot_with_JFS_file_system

Let's keep keyword IN_ERRATA7 here so we remember to update it if there comes a fix that makes it work when update media is configured during upgrade.

Whiteboard: (none) => Update Errata when appropriate, see comment 5
CC: (none) => fri
Keywords: (none) => FOR_ERRATA7

Comment 6 Morgan Leijström 2019-06-29 16:02:16 CEST
Not only on Virtualbox; on real hardware too.

Summary: Update of grub on jfs crashes VirtualBox and fails to boot => Update of grub on jfs crashes and fails to boot

Comment 7 Martin Whitaker 2019-06-29 22:22:44 CEST
Testing in VirtualBox, this is fixed by grub-0.97-48.1.mga7.
Note that I could only reproduce the bug on a 64-bit system.

To Reproduce
============
1. Install a 64-bit Mageia 7 system, choosing JFS for the /boot partition. (if you don't choose to have a separate /boot partition, choose JFS for the root partition).
2. If using VBox, make a clone here for use when testing the fix.
3. After booting into the installed system, use MCC/drakboot to change the bootloader to GRUB. drakboot doesn't propose any default menu entries when switching from GRUB2, so you will need to add one. Select "Linux", the kernel and root partition to use, and any boot options you need (in VBox I just added vga=788).
4. On reboot, boot will fail before reaching the GRUB boot menu.

To Test
=======
As above, but enable the updates_testing media before running drakboot.

Suggested Advisory
==================
This update fixes a bug in the legacy grub package that caused it to fail to boot when /boot was located on a JFS filesystem.

SRPMs
=====
grub-0.97-48.1.mga7.src.rpm

i586
====
grub-0.97-48.1.mga7.i586.rpm
grub-doc-0.97-48.1.mga7.i586.rpm

x86_64
======
grub-0.97-48.1.mga7.x86_64.rpm
grub-doc-0.97-48.1.mga7.x86_64.rpm

Assignee: pkg-bugs => qa-bugs
Priority: Normal => High
Status: NEW => ASSIGNED

Comment 8 Morgan Leijström 2019-06-30 00:46:00 CEST
Did not test, but updated https://wiki.mageia.org/en/Mageia_7_Errata#LVM_and.2For_LUKS_with_old_udisks accordingly.
Comment 9 katnatek 2019-06-30 01:03:14 CEST
(In reply to Morgan Leijström from comment #8)
> Did not test, but updated
> https://wiki.mageia.org/en/Mageia_7_Errata#LVM_and.2For_LUKS_with_old_udisks
> accordingly.

Moved to right part
https://wiki.mageia.org/en/Mageia_7_Errata#GRUB_fail_to_boot_with_JFS_file_system
Comment 10 Morgan Leijström 2019-06-30 01:14:48 CEST
OOPS, thanks! :)
Morgan Leijström 2019-06-30 01:21:13 CEST

Whiteboard: Update Errata when appropriate, see comment 5 => When fix test OK please update Errata and remove FOR_ERRATA7 , see comment 7

Comment 11 James Kerr 2019-07-05 18:28:39 CEST
On mga7-64

I followed the procedures described in comment#7

In the cloned VM after changing from grub2 to grub,
on reboot the boot process failed as expected before the boot menu appeared

In the original VM I enabled updates-testing before running drakboot
and the VM rebooted normally 

(Incidentally, in both of my tests drakboot did create a menu.lst file with the usual three boot options)

This looks OK to me for mga7-64.

CC: (none) => jim

James Kerr 2019-07-05 18:41:59 CEST

Whiteboard: When fix test OK please update Errata and remove FOR_ERRATA7 , see comment 7 => MGA7-64-OK

Comment 12 Rémi Verschelde 2019-07-10 11:26:55 CEST
Advisory uploaded, validating.

Keywords: FOR_ERRATA7 => advisory, IN_ERRATA7, validated_update
CC: (none) => sysadmin-bugs

Comment 13 Mageia Robot 2019-07-10 12:45:34 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2019-0053.html

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.