Bug 22883 - pngcheck warns of zlib version - need update?
Summary: pngcheck warns of zlib version - need update?
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 6
Hardware: All Linux
Priority: Normal minor
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA6-64-OK
Keywords: advisory, validated_update
Depends on:
Blocks:
 
Reported: 2018-04-09 11:12 CEST by Morgan Leijström
Modified: 2018-04-13 22:09 CEST (History)
2 users (show)

See Also:
Source RPM: pngcheck-2.3.0-1.mga6.src.rpm
CVE:
Status comment:


Attachments

Description Morgan Leijström 2018-04-09 11:12:23 CEST
$ pngcheck some.png 
zlib warning:  different version (expected 1.2.8, using 1.2.11)

(I dont know if it affect anything, just noted the warning...)

zlib 1.2.11 is in mga6 core updates since long
Comment 1 David Walser 2018-04-09 22:38:57 CEST
Even the core/release version was 1.2.11.  I think pngcrush complains if it's run against a different version of zlib than it was built against too.  pngcheck probably just needs a simple rebuild.
Comment 2 Marja Van Waes 2018-04-10 10:01:17 CEST
Assigning to the registered maintainer.

Assignee: bugsquad => zen25000
CC: (none) => marja11

Comment 3 Barry Jackson 2018-04-10 13:41:47 CEST
(In reply to Marja van Waes from comment #2)
> Assigning to the registered maintainer.

This is only a warning and nothing is broken.

Do we really need to burden QA with testing an update for no good reason.

My first reaction was WONTFIX but I will await other opinions.
Comment 4 Morgan Leijström 2018-04-10 16:09:04 CEST
If it is only a warning and nothing can go bad, i suggest to only make sure it is OK in mga7.
Comment 5 David Walser 2018-04-10 19:43:46 CEST
What would be even better is patch that stupid pointless warning out of the code.
Comment 6 Barry Jackson 2018-04-11 16:15:57 CEST
(In reply to David Walser from comment #5)
> What would be even better is patch that stupid pointless warning out of the
> code.

Yes, this should fix it, it still works as expected in cauldron:

diff -ur pngcheck-2.3.0_o/pngcheck.c pngcheck-2.3.0/pngcheck.c
--- pngcheck-2.3.0_o/pngcheck.c	2007-07-08 07:23:31.000000000 +0100
+++ pngcheck-2.3.0/pngcheck.c	2018-04-11 15:05:17.144145056 +0100
@@ -672,9 +672,6 @@
       check_zlib = 0;
       if (verbose > 1)
         verbose = 1;
-    } else if (strcmp(zlib_version, ZLIB_VERSION) != 0) {
-      printf("zlib warning:  different version (expected %s,"
-        " using %s)\n\n", ZLIB_VERSION, zlib_version);
     }
 #endif /* USE_ZLIB */

I will push to cauldron before submitting to Mga6 updates testing.
Comment 7 Barry Jackson 2018-04-11 16:56:22 CEST
pngcheck-2.3.0-1.1 has been submitted to 6/core/updates_testing.
This update suppresses a useless warning when a slightly older but still compatible version of zlib is in use.

####################################
Update Advisory
####################################

pngcheck has been updated to suppress a confusing warning which was emitted when an older but still compatible version of zlib was being used.

References:
https://bugs.mageia.org/show_bug.cgi?id=22883

###################################
Rpms affected:

pngcheck-2.3.0-1.1.mga6.x86_64.rpm
pngcheck-debuginfo-2.3.0-1.1.mga6.x86_64.rpm

pngcheck-2.3.0-1.1.mga6.i586.rpm
pngcheck-debuginfo-2.3.0-1.1.mga6.i586.rpm

From:
pngcheck-2.3.0-1.1.mga6.src.rpm

###################################
Testing

Install current version and in a directory with several .png images run:

pngcheck *.png

Note the result and install the version from updates_testing and repeat in the same directory.
The result should be the same except for the missing warning.

Note that this does not actually test the patch as the testing version was built against the new zlib so the warning would not appear anyway. No way to avoid that really :\
Barry Jackson 2018-04-11 16:57:35 CEST

Assignee: zen25000 => qa-bugs

Comment 8 Morgan Leijström 2018-04-11 18:48:38 CEST
64 bit test OK simply running pngcheck *.png

Whiteboard: (none) => MGA6-64-OK

Lewis Smith 2018-04-12 08:45:54 CEST

CC: (none) => sysadmin-bugs
Keywords: (none) => advisory, validated_update

Comment 9 Mageia Robot 2018-04-13 22:09:43 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2018-0061.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.