Bug 2199 - Update candidate : pidgin 2.10.0
Summary: Update candidate : pidgin 2.10.0
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: http://developer.pidgin.im/ticket/14602
Whiteboard:
Keywords: Security, validated_update
: 1739 (view as bug list)
Depends on:
Blocks: 2750
  Show dependency treegraph
 
Reported: 2011-07-18 19:49 CEST by Frédéric "LpSolit" Buclin
Modified: 2014-05-08 18:06 CEST (History)
9 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
screenshot of the problem (138.46 KB, image/png)
2011-09-14 16:36 CEST, Frédéric "LpSolit" Buclin
Details

Description Frédéric "LpSolit" Buclin 2011-07-18 19:49:40 CEST
Pidgin 2.9.0 has many bug fixes compared to the currently available 2.7.11 version in Mageia 1. Please backport it.
Comment 1 Frédéric "LpSolit" Buclin 2011-08-21 12:09:40 CEST
2.10.0 contains some security fixes.

Summary: Backport Pidgin 2.9.0 to Mageia 1 => Backport Pidgin 2.10.0 to Mageia 1

Comment 2 D Morgan 2011-09-06 16:41:34 CEST
please test in update_testing.

CC: (none) => dmorganec
Assignee: bugsquad => qa-bugs

Comment 3 claire robinson 2011-09-06 16:48:26 CEST
Thankyou for the new package.

To properly validate we should show that bugs and security fixes actually do fix what they say they do. Can somebody provide testing procedures please?

If none are available we will only be able to check that it appears to work OK, which is not ideal.

CC: (none) => eeeemail

Comment 4 Samuel Verschelde 2011-09-06 16:55:17 CEST
Question : would it have been possible to backport the fixes from 2.10.0 to 2.7.11 ?

CC: (none) => stormi

Comment 5 Frédéric "LpSolit" Buclin 2011-09-06 23:16:31 CEST
(In reply to comment #3)
> To properly validate we should show that bugs and security fixes actually do
> fix what they say they do. Can somebody provide testing procedures please?

Does this really make sense? It's like saying that we should check that Firefox 6 really implements everything what it pretends to implement since Firefox 5. Nobody will ever do this.

Upgrading to Pidgin 2.10.0 is much safer than trying to backport fixes to 2.7.11 and then realize that the backport is not complete/broken because it depends on another change.
Comment 6 D Morgan 2011-09-06 23:21:56 CEST
Because mandriva update in updates to 2.10.0 and now we can update mdv 2010.1 -> mga 1 if we don't do this update.
Comment 7 D Morgan 2011-09-06 23:23:31 CEST
Because mandriva update in updates to 2.10.0 and now we can update mdv 2010.1 -> mga 1 if we don't do this update.

see: http://svn.mandriva.com/viewvc/packages?view=revision&revision=698446
Comment 8 Samuel Verschelde 2011-09-07 00:00:43 CEST
(In reply to comment #5)
> (In reply to comment #3)
> > To properly validate we should show that bugs and security fixes actually do
> > fix what they say they do. Can somebody provide testing procedures please?
> 
> Does this really make sense? It's like saying that we should check that Firefox
> 6 really implements everything what it pretends to implement since Firefox 5.
> Nobody will ever do this.
> 
> Upgrading to Pidgin 2.10.0 is much safer than trying to backport fixes to
> 2.7.11 and then realize that the backport is not complete/broken because it
> depends on another change.

Firefox is an exception : we had not choice because firefox 4 was unmaintained and there were security issues. Otherwise, the policy applies : only bugfixes, no new features. New features go to backports or to the next release. However, sometimes we ship new versions because backporting the fixes would almost mean recreating the same software minus, and potentially break things. So sometimes using the new upstream version is the most sensible option. But we must not forget that this remains an exception to the common rule. So to answer your question, I think that yes, asking "if" backport the fixes would have been doable makes sense. Now for pidgin, regardless of how doable or sensible backporting the fixes would have been, the fact that Mandriva provided 2.10.0 forces us to follow the same path, so that upgrades still work from Mandriva to Mageia.
Comment 9 Samuel Verschelde 2011-09-07 00:05:23 CEST
(In reply to comment #8)
> Now for pidgin, regardless of how doable or sensible
> backporting the fixes would have been, the fact that Mandriva 
> provided 2.10.0 forces us to follow the same path, so that
> upgrades still work from Mandriva to Mageia.

Just in case my english is ambiguous here : I mean that backporting the fixes for pidgin may have been doable and sensible, or maybe not, I don't know, but whatever the answer, an other consideration makes us package the latest upstream version for this update.
Comment 10 Dave Hodgins 2011-09-07 05:53:32 CEST
Installing pidgin-silc pulls the following from Core Release
  libsilc1.1_2                   1.1.10       5.mga1        i586
  libsilcclient1.1_3             1.1.10       5.mga1        i586
  silc-toolkit                   1.1.10       5.mga1        i586
The same versions are in Mandriva 2010.2, so it should be ok
for bug 2317, but I will test with the Mandriva version installed later.

CC: (none) => davidwhodgins

Samuel Verschelde 2011-09-07 11:35:02 CEST

Summary: Backport Pidgin 2.10.0 to Mageia 1 => Update candidate : pidgin 2.10.0

Comment 11 Dave Hodgins 2011-09-07 23:08:32 CEST
Regarding comment 10, on a clean mageia 1 install, I installed pidgin
and all needed dependencies from Mandriva 2010.2, and then updated
from Mageia Core Updates Testing via mgaapplet.

It worked. The three rpm packages (as well as some others like libpurple0)
are still the mdv versions, but it didn't cause the update to fail.

So, as long as the Mageia version number is the same as the Mandriva 2010.2
version number, bug 2317 does not block the update.
Comment 12 Samuel Verschelde 2011-09-10 01:41:41 CEST
(In reply to comment #3)
> Thankyou for the new package.
> 
> To properly validate we should show that bugs and security fixes actually do
> fix what they say they do. Can somebody provide testing procedures please?
> 
> If none are available we will only be able to check that it appears to work OK,
> which is not ideal.

The upstream website gives the list of fixed CVEs :
http://pidgin.im/news/security/

Here is the complete changelog: http://developer.pidgin.im/wiki/ChangeLog

It is huge, so I think we really must limit to test that the program works well for this update.
Samuel Verschelde 2011-09-12 14:33:59 CEST

Keywords: (none) => Security

Comment 13 AL13N 2011-09-12 23:54:28 CEST
no regressions for me

CC: (none) => alien

Comment 14 AL13N 2011-09-12 23:57:58 CEST
*** Bug 1739 has been marked as a duplicate of this bug. ***

CC: (none) => jan.ciger

Manuel Hiebel 2011-09-13 00:27:08 CEST

Component: RPM Packages => Security
Assignee: qa-bugs => bugsquad

Manuel Hiebel 2011-09-13 00:31:33 CEST

Assignee: bugsquad => qa-bugs

Comment 15 Dave Hodgins 2011-09-13 00:44:37 CEST
testing pidgin-2.10.0-1.1.mga1.src.rpm on i586 complete.

I've been testing for 4 days now, with msn, yahoo, and gmail accounts
with no regressions showing up.
Comment 16 Sander Lepik 2011-09-13 09:43:55 CEST
Tested on x86_64. Seems to work just fine :)

CC: (none) => sander.lepik

Comment 17 claire robinson 2011-09-13 11:30:27 CEST
Also tested OK i586.

It should be alright to validate this now.

SRPM: 	pidgin-2.10.0-1.1.mga1.src.rpm

Advisory:

--------------

This update brings Pidgin 2.10.0 with many security and bug fixes. It also enables proper upgrade from Mandriva 2010 to Mageia 1.

For a complete changelog please see http://developer.pidgin.im/wiki/ChangeLog

For a list of security fixes please see http://pidgin.im/news/security/

--------------


Could somebody from sysadmin please push from core/updates_testing to core/updates.

Thankyou!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Hardware: i586 => All

Comment 18 Frédéric "LpSolit" Buclin 2011-09-13 23:28:15 CEST
Every time someone joins a IRC channel, the user list scrolls by one line. This never happened with 2.7.11. Can someone else reproduce this problem?
Comment 19 Frédéric "LpSolit" Buclin 2011-09-13 23:35:14 CEST
Hum, it looks like it doesn't even need someone to enter the channel to trigger this. Weird.
Comment 20 AL13N 2011-09-13 23:52:15 CEST
cannot reproduce on x86_64 tried various things.

can you show a screenshot?
Comment 21 Frédéric "LpSolit" Buclin 2011-09-14 00:20:07 CEST
A screenshot of what? Do you expect to see scrolling in a static image? :)
Comment 22 AL13N 2011-09-14 01:47:50 CEST
i donno, i don't know exactly what to look for? is it scrolling up or down or sideways and is the friends list? or channel list? or whatever? i cannot see it, show me a before and after maybe, i donno?

I cannot see this issue you're describing...
Comment 23 Florian Hubold 2011-09-14 11:18:43 CEST
(In reply to comment #18)
> Every time someone joins a IRC channel, the user list scrolls by one line. This
> never happened with 2.7.11. Can someone else reproduce this problem?

Not reproducable here, BTW even not under Windows 7 ;)
also not with pidgin-2.9.0 which i was using before on Mageia 1.


Tested pidgin 2.10.0 on x86_64, everything works so far.

CC: (none) => doktor5000

Comment 24 claire robinson 2011-09-14 11:34:26 CEST
I think what you are seeing is the user list adding the user to the list.

I've sat in #ubuntu for a while and if you scroll down nearer the bottom of the user list it is more noticeable. I don't think its a bug. It is just reorganising the list and you see that in real time.
Comment 25 claire robinson 2011-09-14 11:58:50 CEST
It's not very smooth, looks like it jumps. For me it's worse when people leave the channel. It's probably something to do with colourising the nicknames.

One thing I did notice though is sometimes it jumps to nicks beginning with E for no apparent reason. If it is a bug, I would imagine it's an upstream bug, they do seem to have had a couple of bugs related to the user list.

They had one which they claim fixed in 2.10.0 where users were displaying multiple times and the list wasn't updating so I suppose they have changed the way it updates.
Comment 26 Frédéric "LpSolit" Buclin 2011-09-14 16:36:47 CEST
Created attachment 789 [details]
screenshot of the problem

As you can see, Pidgin started scrolling for no reason. I always keep the list at the very top, because that's where core developers are listed, as they are all channel operators. After a few minutes, the first 3 or 4 channel operators are out of view, and waiting some more tens of minutes, scrolling reached the very bottom of the list. This never happened before.
Comment 27 D Morgan 2011-09-14 18:33:09 CEST
i push this update or we block it for the moment ?
Comment 28 claire robinson 2011-09-14 18:40:32 CEST
I'm not able to replicate the problem but there are funny things going on with the nicklist when it updates. They do appear to have been doing some work on the nicklist for other reasons recently.

I vote for push but perhaps Frédéric Buclin could report his issue upstream
here - http://developer.pidgin.im/

Defer to Stormi's judgement.
Comment 29 claire robinson 2011-09-14 19:13:15 CEST
Maybe before we do so we could check other distro's with 2.10.0 with a livecd, I can do so tomorrow.
Comment 30 Frédéric "LpSolit" Buclin 2011-09-14 19:30:46 CEST
I downgraded to 2.7.11. I need and want to see channel operators, and having the list to scroll makes me crazy. Why do we want to push it when we know there is such a regression?
Comment 31 D Morgan 2011-09-14 19:35:15 CEST
i agree we can't .

can you report the bug upstream so we can follow it ?

Keywords: validated_update => (none)

Comment 32 Frédéric "LpSolit" Buclin 2011-09-14 19:59:48 CEST
Upstream bug: http://developer.pidgin.im/ticket/14602

URL: (none) => http://developer.pidgin.im/ticket/14602

Comment 33 claire robinson 2011-09-15 09:53:33 CEST
It currently prevents proper upgrade from Mandriva (comment 7) and contains security fixes (comment 1).

IMHO the IRC nicklist issues would be better handled in a separate bug report.
Comment 34 Samuel Verschelde 2011-09-15 13:54:24 CEST
Now we understand why I asked whether patching our existing pidgin was doable. When we upgrade to a newer version that is not purely a bugfix release, we always risk to introduce new bugs.

As Claire said, if we don't update, upgrade from Mandriva can fail, which is a critical problem. I perfectly understand how bad it is to have such a regression and how nerve-breaking it can be. Without the constraints of security fixes and upgrade from mandriva, I would delay the update, but here we have to choose the lesser of two evils, unfortunately.

As soon as the upstream project issues a patch for your problem, we will issue an update for it.

Let's give us another 24h hours to try to fix this bug, then we'll push the update. This is not a satisfactory decision, but we need to make it :(
Comment 35 claire robinson 2011-09-15 16:14:29 CEST
Pidgin 2.9.0 tested in Ubuntu 11.04 and the same strange nicklist behaviour exists there too. That is the latest in the Ubuntu Pidgin PPA.

I have been unable to reproduce the actual scrolling effect Frédéric experiences with either version and I can see who is opped in a channel OK. They are obviously valid concerns though. The nicklist does behave strangely for me, it looks as if it jumps when it updates as people leave a channel.

Bug 2750 has been created regarding the strange nicklist problems, which should allow this to be pushed.
Comment 36 claire robinson 2011-09-15 16:28:30 CEST
SRPM:     pidgin-2.10.0-1.1.mga1.src.rpm

Advisory:

--------------

This update brings Pidgin 2.10.0 with many security and bug fixes. It also
enables proper upgrade from Mandriva 2010 to Mageia 1.

For a complete changelog please see http://developer.pidgin.im/wiki/ChangeLog

For a list of security fixes please see http://pidgin.im/news/security/

Please note that there is currently an upstream bug report regarding IRC nicklists scrolling down by themselves at http://developer.pidgin.im/ticket/14602 and a matching Mageia bug report at https://bugs.mageia.org/show_bug.cgi?id=2750

--------------
Frédéric "LpSolit" Buclin 2011-09-15 16:54:07 CEST

Blocks: (none) => 2750

Comment 37 Samuel Verschelde 2011-09-19 10:49:39 CEST
Update validated, please push it (see comment 36)

Keywords: (none) => validated_update

Comment 38 Nicolas Vigier 2011-09-23 21:49:28 CEST
pushed to updates.

Status: NEW => RESOLVED
CC: (none) => boklm
Resolution: (none) => FIXED

Nicolas Vigier 2014-05-08 18:06:29 CEST

CC: boklm => (none)


Note You need to log in before you can comment on or make changes to this bug.