Bug 21463 - Change in FFMPEG libavcodec == MPlayer segfault when taking screenshot
Summary: Change in FFMPEG libavcodec == MPlayer segfault when taking screenshot
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 6
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: https://bugs.debian.org/cgi-bin/bugre...
Whiteboard: MGA6-64-OK advisory
Keywords: validated_update
: 21837 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-07 09:58 CEST by John L. ten Wolde
Modified: 2017-10-27 09:16 CEST (History)
4 users (show)

See Also:
Source RPM: mplayer-1.3.0-11.mga6
CVE:
Status comment:


Attachments

Description John L. ten Wolde 2017-08-07 09:58:54 CEST
MPlayer will throw the following errors in its terminal output if it is invoked with the '-vf screenshot' option at the command line or if ~/.mplayer/config contains 'vf=screenshot':

[png @ 0x7fb746c9c820]The encoder timebase is not set.
Could not open libavcodec PNG encoder
FATAL: Cannot initialize video driver.


It will then segfault if (by pressing the 'S' key) an actual attempt is made to take a screenshot from a playing video:

sending VFCTRL_SCREENSHOT!
Segmentation fault (core dumped)


I tracked down a year-old (Aug 2016) discussion on the Debian Mailing List of what appears to be this self same bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=834135

And a similar thread on the ArchLinux forum from this January: https://bbs.archlinux.org/viewtopic.php?id=221688

Both discussions point to a change made by the FFMPEG team to their avcodec library: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2016-July/073502.html

MPlayer version numbers from 1.3.0-3 to 1.3.0-6 are thrown around, and it's suggested that upstream has applied patch(es) SVN 37875 and/or SVN 37916-1 to resolve this issue (see https://bugs.debian.org/cgi-bin/bugreport.cgi?att=0;bug=834135;msg=25 and https://bbs.archlinux.org/viewtopic.php?pid=1683388#p1683388 respectively).  But since Mageia 6 shipped with 1.3.0-11, shouldn't these patches be included already? I couldn't find mention of them, either by description or SVN number using 'rpm --changelog -qa mplayer', but if they *were* added, I don't understand why I'm experiencing this problem.

This is all a bit over my head, so I'd appreciate if someone more knowledgeable poked into it.  Thanks.


Version-Release number of selected component:

MPlayer 1.3.0-11.mga6.tainted-5.4.0


How reproducible:

Always.
John L. ten Wolde 2017-08-07 10:04:00 CEST

CC: (none) => johnltw

Comment 1 Marja Van Waes 2017-08-07 18:01:16 CEST
Assigning to the mplayer maintainer.

CC: (none) => marja11
Assignee: bugsquad => shlomif

Comment 2 David Walser 2017-08-13 19:29:12 CEST
The release tag, the number after the 1.3.0-, has no relationship between Debian and Mageia, so no, these patches have not been included in our package.

I'm guessing 37916 is just a newer revision that Arch updated to, so it's actually 37875 that's the patch we need:
http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/2016-July/047089.html

Thanks for the report, and for tracking down the fix.  Builds in progress.

Source RPM: mplayer-1.3.0-11.mga6.tainted => mplayer-1.3.0-11.mga6

Comment 3 John L. ten Wolde 2017-08-13 19:58:17 CEST
(In reply to David Walser from comment #2)
> Thanks for the report, and for tracking down the fix.  Builds in progress.

You're welcome, David, and thanks right back at ya.
Comment 4 David Walser 2017-08-14 00:22:02 CEST
Note: there are core and tainted packages to test.

Advisory:
--------------------------------------------------

The mplayer package has been patched to fix an issue where it would crash when
attempting to take screenshots.

References:
http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2016-July/073502.html
http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/2016-July/047089.html
--------------------------------------------------

Updated packages in {core,tainted}/updates_testing:
--------------------------------------------------
mplayer-1.3.0-12.mga6
mplayer-doc-1.3.0-12.mga6
mplayer-gui-1.3.0-12.mga6
mencoder-1.3.0-12.mga6

from mplayer-1.3.0-12.mga6.src.rpm

Assignee: shlomif => qa-bugs

Comment 5 David Walser 2017-08-14 00:32:19 CEST
John, if you wouldn't mind testing the update in updates_testing, we can get this fix out in short order.  If you could test both the core and tainted builds that would help too.  If you're testing on i586 or x86_64, please add MGA6-32-OK or MGA6-64-OK, respectively, to the whiteboard field of this bug if the updated packages fix your issue.  Thanks again, and you're welcome.
Comment 6 John L. ten Wolde 2017-08-15 03:26:43 CEST
(In reply to David Walser from comment #5)
> John, if you wouldn't mind testing the update in updates_testing, we can get
> this fix out in short order.

Okay, I tried both x86_64 revision 12s out of the Core and Tainted testing repos in turn.  No unsightly errors messages or segfaults occurred with either and the screenshots were created as expected.  They look good to me, and I've updated the whiteboard as you requested accordingly.

Whiteboard: (none) => MGA6-64-OK

Comment 7 Lewis Smith 2017-08-15 21:46:36 CEST
(In reply to John ten Wolde from comment #6)
> Okay, I tried both x86_64 revision 12s out of the Core and Tainted testing
> repos in turn.  No unsightly errors messages or segfaults occurred with
> either and the screenshots were created as expected.  They look good to me,
> and I've updated the whiteboard as you requested accordingly.
Many thanks, John; this was *very* helpful.
Validating the update as it is for M6 only, and we have the good 64-bit OK.
Advisory to follow.

Keywords: (none) => validated_update
CC: (none) => lewyssmith, sysadmin-bugs

Lewis Smith 2017-08-15 21:58:27 CEST

Whiteboard: MGA6-64-OK => MGA6-64-OK advisory

Comment 8 Mageia Robot 2017-08-16 02:01:56 CEST
An update for this issue has been pushed to the Mageia Updates repository.

http://advisories.mageia.org/MGAA-2017-0057.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED

Comment 9 John L. ten Wolde 2017-08-30 04:17:25 CEST
Hi guys.  I hate to bump a closed report, but I happened to notice that the fixed tainted packages (for both i586 and x86_64) never actually made it into tainted_updates but are still stuck in the testing repos.

The App DB confirms this:
http://madb.mageia.org/package/show/application/0/arch/x86_64/name/mplayer
http://madb.mageia.org/package/show/application/0/arch/i586/name/mplayer
Comment 10 David Walser 2017-10-12 02:19:09 CEST
Thanks for noticing John.  This happens all the time with dual-media packages.

Sysadmins, I updated the advisory in SVN to include tainted.  Please push :o)

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 11 David Walser 2017-10-12 02:19:43 CEST
*** Bug 21837 has been marked as a duplicate of this bug. ***
Comment 12 Frédéric "LpSolit" Buclin 2017-10-21 14:49:57 CEST
(In reply to David Walser from comment #10)
> Sysadmins, I updated the advisory in SVN to include tainted.  Please push :o)

ping?
Comment 13 Mageia Robot 2017-10-27 09:16:44 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2017-0057.html

Resolution: (none) => FIXED
Status: REOPENED => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.