Bug 2086 - Update candidate : cultivation
Summary: Update candidate : cultivation
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: New RPM package request (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Sysadmin Team
QA Contact:
URL:
Whiteboard:
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2011-07-09 10:31 CEST by Samuel Verschelde
Modified: 2011-10-07 15:32 CEST (History)
6 users (show)

See Also:
Source RPM: cultivation
CVE:
Status comment:


Attachments
Patch to allow portaudio to use realtime priority (403 bytes, patch)
2011-07-22 20:16 CEST, Dave Hodgins
Details | Diff

Description Samuel Verschelde 2011-07-09 10:31:42 CEST
cultivation-9-0.20071217.6.1.mga1 is an update candidate for Mageia 1. It was present in Mandriva 2010.2 but absent from Mageia 1.

On i586, the game seems to work, I played the tutorial for 5 minutes.

Advisory :
"cultivation was missing in Mageia 1 although present in Mandriva 2010.2. This
update adds it to Mageia 1."
José Jorge 2011-07-09 14:46:10 CEST

CC: (none) => lists.jjorge

Comment 1 Dave Hodgins 2011-07-10 02:30:31 CEST
This one fails on my i586 system.  Starting it from a konsole, it shows
$ cultivation
Game seed = 1310257775
PaHost_WatchDogProc: cannot set watch dog priority!
PaHost_WatchDogProc: killing hung audio thread!
/usr/games/cultivation: line 27: 28678 Killed                  ./cultivation.real

CC: (none) => davidwhodgins

Comment 2 Samuel Verschelde 2011-07-10 09:47:06 CEST
Apparently this is not a new bug, and I don't know if it's a specific cultivation bug : 

https://qa.mandriva.com/show_bug.cgi?id=39318

see also, for other pieces of software :
http://comments.gmane.org/gmane.linux.mandrake.expert/65113

and https://qa.mandriva.com/show_bug.cgi?id=50322 which suggests that it can be a pam problem.

Adding coling in CC for his audio superpowers.

CC: (none) => mageia

Comment 3 Colin Guthrie 2011-07-10 14:45:36 CEST
Do you know which auto system is used for cultivation? From the PaHost text I'd guess portaudio, but when running this app I see it has /dev/dsp open which suggests it's using OSS audio output.

Running it when PA has the device open will cause /dev/dsp to not work. But running it via soundwrapper, or when PA happens to have the devices closed, allows the game to run. That said when it does run, all it plays is static (either when going via PA or not).

So all in all, the cauldron version isn't playing nicely for me with sound generally: static noise is not very nice!
Comment 4 José Jorge 2011-07-10 21:10:29 CEST
I have played the whole game, and it plays no sound. Seems like a useless OSS port is opened, after trying it with soundwrapper.

What is strange is that it fails on i586, while not in x86_64.
Comment 5 Samuel Verschelde 2011-07-10 21:12:31 CEST
Something strange too is that noboby has sound except me in this game :/ 
Could it be a missing dependency or am I just lucky ?
Comment 6 Dave Hodgins 2011-07-10 23:53:08 CEST
I"ve skimmed through the source, and it is using OSS. The PA it's referring
to is http://www.portaudio.com

I really, dislike having a simple game getting realtime priority, for
anything.  It reminds me of having to disassemble winmm.dll in windows 98
to stop flash advertisements getting higher priority than the mouse or
keyboard.

As the output will normally be intercepted by pulseaudio, which has it's
own real time thread, is it even needed?

While the game does work on my system, given the change from the Mandriva
bug report, I really question if this game should be included, given the
limits.conf already distributed in Mageia 1.

Any user in the audio group trying to start it from the menu will not see
any output.

I also wonder about including a game that looks like something from the late
1970s.
Comment 7 José Jorge 2011-07-11 09:10:20 CEST
> Any user in the audio group trying to start it from the menu will not see
any output.

What is the change needed for it to work?

> I also wonder about including a game that looks like something from the late
1970s.

The gameplay is unique.
Comment 8 Samuel Verschelde 2011-07-22 15:05:24 CEST
José, would you accept to investigate about this package you imported (in cauldron) ? 

- look at other distributions (debian, fedora, etc.) to see if they have a patch for this
- gather more information if needed from Colin and Dave
- try to contact the upstream author about this problem

If not, reassign the bug to me.

Assignee: qa-bugs => lists.jjorge

Comment 9 Samuel Verschelde 2011-07-22 15:06:03 CEST
hmm, maybe I should have opened a new bug against cauldron and make this one blocked by it.
Comment 10 José Jorge 2011-07-22 15:17:16 CEST
It is OK. I am already looking at it, Fedora and Debian stripped the portaudio lib.

Status: NEW => ASSIGNED

Comment 11 Dave Hodgins 2011-07-22 20:16:59 CEST
Created attachment 669 [details]
Patch to allow portaudio to use realtime priority

With this patch, clementine works on Mageia 1, but I would prefer to see
the portaudio lib removed.

This is from
https://qa.mandriva.com/show_bug.cgi?id=50322
Comment 12 José Jorge 2011-07-28 15:02:28 CEST
- Cultivation is again in updates_testing
- tested on x86_64 : OK launching from both CLI and menu
- if the user is in group audio, no sound, else it plays sound

For me tests are finished on x86_64, please test on i586.

Assignee: lists.jjorge => qa-bugs

Comment 13 José Jorge 2011-07-28 15:16:48 CEST
(In reply to comment #11)
> Patch to allow portaudio to use realtime priority
> 
> With this patch, clementine works on Mageia 1, but I would prefer to see
> the portaudio lib removed.
> 
With this patch on my system, no sound :

PaHost_OpenStream: could not open /dev/dsp for O_WRONLY
PaHost_OpenStream: ERROR - result = -10000
Error opening audio stream
Error number: -10000
Error message: Host error.


Still with this patch applied, "pasuspender cultivation" gives sound.
What I don't understand is that clementine already works on my system without this patch ;-)
Comment 14 Samuel Verschelde 2011-07-29 09:48:35 CEST
(In reply to comment #12)
> - Cultivation is again in updates_testing
> - tested on x86_64 : OK launching from both CLI and menu
> - if the user is in group audio, no sound, else it plays sound
> 
> For me tests are finished on x86_64, please test on i586.

It works here (i586), but as the previous package already worked (with sound) for me, so it would be interesting to have the feedback from Dave Hodgins and/or Colin Guthrie
Comment 15 Dave Hodgins 2011-07-30 04:07:29 CEST
I returned /etc/security/limits.conf back to it's default value.

I created a new user that is only a member of it's group, and the program
works for that user.

For my id, which is a member of the audio group, it still fails, with strace
showing
19978 sched_get_priority_max(SCHED_RR)  = 99
19978 sched_setscheduler(0, SCHED_RR, { 53 }) = -1 EPERM (Operation not permitted)
19978 write(1, "PaHost_WatchDogProc: cannot set "..., 52) = 52
19978 write(1, "PaHost_WatchDogProc: killing hun"..., 48) = 48

I'm not sure how common it is for people to add their login ids to the audio group.

I got into the habit of adding my id to all groups years ago, primarily to be
able log files, etc, which I ensure are group readable.

Usually I expect adding my id to a group to give me greater access.

This is the first time I've seen being a member of a group stopping access that
is permitted when not a member of the group.

Perhaps a separate blocking bug report should be opened on pam, the package
that owns the limits.conf file, so being a member of the audio group doesn't
limit the max priority.

Opinions?
Comment 16 D Morgan 2011-08-21 02:51:40 CEST
i agree for the PAM bugreport.

But what is the status of this update request regarding cultivation ?

CC: (none) => dmorganec

Comment 17 Dave Hodgins 2011-08-21 05:31:26 CEST
In comment 11, clementine was a mistype.  I should have typed cultivation,
so Comment 13 doesn't apply to cultivation.

I'll report the bug on pam for the change to the limits.conf file.

I consider the testing of the srpm
cultivation-9-1.1.mga1.src.rpm
from Core Updates Testing complete on i586.
Comment 18 claire robinson 2011-08-31 11:48:12 CEST
As this was previously OK'd by José Jorge in comment 12 on x86_64 it should be Ok to validate this update.

Advisory :

==============

This update adds the game Cultivation which was present in Mandriva 2010.2 but missing from Mageia 1.

==============

SRPM: cultivation-9-1.1.mga1.src.rpm


Could somebody from sysdamin please push this update from core/updates_testing to core/updates.

Thankyou!

Keywords: (none) => validated_update
CC: (none) => qa-bugs
Hardware: i586 => All
Assignee: qa-bugs => sysadmin-bugs

Comment 19 Samuel Verschelde 2011-08-31 11:51:20 CEST
To Dave Hodgins : did you report the bug on pam as you said you would?
Comment 20 Samuel Verschelde 2011-08-31 11:52:53 CEST
To Claire (and others) : don't forget to add sysadmin-bugs@ml.mageia.org in CC when validating an update. If the wiki lacks this piece of information, feel free to edit it :)
Comment 21 claire robinson 2011-08-31 11:54:33 CEST
I assigned to sysadmin-bugs@ml.mageia.org Samuel and added qa-bugs into CC.

CC: (none) => eeeemail

Comment 22 claire robinson 2011-08-31 11:56:57 CEST
I see that is wrong though, you are correct. Thanks for pointing it out!

We really need to rewrite the wiki.
Comment 23 D Morgan 2011-08-31 13:06:07 CEST
update pushed.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 24 Dave Hodgins 2011-08-31 19:48:00 CEST
(In reply to comment #19)
> To Dave Hodgins : did you report the bug on pam as you said you would?

Yes. See bug 2503
Comment 25 Samuel Verschelde 2011-09-29 19:57:10 CEST
Oooooooooooooooooops we forgot to move portaudio0 along with cultivation !

Please push portaudio0 with the following advisory:

This update adds portaudio0 to Mageia1 as a needed dependency for the Cultivation game.
Comment 26 Samuel Verschelde 2011-09-29 19:57:42 CEST
To sysadmins: please push portaudio0, see comment #25

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 27 D Morgan 2011-10-07 15:32:17 CEST
pushed.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.