Bug 20596 - Installer upgrade of Mga5->6 overwrites /etc/default/grub losing custom settings
Summary: Installer upgrade of Mga5->6 overwrites /etc/default/grub losing custom settings
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
: release_blocker critical
Target Milestone: ---
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard: NEEDHELP
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-29 18:52 CEST by Barry Jackson
Modified: 2017-05-15 17:30 CEST (History)
2 users (show)

See Also:
Source RPM: drakx-installer-stage2
CVE:
Status comment:


Attachments

Description Barry Jackson 2017-03-29 18:52:43 CEST
Description of problem:
/etc/default/grub is edited during upgrade from Mga5 to Cauldron.

This is fork from https://bugs.mageia.org/show_bug.cgi?id=20429 where I attempted to fix this in the packaging of grub2 by various means including saving the file in %pre and copying it back in %triggerpostun common when the Mga5 grub2{,-efi} was removed.

I am now thinking that the issue is caused by the installer after the package is installed such that it can't be fixed in the grub2 packaging.

I will check whether this happens in a urpmi upgrade to confirm that the installer is causing this.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
Comment 1 Barry Jackson 2017-03-30 01:33:04 CEST
I have confirmed that rpm is NOT misbehaving as a result of the file move from grub2{,-efi} to grub2-common during upgrade, as was suspected back in the original bug report linked above.

A urpmi upgrade works fine using the current cauldron grub2.

/etc/default/grub.rpmnew is created and /etc/default/grub is left untouched.

/etc/default/grub.rpmnew is then (correctly) deleted as per the spec.

The problem ONLY happens when using the installer to do the upgrade.
Comment 2 Barry Jackson 2017-03-30 01:35:20 CEST
Increasing to release blocker as this affects the installer and can't be fixed afterwards.
Comment 3 Marja van Waes 2017-03-30 08:56:52 CEST
(In reply to Barry Jackson from comment #1)
> I have confirmed that rpm is NOT misbehaving as a result of the file move
> from grub2{,-efi} to grub2-common during upgrade, as was suspected back in
> the original bug report linked above.
> 
> A urpmi upgrade works fine using the current cauldron grub2.
> 
> /etc/default/grub.rpmnew is created and /etc/default/grub is left untouched.
> 
> /etc/default/grub.rpmnew is then (correctly) deleted as per the spec.
> 
> The problem ONLY happens when using the installer to do the upgrade.

Assigning to stage2, then.
Comment 4 Rémi Verschelde 2017-04-26 13:17:47 CEST
Thierry, any idea about this issue?
Comment 5 Frédéric Buclin 2017-05-15 17:19:54 CEST
I did an upgrade from Mageia 5 to 6 using the Mageia 6 RC DVD from this week-end, and I cannot reproduce the issue. The two custom entries in /et/default/grub I had in Mageia 5 are still there after the upgrade to Mageia 6.
Comment 6 Frédéric Buclin 2017-05-15 17:22:11 CEST
Barry: in your case, what kind of changes did you notice? A parameter with another value? Some parameters removed?
Comment 7 Barry Jackson 2017-05-15 17:30:37 CEST
(In reply to Frédéric Buclin from comment #6)
> Barry: in your case, what kind of changes did you notice? A parameter with
> another value? Some parameters removed?

The details are in the original bug linked in comment 0

Note You need to log in before you can comment on or make changes to this bug.