Created attachment 8801 [details]
Proposed fix

I don't know if this is the correct solution, but it works.

As I said in bug #12361, that would only prevent draklive-install to remove it and of install.
But urpme --auto-orphans will still suggest to remove it.

The issue is that draklive-install doesn't tell urpmi about needed packages.
It should.
But as it basically just dumps the live system, it doesn't tell urpmi
I suggested attachment #8651 [details] on bug #12361

CC: (none) => thierry.vignaud

(In reply to Thierry Vignaud from comment #2)
> As I said in bug #12361, that would only prevent draklive-install to remove
> it and of install.
> But urpme --auto-orphans will still suggest to remove it.

It won't because x11-driver-video-vmware isn't an orphan, it's required by x11-driver-video and that's marked as manually installed.

> The issue is that draklive-install doesn't tell urpmi about needed packages.
> It should.
> But as it basically just dumps the live system, it doesn't tell urpmi
> I suggested attachment #8651 [details] on bug #12361

That's not going to help in this case, because pkgs:detect_graphical_drivers only returns proprietary drivers. But it's still a good idea, so I'll test the patch anyway.

What is the reason for pkgs:detect_graphical_drivers only returning proprietary drivers?

Another solution would be to do the same as harddrake2:
- parse rpmsrate
- get the list of needed packages
- run urpmi with that list in order to prevent urpme to remove them

See http://gitweb.mageia.org/software/drakx/tree/perl-install/standalone/harddrake2#n496

Aka we should call a func like:

# prevent urpme --auto-orphans to remove those
sub keep_needed_pkgs {
    if (my @packages = pkgs::detect_hardware_packages($in->do_pkgs)) {
        # we use uniq() because on biarch machines, we got packages twice:
        my @packages2install = uniq($in->do_pkgs->are_available(@packages));
	$in->do_pkgs->install(@packages2install);
    }
}

Then we may have to add part of the pkg list of pkgs
    # do no try to install too generic hw packages:
    my @blacklist = [ qw(...) ];

(In reply to Martin Whitaker from comment #3)
> What is the reason for pkgs:detect_graphical_drivers only returning
> proprietary drivers?

I guess b/c all free drivers are installed by default (in the old days b/c xfree86 was monolitic, then b/c we've x11-driver-video pulling the really used ones)

Thinking about it more, keeping all the common video drivers installed is good in case the user changes their graphics card. So we probably don't want to change that.

(In reply to Thierry Vignaud from comment #2)
> As I said in bug #12361, that would only prevent draklive-install to remove
> it and of install.
> But urpme --auto-orphans will still suggest to remove it.

But if it's not removed, I guess x11-driver-video would be kept and its dependencies would not be seen as orphans, no? Or is x11-driver-video also seen as an orphan?

(In reply to Rémi Verschelde from comment #7)
> (In reply to Thierry Vignaud from comment #2)
> > As I said in bug #12361, that would only prevent draklive-install to remove
> > it and of install.
> > But urpme --auto-orphans will still suggest to remove it.
> 
> But if it's not removed, I guess x11-driver-video would be kept and its
> dependencies would not be seen as orphans, no? Or is x11-driver-video also
> seen as an orphan?

Yes to the first question, no to the second.

So I guess the patch in comment 1 should work as a quick fix, until a better fix is worked on as described in comment 2 or comment 4?

Yes, it's applied as a temporary patch in the latest sta2 ISOs.

commit b1e9ed8a077baf02f1a0be5959c4b39069bf7183
Author: Martin Whitaker <mageia@...>
Date:   Mon Dec 19 14:01:22 2016 +0000

    Exclude x11-driver-video-vmware from unneeded packages (mga#19979).
    
    It's required by x11-driver-video, and removing that orphans all
    the other required x11 video driver packages.
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=b1e9ed8a077baf02f1a0be5959c4b39069bf7183

commit e617931c7ef98da28dc9a99be9a7cc3fa06151e1
Author: Martin Whitaker <mageia@...>
Date:   Mon Dec 19 14:01:22 2016 +0000

    Exclude x11-driver-video-vmware from unneeded packages (mga#19979).
    
    It's required by x11-driver-video, and removing that orphans all
    the other required x11 video driver packages.
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=e617931c7ef98da28dc9a99be9a7cc3fa06151e1

tested with Sta2 live and non live, and this is fixed

Status: NEW => RESOLVED
CC: (none) => mageia
Resolution: (none) => FIXED