Bug 19196 - When a small number of upgrades can be installed after finishing install, the buttons are not visible
Summary: When a small number of upgrades can be installed after finishing install, the...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
: release_blocker normal
Target Milestone: ---
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard:
Keywords: 6RC, PATCH, USABILITY
: 20571 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-14 16:09 CEST by Dick Gevers
Modified: 2017-05-22 08:49 CEST (History)
3 users (show)

See Also:
Source RPM: drakx-installer-stage2, urpmi , mutter
CVE:
Status comment: Dialog floating above the window instead of being embedded


Attachments
screenshot showing buttons are missing (85.37 KB, image/jpeg)
2016-08-14 16:10 CEST, Dick Gevers
Details
ie something like this (510 bytes, patch)
2017-04-04 11:53 CEST, Thierry Vignaud
Details | Diff
new screenshot showing dialog for 3 package updates (42.66 KB, image/png)
2017-05-09 23:37 CEST, PC LX
Details

Description Dick Gevers 2016-08-14 16:09:20 CEST
Description of problem:

Install from classical 64 bit DVD dated 13/8, update sources at the end and elect to install available newer packages.

If there are less than 10 packages, presumably, buttons are shown at the bottom. If there are dozens, the list is broken up and the buttons appear at the end. But if (in my case) there are 14 packages, the buttons are invisible (below the edge of the screen).
One can press [ enter ] to proceed, but the buttons should actually be visible.

Screenshot follows (F2 screenshot from installer actually showed the next step, not this step).
Comment 1 Dick Gevers 2016-08-14 16:10:37 CEST
Created attachment 8345 [details]
screenshot showing buttons are missing
Comment 2 Thierry Vignaud 2016-08-16 15:35:43 CEST
Humm, strange as:
- the size is not really big
- we ask for center position...
Comment 3 Dick Gevers 2016-12-07 19:06:31 CET
Valid for 6sta2 (classical 64 bit iso dated 05 DEC 2016)
Comment 4 Dick Gevers 2016-12-14 13:52:14 CET
corecting keyword
Comment 5 Dick Gevers 2017-03-25 14:27:06 CET
Valid for M6 rc (classical 64 bit iso dated 23 Mar 2017)


There is no keyword for M6rc
Comment 6 Frédéric Buclin 2017-03-26 16:27:28 CEST
*** Bug 20571 has been marked as a duplicate of this bug. ***
Comment 7 Marja van Waes 2017-03-29 07:42:50 CEST
Not sure how confusing this can be, but is certainly something that cannot be fixed after release, so setting to release blocker for now.
Comment 8 Dick Gevers 2017-03-29 11:59:19 CEST
The answer is simple: the focus is on the "ok" button or similar, so pressing 
[ Enter ] works, except a first time user does not know that. So obviously it ought to be fixed ;)
Comment 9 Thierry Vignaud 2017-03-29 13:26:42 CEST
We could try RPMProgressDialog->new() to call set_position('center_always') instead of 'center'
Comment 10 Rémi Verschelde 2017-04-04 10:24:44 CEST
(In reply to Thierry Vignaud from comment #9)
> We could try RPMProgressDialog->new() to call set_position('center_always')
> instead of 'center'

I don't know if it's exposed to our bindings, but there seems to be a `WindowPosition.CENTER_ON_PARENT` flag too.

Could we try one of those on the next set of ISOs?
Comment 11 Thierry Vignaud 2017-04-04 11:53:09 CEST
Created attachment 9184 [details]
ie something like this
Comment 12 Thierry Vignaud 2017-04-04 11:53:49 CEST
But that would not please gurpmi users after install.
Though there should not be much, people are using rpmdrake.
Comment 13 Rémi Verschelde 2017-04-26 11:37:04 CEST
Could someone test the patch in comment 11?
Comment 14 Rémi Verschelde 2017-04-26 13:30:44 CEST
@Thierry: Would drakx-in-chroot pick the system's urpmi version? If so it should be relatively easy to test the patch by patching one's own urpmi.
(https://wiki.mageia.org/en/Drakx-installer_tips_and_tricks#drakx-in-chroot)
Comment 15 Rémi Verschelde 2017-04-26 21:07:03 CEST
I tested the patch locally and I don't see much impact on gurpmi usage, so I guess it's fine (the progress dialog is centered both with and without the patch).
Comment 16 Mageia Robot 2017-04-26 21:23:44 CEST
commit 410cac6cff39dcb65371ba8cbc98f9c389a9f577
Author: Rémi Verschelde <rverschelde@...>
Date:   Wed Apr 26 21:06:23 2017 +0200

    Enforce gurpmi ProgressDialog centering
    
    Should help with mga#19196.
---
 Commit Link:
   http://gitweb.mageia.org/software/rpm/urpmi/commit/?id=410cac6cff39dcb65371ba8cbc98f9c389a9f577
Comment 17 Rémi Verschelde 2017-04-26 21:30:51 CEST
Patch pushed in urpmi-8.107-1.mga6, let's see if it improves things in the next set of ISOs.

BTW Thierry, we still have a stranded patch in the SVN: http://svnweb.mageia.org/packages/cauldron/urpmi/current/SOURCES/0001-increase-transaction-size-from-8-to-50-mga-18426.patch?view=markup
It would be good to commit it to git if it's meant to be kept.
Comment 18 Thierry Vignaud 2017-04-30 01:06:24 CEST
It's best to use "git commit --author=...." in such cases
Comment 19 Rémi Verschelde 2017-05-06 17:59:34 CEST
(In reply to Thierry Vignaud from comment #18)
> It's best to use "git commit --author=...." in such cases

Right, sorry.

Can someone confirm that the bug is fixed in today's set of ISOs?
Comment 20 PC LX 2017-05-09 23:35:58 CEST
Installed Mageia 6 rc using Mageia-6-rc-x86_64-DVD.iso and the update dialog was centered but there were only 3 package needing to be updated so I'm not certain if this bug is resolved or if it was just not triggered because there were not enough packages to trigger it. New screen shot in attachment.

Will try installing again this weekend. Maybe then there will be more package updates and I'll be able to confirm if this bug is resolved or not.

$ cat DATE.txt 
Mon May  8 00:48:36 CEST 2017
$ cat Mageia-6-rc-x86_64-DVD.iso.sha1
fd11e0581a749cb517b203d0cd6f15a919e87e54  Mageia-6-rc-x86_64-DVD.iso
Comment 21 PC LX 2017-05-09 23:37:28 CEST
Created attachment 9292 [details]
new  screenshot showing dialog for 3 package updates
Comment 22 Rémi Verschelde 2017-05-16 09:03:03 CEST
(In reply to PC LX from comment #21)
> Created attachment 9292 [details]
> new  screenshot showing dialog for 3 package updates

Thanks. So the patch worked, but I don't think it really fixed the issue: IINM, this dialog is meant to be embedded in the main window, not floating above it.

Note You need to log in before you can comment on or make changes to this bug.