Bug 18972 - Mga 1 to 5 had tap-to-click enabled by default, but Mga6 uses libinput where it's turned off by default. There is no (easy) way to enable it in installer and in DMs
Summary: Mga 1 to 5 had tap-to-click enabled by default, but Mga6 uses libinput where ...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
: High major
Target Milestone: ---
Assignee: Funda Wang
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-17 22:53 CEST by Frank Griffin
Modified: 2017-02-13 12:07 CET (History)
12 users (show)

See Also:
Source RPM: libinput
CVE:
Status comment:


Attachments

Description Frank Griffin 2016-07-17 22:53:41 CEST
See https://wayland.freedesktop.org/libinput/doc/latest/tapping.html .

Upstream libinput seems to think that saving a few users from the unintended consequences of tap-to-click is worth disabling it by default for everyone.  I disagree.  MGA has had tap-to-click enabled since MGA1, and it is only disabled in MGA6 because we converted from the synaptics driver to libinput during the release cycle and libinput has a different default.

In most cases, the default can be easily changed by adding the following entry to /etc/X11/xorg.conf.d as 10-touchpad.conf:

Section "InputClass"
   Identifier "MyTouchpad"
   MatchIsTouchpad "on"
   Driver "libinput"
   Option "Tapping" "on"
EndSection

I believe that if tap-to-click was desirable in MGA1-5, we ought to take steps to enable it in MGA6.  Affected components are (at least) the installer and the DMs, since, unlike the individual DEs, neither of these has any mechanism to allow the user to enable tap-to-click if he wants it.
Comment 1 Marja van Waes 2016-07-18 07:14:01 CEST
(In reply to Frank Griffin from comment #0)

> 
> In most cases, the default can be easily changed by adding the following
> entry to /etc/X11/xorg.conf.d as 10-touchpad.conf:
> 
> Section "InputClass"
>    Identifier "MyTouchpad"
>    MatchIsTouchpad "on"
>    Driver "libinput"
>    Option "Tapping" "on"
> EndSection

You don't say that you tested that ;-) 
I assume you did and that it works as desired?

> 
> I believe that if tap-to-click was desirable in MGA1-5, we ought to take
> steps to enable it in MGA6. 

I'm certainly not the only one for whom the "tap-to-click" feature turned into a disaster.

   Did _lacking_ the "tap to click" feature lead to any disaster for you?
   If not: Does anything indicate that a disaster could happen?

CC'ing libinput packager, packaging team leaders and those of whom I've seen an opinion about tap-to-click.

(A solution where it is disabled by default on all systems that have "mouse" buttons, but enabled where "mouse" buttons are missing, would have my preference)
Comment 2 Rémi Verschelde 2016-07-18 08:53:54 CEST
Given the various discussions that we had about this, I think the only consensual solution would be to edit the installer so that it proposes to enable or disable tab to click during the install or post-install step.

Based on this option, it would write or not the above-mentioned /etc/X11/xorg.conf.d/10-touchpad.conf.
Comment 3 Rémi Verschelde 2016-07-20 12:32:06 CEST
Might be worth checking if the new libinput changes things regarding this issue:

tmb <tmb> 1.4.0-1.mga6:
+ Revision: 1042911
- 1.4.0 (improved tablet and touchpad support)
Comment 4 Frank Griffin 2016-07-20 14:34:05 CEST
@Marja I'm fine with disable by default as long as there's a way to enable it.  Yes, I did test the X11 directive; when present, tap-to-click is enabled for SDDM and disabled when it's not present.  I couldn't test the installer, as I didn't know how to add it in.  Oddly enough, it does NOT work for GDM, so the installer may still have a problem if this is being overridden by GTK.

@Remi The link at the top of this bug report has had its version updated to 1.4.0 and still says it's disabled by default.
Comment 5 Barry Jackson 2017-02-10 15:08:36 CET
I have just net-installed Mga6 plasma (all defaults) on two laptops.
Acer 5920
Lenovo Thinkpad T420

It was rather non-intuitive to have no taps working on the Acer during install. I can't recall whether it worked or not on the Thinkpad.

After reboot the tap-to-click feature works fine on the Thinkpad, but the Acer would not work at all, despite what appeared to be correct settings in systemsettings.
The Thinkpad has no /etc/X11/xorg.conf.d/*-touchpad.conf.

Adding the workaround from #1 (I actually  put it in xorg.conf by mistake) works fine and the Acer now responds to taps.

So it seems this is hardware dependant.
Comment 6 Frank Griffin 2017-02-10 15:21:49 CET
When you say "it worked fine on the Thinkpad" do you mean that on reboot it worked by default or that you were able to turn it on for Plasma ?

I was always able to turn it on in Plasma System Settings without using the workaround above.  But that had no effect on SDDM.

OpenSUSE enables tap-to-click in its installer, the DM, and GNOME by default.
Comment 7 Barry Jackson 2017-02-11 16:27:12 CET
(In reply to Frank Griffin from comment #6)
> When you say "it worked fine on the Thinkpad" do you mean that on reboot it
> worked by default or that you were able to turn it on for Plasma ?

I don't know for sure - I think it was on by default but as it was not an issue I really can't remember.
It was only when I could not make it work at all on the Acer that I found this bug report.
> 
> I was always able to turn it on in Plasma System Settings without using the
> workaround above.  But that had no effect on SDDM.

No - I can't get tap-to-click working in SDDM on either of them.

> 
> OpenSUSE enables tap-to-click in its installer, the DM, and GNOME by default.

I am currently net-installing Mga6 plasma on another Acer 7720g that I have just repaired, so I will pay close attention on this one. ;)
Comment 8 Donald 2017-02-12 04:07:46 CET
I have similar behavior on another lenovo. 

No taps during installation, or after reboot, but they work after changing systemsettings but not in sddm. 

While you can click with its track pad, it's about as accurate as me playing golf, so a highly frustrating experience. 

I feel that we should follow opensuse on this. It seems insane having a configuration that disables a key piece of hardware by default.
Comment 9 Marja van Waes 2017-02-13 12:07:24 CET
(In reply to Frank Griffin from comment #0)
> See https://wayland.freedesktop.org/libinput/doc/latest/tapping.html .
> 
> Upstream libinput seems to think that saving a few users from the unintended
> consequences of tap-to-click is worth disabling it by default for everyone. 
> I disagree.  MGA has had tap-to-click enabled since MGA1, and it is only
> disabled in MGA6 because we converted from the synaptics driver to libinput
> during the release cycle and libinput has a different default.
> 

> 
> I believe that if tap-to-click was desirable in MGA1-5, we ought to take
> steps to enable it in MGA6.  Affected components are (at least) the
> installer and the DMs, since, unlike the individual DEs, neither of these
> has any mechanism to allow the user to enable tap-to-click if he wants it.

(In reply to Frank Griffin from comment #6)

> 
> OpenSUSE enables tap-to-click in its installer, the DM, and GNOME by default.

(In reply to Donald from comment #8)
> I have similar behavior on another lenovo. 
> 
> No taps during installation, or after reboot, but they work after changing
> systemsettings but not in sddm. 
> 
> While you can click with its track pad, it's about as accurate as me playing
> golf, so a highly frustrating experience. 
> 
> I feel that we should follow opensuse on this. It seems insane having a
> configuration that disables a key piece of hardware by default.

It is only since I've used such a touchpad that I fully understand the problem :-(

Assigning to maintainer, but CC'ing some committers in case fwang is unavailable

Note You need to log in before you can comment on or make changes to this bug.