Bug 18857 - fonts-otf-source-han not included in live-media
Summary: fonts-otf-source-han not included in live-media
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Release (media or process) (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker normal
Target Milestone: Mageia 6
Assignee: Martin Whitaker
QA Contact: You-Cheng Hsieh
URL:
Whiteboard:
Keywords: 6sta1
Depends on:
Blocks:
 
Reported: 2016-07-04 07:46 CEST by You-Cheng Hsieh
Modified: 2017-01-17 10:29 CET (History)
12 users (show)

See Also:
Source RPM: draklive-config
CVE:
Status comment: Fix committed, will be on sta2 ISOs


Attachments

Description You-Cheng Hsieh 2016-07-04 07:46:10 CEST
Description of problem:
fonts-otf-source-han not included in live-media, causes CJK font look ugly.(especially notable on plasma5)

Version-Release number of selected component (if applicable):
Mageia-6-sta1-LiveDVD-GNOME-i586-DVD	
Mageia-6-sta1-LiveDVD-GNOME-x86_64-DVD	
Mageia-6-sta1-LiveDVD-PLASMA5-i586-DVD	
Mageia-6-sta1-LiveDVD-PLASMA5-x86_64-DVD	

How reproducible:
Only notable for CJK locale on live-media.

Steps to Reproduce:
(recommend using virtualbox for comparison)
1.Boot any of the mga6 sta1 plasma5 live DVD.
2.select Chinese language.
3.Compare with the mga5 kde4 live-DVD.
(If you can't notice the difference, I can upload screenshots later.)

fonts-otf-source-han was introduced in mga5 as default CJK font. It should be included in all install media that supports CJK locales.
Comment 1 Marja Van Waes 2016-07-04 09:02:07 CEST

See also

https://bugs.mageia.org/show_bug.cgi?id=17223#c17

I can't now find that it was decided to not have that font on this iso, and re-add it later, but I do have a vague memory of such a decision.

tmb will know :-)

Setting to release blocker.

Keywords: (none) => 6sta1
Priority: Normal => release_blocker
CC: (none) => marja11
See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=17223
Assignee: bugsquad => tmb

Comment 2 Thomas Backlund 2016-07-04 10:54:40 CEST
Hm, seems I forgot to fix the second part of this problem...

The font is not installed on live media by default as it triggers a bug / slowdown in fontconfig cache that makes live boot stall in 30-40 seconds, appearing to have "hung" with no visible output at all...
(and upstream fontconfig guys still dont have any idea of how to fix)

So I moved the font to "Live Core" media so it would ship with live medias, with the intention to install it only for user selecting a language needing it...

But I forgot to change the code to ensure it got installed it on language selection :/

for now you can "urpmi fonts-otf-source-han" even in live mode, and it will install it.
Comment 3 You-Cheng Hsieh 2016-07-04 11:44:42 CEST
Thanks for clarify. Install it for CJK languages would be nice indeed, hope you could finish it before next release.:)
Marja Van Waes 2016-07-10 13:16:05 CEST

Blocks: (none) => 15527

Comment 4 You-Cheng Hsieh 2016-08-11 03:54:21 CEST
OpenMandriva use NotaSanscjk as default CJK font and therefore encounter similar problem. I think how they deal with this issue might worth taking a look:
https://issues.openmandriva.org/show_bug.cgi?id=1764#c58
Attempt fix:
https://github.com/OpenMandrivaAssociation/omdv-build-iso/commit/2ff0f766c060b37b134b7993f61dcb8c9805ceee
Comment 5 Marja Van Waes 2016-08-11 13:05:11 CEST
(In reply to You-Cheng Hsieh from comment #4)
> OpenMandriva use NotaSanscjk as default CJK font and therefore encounter
> similar problem. I think how they deal with this issue might worth taking a
> look:
> https://issues.openmandriva.org/show_bug.cgi?id=1764#c58
> Attempt fix:
> https://github.com/OpenMandrivaAssociation/omdv-build-iso/commit/
> 2ff0f766c060b37b134b7993f61dcb8c9805ceee

Thanks :-)

Did you already find the RedHat patch this one seems to (at least partly) come from?

CC: (none) => ennael1, mageia, mageia, pterjan, thierry.vignaud
Assignee: tmb => pkg-bugs

Comment 6 Thomas Backlund 2016-08-11 15:41:19 CEST
It's not a patch as such, it's this part of the iso build scripts that should be adapted for mageia draklive config:

+        # set the timestamp on the directories to be a whole second
+        # fc-cache looks at the nano second portion which will otherwise be
+        # non-zero as we are on ext4, but then it will compare against the stamps
+        # on the squashfs live image, squashfs only has second level timestamp resolution
+        FCTIME=$(date +%Y%m%d%H%M.%S)
+        $SUDO chroot "$CHROOTNAME" find /usr/share/fonts -type d -exec touch -t $FCTIME {} \;



The fedora fix (stop systemd running the ldconfig cache) is this part:

+# 
+ $SUDO echo 'File created by omdv-build-iso. See systemd-update-done.service(8).' \
+    | tee "$CHROOTNAME"/etc/.updated >"$CHROOTNAME"/var/.updated
+

CC: (none) => tmb

Comment 7 Marja Van Waes 2016-08-12 14:03:27 CEST
Thanks, Thomas :-)

(Even if we thought it was naughty of you to read bugs and comment in one :-þ )

CC'ing napcok, too, now, in case he'd like to help (and because of the experience he has building live isos)

CC: (none) => napcok

Comment 8 You-Cheng Hsieh 2016-08-15 05:19:02 CEST
Since Thomas' departure, I would like to brief current status of this issue:

At first, font-otf-source-han was picked to cause boot lag because of long fc-cache time. The original approach of Thomas was to:
1) Move font-otf-source-han to a "live core" media. - done.
2) If user select Chinese, Japanese, Korean at language selection, install the font automatically. - not done yet.

On the other hand, OpenMandriva devs found the cause of why live boot still run fc-cache when the font cache is available: a timestemp resolution issue. To resolve this bug in this approach, (I think) the work flow should be:
1) Install font-otf-source-han on live system by default instead of leave it in the "live core" media.
2) Adapt the way OpenMandriva fix the timestemp for mageia draklive config.
3) Build some live iso for testing.
Comment 9 Thierry Vignaud 2016-08-19 07:58:52 CEST
@Blino: if you could fix this one for next live isos...

Assignee: pkg-bugs => mageia
Source RPM: (none) => draklive-config

Samuel Verschelde 2016-09-12 16:25:55 CEST

Status comment: (none) => Fix available from openMandriva but need to be adapt to draklive. Further info available at comment #8
QA Contact: (none) => yochenhsieh

Samuel Verschelde 2016-09-12 16:26:12 CEST

CC: (none) => isobuild

Comment 10 Rémi Verschelde 2016-10-17 11:42:27 CEST
CC'ing Martin who was poking at live ISOs recently.

CC: (none) => mageia

Rémi Verschelde 2016-10-17 11:53:46 CEST

Target Milestone: --- => Mageia 6

Comment 11 Martin Whitaker 2016-10-25 00:16:15 CEST
I've adapted and incorporated the OpenMandriva fix in draklive-config, and tested it works in my local build.
Comment 12 You-Cheng Hsieh 2016-10-25 12:06:27 CEST
Thanks! That's a really good news!

I'll have to wait for sta2 iso to confirm the fix, but I can update the status comment now.

Status comment: Fix available from openMandriva but need to be adapt to draklive. Further info available at comment #8 => Fix incorporated and tested works in local build

Comment 13 Nicolas Lécureuil 2016-10-25 12:12:53 CEST
(In reply to Martin Whitaker from comment #11)
> I've adapted and incorporated the OpenMandriva fix in draklive-config, and
> tested it works in my local build.


is it commited on our repos ?

CC: (none) => mageia

Comment 14 Martin Whitaker 2016-10-25 19:28:36 CEST
(In reply to Nicolas Lécureuil from comment #13)
> is it commited on our repos ?

No. I'm still waiting to be given commit rights (and access to the rabbit/bcd servers, so I can release ISOs to QA). This was requested nearly a month ago, but as far as I can tell, never done.
Comment 15 Marja Van Waes 2016-10-26 10:28:32 CEST
(In reply to Martin Whitaker from comment #14)
> (In reply to Nicolas Lécureuil from comment #13)
> > is it commited on our repos ?
> 
> No. I'm still waiting to be given commit rights (and access to the
> rabbit/bcd servers, so I can release ISOs to QA). This was requested nearly
> a month ago, but as far as I can tell, never done.

Afaik rabbit didn't come back up after last week's "Dirty cow" fix, but apart from that: I don't understand why, after all the good patches you've provided, you don't have git commit rights.
Comment 16 Nicolas Lécureuil 2016-11-06 15:02:41 CET
now martin has access and rabbit is up. 

Please martin commit your fix on the git so we can close this bugreport.
Comment 17 Samuel Verschelde 2016-11-17 15:22:09 CET
Assigning to Martin, if I understood correctly.

Assignee: mageia => mageia

Comment 18 Mageia Robot 2016-11-20 21:06:41 CET
commit 8eb7d39964d283fa8f89699d2df626aca0f36a91
Author: Martin Whitaker <mageia@...>
Date:   Tue Oct 25 20:53:01 2016 +0100

    Reenable inclusion of fonts-otf-source-han (mga#18857)
    
    Includes fix for slow boot (due to unnecessary font cache update)
    ported from OpenMandriva.
---
 Commit Link:
   http://gitweb.mageia.org/software/build-system/draklive-config/commit/?id=8eb7d39964d283fa8f89699d2df626aca0f36a91
Martin Whitaker 2016-11-21 19:59:52 CET

Status comment: Fix incorporated and tested works in local build => Fix committed, will be on sta2 ISOs

Comment 19 Nicolas Lécureuil 2016-12-03 14:24:57 CET
closing then.

Please reopen when sta2 will be out and if the bug is still valid

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Samuel Verschelde 2017-01-17 10:29:39 CET

Blocks: 15527 => (none)


Note You need to log in before you can comment on or make changes to this bug.