Bug 18635 - adwaita-gtk2-theme: impossible to modify the background colour of a GtkEntry or a wxTextCtrl
Summary: adwaita-gtk2-theme: impossible to modify the background colour of a GtkEntry ...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: GNOME maintainers
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO, PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2016-06-06 16:02 CEST by Nicolas Salguero
Modified: 2016-09-07 11:51 CEST (History)
1 user (show)

See Also:
Source RPM: gnome-themes-standard
CVE:
Status comment:


Attachments
Source code of a GtkEntry test (869 bytes, text/x-csrc)
2016-06-06 16:03 CEST, Nicolas Salguero
Details
wx.TextCtrl test (777 bytes, text/x-python)
2016-06-06 16:04 CEST, Nicolas Salguero
Details
Result of GtkEntry test using Adwaita as GTK+ 2 theme (2.41 KB, image/png)
2016-06-06 16:05 CEST, Nicolas Salguero
Details
Result of GtkEntry test when not using Adwaita as GTK+ 2 theme (3.12 KB, image/png)
2016-06-06 16:05 CEST, Nicolas Salguero
Details
Result of wx.TextCtrl test using Adwaita as GTK+ 2 theme (6.05 KB, image/png)
2016-06-06 16:06 CEST, Nicolas Salguero
Details
Result of wx.TextCtrl test when not using Adwaita as GTK+ 2 theme (4.88 KB, image/png)
2016-06-06 16:06 CEST, Nicolas Salguero
Details
File taken from Mga5 pkg (4.82 KB, image/png)
2016-06-06 17:26 CEST, Nicolas Salguero
Details
A patch to restore the ability to set the background colour of GtkEntry or wxTextCtrl (701 bytes, patch)
2016-06-06 17:28 CEST, Nicolas Salguero
Details | Diff

Description Nicolas Salguero 2016-06-06 16:02:22 CEST
Hi,

I found that, with adwaita-gtk2-theme 3.20.2 from Cauldron, it is no more possible to modify the background colour of a GtkEntry (gtk+2.0) or a wxTextCtrl (wxPython using wxGTK built against gtk+2.0).

The problem does not exist in Mga5.

Best regards,

Nico.
Comment 1 Nicolas Salguero 2016-06-06 16:03:53 CEST
Created attachment 7927 [details]
Source code of a GtkEntry test

I built that test with: gcc -o test $(pkg-config --cflags --libs gtk+-2.0) test.c
Comment 2 Nicolas Salguero 2016-06-06 16:04:32 CEST
Created attachment 7928 [details]
wx.TextCtrl test
Comment 3 Nicolas Salguero 2016-06-06 16:05:31 CEST
Created attachment 7929 [details]
Result of GtkEntry test using Adwaita as GTK+ 2 theme
Comment 4 Nicolas Salguero 2016-06-06 16:05:56 CEST
Created attachment 7930 [details]
Result of GtkEntry test when not using Adwaita as GTK+ 2 theme
Comment 5 Nicolas Salguero 2016-06-06 16:06:20 CEST
Created attachment 7931 [details]
Result of wx.TextCtrl test using Adwaita as GTK+ 2 theme
Comment 6 Nicolas Salguero 2016-06-06 16:06:37 CEST
Created attachment 7932 [details]
Result of wx.TextCtrl test when not using Adwaita as GTK+ 2 theme
Nicolas Salguero 2016-06-06 16:07:35 CEST

Source RPM: (none) => gnome-themes-standard

Comment 7 Nicolas Salguero 2016-06-06 16:35:51 CEST
If I replace the directory /usr/share/themes/Adwaita/gtk-2.0 by the one from adwaita-gtk2-theme Mga5 pkg, the problem disappears too.
Comment 8 Nicolas Salguero 2016-06-06 17:26:54 CEST
Created attachment 7933 [details]
File taken from Mga5 pkg

This file would have to be put into /usr/share/themes/Adwaita/gtk-2.0/assets
Comment 9 Nicolas Salguero 2016-06-06 17:28:08 CEST
Created attachment 7934 [details]
A patch to restore the ability to set the background colour of GtkEntry or wxTextCtrl
Rémi Verschelde 2016-06-06 18:04:02 CEST

Keywords: (none) => PATCH, UPSTREAM
CC: (none) => olav
Assignee: bugsquad => pkg-bugs

Comment 10 Nicolas Salguero 2016-06-07 14:58:07 CEST
A little precision: the problem does not occur with multi line wxTextCtrl because, in that case, the GTK component which is used is not GtkEntry but GtkTextView, which does not have the bug.
Comment 11 Olav Vitters 2016-06-11 18:51:53 CEST
Wouldn't you want to submit this patch upstream? Then it is fixed for everyone.
Comment 12 Nicolas Salguero 2016-06-12 14:16:45 CEST
Hi,

I created this bug report: https://bugzilla.gnome.org/show_bug.cgi?id=767562

Best regards,

Nico.
Comment 13 Olav Vitters 2016-06-12 17:03:17 CEST
Thanks!! As we're close to Mageia 6 release, I've added your patch to gnome-themes-standard. I've also cc'ed myself upstream.

Note: If you want to help out with GNOME in Mageia, I'd support you. You can do as little or as much as you'd like.
Comment 14 Nicolas Salguero 2016-06-13 09:40:37 CEST
The PNG file taken from version 3.14.2.3 was missing so I added it and pushed a new build (3.mga6).
Comment 15 Marja Van Waes 2016-09-07 11:49:22 CEST
Re-assigning to the Gnome maintainers group.

Is this bug still valid in a completely updated system?

Keywords: (none) => NEEDINFO
Assignee: pkg-bugs => gnome

Comment 16 Nicolas Salguero 2016-09-07 11:51:28 CEST
(In reply to Marja van Waes from comment #15)
> Is this bug still valid in a completely updated system?

No the problem is now solved.  I forgot to close the bug report, sorry.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.