Bug 18269 - squid startup script looks for '$adir/00' instead of '$CACHE_SWAP/00'
Summary: squid startup script looks for '$adir/00' instead of '$CACHE_SWAP/00'
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 5
Hardware: All Linux
Priority: Normal minor
Target Milestone: Mageia 5
Assignee: Bruno Cornec
QA Contact: QA Team
URL: http://users.on.net/~emerson/mga/doku...
Whiteboard: MGA5TOO
Keywords:
Depends on: 19970
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-26 10:16 CEST by Rod Emerson
Modified: 2017-06-28 13:55 CEST (History)
3 users (show)

See Also:
Source RPM: squid-3.5.17-1.mga5.src.rpm
CVE:
Status comment:


Attachments

Description Rod Emerson 2016-04-26 10:16:40 CEST
Description of problem:

Initial mga5 squid install and subsequent mga5 squid updates have an
incorrect variable name in /etc/init.d/squid

Version-Release number of selected component (if applicable):

Currently squid-3.5.17-1.mga5

How reproducible:

I have needed to do the following after each install/update of squid :

--- /etc/init.d/squid
+++ /etc/init.d/squid
@@ -75,8 +75,8 @@
         ;;
     esac
 
-    if [ ! -d $adir/00 ]; then 
-       gprintf "init_cache_dir %s... " "$adir"
+    if [ ! -d $CACHE_SWAP/00 ]; then 
+       gprintf "init_cache_dir %s... " "$CACHE_SWAP"
        $SQUID -z -F >> /var/log/squid/squid.out 2>&1
     fi


Change 'adir' to 'CACHE_SWAP'.

systemctl daemon-reload
systemctl start squid

Steps to Reproduce:
1. For me this has happened at install and subsequent updates of mga5 squid.
   Old notes show I also needed this change (and more) in Mandriva.

   # urpmi --auto squid

2. $ grep cache_dir /etc/squid/squid.conf 
   cache_dir ufs /var/spool/squid 100 16 256

3. $ grep adir /etc/init.d/squid
       if [ ! -d $adir/00 ]; then 
           gprintf "init_cache_dir %s... " "$adir"

This is trivial and can be closed as wontfix (or mga equivalent)
if mga6 squid is ok.
Marja Van Waes 2016-04-26 15:37:31 CEST

CC: (none) => marja11
Assignee: bugsquad => bruno

Comment 1 Bruno Cornec 2016-05-23 02:13:51 CEST
Thanks for your report, this is now fixed in both cauldron and mga5

Status: NEW => ASSIGNED
Target Milestone: --- => Mageia 5
QA Contact: (none) => qa-bugs
Whiteboard: (none) => MGA5TOO

David Walser 2016-12-17 18:20:50 CET

Depends on: (none) => 19970

Bruno Cornec 2017-06-22 01:36:29 CEST

Assignee: bruno => qa-bugs

Comment 2 Lewis Smith 2017-06-28 11:58:04 CEST
Looking at M5 64-bit

This update puzzlés me. Without [knowingly] using Squid, I have it installed anyway, and with the system up-to-date, simply do not see the problem. Is this update still valid?

1)
 $ rpm -qa | grep squid
 squid-3.5.23-1.mga5
 squid-cachemgr-3.5.23-1.mga5
Reported for squid-3.5.17-1.mga5.

2)
 $ grep adir /etc/init.d/squid
 $

3)
 $ grep CACHE_SWAP /etc/init.d/squid
 CACHE_SWAP=`sed -e 's/#.*//g' /etc/squid/squid.conf | \
 [ -z "$CACHE_SWAP" ] && CACHE_SWAP=/var/spool/squid
     if [ ! -d $CACHE_SWAP/00 ]; then 
	gprintf "init_cache_dir %s... " "$CACHE_SWAP"
of which the last 2 lines are the change.

CC: (none) => lewyssmith

Comment 3 Herman Viaene 2017-06-28 13:28:01 CEST
Looking at MGA5-32
In the repos I find version 3.4.13 marked as "official package" and version 3.5.23 as "Offical supported update",so this bug has become outdated and superfluous ????

CC: (none) => herman.viaene

Comment 4 Rémi Verschelde 2017-06-28 13:55:43 CEST
It was fixed already by bug 19970, and Bruno wrongly assigned this one to the QA team.

Bruno, it's not the first time you get the updates policy wrong, so please please take the 5 minutes needed to read https://wiki.mageia.org/en/Updates_policy#Maintainer_.28or_any_interested_packager.29 I've linked to you many times.

When you do an update candidate:
- Assign the bug to the QA team
- Write an advisory in the bug report so that the QA team knows what it's expected to do

Here you checked in a patch in May 2016, which was never tested by the QA team because they were never made aware of it, but was finally pushed as an update by chance *thanks* to a later security update by Luigi in Dec 2016. http://svnweb.mageia.org/packages/updates/5/squid/current/SPECS/squid.spec?view=log

Resolution: (none) => FIXED
Status: ASSIGNED => RESOLVED

Rémi Verschelde 2017-06-28 13:55:56 CEST

Assignee: qa-bugs => bruno


Note You need to log in before you can comment on or make changes to this bug.