Description of problem: When you try to open a previously saved backup, BackupPC fails with the message Software error: Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at /usr/share/backuppc/lib/BackupPC/CGI/Browse.pm line 68. Line 68 in Browse.pm contains an " if (defined (@Backups) ..." term, but calling "defined" on an array is deprecated; perl 5.22 does not tolerate this any more (perl 5.20 on Mageia 5 did) It is not very clear what this term is meant to achieve - simply replacing if ( !defined($In{num}) && defined(@Backups) && @Backups > 0 ) { by if ( !defined($In{num}) && @Backups > 0 ) { (line 68) makes the error go away and permits to correctly open any existing backup. See also: https://bugzilla.redhat.com/show_bug.cgi?id=755076 Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Open a BackupPC browser window 2. Select a target host (some backups must already exist for that host) 3. In the "Backup Summary" list, select any backup number (Backup# column)
CC: (none) => marja11Assignee: bugsquad => shlomif
Created attachment 7695 [details] Patch for a workaround and, possibly, a fix
Craig Barrat has just released a stability update - BackupPC 3.3.2. It might be worth while considering this new release for Mageia 6
CC: (none) => juergen.harms
Ping Mageia-6 should not come with a frequently used backup tool that backs up, but than does not allow users to restore their saved data (there is no problem with Mageia 5 since the problem is caused by Perl recently having tightened the rules for doing scalar operations on an array). I did not shout so far since I was not 100% sure whether the patch I suggested is just a workaround or whether it is a solid fix of the problem: it is a solid fix, BackupPC 3.3.2 introduces precisely the same code as the proposed patch. So, for Mageia-6 there is now the choice of either applying the patch or (I think the better solution) offering BackupPC 3.3.2 instead of the present 3.3.1. If that helps, I should be able to locally build and test 3.3.2, reducing the work still to be done to a final verification and submitting the package. I append the announcement of BackupPC 3.3.2 Juergen ---------------------------------------------- I'm pleased to announce that BackupPC 3.3.2 was released a few days ago on Github and SF.net. It's a minor release with a couple of small changes. The ChangeLog is below. Craig #------------------------------------------------------------------------ # Version 3.3.2, 25 Jan 2017 #------------------------------------------------------------------------ * Updates to bin/BackupPC_dump and lib/BackupPC/Xfer/Smb.pm from maksyms to fix incompatabilities with Samba 4.3 (#22) * Sort hash of config editor tabs in lib/BackupPC/CGI/EditConfig.pm from polo (#23) * Fixes to bin/BackupPC_sendEmail to avoid per-host overwrite of EMailAdminUserName from derrickdominic (#30) * Fixed minor typos in several language files; from Alexander Moisseev * Updated deprecated syntax (defined(@array) and "{" in regexps) from Alexander Moisseev. * Documentation updates from Alexander Moisseev.
Hi! I updated backuppc to 3.3.2 in the mgarepo/SVN repository and requested a freeze push. Sorry it took me so long.
Sorry Shlomi - I did not want to rush you, rather offer help to make this bug get fixed before freezes become tough. Cheers - and thanks for your great work.
(In reply to Juergen Harms from comment #5) > Sorry Shlomi - I did not want to rush you, rather offer help to make this > bug get fixed before freezes become tough. > > Cheers - and thanks for your great work. Hi Juergen! No worries really. I should really have done it earlier, and it's my fault.
I believe this is solved then?
CC: (none) => fri
It is, thanks for catching this - closing
Fixed with updated BackupPC (3.3.2) package
Status: NEW => RESOLVEDResolution: (none) => FIXED